)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"70a6cd27aca4b6c4ba363f712b500957508fc2db","unresolved":false,"context_lines":[{"line_number":7,"context_line":"vif: Resolve a TODO and update another"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Once TODO noted that a block could be removed once we bump to libvirt"},{"line_number":10,"context_line":"1.3.8 or greater. We require 3.0.0 now so that\u0027s resolved. Another one"},{"line_number":11,"context_line":"looks like it should be resolved in 3.2.0 so the TODO is updated to"},{"line_number":12,"context_line":"highlight this for future reviewers."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7faddb67_5ee740ad","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":5},"updated":"2019-07-16 18:32:52.000000000","message":"1.3.5","commit_id":"3f56e44b843ab8c0ee017eb58a8d77679aeb7b3b"}],"nova/virt/libvirt/vif.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d4bc40079cda48c56284b41e7238a728d1c009bf","unresolved":false,"context_lines":[{"line_number":647,"context_line":"                          instance\u003dinstance)"},{"line_number":648,"context_line":""},{"line_number":649,"context_line":"    def plug_hw_veb(self, instance, vif):"},{"line_number":650,"context_line":"        # TODO(vladikr): This code can be removed once the minimum version of"},{"line_number":651,"context_line":"        # Libvirt is incleased above 1.3.5, as vlan will be set by libvirt"},{"line_number":652,"context_line":"        if vif[\u0027vnic_type\u0027] \u003d\u003d network_model.VNIC_TYPE_MACVTAP:"},{"line_number":653,"context_line":"            set_vf_interface_vlan("},{"line_number":654,"context_line":"                vif[\u0027profile\u0027][\u0027pci_slot\u0027],"},{"line_number":655,"context_line":"                mac_addr\u003dvif[\u0027address\u0027],"},{"line_number":656,"context_line":"                vlan\u003dvif[\u0027details\u0027][network_model.VIF_DETAILS_VLAN])"},{"line_number":657,"context_line":""},{"line_number":658,"context_line":"        elif vif[\u0027vnic_type\u0027] \u003d\u003d network_model.VNIC_TYPE_DIRECT:"},{"line_number":659,"context_line":"            trusted \u003d strutils.bool_from_string("}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_ce6e7795","side":"PARENT","line":656,"range":{"start_line":650,"start_character":7,"end_line":656,"end_character":68},"updated":"2019-06-21 10:47:42.000000000","message":"ok so we generate the libvirt xml here by calling the designer\nhttps://github.com/openstack/nova/blob/master/nova/virt/libvirt/vif.py#L352-L354\n\nwhich sets the vlan in the config element here\nhttps://github.com/openstack/nova/blob/master/nova/virt/libvirt/designer.py#L116\n\nso yes since our minium is now 3.0.0 this should not be needed.","commit_id":"d77b0a4cdd6a459c123978821b557ac95f49baf8"}]}