)]}'
{"nova/network/linux_net.py":[{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"2cf9d68724573f93e9916f904a26bd5078a48128","unresolved":false,"context_lines":[{"line_number":830,"context_line":"    except AttributeError:"},{"line_number":831,"context_line":"        prefix \u003d network_ref[\u0027cidr\u0027].rpartition(\u0027/\u0027)[2]"},{"line_number":832,"context_line":""},{"line_number":833,"context_line":"    full_ip \u003d \u0027%s/%s\u0027 % (network_ref[\u0027dhcp_server\u0027], prefix)"},{"line_number":834,"context_line":"    new_ip_params \u003d [[full_ip, \u0027brd\u0027, network_ref[\u0027broadcast\u0027]]]"},{"line_number":835,"context_line":"    old_ip_params \u003d []"},{"line_number":836,"context_line":"    out, err \u003d _execute(\u0027ip\u0027, \u0027addr\u0027, \u0027show\u0027, \u0027dev\u0027, dev,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2FRtk%3D","line":833,"updated":"2014-01-15 15:38:03.000000000","message":"So if this is here to make it compatible with both network object with net_addr field and the old network dict from db field being passed here, shouldn\u0027t we have done this several patches ago (when you chenged the get_by_host query in init_host, as it can get passed into here too (if we are rubnning a flatdhcp network, we call _setup_netwrk_on_host which gets here)?","commit_id":"c8e67dac1cd3bc67a77b6683a9faa0422192aa81"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"12f87ce4c8f21233847cfb78e784e7c0ee0fa52c","unresolved":false,"context_lines":[{"line_number":830,"context_line":"    except AttributeError:"},{"line_number":831,"context_line":"        prefix \u003d network_ref[\u0027cidr\u0027].rpartition(\u0027/\u0027)[2]"},{"line_number":832,"context_line":""},{"line_number":833,"context_line":"    full_ip \u003d \u0027%s/%s\u0027 % (network_ref[\u0027dhcp_server\u0027], prefix)"},{"line_number":834,"context_line":"    new_ip_params \u003d [[full_ip, \u0027brd\u0027, network_ref[\u0027broadcast\u0027]]]"},{"line_number":835,"context_line":"    old_ip_params \u003d []"},{"line_number":836,"context_line":"    out, err \u003d _execute(\u0027ip\u0027, \u0027addr\u0027, \u0027show\u0027, \u0027dev\u0027, dev,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2FMKg%3D","line":833,"in_reply_to":"AAAAUH%2F%2FRtk%3D","updated":"2014-01-16 16:06:58.000000000","message":"Wow, nice catch.","commit_id":"c8e67dac1cd3bc67a77b6683a9faa0422192aa81"}],"nova/network/manager.py":[{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"2cf9d68724573f93e9916f904a26bd5078a48128","unresolved":false,"context_lines":[{"line_number":1232,"context_line":"        if require_disassociated and network.project_id is not None:"},{"line_number":1233,"context_line":"            raise ValueError(_(\u0027Network must be disassociated from project %s\u0027"},{"line_number":1234,"context_line":"                               \u0027 before delete\u0027) % network.project_id)"},{"line_number":1235,"context_line":"        self.db.network_delete_safe(context, network.id)"},{"line_number":1236,"context_line":""},{"line_number":1237,"context_line":"    @property"},{"line_number":1238,"context_line":"    def _bottom_reserved_ips(self):  # pylint: disable\u003dR0201"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2FRuw%3D","line":1235,"updated":"2014-01-15 15:38:03.000000000","message":"K - this is left here to keep the patches smaller? Nice.","commit_id":"c8e67dac1cd3bc67a77b6683a9faa0422192aa81"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"fe720dc89a5c4da127856006f66e278a8b0cbe51","unresolved":false,"context_lines":[{"line_number":1236,"context_line":"        if require_disassociated and network.project_id is not None:"},{"line_number":1237,"context_line":"            raise ValueError(_(\u0027Network must be disassociated from project %s\u0027"},{"line_number":1238,"context_line":"                               \u0027 before delete\u0027) % network.project_id)"},{"line_number":1239,"context_line":"        self.db.network_delete_safe(context, network.id)"},{"line_number":1240,"context_line":""},{"line_number":1241,"context_line":"    @property"},{"line_number":1242,"context_line":"    def _bottom_reserved_ips(self):  # pylint: disable\u003dR0201"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUH%2F%2B%2F0s%3D","line":1239,"updated":"2014-01-19 18:53:16.000000000","message":"don\u0027t want to just call network.destroy()?  (maybe you left it because it\u0027s outside of the scope of this patch, which is fine)","commit_id":"ff1d58daf496e3db09121e63dab77d6ec420c9e5"}],"nova/tests/compute/test_compute.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"39ae6b43da03d0fe6f7c371dbd17bb1ba0c97497","unresolved":false,"context_lines":[{"line_number":7004,"context_line":"        c \u003d context.get_admin_context()"},{"line_number":7005,"context_line":"        network_manager \u003d fake_network.FakeNetworkManager()"},{"line_number":7006,"context_line":"        network_get.return_value \u003d ("},{"line_number":7007,"context_line":"            dict(test_network.fake_network,"},{"line_number":7008,"context_line":"                 **network_manager.db.network_get(None, 1)))"},{"line_number":7009,"context_line":"        self.stubs.Set(self.compute_api.network_api,"},{"line_number":7010,"context_line":"                       \u0027get_instance_uuids_by_ip_filter\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUH%2F%2FBoA%3D","line":7007,"updated":"2014-01-18 16:08:04.000000000","message":"is it worth using {} instead of dict of this just an overkill?","commit_id":"ff1d58daf496e3db09121e63dab77d6ec420c9e5"}]}