)]}'
{"nova/network/manager.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"2f31e488b38d2c28dc59ea283e2f3ea5d8de517b","unresolved":false,"context_lines":[{"line_number":1854,"context_line":"        if not network.vpn_public_address:"},{"line_number":1855,"context_line":"            net \u003d {}"},{"line_number":1856,"context_line":"            address \u003d CONF.vpn_ip"},{"line_number":1857,"context_line":"            net[\u0027vpn_public_address\u0027] \u003d address"},{"line_number":1858,"context_line":"            network.vpn_public_address \u003d address"},{"line_number":1859,"context_line":"            network.save()"},{"line_number":1860,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUH%2F%2FEfo%3D","line":1857,"updated":"2014-01-17 18:28:11.000000000","message":"the variable net is not used","commit_id":"be3a51f592950a6d88b16b9e9424ef49f34c2dac"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"311eec4f8146cbdc0b89bd2c19b55ae495d7d820","unresolved":false,"context_lines":[{"line_number":1854,"context_line":"        if not network.vpn_public_address:"},{"line_number":1855,"context_line":"            net \u003d {}"},{"line_number":1856,"context_line":"            address \u003d CONF.vpn_ip"},{"line_number":1857,"context_line":"            net[\u0027vpn_public_address\u0027] \u003d address"},{"line_number":1858,"context_line":"            network.vpn_public_address \u003d address"},{"line_number":1859,"context_line":"            network.save()"},{"line_number":1860,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUH%2F%2FAt0%3D","line":1857,"in_reply_to":"AAAAUH%2F%2FBig%3D","updated":"2014-01-19 07:40:12.000000000","message":"i feel like i am between a rock and a hard place here. i understand the fact that there is a huge patch set and the rebasing will be a real pain. on the other hand i know that this would have certainly got a -1 in other circumstances.\nAs a stop gap I have added a patch that removes this unnecessary code https://review.openstack.org/67694","commit_id":"be3a51f592950a6d88b16b9e9424ef49f34c2dac"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7d8db2b268320f1b597213ff8088e0f83b2fc24a","unresolved":false,"context_lines":[{"line_number":1854,"context_line":"        if not network.vpn_public_address:"},{"line_number":1855,"context_line":"            net \u003d {}"},{"line_number":1856,"context_line":"            address \u003d CONF.vpn_ip"},{"line_number":1857,"context_line":"            net[\u0027vpn_public_address\u0027] \u003d address"},{"line_number":1858,"context_line":"            network.vpn_public_address \u003d address"},{"line_number":1859,"context_line":"            network.save()"},{"line_number":1860,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUH%2F%2FBig%3D","line":1857,"in_reply_to":"AAAAUH%2F%2FBoU%3D","updated":"2014-01-18 17:05:01.000000000","message":"Yep, understood. This is really deep in a 35-patch set, so I think it\u0027s not worth rebasing just for this. If I do, I\u0027ll snag it, otherwise I think we can fix it later.","commit_id":"be3a51f592950a6d88b16b9e9424ef49f34c2dac"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"01d672aae0a0c02e0bef56412904b1b8027b8bbd","unresolved":false,"context_lines":[{"line_number":1854,"context_line":"        if not network.vpn_public_address:"},{"line_number":1855,"context_line":"            net \u003d {}"},{"line_number":1856,"context_line":"            address \u003d CONF.vpn_ip"},{"line_number":1857,"context_line":"            net[\u0027vpn_public_address\u0027] \u003d address"},{"line_number":1858,"context_line":"            network.vpn_public_address \u003d address"},{"line_number":1859,"context_line":"            network.save()"},{"line_number":1860,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUH%2F%2FBoU%3D","line":1857,"in_reply_to":"AAAAUH%2F%2FD4Y%3D","updated":"2014-01-18 16:04:18.000000000","message":"it is related to this path - please see on the left:\nself.db.network_update(context, network[\u0027id\u0027], net) (line 1589)\nthe parameter net was used to update the database. this is no longer needed","commit_id":"be3a51f592950a6d88b16b9e9424ef49f34c2dac"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"6c9ddd78aae8d1fb637fbb7770bc8ba0078907ba","unresolved":false,"context_lines":[{"line_number":1854,"context_line":"        if not network.vpn_public_address:"},{"line_number":1855,"context_line":"            net \u003d {}"},{"line_number":1856,"context_line":"            address \u003d CONF.vpn_ip"},{"line_number":1857,"context_line":"            net[\u0027vpn_public_address\u0027] \u003d address"},{"line_number":1858,"context_line":"            network.vpn_public_address \u003d address"},{"line_number":1859,"context_line":"            network.save()"},{"line_number":1860,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUH%2F%2FD4Y%3D","line":1857,"in_reply_to":"AAAAUH%2F%2FEfo%3D","updated":"2014-01-17 20:19:51.000000000","message":"but it\u0027s not related to this patch, so not worth a -1 IMO ...","commit_id":"be3a51f592950a6d88b16b9e9424ef49f34c2dac"}]}