)]}'
{"nova/compute/api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"928d33e196dcfece081b0e4d660af45f283125c0","unresolved":false,"context_lines":[{"line_number":1036,"context_line":"                # batch."},{"line_number":1037,"context_line":"                req_spec.num_instances \u003d num_instances"},{"line_number":1038,"context_line":""},{"line_number":1039,"context_line":"                # NOTE(stephenfin): The network_metadata field is not persisted"},{"line_number":1040,"context_line":"                # and is therefore set after \u0027create\u0027 is called."},{"line_number":1041,"context_line":"                if network_metadata:"},{"line_number":1042,"context_line":"                    req_spec.network_metadata \u003d network_metadata"},{"line_number":1043,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_fda66fc1","side":"PARENT","line":1040,"range":{"start_line":1039,"start_character":16,"end_line":1040,"end_character":64},"updated":"2019-06-24 18:30:54.000000000","message":"Just change the patch to remove this comment, you can leave where the field gets set on the object before it\u0027s created.","commit_id":"aa3581ad44ef915477b27349f3be4c818deee80c"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"73666831b1d170487c33950f6b44f7ab41b3254e","unresolved":false,"context_lines":[{"line_number":1036,"context_line":"                # batch."},{"line_number":1037,"context_line":"                req_spec.num_instances \u003d num_instances"},{"line_number":1038,"context_line":""},{"line_number":1039,"context_line":"                # NOTE(stephenfin): The network_metadata field is not persisted"},{"line_number":1040,"context_line":"                # and is therefore set after \u0027create\u0027 is called."},{"line_number":1041,"context_line":"                if network_metadata:"},{"line_number":1042,"context_line":"                    req_spec.network_metadata \u003d network_metadata"},{"line_number":1043,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_e05d6379","side":"PARENT","line":1040,"range":{"start_line":1039,"start_character":16,"end_line":1040,"end_character":64},"in_reply_to":"9fb8cfa7_fda66fc1","updated":"2019-06-25 00:58:43.000000000","message":"ok, I see now.","commit_id":"aa3581ad44ef915477b27349f3be4c818deee80c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"422c1e13085758668b8821c2a50209cfbaa76769","unresolved":false,"context_lines":[{"line_number":1021,"context_line":"                        base_options[\u0027pci_requests\u0027], filter_properties,"},{"line_number":1022,"context_line":"                        instance_group, base_options[\u0027availability_zone\u0027],"},{"line_number":1023,"context_line":"                        security_groups\u003dsecurity_groups,"},{"line_number":1024,"context_line":"                        port_resource_requests\u003dport_resource_requests)"},{"line_number":1025,"context_line":""},{"line_number":1026,"context_line":"                if block_device_mapping:"},{"line_number":1027,"context_line":"                    # Record whether or not we are a BFV instance"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_5d953b3f","line":1024,"range":{"start_line":1024,"start_character":24,"end_line":1024,"end_character":69},"updated":"2019-06-24 18:31:34.000000000","message":"For example, these aren\u0027t persisted either (the requested_resources field):\n\nhttps://github.com/openstack/nova/blob/ff0f33cf7e44c5d01f3fb999295eff4508c24a14/nova/objects/request_spec.py#L618","commit_id":"d3f97213efa19b8fec8bb2f71924782f1de8f18e"}],"nova/objects/request_spec.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"89f2d241471e1997e0a9543cf53e29e638c7eb23","unresolved":false,"context_lines":[{"line_number":615,"context_line":"            if \u0027instance_group\u0027 in spec and spec.instance_group:"},{"line_number":616,"context_line":"                spec.instance_group.members \u003d None"},{"line_number":617,"context_line":"                spec.instance_group.hosts \u003d None"},{"line_number":618,"context_line":"            # NOTE(mriedem): Don\u0027t persist retries, requested_destination,"},{"line_number":619,"context_line":"            # requested_resources or ignored hosts since those are per-request"},{"line_number":620,"context_line":"            for excluded in (\u0027retry\u0027, \u0027requested_destination\u0027,"},{"line_number":621,"context_line":"                             \u0027requested_resources\u0027, \u0027ignore_hosts\u0027):"},{"line_number":622,"context_line":"                if excluded in spec and getattr(spec, excluded):"},{"line_number":623,"context_line":"                    setattr(spec, excluded, None)"},{"line_number":624,"context_line":"            # NOTE(stephenfin): Don\u0027t persist network metadata since we have"},{"line_number":625,"context_line":"            # no need for it after scheduling"},{"line_number":626,"context_line":"            if \u0027network_metadata\u0027 in spec and spec.network_metadata:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_294d9f99","line":623,"range":{"start_line":618,"start_character":12,"end_line":623,"end_character":49},"updated":"2019-06-25 13:31:17.000000000","message":"If you\u0027re going to add a comment per field that isn\u0027t persisted in the object (by the fields above), you\u0027ve missed \"retry\" and \"ignore_hosts\".","commit_id":"32c894054c3e6f9533d50dad92d413d5805edbb6"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"a1c717e81a0f938491c85d9b2a49a7b463df06ed","unresolved":false,"context_lines":[{"line_number":615,"context_line":"            if \u0027instance_group\u0027 in spec and spec.instance_group:"},{"line_number":616,"context_line":"                spec.instance_group.members \u003d None"},{"line_number":617,"context_line":"                spec.instance_group.hosts \u003d None"},{"line_number":618,"context_line":"            # NOTE(mriedem): Don\u0027t persist retries, requested_destination,"},{"line_number":619,"context_line":"            # requested_resources or ignored hosts since those are per-request"},{"line_number":620,"context_line":"            for excluded in (\u0027retry\u0027, \u0027requested_destination\u0027,"},{"line_number":621,"context_line":"                             \u0027requested_resources\u0027, \u0027ignore_hosts\u0027):"},{"line_number":622,"context_line":"                if excluded in spec and getattr(spec, excluded):"},{"line_number":623,"context_line":"                    setattr(spec, excluded, None)"},{"line_number":624,"context_line":"            # NOTE(stephenfin): Don\u0027t persist network metadata since we have"},{"line_number":625,"context_line":"            # no need for it after scheduling"},{"line_number":626,"context_line":"            if \u0027network_metadata\u0027 in spec and spec.network_metadata:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_e16793e8","line":623,"range":{"start_line":618,"start_character":12,"end_line":623,"end_character":49},"in_reply_to":"9fb8cfa7_294d9f99","updated":"2019-06-26 02:38:50.000000000","message":"Emm..I prefer to add a comment for those fields, it is better than check the code to collect all the field aren\u0027t persisted.","commit_id":"32c894054c3e6f9533d50dad92d413d5805edbb6"}]}