)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ce7035553f8a2c46a659cd28244cee6df835e9ba","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When we try to refresh instance info cache on DELETED instances, it"},{"line_number":10,"context_line":"fails with InstanceInfoCacheNotFound exception."},{"line_number":11,"context_line":"We cant refresh network info on DELETED instances."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I09eb70197138a2a12dde721a93cd7ef7f2fe1ae2"},{"line_number":14,"context_line":"Signed-off-by: Arnaud Morin \u003carnaud.morin@corp.ovh.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fb8cfa7_095cfc16","line":12,"updated":"2019-07-01 15:40:35.000000000","message":"We should have a bug report for this since you\u0027re trying to backport https://review.opendev.org/#/q/I99601773406c61f93002e2f7cbb248cf73cef0ab which introduced this regression so I\u0027m going to be holding those further backports for rocky and queens until we have this backported on top so they can go together, i.e. let\u0027s be sure to not release the regression on stable branches.","commit_id":"bef1a08b223b62d19f14d2a02d2958135f111d5d"}],"nova/compute/manager.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2417c0078b729b05b9f24a6ff04074ed6c2738bf","unresolved":false,"context_lines":[{"line_number":2574,"context_line":"        # But dont do it if the instance is already marked as DELETED in"},{"line_number":2575,"context_line":"        # the DB, because in that case, it would raise an"},{"line_number":2576,"context_line":"        # InstanceInfoCacheNotFound exception."},{"line_number":2577,"context_line":"        if not network_info and not instance.vm_state \u003d\u003d vm_states.DELETED:"},{"line_number":2578,"context_line":"            network_info \u003d self.network_api.get_instance_nw_info("},{"line_number":2579,"context_line":"                context, instance)"},{"line_number":2580,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_884caf9e","line":2577,"updated":"2019-06-26 14:27:04.000000000","message":"I remember a similar check being added here:\n\nhttps://github.com/openstack/nova/blob/707deb158996d540111c23afd8c916ea1c18906a/nova/network/base_api.py#L35\n\nMaybe we should re-use that logic (check instance.deleted instead of vm_state though I\u0027m not sure it makes a different), or catch and gracefully ignore the NotFound error.","commit_id":"bef1a08b223b62d19f14d2a02d2958135f111d5d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1ecd8d2b04e8878b978edf1a4819e5ce77055467","unresolved":false,"context_lines":[{"line_number":2732,"context_line":"                raise_exc\u003dFalse, detach\u003dFalse)"},{"line_number":2733,"context_line":"        # if a delete task succeeded, always update vm state and task"},{"line_number":2734,"context_line":"        # state without expecting task state to be DELETING"},{"line_number":2735,"context_line":"        instance.vm_state \u003d vm_states.DELETED"},{"line_number":2736,"context_line":"        instance.task_state \u003d None"},{"line_number":2737,"context_line":"        instance.power_state \u003d power_state.NOSTATE"},{"line_number":2738,"context_line":"        instance.terminated_at \u003d timeutils.utcnow()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_5c28b884","line":2735,"updated":"2019-06-26 14:31:11.000000000","message":"Note that the instance vm_state isn\u0027t set to DELETED until we get here which is after calling _shutdown_instance.","commit_id":"bef1a08b223b62d19f14d2a02d2958135f111d5d"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"a6466adf24add2bf8dc4db66f974f082d3527781","unresolved":false,"context_lines":[{"line_number":2732,"context_line":"                raise_exc\u003dFalse, detach\u003dFalse)"},{"line_number":2733,"context_line":"        # if a delete task succeeded, always update vm state and task"},{"line_number":2734,"context_line":"        # state without expecting task state to be DELETING"},{"line_number":2735,"context_line":"        instance.vm_state \u003d vm_states.DELETED"},{"line_number":2736,"context_line":"        instance.task_state \u003d None"},{"line_number":2737,"context_line":"        instance.power_state \u003d power_state.NOSTATE"},{"line_number":2738,"context_line":"        instance.terminated_at \u003d timeutils.utcnow()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_498f6c74","line":2735,"in_reply_to":"9fb8cfa7_5c28b884","updated":"2019-08-05 12:38:31.000000000","message":"Damn, you are right, so I cant explain why I have this bug on my infra (I am running newton, but the code is pretty much the same)\n\nAnyway I need to rework/recheck that in a closer way.","commit_id":"bef1a08b223b62d19f14d2a02d2958135f111d5d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1ecd8d2b04e8878b978edf1a4819e5ce77055467","unresolved":false,"context_lines":[{"line_number":2742,"context_line":"        # only destroy the instance in the db if the _complete_deletion"},{"line_number":2743,"context_line":"        # doesn\u0027t raise and therefore allocation is successfully"},{"line_number":2744,"context_line":"        # deleted in placement"},{"line_number":2745,"context_line":"        instance.destroy()"},{"line_number":2746,"context_line":""},{"line_number":2747,"context_line":"        self._notify_about_instance_usage(context, instance, \"delete.end\")"},{"line_number":2748,"context_line":"        compute_utils.notify_about_instance_action(context, instance,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_3c2384a9","line":2745,"updated":"2019-06-26 14:31:11.000000000","message":"And here is where the instance.deleted value would be changed to a non-0 value.","commit_id":"bef1a08b223b62d19f14d2a02d2958135f111d5d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"fbcbc9915e8bcb9aa6b46bafca2a6aad3218dc7d","unresolved":false,"context_lines":[{"line_number":8237,"context_line":"                        context, instance.uuid, use_slave\u003dTrue)"},{"line_number":8238,"context_line":"                    self.instance_events.clear_events_for_instance(instance)"},{"line_number":8239,"context_line":"                    try:"},{"line_number":8240,"context_line":"                        self._shutdown_instance(context, instance, bdms,"},{"line_number":8241,"context_line":"                                                notify\u003dFalse)"},{"line_number":8242,"context_line":"                        self._cleanup_volumes(context, instance, bdms,"},{"line_number":8243,"context_line":"                                              detach\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_e9d178cd","line":8240,"updated":"2019-08-05 13:16:42.000000000","message":"Are you seeing it from here?","commit_id":"bef1a08b223b62d19f14d2a02d2958135f111d5d"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"55b6c681ed69fb68e7d2bfdd5381eb08db810eeb","unresolved":false,"context_lines":[{"line_number":8237,"context_line":"                        context, instance.uuid, use_slave\u003dTrue)"},{"line_number":8238,"context_line":"                    self.instance_events.clear_events_for_instance(instance)"},{"line_number":8239,"context_line":"                    try:"},{"line_number":8240,"context_line":"                        self._shutdown_instance(context, instance, bdms,"},{"line_number":8241,"context_line":"                                                notify\u003dFalse)"},{"line_number":8242,"context_line":"                        self._cleanup_volumes(context, instance, bdms,"},{"line_number":8243,"context_line":"                                              detach\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_6cdfaf0c","line":8240,"in_reply_to":"7faddb67_e9d178cd","updated":"2019-08-07 08:09:25.000000000","message":"I checked my logs, I am seeing it after deletion of an instance which was not built correctly.\nI will dig a little big more to find the code which is called on this case.","commit_id":"bef1a08b223b62d19f14d2a02d2958135f111d5d"}]}