)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4643669b0bd938d15f6e913791dde261a487fb35","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support for osprofiler in placement wsgi"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is backport of the placement fix [1] from stein (and master)."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"[1] https://review.opendev.org/#/c/667647"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fb8cfa7_3dc36c8b","line":9,"updated":"2019-06-27 12:35:44.000000000","message":"Minus the release note of course.","commit_id":"3949ee947dd0c188889e8f4208add962243ff20b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8a7fc040cc2bbd54d28092d12ce2bfbcb06801e0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support for osprofiler in placement wsgi"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is backport of the placement fix [1] from stein (and master)."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"[1] https://review.opendev.org/#/c/667647"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fb8cfa7_7f979746","line":9,"in_reply_to":"9fb8cfa7_3dc36c8b","updated":"2019-06-27 14:52:48.000000000","message":"good point. I need to add a reno.","commit_id":"3949ee947dd0c188889e8f4208add962243ff20b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4643669b0bd938d15f6e913791dde261a487fb35","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"[1] https://review.opendev.org/#/c/667647"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1834450"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I5a0e805fe04c00c5e7cf316f0ea8d432b940e560"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fb8cfa7_1d4b082b","line":13,"updated":"2019-06-27 12:35:44.000000000","message":"Is this actually a bug? Did placement ever support osprofiler while it was in nova? IOW, this smells a bit feature-ish even though it\u0027s not really runtime production code so it\u0027s less of a risk to backport (I should have asked this on the stable/stein backport I just approved in the placement repo).","commit_id":"3949ee947dd0c188889e8f4208add962243ff20b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8a7fc040cc2bbd54d28092d12ce2bfbcb06801e0","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"[1] https://review.opendev.org/#/c/667647"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1834450"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I5a0e805fe04c00c5e7cf316f0ea8d432b940e560"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fb8cfa7_bfcd0f5e","line":13,"in_reply_to":"9fb8cfa7_1d4b082b","updated":"2019-06-27 14:52:48.000000000","message":"It depends. I guess osprofiler never worked for placement service (but I haven\u0027t tried back in Queens and Pike yet). But osprofiler in general supported in nova. Which causes that the generated trace without this patch is incomplete from nova perspective.\n\nOn a different note. I needed to help profiling my employer\u0027s Pike base distro and there I realized that placement related information is missing hence my effort to make this work.","commit_id":"3949ee947dd0c188889e8f4208add962243ff20b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"aa6c358cc999b1afde55d17eeb38d575e473152d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"[1] https://review.opendev.org/#/c/667647"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1834450"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I5a0e805fe04c00c5e7cf316f0ea8d432b940e560"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_033c28c6","line":14,"updated":"2019-07-31 20:40:49.000000000","message":"Why isn\u0027t this a cherry-pick of https://review.opendev.org/#/c/667647/ ? Would it have substantial differences? I realize the nova stable/stein backport was a \"cherry pick\" from placement which makes things weirder, but once we\u0027re going from stein-\u003erocky in nova it should be a cherry pick rather than something that\u0027s mostly the same but slight changes in the release and a different commit message but the same Change ID.","commit_id":"04bc27f9575bdbb43347ebab135269126e5ac8ee"}],"nova/api/openstack/placement/deploy.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dac1ca5090bb3eccc65aef44bf9be198fc24a4ee","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from nova.api.openstack.placement.objects import resource_provider"},{"line_number":25,"context_line":"from nova.api.openstack.placement import requestlog"},{"line_number":26,"context_line":"from nova.api.openstack.placement import util"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"os_profiler \u003d importutils.try_import(\u0027osprofiler.profiler\u0027)"},{"line_number":29,"context_line":"os_profiler_web \u003d importutils.try_import(\u0027osprofiler.web\u0027)"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_96821f4f","line":27,"updated":"2019-09-17 18:58:58.000000000","message":"nit: https://review.opendev.org/#/c/667647/1/placement/deploy.py has 2 blank lines which accounts for the LOC difference.","commit_id":"04bc27f9575bdbb43347ebab135269126e5ac8ee"}]}