)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"362be1230cbdcc16b4c52a917d80a46815c30a1c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Images that use cloud-init are not correctly initialized when using"},{"line_number":10,"context_line":"libvirt LXC nova driver."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"One way cloud-init checks if the OpenStack datasource should be used"},{"line_number":13,"context_line":"is by checking DMI data that is meaningful for virtual machines but"},{"line_number":14,"context_line":"not for containers."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Another way cloud-init is using is to check if the \u0027product_name\u0027"},{"line_number":17,"context_line":"env variable for init process (PID 1) is \"OpenStack Nova\" [1][2]."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_6b08a3d8","line":14,"range":{"start_line":12,"start_character":0,"end_line":14,"end_character":19},"updated":"2019-07-09 20:52:25.000000000","message":"Presumably this is why the change here is not necessary for other libvirt virt_types, because the others (except some form of virtuozzo containers?) are VMs and not containers.","commit_id":"ee5492922078ff454421150c27c5bdbc1007f905"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"44b5668cda160f970072fd86eab74397e0995d01","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Images that use cloud-init are not correctly initialized when using"},{"line_number":10,"context_line":"libvirt LXC nova driver."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"One way cloud-init checks if the OpenStack datasource should be used"},{"line_number":13,"context_line":"is by checking DMI data that is meaningful for virtual machines but"},{"line_number":14,"context_line":"not for containers."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Another way cloud-init is using is to check if the \u0027product_name\u0027"},{"line_number":17,"context_line":"env variable for init process (PID 1) is \"OpenStack Nova\" [1][2]."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_cd7acf22","line":14,"range":{"start_line":12,"start_character":0,"end_line":14,"end_character":19},"in_reply_to":"7faddb67_6b08a3d8","updated":"2019-08-15 14:31:42.000000000","message":"ya that would make sense.\n\nill deploy this in my lxc dev env and see if it works to solve the issue i was having with no ssh keys and no dhcp in the container. i was testing with 18.04 which uses cloud-init for networking even on phyical installs.","commit_id":"ee5492922078ff454421150c27c5bdbc1007f905"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ca097b742225d21a3398c5c8e1b84b8faddf3672","unresolved":false,"context_lines":[{"line_number":20,"context_line":"is LXC."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"[1] https://cloudinit.readthedocs.io/en/latest/topics/datasources/openstack.html"},{"line_number":23,"context_line":"[2] https://git.launchpad.net/cloud-init/tree/tools/ds-identify#n974"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Closes-Bug: 1834506"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_ee8f9320","line":23,"range":{"start_line":23,"start_character":4,"end_line":23,"end_character":68},"updated":"2019-10-09 16:04:50.000000000","message":"This is already out-of-date. However, I can\u0027t seem to find any way to link to a specific commit so perhaps this will have to do","commit_id":"8f93eea62b4a1695155f4939e4c233f8691bcccc"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8f850907928e54fdb52bf5d868d4b0190956c8b8","unresolved":false,"context_lines":[{"line_number":20,"context_line":"is LXC."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"[1] https://cloudinit.readthedocs.io/en/latest/topics/datasources/openstack.html"},{"line_number":23,"context_line":"[2] https://git.launchpad.net/cloud-init/tree/tools/ds-identify#n974"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Closes-Bug: 1834506"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3fa7e38b_d373dee7","line":23,"updated":"2019-10-17 17:45:04.000000000","message":"Would be better to use a tag or hash for this since the line number is going to change.","commit_id":"8f975bc8287d980f3e6c5da601051cf626c081dd"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8f850907928e54fdb52bf5d868d4b0190956c8b8","unresolved":false,"context_lines":[{"line_number":5068,"context_line":"        elif virt_type \u003d\u003d \"lxc\":"},{"line_number":5069,"context_line":"            guest.os_init_path \u003d \"/sbin/init\""},{"line_number":5070,"context_line":"            guest.os_cmdline \u003d CONSOLE"},{"line_number":5071,"context_line":"            guest.os_init_env[\"product_name\"] \u003d \"OpenStack Nova\""},{"line_number":5072,"context_line":"        elif virt_type \u003d\u003d \"uml\":"},{"line_number":5073,"context_line":"            guest.os_kernel \u003d \"/usr/bin/linux\""},{"line_number":5074,"context_line":"            guest.os_root \u003d root_device_name"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_53492e8c","line":5071,"updated":"2019-10-17 17:45:04.000000000","message":"A comment would have been good here especially since doing git blame in places like github on this driver module is basically impossible now. Just something simple like, \"Support cloud-init discovering this as an OpenStack guest.\"","commit_id":"8f975bc8287d980f3e6c5da601051cf626c081dd"}]}