)]}'
{"id":"openstack%2Fnova~668263","triplet_id":"openstack%2Fnova~master~Id3c847be32d8a1037722d08bf52e4b88dc5adc97","project":"openstack/nova","branch":"master","topic":"bug/1834712","hashtags":[],"change_id":"Id3c847be32d8a1037722d08bf52e4b88dc5adc97","subject":"Restore RT.old_resources if ComputeNode.save() fails","status":"MERGED","created":"2019-06-28 23:05:32.000000000","updated":"2019-07-22 13:14:10.000000000","submitted":"2019-07-17 17:11:34.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"668263-1563383494845-ef2d6f53","meta_rev_id":"5fef13dee34bf19ac27e3098d01e437ac49118fc","_number":668263,"virtual_id_number":668263,"owner":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"date":"2019-07-17 13:22:05.000000000","_account_id":16898,"name":"Virtuozzo CI","email":"virtuozzo6-ci@virtuozzo.com","username":"virtuozzo6-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"date":"2019-07-17 14:02:52.000000000","_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"date":"2019-07-17 11:14:24.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"date":"2019-07-17 13:08:48.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":2,"date":"2019-07-17 17:11:34.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2019-07-17 22:57:21.000000000","post_submit":true,"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":16898,"name":"Virtuozzo CI","email":"virtuozzo6-ci@virtuozzo.com","username":"virtuozzo6-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"value":2,"date":"2019-07-17 09:29:46.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"value":1,"date":"2019-07-17 09:29:46.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"value":2,"date":"2019-07-17 09:29:46.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":1,"date":"2019-07-17 09:47:53.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":16898,"name":"Virtuozzo CI","email":"virtuozzo6-ci@virtuozzo.com","username":"virtuozzo6-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"value":1,"date":"2019-07-17 09:32:07.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":16898,"name":"Virtuozzo CI","email":"virtuozzo6-ci@virtuozzo.com","username":"virtuozzo6-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"_account_id":16898,"name":"Virtuozzo CI","email":"virtuozzo6-ci@virtuozzo.com","username":"virtuozzo6-ci","tags":["SERVICE_USER"]},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-06-29 01:24:28.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2019-06-29 02:43:32.000000000","updated_by":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-06-30 07:40:03.000000000","updated_by":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-07-03 21:29:55.000000000","updated_by":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"reviewer":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"state":"REVIEWER"},{"updated":"2019-07-05 11:31:22.000000000","updated_by":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"reviewer":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"state":"REVIEWER"},{"updated":"2019-07-10 12:06:28.000000000","updated_by":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-07-17 09:32:07.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2019-07-17 09:47:53.000000000","updated_by":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"reviewer":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"state":"REVIEWER"},{"updated":"2019-07-17 11:14:24.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-07-17 13:08:48.000000000","updated_by":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"reviewer":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"state":"REVIEWER"},{"updated":"2019-07-17 13:22:05.000000000","updated_by":{"_account_id":16898,"name":"Virtuozzo CI","email":"virtuozzo6-ci@virtuozzo.com","username":"virtuozzo6-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":16898,"name":"Virtuozzo CI","email":"virtuozzo6-ci@virtuozzo.com","username":"virtuozzo6-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-07-17 14:02:52.000000000","updated_by":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-07-17 17:11:34.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-07-17 22:57:21.000000000","updated_by":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"813d127f25fd71645d92753c49645988d4a42a41","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-06-28 23:05:32.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"81969470d79880f30b222e3e5619d5beea566495","author":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"date":"2019-06-29 00:05:54.000000000","message":"Patch Set 1:\n\nTesting completed on the zVM Driver CI system check-nova pipeline.  To recheck only the zVM driver plugins, submit a comment with only zvm: recheck in the comment. Contact information: zvmosci@us.ibm.com. For information see https://wiki.openstack.org/wiki/ZVMDriver.\n\n- check-nova-master http://extbasicopstackcilog01.podc.sl.edst.ibm.com/test_logs/jenkins-check-nova-master-33323 : SUCCESS in 59m 57s","accounts_in_message":[],"_revision_number":1},{"id":"6a20044478f7af09d062c117d21cb85fa281d472","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-06-29 01:24:28.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/668263/1 : FAILURE in 2h 18m 17s","accounts_in_message":[],"_revision_number":1},{"id":"85001ea3c26fd51689f6c4682cdd320963ed4088","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-29 01:44:55.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade-py3 http://logs.openstack.org/63/668263/1/check/grenade-py3/2abf6b4/ : SUCCESS in 58m 50s\n- tempest-full-py3 http://logs.openstack.org/63/668263/1/check/tempest-full-py3/0319a1f/ : SUCCESS in 1h 39m 14s\n- openstack-tox-cover http://logs.openstack.org/63/668263/1/check/openstack-tox-cover/b2a98be/cover/ : SUCCESS in 14m 55s\n- openstack-tox-lower-constraints http://logs.openstack.org/63/668263/1/check/openstack-tox-lower-constraints/5fa0b89/ : SUCCESS in 13m 52s\n- openstack-tox-pep8 http://logs.openstack.org/63/668263/1/check/openstack-tox-pep8/286871d/ : SUCCESS in 9m 44s\n- openstack-tox-py27 http://logs.openstack.org/63/668263/1/check/openstack-tox-py27/ffcc63d/ : SUCCESS in 10m 36s\n- openstack-tox-py36 http://logs.openstack.org/63/668263/1/check/openstack-tox-py36/a648fa0/ : SUCCESS in 12m 05s\n- openstack-tox-py37 http://logs.openstack.org/63/668263/1/check/openstack-tox-py37/da5bd8a/ : SUCCESS in 11m 08s\n- openstack-tox-docs http://logs.openstack.org/63/668263/1/check/openstack-tox-docs/06374a5/html/ : SUCCESS in 5m 44s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa http://logs.openstack.org/63/668263/1/check/ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa/d6cc260/ : SUCCESS in 48m 55s (non-voting)\n- devstack-plugin-ceph-tempest http://logs.openstack.org/63/668263/1/check/devstack-plugin-ceph-tempest/04200a6/ : SUCCESS in 1h 31m 33s (non-voting)\n- neutron-grenade-multinode http://logs.openstack.org/63/668263/1/check/neutron-grenade-multinode/7aeb3d3/ : SUCCESS in 1h 07m 17s\n- nova-grenade-live-migration http://logs.openstack.org/63/668263/1/check/nova-grenade-live-migration/1d4289d/ : SUCCESS in 1h 05m 51s\n- nova-live-migration http://logs.openstack.org/63/668263/1/check/nova-live-migration/364481f/ : SUCCESS in 50m 11s\n- nova-multi-cell http://logs.openstack.org/63/668263/1/check/nova-multi-cell/e5e324b/ : SUCCESS in 1h 20m 54s (non-voting)\n- nova-next http://logs.openstack.org/63/668263/1/check/nova-next/4336eba/ : SUCCESS in 1h 29m 33s\n- nova-tox-functional http://logs.openstack.org/63/668263/1/check/nova-tox-functional/21c4eb3/ : SUCCESS in 17m 26s\n- nova-tox-functional-py36 http://logs.openstack.org/63/668263/1/check/nova-tox-functional-py36/d7e446c/ : SUCCESS in 17m 30s\n- tempest-slow-py3 http://logs.openstack.org/63/668263/1/check/tempest-slow-py3/18574ef/ : SUCCESS in 2h 32m 53s","accounts_in_message":[],"_revision_number":1},{"id":"e8d980b026ad5930f4f957ee9f403c544bdd7efc","author":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"date":"2019-06-29 01:45:27.000000000","message":"Patch Set 1:\n\nBuild failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\n- EMC_VxFlexOS_NOVA http://publiclogs.emc.com/63/668263/1/check/EMC_VxFlexOS_NOVA/c5acdc4/EMC_VxFlexOS_NOVA/None : NOT_REGISTERED\n\nLeave a comment with \u0027run-DellEMC VxFlexOS CI\u0027 to trigger a recheck. For more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_VxFlexOS_CI","accounts_in_message":[],"_revision_number":1},{"id":"3ab6bb339b370867d4c1adc52db768ea9befbe58","author":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"date":"2019-06-29 02:43:32.000000000","message":"Patch Set 1:\n\n* nova-quobyteci-dsvm-volume http://78.46.57.153:8081/refs-changes-63-668263-1 : SUCCESS \n\nhttps://wiki.openstack.org/wiki/ThirdPartySystems/Quobyte_CI","accounts_in_message":[],"_revision_number":1},{"id":"6951a9694c4e436e8b640c00fd63608743567029","author":{"_account_id":16898,"name":"Virtuozzo CI","email":"virtuozzo6-ci@virtuozzo.com","username":"virtuozzo6-ci","tags":["SERVICE_USER"]},"date":"2019-06-29 04:45:02.000000000","message":"Patch Set 1:\n\nBuild failed\n\n- check-dsvm-tempest-vz7-exe-minimal http://openstack-3rd-party-virtuozzo-ci-logs.virtuozzo.com/63/668263/1/check/check-dsvm-tempest-vz7-exe-minimal/bd12e36 : FAILURE in 9m 10s\n\nFor information, see https://wiki.openstack.org/wiki/ThirdPartySystems/Virtuozzo_CI Make the comment \u0027run-Virtuozzo CI\u0027 to recheck","accounts_in_message":[],"_revision_number":1},{"id":"8c7972eccac9ffcada7229a277bfa8954a99c630","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2019-06-29 09:11:44.000000000","message":"Patch Set 1:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/63/668263/1/check/tempest-dsvm-full-xenial/658d66b/ : SUCCESS in 1h 28m 52s\n- tempest-dsvm-full-xenial-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/63/668263/1/check/tempest-dsvm-full-xenial-py3/42815cb/ : SUCCESS in 1h 28m 43s (non-voting)\n- grenade-dsvm-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/63/668263/1/check/grenade-dsvm-xenial/5a4056c/ : SUCCESS in 1h 13m 47s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"bc1edf4b190d444e18537d6c7bf2d448de04e8bb","author":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"date":"2019-06-30 07:40:03.000000000","message":"Patch Set 1:\n\nBuild failed. Comment \u0027powervm: recheck\u0027 to recheck.\n For 3rd party CI contact info: https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_PowerVM_CI\n\n- nova-out-of-tree-pvm http://184.172.12.213/63/668263/1/check/nova-out-of-tree-pvm/7303c43 : FAILURE in 3h 19m 45s\n- nova-in-tree-pvm http://184.172.12.213/63/668263/1/check/nova-in-tree-pvm/2926c35 : FAILURE in 3h 05m 37s","accounts_in_message":[],"_revision_number":1},{"id":"7eff1ae0f26dfc3aafbef9e46a838666aba75b90","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2019-07-01 06:09:32.000000000","message":"Patch Set 1:\n\nBuild succeeded\n\n- dsvm-nova http://207.189.188.190/logs/63/668263/1/check-vote/ext-nova-zuul/cbc381d : SUCCESS in 55m 30s","accounts_in_message":[],"_revision_number":1},{"id":"4902757df9fbe6e235cb1f851cde6d55710372a0","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2019-07-03 21:29:55.000000000","message":"Patch Set 1: Code-Review+2\n\n(2 comments)\n\nI think this is a simple and reasonable way to handle the issue. The new test coverage fails without the fix and passes with it. LGTM","accounts_in_message":[],"_revision_number":1},{"id":"bcbe943ba54ece6d4c4782f23f80f6cc5cf63f22","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-07-05 11:31:22.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)\n\nGood find. As you say: There are _loads_ of little messes like this throughout the resource tracker.","accounts_in_message":[],"_revision_number":1},{"id":"83bdc693494de3bf22245a05582602fbcbfabc7b","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-07-05 18:45:16.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"3836c344dd430aa378e63e840fecb6c9a72904fc","author":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"date":"2019-07-10 12:06:28.000000000","message":"Patch Set 1:\n\nTesting failed ubuntu-xenial-s390x. For rechecking only on the ubuntu-xenial-s390x CI, add a review comment with recheck-zkvm. Contact info: zkvm-ci@linux.vnet.ibm.com. For more information, see https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_zKVM_CI\n\n- check-tempest-dsvm-neutron-full-ubuntu-xenial-s390x http://sng01.objectstorage.softlayer.net/v1/AUTH_1940ea10-6e82-4501-b2f9-eb236510e575/ibmzkvmci/production/668263/1/check-tempest-dsvm-neutron-full-ubuntu-xenial-s390x/21c84b9 : EXCEPTION","accounts_in_message":[],"_revision_number":1},{"id":"be956c4b35d5d3aa3e3ad36e8a7257935be44428","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2019-07-17 09:14:13.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nThis seems very sensible. No arguments from me","accounts_in_message":[],"_revision_number":1},{"id":"c8d3e9d1cb152283699c4d74d462d34c9ab13bdc","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-17 09:16:05.000000000","message":"Patch Set 1: Verified-2\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":1},{"id":"b46656dd8c8e38232043d00be70e41a3c6f9bc3f","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-07-17 09:29:46.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"29f4ec1f5261344e8db81ee9bb0f4b05652229fa","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-07-17 09:30:35.000000000","message":"Patch Set 2:\n\nI fixed the merge conflict,","accounts_in_message":[],"_revision_number":2},{"id":"0c1037be69b4230d0dcb98c0a61bb5958c2e69ea","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2019-07-17 09:32:07.000000000","message":"Patch Set 2: Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"f0e5ddf77a1b85f1e4a31015b125c25110a8381b","author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"date":"2019-07-17 09:47:53.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"ea356e78e77d62adcfaa444984423215e6053fe1","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2019-07-17 11:14:24.000000000","message":"Patch Set 2:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/63/668263/2/check/tempest-dsvm-full-xenial/b5f30e9/ : SUCCESS in 1h 24m 31s\n- tempest-dsvm-full-xenial-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/63/668263/2/check/tempest-dsvm-full-xenial-py3/3b08954/ : SUCCESS in 1h 19m 45s (non-voting)\n- grenade-dsvm-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/63/668263/2/check/grenade-dsvm-xenial/0f6338b/ : SUCCESS in 1h 14m 43s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"985edd9d72f333be9755875a81ad6d7a592e8035","author":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"date":"2019-07-17 13:08:48.000000000","message":"Patch Set 2:\n\nTesting completed on the zVM Driver CI system check-nova pipeline.  To recheck only the zVM driver plugins, submit a comment with only zvm: recheck in the comment. Contact information: zvmosci@us.ibm.com. For information see https://wiki.openstack.org/wiki/ZVMDriver.\n\n- check-nova-master http://extbasicopstackcilog01.podc.sl.edst.ibm.com/test_logs/jenkins-check-nova-master-33978 : SUCCESS in 1h 30m 50s","accounts_in_message":[],"_revision_number":2},{"id":"3391d4b9e7f12a720c9c1540c19d3568466ef3a3","author":{"_account_id":16898,"name":"Virtuozzo CI","email":"virtuozzo6-ci@virtuozzo.com","username":"virtuozzo6-ci","tags":["SERVICE_USER"]},"date":"2019-07-17 13:22:05.000000000","message":"Patch Set 2:\n\nBuild failed\n\n- check-dsvm-tempest-vz7-exe-minimal http://openstack-3rd-party-virtuozzo-ci-logs.virtuozzo.com/63/668263/2/check/check-dsvm-tempest-vz7-exe-minimal/230c823 : FAILURE in 12m 20s\n\nFor information, see https://wiki.openstack.org/wiki/ThirdPartySystems/Virtuozzo_CI Make the comment \u0027run-Virtuozzo CI\u0027 to recheck","accounts_in_message":[],"_revision_number":2},{"id":"4786da10255e0a1c0efbeb43537e5fe42bfd0c15","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-17 14:02:22.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade-py3 http://logs.openstack.org/63/668263/2/check/grenade-py3/3896265/ : SUCCESS in 59m 23s\n- tempest-full-py3 http://logs.openstack.org/63/668263/2/check/tempest-full-py3/74e9cbd/ : SUCCESS in 1h 22m 20s\n- openstack-tox-cover http://logs.openstack.org/63/668263/2/check/openstack-tox-cover/27ff588/cover/ : SUCCESS in 19m 40s\n- openstack-tox-lower-constraints http://logs.openstack.org/63/668263/2/check/openstack-tox-lower-constraints/41b409b/ : SUCCESS in 19m 27s\n- openstack-tox-pep8 http://logs.openstack.org/63/668263/2/check/openstack-tox-pep8/2313408/ : SUCCESS in 10m 08s\n- openstack-tox-py27 http://logs.openstack.org/63/668263/2/check/openstack-tox-py27/1dd9183/ : SUCCESS in 20m 35s\n- openstack-tox-py36 http://logs.openstack.org/63/668263/2/check/openstack-tox-py36/7e84c2f/ : SUCCESS in 16m 01s\n- openstack-tox-py37 http://logs.openstack.org/63/668263/2/check/openstack-tox-py37/cd10592/ : SUCCESS in 18m 27s\n- openstack-tox-docs http://logs.openstack.org/63/668263/2/check/openstack-tox-docs/35b2a43/html/ : SUCCESS in 7m 46s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa http://logs.openstack.org/63/668263/2/check/ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa/e3b04ee/ : SUCCESS in 54m 03s (non-voting)\n- devstack-plugin-ceph-tempest http://logs.openstack.org/63/668263/2/check/devstack-plugin-ceph-tempest/25c04ae/ : SUCCESS in 1h 14m 11s (non-voting)\n- neutron-grenade-multinode http://logs.openstack.org/63/668263/2/check/neutron-grenade-multinode/4a7f4eb/ : SUCCESS in 1h 10m 48s\n- nova-grenade-live-migration http://logs.openstack.org/63/668263/2/check/nova-grenade-live-migration/22bd686/ : SUCCESS in 58m 57s\n- nova-live-migration http://logs.openstack.org/63/668263/2/check/nova-live-migration/37c6ca7/ : SUCCESS in 54m 14s\n- nova-multi-cell http://logs.openstack.org/63/668263/2/check/nova-multi-cell/598a9ab/ : SUCCESS in 1h 23m 16s (non-voting)\n- nova-next http://logs.openstack.org/63/668263/2/check/nova-next/911212e/ : SUCCESS in 1h 16m 02s\n- nova-tox-functional http://logs.openstack.org/63/668263/2/check/nova-tox-functional/6b294dd/ : SUCCESS in 23m 25s\n- nova-tox-functional-py36 http://logs.openstack.org/63/668263/2/check/nova-tox-functional-py36/cdf2e3d/ : SUCCESS in 23m 37s\n- tempest-slow-py3 http://logs.openstack.org/63/668263/2/check/tempest-slow-py3/a947988/ : SUCCESS in 2h 24m 52s","accounts_in_message":[],"_revision_number":2},{"id":"e4e55269a03e354250d7a333451bfeae9c9dba6c","author":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"date":"2019-07-17 14:02:52.000000000","message":"Patch Set 2:\n\nBuild failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\n- EMC_VxFlexOS_NOVA http://publiclogs.emc.com/63/668263/2/check/EMC_VxFlexOS_NOVA/a00533a/EMC_VxFlexOS_NOVA/None : NOT_REGISTERED\n\nLeave a comment with \u0027run-DellEMC VxFlexOS CI\u0027 to trigger a recheck. For more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_VxFlexOS_CI","accounts_in_message":[],"_revision_number":2},{"id":"83cb1597858277df5dad4181885e2c932ac2eafb","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-17 14:04:21.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"ed5dc3469e17a7948f3de0e41ca7b3227b17b9a8","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-17 17:11:34.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"4563fbf4c7cff6611162c5e906ee1b50471c85f5","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-17 17:11:34.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- grenade-py3 http://logs.openstack.org/63/668263/2/gate/grenade-py3/8dce09f/ : SUCCESS in 1h 03m 01s\n- tempest-full-py3 http://logs.openstack.org/63/668263/2/gate/tempest-full-py3/2868662/ : SUCCESS in 1h 27m 38s\n- openstack-tox-lower-constraints http://logs.openstack.org/63/668263/2/gate/openstack-tox-lower-constraints/b982c47/ : SUCCESS in 18m 55s\n- openstack-tox-pep8 http://logs.openstack.org/63/668263/2/gate/openstack-tox-pep8/2979ca5/ : SUCCESS in 11m 26s\n- openstack-tox-py27 http://logs.openstack.org/63/668263/2/gate/openstack-tox-py27/75721ae/ : SUCCESS in 19m 38s\n- openstack-tox-py36 http://logs.openstack.org/63/668263/2/gate/openstack-tox-py36/6889ee7/ : SUCCESS in 18m 13s\n- openstack-tox-py37 http://logs.openstack.org/63/668263/2/gate/openstack-tox-py37/0c0e41c/ : SUCCESS in 18m 52s\n- openstack-tox-docs http://logs.openstack.org/63/668263/2/gate/openstack-tox-docs/916edf0/html/ : SUCCESS in 7m 09s\n- nova-grenade-live-migration http://logs.openstack.org/63/668263/2/gate/nova-grenade-live-migration/1a35d51/ : SUCCESS in 1h 08m 19s\n- nova-live-migration http://logs.openstack.org/63/668263/2/gate/nova-live-migration/233a9ee/ : SUCCESS in 55m 37s\n- nova-tox-functional http://logs.openstack.org/63/668263/2/gate/nova-tox-functional/3087ea2/ : SUCCESS in 22m 03s\n- nova-tox-functional-py36 http://logs.openstack.org/63/668263/2/gate/nova-tox-functional-py36/ccd7551/ : SUCCESS in 27m 28s\n- nova-next http://logs.openstack.org/63/668263/2/gate/nova-next/b918b08/ : SUCCESS in 1h 22m 42s\n- tempest-slow-py3 http://logs.openstack.org/63/668263/2/gate/tempest-slow-py3/c490c29/ : SUCCESS in 2h 20m 34s","accounts_in_message":[],"_revision_number":2},{"id":"c527d73668ecfb62d8755ddc0477a952204a882a","author":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"date":"2019-07-17 17:23:48.000000000","message":"Patch Set 2:\n\n* nova-quobyteci-dsvm-volume http://78.46.57.153:8081/refs-changes-63-668263-2 : SUCCESS \n\nhttps://wiki.openstack.org/wiki/ThirdPartySystems/Quobyte_CI","accounts_in_message":[],"_revision_number":2},{"id":"cbff6411c5fd8ebb832d70332478594680351a3b","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2019-07-17 22:57:21.000000000","message":"Patch Set 2:\n\nBuild succeeded\n\n- dsvm-nova http://207.189.188.190/logs/63/668263/2/check-vote/ext-nova-zuul/217cd4f : SUCCESS in 1h 09m 23s","accounts_in_message":[],"_revision_number":2},{"id":"b6e768b1800a545e82da75162453ccbb24f9451f","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-07-22 13:14:10.000000000","message":"Patch Set 2: Cherry Picked\n\nThis patchset was cherry picked to branch stable/stein as commit 39ed79ea09fbab590092ef6b1bd4899270f19c9b","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"11cb42f396fdbc1d973e1a1b592c00896f646015","revisions":{"e699d4ac29e5223bc4c5719c75eed81b9f1e8cb7":{"kind":"REWORK","_number":1,"created":"2019-06-28 23:05:32.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/63/668263/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/63/668263/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/63/668263/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/63/668263/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/63/668263/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/63/668263/1"}}},"commit":{"parents":[{"commit":"324da0532f3b59aa16233a93a260d289e55860fb","subject":"Merge \"Add missing tests for flavor extra_specs mv 2.61\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/324da0532f3b59aa16233a93a260d289e55860fb"}]}],"author":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-06-28 22:50:33.000000000","tz":-240},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-06-28 22:50:33.000000000","tz":-240},"subject":"Restore RT.old_resources if ComputeNode.save() fails","message":"Restore RT.old_resources if ComputeNode.save() fails\n\nWhen starting nova-compute for the first time with a new node,\nthe ResourceTracker will create a new ComputeNode record in\n_init_compute_node but without all of the fields set on the\nComputeNode, for example \"free_disk_gb\".\n\nLater _update_usage_from_instances will set some fields on the\nComputeNode record (even if there are no instances on the node,\nwhy - I don\u0027t know) like free_disk_gb.\n\nThis will make the eventual call from _update() to _resource_change()\nupdate the value in the old_resouces dict and return True, and then\n_update() will try to update those ComputeNode changes to the database.\nIf that update fails, for example due to a DBConnectionError, the\nvalue in old_resources will still be for the current version of the node\nin memory but not what is actually in the database.\n\nNote that this failure does not result in the compute service failing\nto start because ComputeManager._update_available_resource_for_node\ntraps the Exception and just logs it.\n\nA subsequent trip through the RT._update() method - because of the\nupdate_available_resource periodic task - will call _resource_change\nbut because old_resource matches the current state of the node, it\nreturns False and the RT does not attempt to persist the changes to\nthe DB. _update() will then go on to call _update_to_placement\nwhich will create the resource provider in placement along with its\ninventory, making it potentially a candidate for scheduling.\n\nThis can be a problem later in the scheduler because the\nHostState._update_from_compute_node method may skip setting fields\non the HostState object if free_disk_gb is not set in the\nComputeNode record - which can then break filters and weighers\nlater in the scheduling process (see bug 1834691 and bug 1834694).\n\nThe fix proposed here is simple: if the ComputeNode.save() in\nRT._update() fails, restore the previous value in old_resources\nso that the subsequent run through _resource_change will compare the\ncorrect state of the object and retry the update.\n\nAn alternative to this would be killing the compute service on startup\nif there is a DB error but that could have unintended side effects,\nespecially if the DB error is transient and can be fixed on the next\ntry.\n\nObviously the scheduler code needs to be more robust also, but those\nimprovements are left for separate changes related to the other bugs\nmentioned above.\n\nAlso, ComputeNode.update_from_virt_driver could be updated to set\nfree_disk_gb if possible to workaround the tight coupling in the\nHostState._update_from_compute_node code, but that\u0027s also sort of\na whack-a-mole type change best made separately.\n\nChange-Id: Id3c847be32d8a1037722d08bf52e4b88dc5adc97\nCloses-Bug: #1834712\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/e699d4ac29e5223bc4c5719c75eed81b9f1e8cb7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/e699d4ac29e5223bc4c5719c75eed81b9f1e8cb7"}]},"branch":"refs/heads/master"},"11cb42f396fdbc1d973e1a1b592c00896f646015":{"kind":"REWORK","_number":2,"created":"2019-07-17 09:29:46.000000000","uploader":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"ref":"refs/changes/63/668263/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/63/668263/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/63/668263/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/63/668263/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/63/668263/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/63/668263/2"}}},"commit":{"parents":[{"commit":"b7c98befdab1a88932f41f9c463358f91701ce4a","subject":"Merge \"vif: Resolve a TODO and update another\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b7c98befdab1a88932f41f9c463358f91701ce4a"}]}],"author":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-06-28 22:50:33.000000000","tz":-240},"committer":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-07-17 09:29:10.000000000","tz":60},"subject":"Restore RT.old_resources if ComputeNode.save() fails","message":"Restore RT.old_resources if ComputeNode.save() fails\n\nWhen starting nova-compute for the first time with a new node,\nthe ResourceTracker will create a new ComputeNode record in\n_init_compute_node but without all of the fields set on the\nComputeNode, for example \"free_disk_gb\".\n\nLater _update_usage_from_instances will set some fields on the\nComputeNode record (even if there are no instances on the node,\nwhy - I don\u0027t know) like free_disk_gb.\n\nThis will make the eventual call from _update() to _resource_change()\nupdate the value in the old_resouces dict and return True, and then\n_update() will try to update those ComputeNode changes to the database.\nIf that update fails, for example due to a DBConnectionError, the\nvalue in old_resources will still be for the current version of the node\nin memory but not what is actually in the database.\n\nNote that this failure does not result in the compute service failing\nto start because ComputeManager._update_available_resource_for_node\ntraps the Exception and just logs it.\n\nA subsequent trip through the RT._update() method - because of the\nupdate_available_resource periodic task - will call _resource_change\nbut because old_resource matches the current state of the node, it\nreturns False and the RT does not attempt to persist the changes to\nthe DB. _update() will then go on to call _update_to_placement\nwhich will create the resource provider in placement along with its\ninventory, making it potentially a candidate for scheduling.\n\nThis can be a problem later in the scheduler because the\nHostState._update_from_compute_node method may skip setting fields\non the HostState object if free_disk_gb is not set in the\nComputeNode record - which can then break filters and weighers\nlater in the scheduling process (see bug 1834691 and bug 1834694).\n\nThe fix proposed here is simple: if the ComputeNode.save() in\nRT._update() fails, restore the previous value in old_resources\nso that the subsequent run through _resource_change will compare the\ncorrect state of the object and retry the update.\n\nAn alternative to this would be killing the compute service on startup\nif there is a DB error but that could have unintended side effects,\nespecially if the DB error is transient and can be fixed on the next\ntry.\n\nObviously the scheduler code needs to be more robust also, but those\nimprovements are left for separate changes related to the other bugs\nmentioned above.\n\nAlso, ComputeNode.update_from_virt_driver could be updated to set\nfree_disk_gb if possible to workaround the tight coupling in the\nHostState._update_from_compute_node code, but that\u0027s also sort of\na whack-a-mole type change best made separately.\n\nChange-Id: Id3c847be32d8a1037722d08bf52e4b88dc5adc97\nCloses-Bug: #1834712\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/11cb42f396fdbc1d973e1a1b592c00896f646015"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/11cb42f396fdbc1d973e1a1b592c00896f646015"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}