)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c1b6ded2a43ad2abdb5763629aeab950b651af4c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Matthew Booth \u003cmbooth@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-01-23 09:33:32 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VMware: Remove some unused variables"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I43ee2f71edf5872bfe1b1fe010e83435689501bb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"AAAAUH%2F996c%3D","line":7,"updated":"2014-01-31 15:33:01.000000000","message":"Could you add subtext to the commit message below the title? Just listing the places/names would help this be a little less ambiguous.","commit_id":"d522223c12239423cfe880af295adf1123c1a08b"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"4aa71c6fc9abd208c9057615c2f0bcb2fb36ee24","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Matthew Booth \u003cmbooth@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-01-23 09:33:32 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VMware: Remove some unused variables"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I43ee2f71edf5872bfe1b1fe010e83435689501bb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"AAAAUH%2F91oU%3D","line":7,"in_reply_to":"AAAAUH%2F996c%3D","updated":"2014-02-03 13:27:03.000000000","message":"Done","commit_id":"d522223c12239423cfe880af295adf1123c1a08b"}],"nova/virt/vmwareapi/driver.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"492f9e8349664d8cdd1bd57c8e23d44b4a60864f","unresolved":false,"context_lines":[{"line_number":837,"context_line":"            except error_util.SessionOverLoadException as excep:"},{"line_number":838,"context_line":"                # For exceptions which may come because of session overload,"},{"line_number":839,"context_line":"                # we retry"},{"line_number":840,"context_line":"                pass"},{"line_number":841,"context_line":"            except error_util.SessionConnectionException as excep:"},{"line_number":842,"context_line":"                # For exceptions with connections we create the session"},{"line_number":843,"context_line":"                self._create_session()"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2B8Js%3D","line":840,"updated":"2014-01-20 15:35:31.000000000","message":"why the addition of the pass here?","commit_id":"9ccfbe3a4e430c8f9894cd75e00d63bef6758547"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"adb258e19aead78ed6e3666f600bab8bb22b8fe5","unresolved":false,"context_lines":[{"line_number":837,"context_line":"            except error_util.SessionOverLoadException as excep:"},{"line_number":838,"context_line":"                # For exceptions which may come because of session overload,"},{"line_number":839,"context_line":"                # we retry"},{"line_number":840,"context_line":"                pass"},{"line_number":841,"context_line":"            except error_util.SessionConnectionException as excep:"},{"line_number":842,"context_line":"                # For exceptions with connections we create the session"},{"line_number":843,"context_line":"                self._create_session()"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2B7bM%3D","line":840,"in_reply_to":"AAAAUH%2F%2B8Js%3D","updated":"2014-01-20 17:20:53.000000000","message":"There\u0027s nothing else in the block. Wouldn\u0027t a blank line be a syntax error here?","commit_id":"9ccfbe3a4e430c8f9894cd75e00d63bef6758547"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"492f9e8349664d8cdd1bd57c8e23d44b4a60864f","unresolved":false,"context_lines":[{"line_number":845,"context_line":"                # If it is a proper exception, say not having furnished"},{"line_number":846,"context_line":"                # proper data in the SOAP call or the retry limit having"},{"line_number":847,"context_line":"                # exceeded, we raise the exception"},{"line_number":848,"context_line":"                break"},{"line_number":849,"context_line":"            # If retry count has been reached then break and"},{"line_number":850,"context_line":"            # raise the exception"},{"line_number":851,"context_line":"            if retry_count \u003e self._api_retry_count:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2B8Jc%3D","line":848,"updated":"2014-01-20 15:35:31.000000000","message":"it may be worthwhile leaving the variables and logging the exception here - it will certainly help debug things","commit_id":"9ccfbe3a4e430c8f9894cd75e00d63bef6758547"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"82f97d5ed42224b06d839cdc042be4af9b304415","unresolved":false,"context_lines":[{"line_number":845,"context_line":"                # If it is a proper exception, say not having furnished"},{"line_number":846,"context_line":"                # proper data in the SOAP call or the retry limit having"},{"line_number":847,"context_line":"                # exceeded, we raise the exception"},{"line_number":848,"context_line":"                break"},{"line_number":849,"context_line":"            # If retry count has been reached then break and"},{"line_number":850,"context_line":"            # raise the exception"},{"line_number":851,"context_line":"            if retry_count \u003e self._api_retry_count:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2Bv1Q%3D","line":848,"in_reply_to":"AAAAUH%2F%2B1RY%3D","updated":"2014-01-22 15:11:37.000000000","message":"Agreed. I\u0027ve moved it into a separate change to keep this change purely about removal of unused variables.","commit_id":"9ccfbe3a4e430c8f9894cd75e00d63bef6758547"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"c380654b1a2d08527c85deb34d1d4fd754cc454f","unresolved":false,"context_lines":[{"line_number":845,"context_line":"                # If it is a proper exception, say not having furnished"},{"line_number":846,"context_line":"                # proper data in the SOAP call or the retry limit having"},{"line_number":847,"context_line":"                # exceeded, we raise the exception"},{"line_number":848,"context_line":"                break"},{"line_number":849,"context_line":"            # If retry count has been reached then break and"},{"line_number":850,"context_line":"            # raise the exception"},{"line_number":851,"context_line":"            if retry_count \u003e self._api_retry_count:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2B1RY%3D","line":848,"in_reply_to":"AAAAUH%2F%2B7ZA%3D","updated":"2014-01-21 16:23:58.000000000","message":"the call method has retries. that is if a request fails for some reason then it will be retried. it wouldbe nice to know that the method has failed.\nso doing\nLOG.debug(_(\"Request failed. Iteration: %(retry). Exception: %(excep). Module: ....)","commit_id":"9ccfbe3a4e430c8f9894cd75e00d63bef6758547"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"adb258e19aead78ed6e3666f600bab8bb22b8fe5","unresolved":false,"context_lines":[{"line_number":845,"context_line":"                # If it is a proper exception, say not having furnished"},{"line_number":846,"context_line":"                # proper data in the SOAP call or the retry limit having"},{"line_number":847,"context_line":"                # exceeded, we raise the exception"},{"line_number":848,"context_line":"                break"},{"line_number":849,"context_line":"            # If retry count has been reached then break and"},{"line_number":850,"context_line":"            # raise the exception"},{"line_number":851,"context_line":"            if retry_count \u003e self._api_retry_count:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2B7ZA%3D","line":848,"in_reply_to":"AAAAUH%2F%2B8Jc%3D","updated":"2014-01-20 17:20:53.000000000","message":"Well, the exception will still be raised below. Is it worth logging an exception which will also be raised? (Possibly, I\u0027m yet familiar enough with the conventions on logging.)","commit_id":"9ccfbe3a4e430c8f9894cd75e00d63bef6758547"}],"nova/virt/vmwareapi/vmops.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"f2154890f9cd14bdd0b6de9a1ae272a83108cabf","unresolved":false,"context_lines":[{"line_number":1239,"context_line":"            reconfig_task \u003d self._session._call_method("},{"line_number":1240,"context_line":"                                            self._session._get_vim(),"},{"line_number":1241,"context_line":"                                            \"ReconfigVM_Task\", vm_ref,"},{"line_number":1242,"context_line":"                                            spec\u003dvm_resize_spec)"},{"line_number":1243,"context_line":""},{"line_number":1244,"context_line":"        # 4. Start VM"},{"line_number":1245,"context_line":"        if power_on:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2FAqE%3D","side":"PARENT","line":1242,"updated":"2014-01-19 08:46:15.000000000","message":"this is missing:\nself._session._wait_for_task(instance[\u0027uuid\u0027], reconfig_task)","commit_id":"9b1c7cbedda21f4e199226cac257560aec61ece7"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"a6d7f7f767b94b2bf1964fc2e848e8d5804aaff1","unresolved":false,"context_lines":[{"line_number":1239,"context_line":"            reconfig_task \u003d self._session._call_method("},{"line_number":1240,"context_line":"                                            self._session._get_vim(),"},{"line_number":1241,"context_line":"                                            \"ReconfigVM_Task\", vm_ref,"},{"line_number":1242,"context_line":"                                            spec\u003dvm_resize_spec)"},{"line_number":1243,"context_line":""},{"line_number":1244,"context_line":"        # 4. Start VM"},{"line_number":1245,"context_line":"        if power_on:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2FARk%3D","side":"PARENT","line":1242,"in_reply_to":"AAAAUH%2F%2FAqE%3D","updated":"2014-01-19 13:21:01.000000000","message":"i have dealt with this in https://bugs.launchpad.net/nova/+bug/1270573","commit_id":"9b1c7cbedda21f4e199226cac257560aec61ece7"}],"nova/virt/vmwareapi/volumeops.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"a781d95dcd25449c677e0b9258979f7b7d0a7531","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                   \u0027device_name\u0027: device_name, \u0027disk_type\u0027: disk_type})"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def _update_volume_details(self, vm_ref, instance, volume_uuid):"},{"line_number":79,"context_line":"        instance_name \u003d instance[\u0027name\u0027]"},{"line_number":80,"context_line":"        instance_uuid \u003d instance[\u0027uuid\u0027]"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        # Store the uuid of the volume_device"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUH%2F%2BrzU%3D","side":"PARENT","line":79,"updated":"2014-01-23 07:50:18.000000000","message":"this is removed by https://review.openstack.org/#/c/65456/","commit_id":"5a9f1fc18a6ad54451c2123686421294bf456267"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"a781d95dcd25449c677e0b9258979f7b7d0a7531","unresolved":false,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def get_volume_connector(self, instance):"},{"line_number":167,"context_line":"        \"\"\"Return volume connector information.\"\"\""},{"line_number":168,"context_line":"        instance_name \u003d instance[\u0027name\u0027]"},{"line_number":169,"context_line":"        try:"},{"line_number":170,"context_line":"            vm_ref \u003d vm_util.get_vm_ref(self._session, instance)"},{"line_number":171,"context_line":"        except exception.InstanceNotFound:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUH%2F%2BrzQ%3D","side":"PARENT","line":168,"updated":"2014-01-23 07:50:18.000000000","message":"ditto\nhttps://review.openstack.org/#/c/65456/","commit_id":"5a9f1fc18a6ad54451c2123686421294bf456267"}]}