)]}'
{"nova/tests/unit/virt/libvirt/storage/test_rbd.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2b3afb8265bc69d34e0819b564611fd85af0f9be","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        self.rbd_pool \u003d \u0027rbd\u0027"},{"line_number":86,"context_line":"        self.rbd_connect_timeout \u003d 5"},{"line_number":87,"context_line":"        self.flags(images_rbd_pool\u003dself.rbd_pool, group\u003d\u0027libvirt\u0027)"},{"line_number":88,"context_line":"        self.flags(rbd_connect_timeout\u003dself.rbd_connect_timeout,"},{"line_number":89,"context_line":"                    group\u003d\u0027libvirt\u0027)"},{"line_number":90,"context_line":"        self.driver \u003d rbd_utils.RBDDriver()"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        self.volume_name \u003d u\u0027volume-00000001\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_978eab2c","line":89,"range":{"start_line":87,"start_character":0,"end_line":89,"end_character":36},"updated":"2019-07-04 09:55:15.000000000","message":"I\u0027d prefer to see this at the top of the function since it\u0027s kind of global configuration and easy to miss otherwise. Any chance you could move it?","commit_id":"5b4d919324fd0becab10e5c2274b615c4ba203a9"}],"nova/virt/libvirt/imagebackend.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2b3afb8265bc69d34e0819b564611fd85af0f9be","unresolved":false,"context_lines":[{"line_number":847,"context_line":""},{"line_number":848,"context_line":"        self.driver \u003d rbd_utils.RBDDriver()"},{"line_number":849,"context_line":"        self.pool \u003d self.driver.pool"},{"line_number":850,"context_line":"        self.rbd_user \u003d self.driver.rbd_user"},{"line_number":851,"context_line":""},{"line_number":852,"context_line":"        path \u003d \u0027rbd:%s/%s\u0027 % (self.pool, self.rbd_name)"},{"line_number":853,"context_line":"        if self.rbd_user:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_f7a11f97","line":850,"range":{"start_line":850,"start_character":8,"end_line":850,"end_character":44},"updated":"2019-07-04 09:55:15.000000000","message":"This is a super nit, but why do you do this here","commit_id":"5b4d919324fd0becab10e5c2274b615c4ba203a9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2b3afb8265bc69d34e0819b564611fd85af0f9be","unresolved":false,"context_lines":[{"line_number":853,"context_line":"        if self.rbd_user:"},{"line_number":854,"context_line":"            path +\u003d \u0027:id\u003d\u0027 + self.rbd_user"},{"line_number":855,"context_line":"        if self.driver.ceph_conf:"},{"line_number":856,"context_line":"            path +\u003d \u0027:conf\u003d\u0027 + self.driver.ceph_conf"},{"line_number":857,"context_line":""},{"line_number":858,"context_line":"        super(Rbd, self).__init__(path, \"block\", \"rbd\", is_block_dev\u003dFalse)"},{"line_number":859,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_179f1b51","line":856,"range":{"start_line":856,"start_character":31,"end_line":856,"end_character":52},"updated":"2019-07-04 09:55:15.000000000","message":"but not here?","commit_id":"5b4d919324fd0becab10e5c2274b615c4ba203a9"}],"nova/virt/libvirt/storage/rbd_utils.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2b3afb8265bc69d34e0819b564611fd85af0f9be","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        self.pool \u003d CONF.libvirt.images_rbd_pool"},{"line_number":130,"context_line":"        self.rbd_user \u003d CONF.libvirt.rbd_user"},{"line_number":131,"context_line":"        self.rbd_connect_timeout \u003d CONF.libvirt.rbd_connect_timeout"},{"line_number":132,"context_line":"        # NOTE(angdraug): rados.Rados fails to connect if ceph_conf is None:"},{"line_number":133,"context_line":"        # https://github.com/ceph/ceph/pull/1787"},{"line_number":134,"context_line":"        self.ceph_conf \u003d CONF.libvirt.images_rbd_ceph_conf or \u0027\u0027"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def _connect_to_rados(self, pool\u003dNone):"},{"line_number":137,"context_line":"        client \u003d rados.Rados(rados_id\u003dself.rbd_user,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_b7c40742","line":134,"range":{"start_line":132,"start_character":0,"end_line":134,"end_character":64},"updated":"2019-07-04 09:55:15.000000000","message":"Clicking through the URL, it appears that this hasn\u0027t been true since 2014. Want to clean this up too (noting it in the commit message, obv)?","commit_id":"5b4d919324fd0becab10e5c2274b615c4ba203a9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4a0e1d5fbdbf25f89973b5c0ceb541c37d10f1ae","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from eventlet import tpool"},{"line_number":18,"context_line":"from six.moves import urllib"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"try:"},{"line_number":21,"context_line":"    import rados"},{"line_number":22,"context_line":"    import rbd"},{"line_number":23,"context_line":"except ImportError:"},{"line_number":24,"context_line":"    rados \u003d None"},{"line_number":25,"context_line":"    rbd \u003d None"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from oslo_concurrency import processutils"},{"line_number":28,"context_line":"from oslo_log import log as logging"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_931eaa0a","line":25,"range":{"start_line":20,"start_character":0,"end_line":25,"end_character":14},"updated":"2019-07-05 15:19:31.000000000","message":"We should probably clean this up later using oslo_util.try_import (or whatever it\u0027s called)","commit_id":"8a2d23a7e7f134d530577566ad61bfcda144cb62"}]}