)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6f039d6f37ec6d2e39d524b1c50d4b86e900f220","unresolved":false,"context_lines":[{"line_number":26,"context_line":"self._wait_for_notification(\u0027instance.unshelve.end\u0027) call to each test"},{"line_number":27,"context_line":"step to prevent the instability."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"[1] https://github.com/openstack/nova/blob/5c6c1f8fce7cd976dedc0a1ad28836ed87af2780/nova/compute/manager.py#L5322-L5326"},{"line_number":30,"context_line":"[2] https://github.com/openstack/nova/blob/5c6c1f8fce7cd976dedc0a1ad28836ed87af2780/nova/compute/manager.py#L5329"},{"line_number":31,"context_line":"[3] https://github.com/openstack/nova/blob/5c6c1f8fce7cd976dedc0a1ad28836ed87af2780/nova/tests/functional/notification_sample_tests/test_instance.py#L836"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fb8cfa7_27b47ad1","line":29,"range":{"start_line":29,"start_character":43,"end_line":29,"end_character":83},"updated":"2019-07-02 14:28:23.000000000","message":"nit: you could shorten these to like 8 characters","commit_id":"1bcbe53c5c4716decc73a39be786333673c6fa49"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b9c17d05281bc18dd50a35d441c2cd483b53c27f","unresolved":false,"context_lines":[{"line_number":26,"context_line":"self._wait_for_notification(\u0027instance.unshelve.end\u0027) call to each test"},{"line_number":27,"context_line":"step to prevent the instability."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"[1] https://github.com/openstack/nova/blob/5c6c1f8fce7cd976dedc0a1ad28836ed87af2780/nova/compute/manager.py#L5322-L5326"},{"line_number":30,"context_line":"[2] https://github.com/openstack/nova/blob/5c6c1f8fce7cd976dedc0a1ad28836ed87af2780/nova/compute/manager.py#L5329"},{"line_number":31,"context_line":"[3] https://github.com/openstack/nova/blob/5c6c1f8fce7cd976dedc0a1ad28836ed87af2780/nova/tests/functional/notification_sample_tests/test_instance.py#L836"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fb8cfa7_ea662756","line":29,"range":{"start_line":29,"start_character":43,"end_line":29,"end_character":83},"in_reply_to":"9fb8cfa7_27b47ad1","updated":"2019-07-02 15:14:15.000000000","message":"Done","commit_id":"1bcbe53c5c4716decc73a39be786333673c6fa49"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6f039d6f37ec6d2e39d524b1c50d4b86e900f220","unresolved":false,"context_lines":[{"line_number":29,"context_line":"[1] https://github.com/openstack/nova/blob/5c6c1f8fce7cd976dedc0a1ad28836ed87af2780/nova/compute/manager.py#L5322-L5326"},{"line_number":30,"context_line":"[2] https://github.com/openstack/nova/blob/5c6c1f8fce7cd976dedc0a1ad28836ed87af2780/nova/compute/manager.py#L5329"},{"line_number":31,"context_line":"[3] https://github.com/openstack/nova/blob/5c6c1f8fce7cd976dedc0a1ad28836ed87af2780/nova/tests/functional/notification_sample_tests/test_instance.py#L836"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Change-Id: Ie217523a8969326b27930d7f74e50e9b352ab7a1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fb8cfa7_87c20634","line":32,"updated":"2019-07-02 14:28:23.000000000","message":"Is there a bug for this so we can do backports if this is a racy test that fails in the gate?","commit_id":"1bcbe53c5c4716decc73a39be786333673c6fa49"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b9c17d05281bc18dd50a35d441c2cd483b53c27f","unresolved":false,"context_lines":[{"line_number":29,"context_line":"[1] https://github.com/openstack/nova/blob/5c6c1f8fce7cd976dedc0a1ad28836ed87af2780/nova/compute/manager.py#L5322-L5326"},{"line_number":30,"context_line":"[2] https://github.com/openstack/nova/blob/5c6c1f8fce7cd976dedc0a1ad28836ed87af2780/nova/compute/manager.py#L5329"},{"line_number":31,"context_line":"[3] https://github.com/openstack/nova/blob/5c6c1f8fce7cd976dedc0a1ad28836ed87af2780/nova/tests/functional/notification_sample_tests/test_instance.py#L836"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Change-Id: Ie217523a8969326b27930d7f74e50e9b352ab7a1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fb8cfa7_cad7a3c0","line":32,"in_reply_to":"9fb8cfa7_2710faa8","updated":"2019-07-02 15:14:15.000000000","message":"I did not found any hit in logstash but I can got reports form downstream and I was able to reproduce it locally by running the test for an hour.\n\nI filed the bug 1835070","commit_id":"1bcbe53c5c4716decc73a39be786333673c6fa49"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"202f238a0d7e943a28f210474014ae5ed3d30cb4","unresolved":false,"context_lines":[{"line_number":29,"context_line":"[1] https://github.com/openstack/nova/blob/5c6c1f8fce7cd976dedc0a1ad28836ed87af2780/nova/compute/manager.py#L5322-L5326"},{"line_number":30,"context_line":"[2] https://github.com/openstack/nova/blob/5c6c1f8fce7cd976dedc0a1ad28836ed87af2780/nova/compute/manager.py#L5329"},{"line_number":31,"context_line":"[3] https://github.com/openstack/nova/blob/5c6c1f8fce7cd976dedc0a1ad28836ed87af2780/nova/tests/functional/notification_sample_tests/test_instance.py#L836"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Change-Id: Ie217523a8969326b27930d7f74e50e9b352ab7a1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fb8cfa7_2710faa8","line":32,"in_reply_to":"9fb8cfa7_87c20634","updated":"2019-07-02 14:34:12.000000000","message":"Agree a bug would be good, better safe than sorry [1][2].\n\n[1] https://review.opendev.org/#/c/641138/1//COMMIT_MSG@16\n[2] Yes, I\u0027m going to use this forever now.","commit_id":"1bcbe53c5c4716decc73a39be786333673c6fa49"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"bbaa51ea34530e61397face589b1fd5760135925","unresolved":false,"context_lines":[{"line_number":30,"context_line":"[2] https://github.com/openstack/nova/blob/5c6c1f8f/nova/compute/manager.py#L5329"},{"line_number":31,"context_line":"[3] https://github.com/openstack/nova/blob/5c6c1f8f/nova/tests/functional/notification_sample_tests/test_instance.py#L836"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Closes-Bug: #1835070"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Change-Id: Ie217523a8969326b27930d7f74e50e9b352ab7a1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fb8cfa7_8aa8cb20","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":20},"updated":"2019-07-02 15:15:28.000000000","message":"✔","commit_id":"40f1e7c4c22dc6023614b34f28bb7fc416b668a8"}],"nova/tests/functional/notification_sample_tests/test_instance.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6127bb1fc4cb98e9782309ddb3d9c467450db25d","unresolved":false,"context_lines":[{"line_number":359,"context_line":"            self._test_restore_server,"},{"line_number":360,"context_line":"            self._test_suspend_resume_server,"},{"line_number":361,"context_line":"            self._test_pause_unpause_server,"},{"line_number":362,"context_line":"            self._test_shelve_and_shelve_offload_server,"},{"line_number":363,"context_line":"            self._test_unshelve_server,"},{"line_number":364,"context_line":"            self._test_resize_and_revert_server,"},{"line_number":365,"context_line":"            self._test_snapshot_server,"},{"line_number":366,"context_line":"            self._test_reboot_server,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_876a067f","line":363,"range":{"start_line":362,"start_character":11,"end_line":363,"end_character":39},"updated":"2019-07-02 14:20:29.000000000","message":"so discussing this more on irc we could combine these into one step to avoid the ineffince of unshvelving and shelving again between these steps. as gibi pointed out this is need because of the precondtion on line 384 below that server is active between all steps.\n\ngiven that we are using a fake driver and not actully spinning up instastnace that need to be snapshot and uplated to galcne and then downloaed againg to do the shvele/unshelve it think this is proably fine as is.\n\nif this was tempest i think we should really be optimising but for functional test it should not be too expensive.","commit_id":"1bcbe53c5c4716decc73a39be786333673c6fa49"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e3c5343d6b14df7e3f7ef970441b5d558333cb6d","unresolved":false,"context_lines":[{"line_number":814,"context_line":"                \u0027uuid\u0027: server[\u0027id\u0027]},"},{"line_number":815,"context_line":"            actual\u003dfake_notifier.VERSIONED_NOTIFICATIONS[1])"},{"line_number":816,"context_line":""},{"line_number":817,"context_line":"        self.api.post_server_action(server[\u0027id\u0027], {\u0027unshelve\u0027: None})"},{"line_number":818,"context_line":"        self._wait_for_state_change(self.api, server, \u0027ACTIVE\u0027)"},{"line_number":819,"context_line":"        self._wait_for_notification(\u0027instance.unshelve.end\u0027)"},{"line_number":820,"context_line":""},{"line_number":821,"context_line":"    def _test_unshelve_server(self, server):"},{"line_number":822,"context_line":"        # setting the shelved_offload_time to 0 should set the"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_7b2f6cf5","line":819,"range":{"start_line":817,"start_character":7,"end_line":819,"end_character":60},"updated":"2019-07-02 14:00:37.000000000","message":"here we are not asserting that we ever recive unshelv.end\nso unless you add a sel._verify_notifiction ...\nfor unshelve start and end i dont think this change makes sense.\ni would remove these 3 lines as its not part of testign shel and shelve offload\n\nit is tested seperatly in the test below.","commit_id":"1bcbe53c5c4716decc73a39be786333673c6fa49"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"649330b88c65db637014cd9f9b217cfc4e7caa41","unresolved":false,"context_lines":[{"line_number":814,"context_line":"                \u0027uuid\u0027: server[\u0027id\u0027]},"},{"line_number":815,"context_line":"            actual\u003dfake_notifier.VERSIONED_NOTIFICATIONS[1])"},{"line_number":816,"context_line":""},{"line_number":817,"context_line":"        self.api.post_server_action(server[\u0027id\u0027], {\u0027unshelve\u0027: None})"},{"line_number":818,"context_line":"        self._wait_for_state_change(self.api, server, \u0027ACTIVE\u0027)"},{"line_number":819,"context_line":"        self._wait_for_notification(\u0027instance.unshelve.end\u0027)"},{"line_number":820,"context_line":""},{"line_number":821,"context_line":"    def _test_unshelve_server(self, server):"},{"line_number":822,"context_line":"        # setting the shelved_offload_time to 0 should set the"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_dbdbf8e9","line":819,"range":{"start_line":817,"start_character":7,"end_line":819,"end_character":60},"in_reply_to":"9fb8cfa7_7b2f6cf5","updated":"2019-07-02 14:05:44.000000000","message":"This is not here to assert how unshelve works but to push the instance state back to ACTIVE before the next test step starts. (See L342 for the test case itself).\n\nIf you are wondering why we have this kind of single instance multiple test steps setup, then the answer is speed. In the past I was asked not to boot up a separate instance for each functional sample test case so I combined them to a single test case.","commit_id":"1bcbe53c5c4716decc73a39be786333673c6fa49"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e3c5343d6b14df7e3f7ef970441b5d558333cb6d","unresolved":false,"context_lines":[{"line_number":834,"context_line":"        post \u003d {\u0027unshelve\u0027: None}"},{"line_number":835,"context_line":"        self.api.post_server_action(server[\u0027id\u0027], post)"},{"line_number":836,"context_line":"        self._wait_for_state_change(self.admin_api, server, \u0027ACTIVE\u0027)"},{"line_number":837,"context_line":"        self._wait_for_notification(\u0027instance.unshelve.end\u0027)"},{"line_number":838,"context_line":"        self.assertEqual(9, len(fake_notifier.VERSIONED_NOTIFICATIONS))"},{"line_number":839,"context_line":"        self._verify_notification("},{"line_number":840,"context_line":"            \u0027instance-unshelve-start\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_3be7b4e5","line":837,"range":{"start_line":837,"start_character":58,"end_line":837,"end_character":60},"updated":"2019-07-02 14:00:37.000000000","message":"ok so we were racing on the fact that we waited for the server to be active but not for the notifiaction to be sent\n\nthis makes snese in this context","commit_id":"1bcbe53c5c4716decc73a39be786333673c6fa49"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"649330b88c65db637014cd9f9b217cfc4e7caa41","unresolved":false,"context_lines":[{"line_number":834,"context_line":"        post \u003d {\u0027unshelve\u0027: None}"},{"line_number":835,"context_line":"        self.api.post_server_action(server[\u0027id\u0027], post)"},{"line_number":836,"context_line":"        self._wait_for_state_change(self.admin_api, server, \u0027ACTIVE\u0027)"},{"line_number":837,"context_line":"        self._wait_for_notification(\u0027instance.unshelve.end\u0027)"},{"line_number":838,"context_line":"        self.assertEqual(9, len(fake_notifier.VERSIONED_NOTIFICATIONS))"},{"line_number":839,"context_line":"        self._verify_notification("},{"line_number":840,"context_line":"            \u0027instance-unshelve-start\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_bbdc04e1","line":837,"range":{"start_line":837,"start_character":58,"end_line":837,"end_character":60},"in_reply_to":"9fb8cfa7_3be7b4e5","updated":"2019-07-02 14:05:44.000000000","message":"yes","commit_id":"1bcbe53c5c4716decc73a39be786333673c6fa49"}]}