)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"ee7710665689cf3c2f40826639626f9b12ebe684","unresolved":false,"context_lines":[{"line_number":19,"context_line":"As a result of this and a complete lack of any test coverage in the gate"},{"line_number":20,"context_line":"we can now remove this unreachable code from Nova. It might be desirable"},{"line_number":21,"context_line":"to reintroduce this support later but this should take the form of an"},{"line_number":22,"context_line":"extracted volume driver and a new ``driver_volume_type`` in Cinder."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Closes-Bug: #1501447"},{"line_number":25,"context_line":"Change-Id: I1043287fe8063c4b2af07c997a931a7097518ca9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fb8cfa7_ba8e3077","line":22,"range":{"start_line":22,"start_character":24,"end_line":22,"end_character":66},"updated":"2019-07-03 07:17:18.000000000","message":"Sleeping on this, it might be better to just make this configurable again for the iscsi type.","commit_id":"9629820ee5f18c1f0acf3763796f78ab3363b20b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e0fcdf07bf3ed91b34c27e2775aff845fc64d23f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Ieb9a03d308495be4e8c54b5c6c0ff781ea7f0559 introduced support for using"},{"line_number":10,"context_line":"QEMU\u0027s native iSCSI initiator support way back in Kilo. However this was"},{"line_number":11,"context_line":"only enabled when the LibvirtNetVolumeDriver class was configured as the"},{"line_number":12,"context_line":"``iscsi`` volume driver via the ``[libvirt]\\volume_drivers`` configurable."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Unfortunatley this configurable was removed in Liberty by"},{"line_number":15,"context_line":"I832820499ec3304132379ad9b9d1ee92c5a75b61 essentially rendering this"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_97030b0e","line":12,"range":{"start_line":12,"start_character":43,"end_line":12,"end_character":44},"updated":"2019-07-04 09:45:50.000000000","message":"odd choice but okay","commit_id":"163b941020780a0e4d11b2be656aad054509b39a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e0fcdf07bf3ed91b34c27e2775aff845fc64d23f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"only enabled when the LibvirtNetVolumeDriver class was configured as the"},{"line_number":12,"context_line":"``iscsi`` volume driver via the ``[libvirt]\\volume_drivers`` configurable."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Unfortunatley this configurable was removed in Liberty by"},{"line_number":15,"context_line":"I832820499ec3304132379ad9b9d1ee92c5a75b61 essentially rendering this"},{"line_number":16,"context_line":"``iscsi`` based  codepath dead ever since unless operators manually"},{"line_number":17,"context_line":"hacked the now static ``libvirt_volume_drivers`` list within driver.py."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_f7111f55","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":13},"updated":"2019-07-04 09:45:50.000000000","message":"Unfortunately","commit_id":"163b941020780a0e4d11b2be656aad054509b39a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e0fcdf07bf3ed91b34c27e2775aff845fc64d23f","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Unfortunatley this configurable was removed in Liberty by"},{"line_number":15,"context_line":"I832820499ec3304132379ad9b9d1ee92c5a75b61 essentially rendering this"},{"line_number":16,"context_line":"``iscsi`` based  codepath dead ever since unless operators manually"},{"line_number":17,"context_line":"hacked the now static ``libvirt_volume_drivers`` list within driver.py."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"As a result of this and a complete lack of any test coverage in the gate"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_774c4f76","line":16,"range":{"start_line":16,"start_character":17,"end_line":16,"end_character":25},"updated":"2019-07-04 09:45:50.000000000","message":"code path","commit_id":"163b941020780a0e4d11b2be656aad054509b39a"}],"nova/virt/libvirt/volume/net.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e0fcdf07bf3ed91b34c27e2775aff845fc64d23f","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        # to call through for these secret CRUD operations so the volume driver"},{"line_number":35,"context_line":"        # doesn\u0027t need to know the internal attributes of the connection"},{"line_number":36,"context_line":"        # object."},{"line_number":37,"context_line":"        secret \u003d self.host.find_secret(conf.source_protocol,"},{"line_number":38,"context_line":"                                                   conf.source_name)"},{"line_number":39,"context_line":"        if secret is None:"},{"line_number":40,"context_line":"            secret \u003d self.host.create_secret(conf.source_protocol,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_77d1af57","side":"PARENT","line":37,"range":{"start_line":37,"start_character":27,"end_line":37,"end_character":38},"updated":"2019-07-04 09:45:50.000000000","message":"Note to self: This still has other callers","commit_id":"3c5aec113c4f2e6e5811b3e9be333c80fb740ad8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e0fcdf07bf3ed91b34c27e2775aff845fc64d23f","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        secret \u003d self.host.find_secret(conf.source_protocol,"},{"line_number":38,"context_line":"                                                   conf.source_name)"},{"line_number":39,"context_line":"        if secret is None:"},{"line_number":40,"context_line":"            secret \u003d self.host.create_secret(conf.source_protocol,"},{"line_number":41,"context_line":"                                                         conf.source_name,"},{"line_number":42,"context_line":"                                                         password)"},{"line_number":43,"context_line":"        return secret.UUIDString()"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_d7e2e32f","side":"PARENT","line":40,"range":{"start_line":40,"start_character":31,"end_line":40,"end_character":44},"updated":"2019-07-04 09:45:50.000000000","message":"As does this","commit_id":"3c5aec113c4f2e6e5811b3e9be333c80fb740ad8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e0fcdf07bf3ed91b34c27e2775aff845fc64d23f","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            usage_type \u003d \u0027iscsi\u0027"},{"line_number":52,"context_line":"            usage_name \u003d (\"%(target_iqn)s/%(target_lun)s\" %"},{"line_number":53,"context_line":"                          netdisk_properties)"},{"line_number":54,"context_line":"            self.host.delete_secret(usage_type, usage_name)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def _set_auth_config_rbd(self, conf, netdisk_properties):"},{"line_number":57,"context_line":"        # The rbd volume driver in cinder sets auth_enabled if the rbd_user is"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_37cb37a6","side":"PARENT","line":54,"range":{"start_line":54,"start_character":22,"end_line":54,"end_character":35},"updated":"2019-07-04 09:45:50.000000000","message":"And this","commit_id":"3c5aec113c4f2e6e5811b3e9be333c80fb740ad8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e0fcdf07bf3ed91b34c27e2775aff845fc64d23f","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            self._set_auth_config_rbd(conf, netdisk_properties)"},{"line_number":83,"context_line":"        return conf"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def disconnect_volume(self, connection_info, instance):"},{"line_number":86,"context_line":"        \"\"\"Detach the volume from instance_name.\"\"\""},{"line_number":87,"context_line":"        super(LibvirtNetVolumeDriver,"},{"line_number":88,"context_line":"              self).disconnect_volume(connection_info, instance)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def extend_volume(self, connection_info, instance, requested_size):"},{"line_number":91,"context_line":"        # There is nothing to do for network volumes. Cinder already extended"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_bc062e20","line":88,"range":{"start_line":85,"start_character":0,"end_line":88,"end_character":64},"updated":"2019-07-04 09:45:50.000000000","message":"Perhaps just drop this entirely now?","commit_id":"163b941020780a0e4d11b2be656aad054509b39a"}]}