)]}'
{"id":"openstack%2Fnova~668806","triplet_id":"openstack%2Fnova~stable%2Fstein~Ie217523a8969326b27930d7f74e50e9b352ab7a1","project":"openstack/nova","branch":"stable/stein","topic":"bug/1835070","hashtags":[],"change_id":"Ie217523a8969326b27930d7f74e50e9b352ab7a1","subject":"Stabilize unshelve notification sample tests","status":"MERGED","created":"2019-07-03 07:25:21.000000000","updated":"2019-07-03 21:42:03.000000000","submitted":"2019-07-03 21:42:03.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"668806-1562190123791-31ef7618","meta_rev_id":"2becc4da8aea9507353bfc469edae0eb8e2622e8","_number":668806,"virtual_id_number":668806,"owner":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2019-07-03 09:43:23.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":2,"date":"2019-07-03 21:42:03.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"all":[{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":2,"date":"2019-07-03 19:11:21.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"all":[{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":1,"date":"2019-07-03 19:11:21.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-07-03 09:43:23.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2019-07-03 19:11:21.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2019-07-03 21:42:03.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"b0f0ddce4ef602ece8cf9b9c888e7e2935567d62","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2019-07-03 07:25:21.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"912492f77ca60d4deb5f6e2451230d320a3abf62","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-03 08:51:39.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover http://logs.openstack.org/06/668806/1/check/openstack-tox-cover/e1d1517/cover/ : SUCCESS in 14m 54s\n- openstack-tox-lower-constraints http://logs.openstack.org/06/668806/1/check/openstack-tox-lower-constraints/49386c3/ : SUCCESS in 12m 11s\n- openstack-tox-pep8 http://logs.openstack.org/06/668806/1/check/openstack-tox-pep8/9001899/ : SUCCESS in 8m 16s\n- openstack-tox-py27 http://logs.openstack.org/06/668806/1/check/openstack-tox-py27/e7c3756/ : SUCCESS in 12m 48s\n- openstack-tox-py35 http://logs.openstack.org/06/668806/1/check/openstack-tox-py35/5d94328/ : SUCCESS in 14m 44s\n- openstack-tox-py36 http://logs.openstack.org/06/668806/1/check/openstack-tox-py36/32b3ab6/ : SUCCESS in 11m 40s\n- openstack-tox-py37 http://logs.openstack.org/06/668806/1/check/openstack-tox-py37/b352b0b/ : SUCCESS in 16m 14s\n- openstack-tox-docs http://logs.openstack.org/06/668806/1/check/openstack-tox-docs/1e216a1/html/ : SUCCESS in 6m 09s\n- nova-tox-functional http://logs.openstack.org/06/668806/1/check/nova-tox-functional/86bc678/ : SUCCESS in 18m 30s\n- nova-tox-functional-py35 http://logs.openstack.org/06/668806/1/check/nova-tox-functional-py35/499a6a0/ : SUCCESS in 25m 43s","accounts_in_message":[],"_revision_number":1},{"id":"898adf6de6d335a0d440582646b1f633fa16d7d0","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-07-03 09:43:23.000000000","message":"Patch Set 1:\n\nBuild succeeded.\n\n- nova http://cloudbase-ci.com/nova/668806/1 : SUCCESS in 2h 17m 22s","accounts_in_message":[],"_revision_number":1},{"id":"4b02cd0532207ae404f1f7ab0ab4a532d8f8c5bd","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2019-07-03 10:38:22.000000000","message":"Topic changed from bug/1835070-stable/stein to bug/1835070","accounts_in_message":[],"_revision_number":1},{"id":"d849339302aff3fb1f8fa83708d3b29af6007ee3","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-07-03 19:11:21.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nLGTM and this is a trivial test-only change so I\u0027m going to fast approve.","accounts_in_message":[],"_revision_number":1},{"id":"2129251906a2c9baaf3bc964f345c5b07aa3cae5","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-03 19:11:43.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"54061b492541e0e6869efd5cb05c49fc5866e63a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-03 21:42:03.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints http://logs.openstack.org/06/668806/1/gate/openstack-tox-lower-constraints/6e571e0/ : SUCCESS in 12m 49s\n- openstack-tox-pep8 http://logs.openstack.org/06/668806/1/gate/openstack-tox-pep8/90fd5a1/ : SUCCESS in 8m 22s\n- openstack-tox-py27 http://logs.openstack.org/06/668806/1/gate/openstack-tox-py27/7faf20c/ : SUCCESS in 16m 18s\n- openstack-tox-py35 http://logs.openstack.org/06/668806/1/gate/openstack-tox-py35/87d578a/ : SUCCESS in 14m 47s\n- openstack-tox-py36 http://logs.openstack.org/06/668806/1/gate/openstack-tox-py36/4a23dfb/ : SUCCESS in 12m 41s\n- openstack-tox-py37 http://logs.openstack.org/06/668806/1/gate/openstack-tox-py37/42d64eb/ : SUCCESS in 12m 28s\n- openstack-tox-docs http://logs.openstack.org/06/668806/1/gate/openstack-tox-docs/e056bc2/html/ : SUCCESS in 6m 52s\n- nova-tox-functional http://logs.openstack.org/06/668806/1/gate/nova-tox-functional/ade6de5/ : SUCCESS in 20m 26s\n- nova-tox-functional-py35 http://logs.openstack.org/06/668806/1/gate/nova-tox-functional-py35/a1ac90e/ : SUCCESS in 23m 16s","accounts_in_message":[],"_revision_number":1},{"id":"2becc4da8aea9507353bfc469edae0eb8e2622e8","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-03 21:42:03.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"3bc6ff029ff24083844db363010988d8d08cff00","revisions":{"3bc6ff029ff24083844db363010988d8d08cff00":{"kind":"REWORK","_number":1,"created":"2019-07-03 07:25:21.000000000","uploader":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"ref":"refs/changes/06/668806/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/06/668806/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/06/668806/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/06/668806/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/06/668806/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/06/668806/1"}}},"commit":{"parents":[{"commit":"b01bc2fd32975b57f2dec3bf2d1cd6ce468e3862","subject":"Merge \"Init HostState.failed_builds\" into stable/stein","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b01bc2fd32975b57f2dec3bf2d1cd6ce468e3862"}]}],"author":{"name":"Balazs Gibizer","email":"balazs.gibizer@est.tech","date":"2019-07-02 12:56:40.000000000","tz":120},"committer":{"name":"Balazs Gibizer","email":"balazs.gibizer@est.tech","date":"2019-07-03 07:25:21.000000000","tz":0},"subject":"Stabilize unshelve notification sample tests","message":"Stabilize unshelve notification sample tests\n\nThe notification sample test for unshelve waits for the instance to\nreach ACTIVE state and then asserts if unshelve.end notification is\nemitted properly. However the instance.vm_state is set to ACTIVE earlier[1]\nthan emitting the unshelve.end notification[2]. This can cause two\ndifferent test case failure.\n\n1) _test_unshelve_server() fails with no ushelve.end notification\nreceived.\n\n2) _test_shelve_and_shelve_offload_server() also has a unshelve action\nat the end and that test step also only waits for the the ACTIVE state.\nSo the unshelve.end notification from the end of\n_test_shelve_and_shelve_offload_server() can bleed into the\n_test_unshelve_server() step causing that it receive one more\nnotifications.\n\nSo this patch adds an extra\nself._wait_for_notification(\u0027instance.unshelve.end\u0027) call to each test\nstep to prevent the instability.\n\n[1] https://github.com/openstack/nova/blob/5c6c1f8f/nova/compute/manager.py#L5322-L5326\n[2] https://github.com/openstack/nova/blob/5c6c1f8f/nova/compute/manager.py#L5329\n[3] https://github.com/openstack/nova/blob/5c6c1f8f/nova/tests/functional/notification_sample_tests/test_instance.py#L836\n\nCloses-Bug: #1835070\n\nChange-Id: Ie217523a8969326b27930d7f74e50e9b352ab7a1\n(cherry picked from commit 40f1e7c4c22dc6023614b34f28bb7fc416b668a8)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3bc6ff029ff24083844db363010988d8d08cff00"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3bc6ff029ff24083844db363010988d8d08cff00"}]},"branch":"refs/heads/stable/stein"}},"requirements":[],"submit_records":[],"submit_requirements":[]}