)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"9306f1334e58ff1dc7b9996cb90eb0331a16f2d0","unresolved":false,"context_lines":[{"line_number":7,"context_line":"libvirt: Remove MIN_{QEMU,LIBVIRT}_LUKS_VERSION"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The MIN_LIBVIRT_LUKS_VERSION and MIN_QEMU_LUKS_VERSION constants[*] are"},{"line_number":10,"context_line":"now longer required.  The updated minimum required libvirt (3.0.0) and"},{"line_number":11,"context_line":"QEMU (2.8.0) for \"Stein\" satisfy the version requirements.  So we can"},{"line_number":12,"context_line":"drop the compatibility code."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Also remove / fix relevant unit tests."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_a1a5a5b7","line":11,"range":{"start_line":10,"start_character":22,"end_line":11,"end_character":58},"updated":"2019-07-04 08:29:58.000000000","message":"Can you reference the change or commit? \n\nI408baef12358a83921c4693b847a692f6c19e36f","commit_id":"704eb9a3a71bf07dc844bda65eeb4b8dafcaf3f6"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"6e473136c949daf2720bea17fbd17434fdf51744","unresolved":false,"context_lines":[{"line_number":8569,"context_line":"        # The required QEMU and Libvirt versions are always available"},{"line_number":8570,"context_line":"        # on the host and a valid LUKS provider is present within the"},{"line_number":8571,"context_line":"        # encryption metadata dict."},{"line_number":8572,"context_line":"        mock_has_min_version.return_value \u003d True"},{"line_number":8573,"context_line":"        self.assertFalse(drvr._use_native_luks({}))"},{"line_number":8574,"context_line":"        self.assertFalse(drvr._use_native_luks({"},{"line_number":8575,"context_line":"            \u0027provider\u0027: \u0027nova.volume.encryptors.cryptsetup.CryptSetupEncryptor\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_dcd68af2","line":8572,"range":{"start_line":8572,"start_character":0,"end_line":8572,"end_character":48},"updated":"2019-07-04 09:13:09.000000000","message":"nit - We don\u0027t need that anymore but I can clean this up in my follow up.","commit_id":"704eb9a3a71bf07dc844bda65eeb4b8dafcaf3f6"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"945387164eb03f9b9b7bb2f0a109d375bf4b84f6","unresolved":false,"context_lines":[{"line_number":8569,"context_line":"        # The required QEMU and Libvirt versions are always available"},{"line_number":8570,"context_line":"        # on the host and a valid LUKS provider is present within the"},{"line_number":8571,"context_line":"        # encryption metadata dict."},{"line_number":8572,"context_line":"        mock_has_min_version.return_value \u003d True"},{"line_number":8573,"context_line":"        self.assertFalse(drvr._use_native_luks({}))"},{"line_number":8574,"context_line":"        self.assertFalse(drvr._use_native_luks({"},{"line_number":8575,"context_line":"            \u0027provider\u0027: \u0027nova.volume.encryptors.cryptsetup.CryptSetupEncryptor\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_b7f2c799","line":8572,"range":{"start_line":8572,"start_character":0,"end_line":8572,"end_character":48},"in_reply_to":"7faddb67_dcd68af2","updated":"2019-07-04 09:58:09.000000000","message":"I41b7c1653c6a887ee4b08e588c5d422409aebfba","commit_id":"704eb9a3a71bf07dc844bda65eeb4b8dafcaf3f6"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"9306f1334e58ff1dc7b9996cb90eb0331a16f2d0","unresolved":false,"context_lines":[{"line_number":1412,"context_line":"        return vol_driver.extend_volume(connection_info, instance,"},{"line_number":1413,"context_line":"                                        requested_size)"},{"line_number":1414,"context_line":""},{"line_number":1415,"context_line":"    def _use_native_luks(self, encryption\u003dNone):"},{"line_number":1416,"context_line":"        \"\"\"Check if LUKS is the required \u0027provider\u0027"},{"line_number":1417,"context_line":"        \"\"\""},{"line_number":1418,"context_line":"        provider \u003d None"},{"line_number":1419,"context_line":"        if encryption:"},{"line_number":1420,"context_line":"            provider \u003d encryption.get(\u0027provider\u0027, None)"},{"line_number":1421,"context_line":"        if provider in encryptors.LEGACY_PROVIDER_CLASS_TO_FORMAT_MAP:"},{"line_number":1422,"context_line":"            provider \u003d encryptors.LEGACY_PROVIDER_CLASS_TO_FORMAT_MAP[provider]"},{"line_number":1423,"context_line":"        return provider \u003d\u003d encryptors.LUKS"},{"line_number":1424,"context_line":""},{"line_number":1425,"context_line":"    def _get_volume_config(self, connection_info, disk_info):"},{"line_number":1426,"context_line":"        vol_driver \u003d self._get_volume_driver(connection_info)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_619d6d58","line":1423,"range":{"start_line":1415,"start_character":0,"end_line":1423,"end_character":42},"updated":"2019-07-04 08:29:58.000000000","message":"This can also go now.","commit_id":"704eb9a3a71bf07dc844bda65eeb4b8dafcaf3f6"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"945387164eb03f9b9b7bb2f0a109d375bf4b84f6","unresolved":false,"context_lines":[{"line_number":1412,"context_line":"        return vol_driver.extend_volume(connection_info, instance,"},{"line_number":1413,"context_line":"                                        requested_size)"},{"line_number":1414,"context_line":""},{"line_number":1415,"context_line":"    def _use_native_luks(self, encryption\u003dNone):"},{"line_number":1416,"context_line":"        \"\"\"Check if LUKS is the required \u0027provider\u0027"},{"line_number":1417,"context_line":"        \"\"\""},{"line_number":1418,"context_line":"        provider \u003d None"},{"line_number":1419,"context_line":"        if encryption:"},{"line_number":1420,"context_line":"            provider \u003d encryption.get(\u0027provider\u0027, None)"},{"line_number":1421,"context_line":"        if provider in encryptors.LEGACY_PROVIDER_CLASS_TO_FORMAT_MAP:"},{"line_number":1422,"context_line":"            provider \u003d encryptors.LEGACY_PROVIDER_CLASS_TO_FORMAT_MAP[provider]"},{"line_number":1423,"context_line":"        return provider \u003d\u003d encryptors.LUKS"},{"line_number":1424,"context_line":""},{"line_number":1425,"context_line":"    def _get_volume_config(self, connection_info, disk_info):"},{"line_number":1426,"context_line":"        vol_driver \u003d self._get_volume_driver(connection_info)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_5704b37b","line":1423,"range":{"start_line":1415,"start_character":0,"end_line":1423,"end_character":42},"in_reply_to":"7faddb67_619d6d58","updated":"2019-07-04 09:58:09.000000000","message":"I41b7c1653c6a887ee4b08e588c5d422409aebfba","commit_id":"704eb9a3a71bf07dc844bda65eeb4b8dafcaf3f6"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"9306f1334e58ff1dc7b9996cb90eb0331a16f2d0","unresolved":false,"context_lines":[{"line_number":8379,"context_line":""},{"line_number":8380,"context_line":"        for bdm in block_device_mapping:"},{"line_number":8381,"context_line":"            connection_info \u003d bdm[\u0027connection_info\u0027]"},{"line_number":8382,"context_line":"            # NOTE(lyarwood): Handle the P to Q LM during upgrade use case"},{"line_number":8383,"context_line":"            # where an instance has encrypted volumes attached using the"},{"line_number":8384,"context_line":"            # os-brick encryptors. Do not attempt to attach the encrypted"},{"line_number":8385,"context_line":"            # volume using native LUKS decryption on the destionation."},{"line_number":8386,"context_line":"            src_native_luks \u003d False"},{"line_number":8387,"context_line":"            if migrate_data.obj_attr_is_set(\u0027src_supports_native_luks\u0027):"},{"line_number":8388,"context_line":"                src_native_luks \u003d migrate_data.src_supports_native_luks"},{"line_number":8389,"context_line":"            self._connect_volume(context, connection_info, instance,"},{"line_number":8390,"context_line":"                                 allow_native_luks\u003dsrc_native_luks)"},{"line_number":8391,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_81898927","line":8388,"range":{"start_line":8382,"start_character":0,"end_line":8388,"end_character":71},"updated":"2019-07-04 08:29:58.000000000","message":"Thinking about this, if the requirements were met in stein and we are now on train I think we can actually drop all of this compat code.","commit_id":"704eb9a3a71bf07dc844bda65eeb4b8dafcaf3f6"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"945387164eb03f9b9b7bb2f0a109d375bf4b84f6","unresolved":false,"context_lines":[{"line_number":8379,"context_line":""},{"line_number":8380,"context_line":"        for bdm in block_device_mapping:"},{"line_number":8381,"context_line":"            connection_info \u003d bdm[\u0027connection_info\u0027]"},{"line_number":8382,"context_line":"            # NOTE(lyarwood): Handle the P to Q LM during upgrade use case"},{"line_number":8383,"context_line":"            # where an instance has encrypted volumes attached using the"},{"line_number":8384,"context_line":"            # os-brick encryptors. Do not attempt to attach the encrypted"},{"line_number":8385,"context_line":"            # volume using native LUKS decryption on the destionation."},{"line_number":8386,"context_line":"            src_native_luks \u003d False"},{"line_number":8387,"context_line":"            if migrate_data.obj_attr_is_set(\u0027src_supports_native_luks\u0027):"},{"line_number":8388,"context_line":"                src_native_luks \u003d migrate_data.src_supports_native_luks"},{"line_number":8389,"context_line":"            self._connect_volume(context, connection_info, instance,"},{"line_number":8390,"context_line":"                                 allow_native_luks\u003dsrc_native_luks)"},{"line_number":8391,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_f7f83f7d","line":8388,"range":{"start_line":8382,"start_character":0,"end_line":8388,"end_character":71},"in_reply_to":"7faddb67_81898927","updated":"2019-07-04 09:58:09.000000000","message":"I41b7c1653c6a887ee4b08e588c5d422409aebfba","commit_id":"704eb9a3a71bf07dc844bda65eeb4b8dafcaf3f6"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"9306f1334e58ff1dc7b9996cb90eb0331a16f2d0","unresolved":false,"context_lines":[{"line_number":8387,"context_line":"            if migrate_data.obj_attr_is_set(\u0027src_supports_native_luks\u0027):"},{"line_number":8388,"context_line":"                src_native_luks \u003d migrate_data.src_supports_native_luks"},{"line_number":8389,"context_line":"            self._connect_volume(context, connection_info, instance,"},{"line_number":8390,"context_line":"                                 allow_native_luks\u003dsrc_native_luks)"},{"line_number":8391,"context_line":""},{"line_number":8392,"context_line":"        self._pre_live_migration_plug_vifs("},{"line_number":8393,"context_line":"            instance, network_info, migrate_data)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_410e31e6","line":8390,"range":{"start_line":8390,"start_character":33,"end_line":8390,"end_character":66},"updated":"2019-07-04 08:29:58.000000000","message":"I think we can also drop this kwarg from _connect_volume.","commit_id":"704eb9a3a71bf07dc844bda65eeb4b8dafcaf3f6"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"945387164eb03f9b9b7bb2f0a109d375bf4b84f6","unresolved":false,"context_lines":[{"line_number":8387,"context_line":"            if migrate_data.obj_attr_is_set(\u0027src_supports_native_luks\u0027):"},{"line_number":8388,"context_line":"                src_native_luks \u003d migrate_data.src_supports_native_luks"},{"line_number":8389,"context_line":"            self._connect_volume(context, connection_info, instance,"},{"line_number":8390,"context_line":"                                 allow_native_luks\u003dsrc_native_luks)"},{"line_number":8391,"context_line":""},{"line_number":8392,"context_line":"        self._pre_live_migration_plug_vifs("},{"line_number":8393,"context_line":"            instance, network_info, migrate_data)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_17f63b91","line":8390,"range":{"start_line":8390,"start_character":33,"end_line":8390,"end_character":66},"in_reply_to":"7faddb67_410e31e6","updated":"2019-07-04 09:58:09.000000000","message":"I41b7c1653c6a887ee4b08e588c5d422409aebfba","commit_id":"704eb9a3a71bf07dc844bda65eeb4b8dafcaf3f6"}]}