)]}'
{"nova/virt/osinfo.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c746db934d347276fb883899892ba1d7818c6699","unresolved":false,"context_lines":[{"line_number":104,"context_line":"            devs \u003d self._os_obj.get_all_devices(fltr)"},{"line_number":105,"context_line":"            if devs.get_length():"},{"line_number":106,"context_line":"                net_model \u003d devs.get_nth(0).get_name()"},{"line_number":107,"context_line":"                # convert to valid libvirt values"},{"line_number":108,"context_line":"                if net_model in [\u0027virtio-net\u0027, \u0027virtio1.0-net\u0027]:"},{"line_number":109,"context_line":"                    return \u0027virtio\u0027"},{"line_number":110,"context_line":"                # ignore any invalid ones"},{"line_number":111,"context_line":"                if net_model in fields.VIFModel.ALL:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_68d549b9","line":108,"range":{"start_line":107,"start_character":16,"end_line":108,"end_character":63},"updated":"2019-07-04 14:47:21.000000000","message":"this seams sane to me my only reservation is that this module should be virt driver independent.\n\ni wonder if we should be doing this in \nhttps://github.com/openstack/nova/blob/master/nova/virt/libvirt/blockinfo.py instead","commit_id":"6be668e51992df53a4d871bea70bc738a9beacb8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c746db934d347276fb883899892ba1d7818c6699","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                if disk_model in [\u0027virtio-block\u0027, \u0027virtio1.0-block\u0027]:"},{"line_number":124,"context_line":"                    return \u0027virtio\u0027"},{"line_number":125,"context_line":"                # ignore any invalid ones"},{"line_number":126,"context_line":"                if disk_model in fields.DiskBus.ALL:"},{"line_number":127,"context_line":"                    return disk_model"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_688789d9","line":126,"range":{"start_line":126,"start_character":33,"end_line":126,"end_character":51},"updated":"2019-07-04 14:47:21.000000000","message":"side not that this does not take into account which disk buses are valid for the current hypervior however that should be done elsewhere as this is intended to be generic code.","commit_id":"6be668e51992df53a4d871bea70bc738a9beacb8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c746db934d347276fb883899892ba1d7818c6699","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                    return disk_model"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"class HardwareProperties(object):"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def __init__(self, image_meta):"},{"line_number":133,"context_line":"        \"\"\":param image_meta:  ImageMeta object"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_e844d9b9","line":130,"range":{"start_line":130,"start_character":5,"end_line":130,"end_character":24},"updated":"2019-07-04 14:47:21.000000000","message":"as noted on irc i dont think this class belongs in this module but that is a latent thing that is unrelated to this change","commit_id":"6be668e51992df53a4d871bea70bc738a9beacb8"}]}