)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ff1e11eb6ea3b963f748c3a64be2b1be85b3d394","unresolved":false,"context_lines":[{"line_number":30,"context_line":"the _delete_allocation_after_move method as documented inline."},{"line_number":31,"context_line":"This also means we have to deal with migration-based and legacy"},{"line_number":32,"context_line":"tracked allocations (where the source and dest node allocations"},{"line_number":33,"context_line":"are both on the instance consumer). As such, similar logic to"},{"line_number":34,"context_line":"_delete_allocation_after_move is used to try and delete the"},{"line_number":35,"context_line":"migration-based allocations first and failing that, attempt"},{"line_number":36,"context_line":"to cleanup the source node allocations the legacy way by removing"},{"line_number":37,"context_line":"them from the \"doubled up\" allocations created by the scheduler."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Change-Id: I52c8d038118c858004e17e71b2fba9e9e2714815"},{"line_number":40,"context_line":"Closes-Bug: #1825537"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_fe89e525","line":37,"range":{"start_line":33,"start_character":36,"end_line":37,"end_character":64},"updated":"2019-07-05 16:18:31.000000000","message":"This makes things quite a bit hairier for this backport and I don\u0027t yet have test coverage for it. I think the easiest thing to do is probably add a variant of the functional regression recreate test which stubs the compute service version looking to make conductor think we have old computes and doesn\u0027t do migration-based allocations.","commit_id":"b65464e42fb2bd5afde014fbc1758e50ac4e0c55"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"649cd1f0e4d4df14528ce1fe430baf73494e1933","unresolved":false,"context_lines":[{"line_number":28,"context_line":"The code fix is also different because we don\u0027t have change"},{"line_number":29,"context_line":"I0851e2d54a1fdc82fe3291fb7e286e790f121e92 in Rocky and cannot use"},{"line_number":30,"context_line":"the _delete_allocation_after_move method as documented inline."},{"line_number":31,"context_line":"This also means we have to deal with migration-based and legacy"},{"line_number":32,"context_line":"tracked allocations (where the source and dest node allocations"},{"line_number":33,"context_line":"are both on the instance consumer). As such, similar logic to"},{"line_number":34,"context_line":"_delete_allocation_after_move is used to try and delete the"},{"line_number":35,"context_line":"migration-based allocations first and failing that, attempt"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_e0738515","line":32,"range":{"start_line":31,"start_character":0,"end_line":32,"end_character":19},"updated":"2019-08-08 14:18:07.000000000","message":"Oof, this is kinda gross. Glad to have that junk in our rearview mirror.","commit_id":"cbf6a46d8fcd3236bff44439c8d143a77167dfe2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7829f60913abff0d016ac20d26a79e4638645129","unresolved":false,"context_lines":[{"line_number":28,"context_line":"The code fix is also different because we don\u0027t have change"},{"line_number":29,"context_line":"I0851e2d54a1fdc82fe3291fb7e286e790f121e92 in Rocky and cannot use"},{"line_number":30,"context_line":"the _delete_allocation_after_move method as documented inline."},{"line_number":31,"context_line":"This also means we have to deal with migration-based and legacy"},{"line_number":32,"context_line":"tracked allocations (where the source and dest node allocations"},{"line_number":33,"context_line":"are both on the instance consumer). As such, similar logic to"},{"line_number":34,"context_line":"_delete_allocation_after_move is used to try and delete the"},{"line_number":35,"context_line":"migration-based allocations first and failing that, attempt"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_0054a120","line":32,"range":{"start_line":31,"start_character":0,"end_line":32,"end_character":19},"in_reply_to":"7faddb67_e0738515","updated":"2019-08-08 14:28:14.000000000","message":"Yup, it wasn\u0027t fun to deal with in the backport.","commit_id":"cbf6a46d8fcd3236bff44439c8d143a77167dfe2"}]}