)]}'
{"id":"openstack%2Fnova~669393","triplet_id":"openstack%2Fnova~stable%2Frocky~I52c8d038118c858004e17e71b2fba9e9e2714815","project":"openstack/nova","branch":"stable/rocky","topic":"bug/1825537","hashtags":[],"change_id":"I52c8d038118c858004e17e71b2fba9e9e2714815","subject":"Drop source node allocations if finish_resize fails","status":"MERGED","created":"2019-07-05 16:15:51.000000000","updated":"2019-08-08 17:02:18.000000000","submitted":"2019-08-08 17:02:18.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"669393-1565283738087-00db80d6","meta_rev_id":"4741185fdab2488ab3d980a05e6fd7fab72f7bde","_number":669393,"virtual_id_number":669393,"owner":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"date":"2019-07-05 18:31:14.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"date":"2019-07-10 12:09:47.000000000","_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"date":"2019-07-05 17:44:41.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"date":"2019-08-08 14:28:14.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":2,"date":"2019-08-08 17:02:17.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":2,"date":"2019-07-31 21:47:28.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":1,"date":"2019-08-01 11:24:23.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":2,"date":"2019-08-08 14:18:07.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":1,"date":"2019-08-08 14:18:07.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-07-05 17:44:41.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-07-05 18:31:14.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2019-07-10 12:09:47.000000000","updated_by":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-07-31 21:47:28.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2019-08-01 11:24:23.000000000","updated_by":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"reviewer":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"state":"REVIEWER"},{"updated":"2019-08-08 14:18:07.000000000","updated_by":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"reviewer":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"state":"REVIEWER"},{"updated":"2019-08-08 17:02:17.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"e3724666e084dc889fb27048c9f5a9755956f50e","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-07-05 16:15:51.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ff1e11eb6ea3b963f748c3a64be2b1be85b3d394","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-07-05 16:18:31.000000000","message":"Patch Set 1: Workflow-1\n\n(1 comment)\n\nWIP while I working on the legacy allocation cleanup testing.","accounts_in_message":[],"_revision_number":1},{"id":"bd0d228f98739a8f0be9651c02b74242e6a3dc6a","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-07-05 16:31:07.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"62f8edd04b646e40d5c581a285dff05e81afeef8","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2019-07-05 17:44:41.000000000","message":"Patch Set 2:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/93/669393/2/check/tempest-dsvm-full-xenial/0736ad9/ : SUCCESS in 1h 09m 54s\n- tempest-dsvm-full-xenial-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/93/669393/2/check/tempest-dsvm-full-xenial-py3/7857801/ : SUCCESS in 1h 12m 32s (non-voting)\n- grenade-dsvm-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/93/669393/2/check/grenade-dsvm-xenial/93c43e6/ : SUCCESS in 59m 33s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"b586268ee439cc48dd530cd0621b5ad4c6b8c4cc","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-07-05 18:31:14.000000000","message":"Patch Set 2:\n\nBuild succeeded.\n\n- nova http://cloudbase-ci.com/nova/669393/2 : SUCCESS in 1h 59m 07s","accounts_in_message":[],"_revision_number":2},{"id":"bacb719168b0fc13c7afb69b4c49ea95cbf203e9","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-05 18:40:49.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/93/669393/2/check/openstack-tox-pep8/cf96249/ : SUCCESS in 10m 06s\n- openstack-tox-py27 http://logs.openstack.org/93/669393/2/check/openstack-tox-py27/2ba482e/ : SUCCESS in 15m 07s\n- openstack-tox-py35 http://logs.openstack.org/93/669393/2/check/openstack-tox-py35/3d0cd07/ : SUCCESS in 13m 00s\n- build-openstack-sphinx-docs http://logs.openstack.org/93/669393/2/check/build-openstack-sphinx-docs/9887d76/html/ : SUCCESS in 8m 10s\n- tempest-full http://logs.openstack.org/93/669393/2/check/tempest-full/416367d/ : SUCCESS in 1h 26m 27s\n- neutron-grenade http://logs.openstack.org/93/669393/2/check/neutron-grenade/ef717a6/ : SUCCESS in 59m 50s\n- tempest-full-py3 http://logs.openstack.org/93/669393/2/check/tempest-full-py3/f50aaa5/ : SUCCESS in 1h 27m 04s\n- ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa http://logs.openstack.org/93/669393/2/check/ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa/83f74bc/ : SUCCESS in 59m 43s (non-voting)\n- nova-cells-v1 http://logs.openstack.org/93/669393/2/check/nova-cells-v1/63c3a60/ : SUCCESS in 57m 28s\n- nova-grenade-live-migration http://logs.openstack.org/93/669393/2/check/nova-grenade-live-migration/9d3c549/ : SUCCESS in 1h 11m 58s (non-voting)\n- nova-live-migration http://logs.openstack.org/93/669393/2/check/nova-live-migration/86b7c97/ : SUCCESS in 43m 32s\n- nova-multiattach http://logs.openstack.org/93/669393/2/check/nova-multiattach/3626214/ : SUCCESS in 59m 37s\n- nova-next http://logs.openstack.org/93/669393/2/check/nova-next/5f39ed3/ : SUCCESS in 1h 32m 16s\n- tempest-slow http://logs.openstack.org/93/669393/2/check/tempest-slow/cebb999/ : SUCCESS in 1h 58m 23s\n- nova-tox-functional http://logs.openstack.org/93/669393/2/check/nova-tox-functional/6431cb0/ : SUCCESS in 19m 29s\n- nova-tox-functional-py35 http://logs.openstack.org/93/669393/2/check/nova-tox-functional-py35/af3e632/ : SUCCESS in 15m 35s\n- openstack-tox-lower-constraints http://logs.openstack.org/93/669393/2/check/openstack-tox-lower-constraints/5a843cd/ : SUCCESS in 18m 05s\n- neutron-grenade-multinode http://logs.openstack.org/93/669393/2/check/neutron-grenade-multinode/16843de/ : SUCCESS in 1h 10m 16s\n- devstack-plugin-ceph-tempest http://logs.openstack.org/93/669393/2/check/devstack-plugin-ceph-tempest/205fd47/ : SUCCESS in 1h 17m 28s (non-voting)\n- tempest-multinode-full http://logs.openstack.org/93/669393/2/check/tempest-multinode-full/c3f4637/ : SUCCESS in 1h 27m 27s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"367523c82feb3368006ebeb5b8eacd7850a7ff66","author":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"date":"2019-07-10 12:09:47.000000000","message":"Patch Set 2:\n\nTesting failed ubuntu-xenial-s390x. For rechecking only on the ubuntu-xenial-s390x CI, add a review comment with recheck-zkvm. Contact info: zkvm-ci@linux.vnet.ibm.com. For more information, see https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_zKVM_CI\n\n- check-tempest-dsvm-neutron-full-ubuntu-xenial-s390x http://sng01.objectstorage.softlayer.net/v1/AUTH_1940ea10-6e82-4501-b2f9-eb236510e575/ibmzkvmci/production/669393/2/check-tempest-dsvm-neutron-full-ubuntu-xenial-s390x/9239fe9 : EXCEPTION","accounts_in_message":[],"_revision_number":2},{"id":"b1015d5e48b18e44651c7e0af0dd4e334237c616","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2019-07-31 21:47:28.000000000","message":"Patch Set 2: Code-Review+2\n\nLooks appropriate to me and backport is good.","accounts_in_message":[],"_revision_number":2},{"id":"17fe5562f50a60e93865fbc2cf663d0f50f9e110","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2019-08-01 11:24:23.000000000","message":"Patch Set 2: Code-Review+1\n\nLGTM but given the conflicts I\u0027d like some addition core review before we merge this.","accounts_in_message":[],"_revision_number":2},{"id":"649cd1f0e4d4df14528ce1fe430baf73494e1933","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2019-08-08 14:18:07.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"45667e24b0aa212ec4fc410c75b7758bff0b3ffd","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-08 14:18:42.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"7829f60913abff0d016ac20d26a79e4638645129","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-08-08 14:28:14.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"c27e81839223e136dcefda302e3268005719d77f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-08 17:02:17.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://logs.opendev.org/93/669393/2/gate/openstack-tox-pep8/a2e3c56/ : SUCCESS in 11m 41s\n- openstack-tox-py27 https://logs.opendev.org/93/669393/2/gate/openstack-tox-py27/e717cc8/ : SUCCESS in 14m 14s\n- openstack-tox-py35 https://logs.opendev.org/93/669393/2/gate/openstack-tox-py35/94ad912/ : SUCCESS in 19m 11s\n- build-openstack-sphinx-docs https://logs.opendev.org/93/669393/2/gate/build-openstack-sphinx-docs/2bb88f8/html/ : SUCCESS in 9m 03s\n- tempest-full https://logs.opendev.org/93/669393/2/gate/tempest-full/038fbe7/ : SUCCESS in 1h 44m 39s\n- neutron-grenade https://logs.opendev.org/93/669393/2/gate/neutron-grenade/0b564ec/ : SUCCESS in 59m 35s\n- tempest-full-py3 https://logs.opendev.org/93/669393/2/gate/tempest-full-py3/0bd93a2/ : SUCCESS in 1h 27m 46s\n- nova-cells-v1 https://logs.opendev.org/93/669393/2/gate/nova-cells-v1/cffa104/ : SUCCESS in 1h 14m 24s\n- nova-live-migration https://logs.opendev.org/93/669393/2/gate/nova-live-migration/7ca2b73/ : SUCCESS in 47m 58s\n- nova-multiattach https://logs.opendev.org/93/669393/2/gate/nova-multiattach/57b2414/ : SUCCESS in 1h 10m 20s\n- nova-next https://logs.opendev.org/93/669393/2/gate/nova-next/564310b/ : SUCCESS in 1h 27m 56s\n- tempest-slow https://logs.opendev.org/93/669393/2/gate/tempest-slow/89adde8/ : SUCCESS in 1h 52m 03s\n- nova-tox-functional https://logs.opendev.org/93/669393/2/gate/nova-tox-functional/3275da4/ : SUCCESS in 28m 50s\n- nova-tox-functional-py35 https://logs.opendev.org/93/669393/2/gate/nova-tox-functional-py35/5351e89/ : SUCCESS in 18m 43s\n- openstack-tox-lower-constraints https://logs.opendev.org/93/669393/2/gate/openstack-tox-lower-constraints/697b325/ : SUCCESS in 14m 58s","accounts_in_message":[],"_revision_number":2},{"id":"6e92bd3e1963613fe7fd780095aa6d03f0bad013","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-08 17:02:18.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"cbf6a46d8fcd3236bff44439c8d143a77167dfe2","revisions":{"b65464e42fb2bd5afde014fbc1758e50ac4e0c55":{"kind":"REWORK","_number":1,"created":"2019-07-05 16:15:51.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/93/669393/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/93/669393/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/93/669393/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/93/669393/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/93/669393/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/93/669393/1"}}},"commit":{"parents":[{"commit":"9a977cb28c1c4f2e8d950476fa373326f636dfd6","subject":"Add functional recreate test for regression bug 1825537","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/9a977cb28c1c4f2e8d950476fa373326f636dfd6"}]}],"author":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-04-19 16:28:34.000000000","tz":-240},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-07-05 16:12:29.000000000","tz":-240},"subject":"WIP: Drop source node allocations if finish_resize fails","message":"WIP: Drop source node allocations if finish_resize fails\n\nBy the time finish_resize runs on the dest host, the instance\nhost/node values are already pointing at the dest (they are\nset by resize_instance on the source compute before casting to\nfinish_resize on the dest). If finish_resize fails, the instance\nis essentially stuck on the dest host so rather than revert the\nallocations (which will drop the new flavor allocations against\nthe dest host where the instance now lives) we should just drop\nthe old flavor allocations on the source node resource provider,\nwhich is what this change does.\n\nThe functional regression recreate test is updated to show this\nworking.\n\nConflicts:\n      nova/tests/functional/regressions/test_bug_1825537.py\n      nova/tests/functional/test_servers.py\n\nNOTE(mriedem): The functional test conflicts are due to not having\nchange If6aa37d9b6b48791e070799ab026c816fda4441c in Rocky.\nThe code fix is also different because we don\u0027t have change\nI0851e2d54a1fdc82fe3291fb7e286e790f121e92 in Rocky and cannot use\nthe _delete_allocation_after_move method as documented inline.\nThis also means we have to deal with migration-based and legacy\ntracked allocations (where the source and dest node allocations\nare both on the instance consumer). As such, similar logic to\n_delete_allocation_after_move is used to try and delete the\nmigration-based allocations first and failing that, attempt\nto cleanup the source node allocations the legacy way by removing\nthem from the \"doubled up\" allocations created by the scheduler.\n\nChange-Id: I52c8d038118c858004e17e71b2fba9e9e2714815\nCloses-Bug: #1825537\n(cherry picked from commit ea297d6ffba81c5dc982afe6519de09ff3744cad)\n(cherry picked from commit e6c6178d22db43959103da1400017fa49b18f514)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b65464e42fb2bd5afde014fbc1758e50ac4e0c55"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b65464e42fb2bd5afde014fbc1758e50ac4e0c55"}]},"branch":"refs/heads/stable/rocky"},"cbf6a46d8fcd3236bff44439c8d143a77167dfe2":{"kind":"REWORK","_number":2,"created":"2019-07-05 16:31:07.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/93/669393/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/93/669393/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/93/669393/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/93/669393/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/93/669393/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/93/669393/2"}}},"commit":{"parents":[{"commit":"9a977cb28c1c4f2e8d950476fa373326f636dfd6","subject":"Add functional recreate test for regression bug 1825537","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/9a977cb28c1c4f2e8d950476fa373326f636dfd6"}]}],"author":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-04-19 16:28:34.000000000","tz":-240},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-07-05 16:30:02.000000000","tz":-240},"subject":"Drop source node allocations if finish_resize fails","message":"Drop source node allocations if finish_resize fails\n\nBy the time finish_resize runs on the dest host, the instance\nhost/node values are already pointing at the dest (they are\nset by resize_instance on the source compute before casting to\nfinish_resize on the dest). If finish_resize fails, the instance\nis essentially stuck on the dest host so rather than revert the\nallocations (which will drop the new flavor allocations against\nthe dest host where the instance now lives) we should just drop\nthe old flavor allocations on the source node resource provider,\nwhich is what this change does.\n\nThe functional regression recreate test is updated to show this\nworking.\n\nConflicts:\n      nova/tests/functional/regressions/test_bug_1825537.py\n      nova/tests/functional/test_servers.py\n\nNOTE(mriedem): The functional test conflicts are due to not having\nchange If6aa37d9b6b48791e070799ab026c816fda4441c in Rocky.\nThe code fix is also different because we don\u0027t have change\nI0851e2d54a1fdc82fe3291fb7e286e790f121e92 in Rocky and cannot use\nthe _delete_allocation_after_move method as documented inline.\nThis also means we have to deal with migration-based and legacy\ntracked allocations (where the source and dest node allocations\nare both on the instance consumer). As such, similar logic to\n_delete_allocation_after_move is used to try and delete the\nmigration-based allocations first and failing that, attempt\nto cleanup the source node allocations the legacy way by removing\nthem from the \"doubled up\" allocations created by the scheduler.\nSince this is new logic in the backport, a functional test is\nadded to cover the legacy cleanup flow.\n\nChange-Id: I52c8d038118c858004e17e71b2fba9e9e2714815\nCloses-Bug: #1825537\n(cherry picked from commit ea297d6ffba81c5dc982afe6519de09ff3744cad)\n(cherry picked from commit e6c6178d22db43959103da1400017fa49b18f514)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/cbf6a46d8fcd3236bff44439c8d143a77167dfe2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/cbf6a46d8fcd3236bff44439c8d143a77167dfe2"}]},"branch":"refs/heads/stable/rocky"}},"requirements":[],"submit_records":[],"submit_requirements":[]}