)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"38d3b8df0ac5fe0db888315419242c19560fa7ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"50b7a9a9_e2be2446","updated":"2022-02-03 17:08:59.000000000","message":"Couple suggestion inline and please add a reno for the change.","commit_id":"209e0336b7fed3e947f9e7d64b09d3146ba391e2"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6c520ce6ed04e06f6a2178bf9516b44db76f0a23","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9d0ed244_df4c1d0f","updated":"2022-02-16 15:59:13.000000000","message":"Looks good thanks","commit_id":"0d71c5a1c1f0e474d4b612eadf8787172af34e15"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a92407c227a48b63e04b719ef9c94599f413393d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ad72307d_329ae4ea","updated":"2022-02-17 18:36:33.000000000","message":"thanks sylvain for picking this up and driving it to completion.\nits nice to finaly close this gap.","commit_id":"0d71c5a1c1f0e474d4b612eadf8787172af34e15"}],"nova/tests/fixtures/neutron.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"68d6214274b4f711380cb915f45b52804a965d1b","unresolved":true,"context_lines":[{"line_number":842,"context_line":"    def create_port(self, body\u003dNone):"},{"line_number":843,"context_line":"        body \u003d body or {\u0027port\u0027: {}}"},{"line_number":844,"context_line":"        # Note(gibi): Some of the test expects that a pre-defined port is"},{"line_number":845,"context_line":"        # created. This defaults to port_2. I that port is not created yet then"},{"line_number":846,"context_line":"        # that is the one created here."},{"line_number":847,"context_line":"        new_port \u003d copy.deepcopy(body[\u0027port\u0027])"},{"line_number":848,"context_line":"        for field in self.default_port:"}],"source_content_type":"text/x-python","patch_set":2,"id":"c03f62aa_bbc06df4","line":845,"range":{"start_line":845,"start_character":44,"end_line":845,"end_character":50},"updated":"2021-08-24 13:11:00.000000000","message":"something is missing here","commit_id":"4d354f22fe73cddd6fa7982342283c6657f64657"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"38d3b8df0ac5fe0db888315419242c19560fa7ea","unresolved":true,"context_lines":[{"line_number":877,"context_line":""},{"line_number":878,"context_line":"    def create_port(self, body\u003dNone):"},{"line_number":879,"context_line":"        body \u003d body or {\u0027port\u0027: {}}"},{"line_number":880,"context_line":"        # Note(gibi): Some of the test expects that a pre-defined port is"},{"line_number":881,"context_line":"        # created. This defaults to port_2. If that port is not created yet"},{"line_number":882,"context_line":"        # then that is the one created here with all the unset attributes of"},{"line_number":883,"context_line":"        # that new port to be defaulted to port_2 values."},{"line_number":884,"context_line":"        new_port \u003d copy.deepcopy(body[\u0027port\u0027])"},{"line_number":885,"context_line":"        for field in self.default_port:"},{"line_number":886,"context_line":"            if field not in new_port:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5c947932_5c113205","line":883,"range":{"start_line":880,"start_character":1,"end_line":883,"end_character":57},"updated":"2022-02-03 17:08:59.000000000","message":"It would be really nice to get rid of this instead of complicating it even more.\n//later\nI suggested a small change in the test to that can be done instead of complicating this code further","commit_id":"209e0336b7fed3e947f9e7d64b09d3146ba391e2"}],"nova/tests/functional/test_ip_allocation.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"38d3b8df0ac5fe0db888315419242c19560fa7ea","unresolved":true,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        # then add a port with an ip_allocation of \u0027none\u0027"},{"line_number":36,"context_line":"        port \u003d {"},{"line_number":37,"context_line":"            \u0027id\u0027: uuids.port_with_none_ip_allocation,"},{"line_number":38,"context_line":"            \u0027name\u0027: \u0027\u0027,"},{"line_number":39,"context_line":"            \u0027description\u0027: \u0027\u0027,"},{"line_number":40,"context_line":"            \u0027network_id\u0027: self.neutron.network_1[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"ae70ae85_de1e9520","line":37,"range":{"start_line":37,"start_character":12,"end_line":37,"end_character":53},"updated":"2022-02-03 17:08:59.000000000","message":"drop this an let neutron ( the fixture) create a uuid for it. This way you don\u0027t need to modify the fixture","commit_id":"209e0336b7fed3e947f9e7d64b09d3146ba391e2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a92407c227a48b63e04b719ef9c94599f413393d","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        # then add a port with an ip_allocation of \u0027none\u0027"},{"line_number":36,"context_line":"        port \u003d {"},{"line_number":37,"context_line":"            \u0027id\u0027: uuids.port_with_none_ip_allocation,"},{"line_number":38,"context_line":"            \u0027name\u0027: \u0027\u0027,"},{"line_number":39,"context_line":"            \u0027description\u0027: \u0027\u0027,"},{"line_number":40,"context_line":"            \u0027network_id\u0027: self.neutron.network_1[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"95a5fba6_529c9aba","line":37,"range":{"start_line":37,"start_character":12,"end_line":37,"end_character":53},"in_reply_to":"ae70ae85_de1e9520","updated":"2022-02-17 18:36:33.000000000","message":"Done","commit_id":"209e0336b7fed3e947f9e7d64b09d3146ba391e2"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"38d3b8df0ac5fe0db888315419242c19560fa7ea","unresolved":true,"context_lines":[{"line_number":37,"context_line":"            \u0027id\u0027: uuids.port_with_none_ip_allocation,"},{"line_number":38,"context_line":"            \u0027name\u0027: \u0027\u0027,"},{"line_number":39,"context_line":"            \u0027description\u0027: \u0027\u0027,"},{"line_number":40,"context_line":"            \u0027network_id\u0027: self.neutron.network_1[\u0027id\u0027],"},{"line_number":41,"context_line":"            \u0027admin_state_up\u0027: True,"},{"line_number":42,"context_line":"            \u0027status\u0027: \u0027ACTIVE\u0027,"},{"line_number":43,"context_line":"            \u0027mac_address\u0027: \u0027ee:94:88:57:d5:7a\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ef0477a2_8440c01d","line":40,"updated":"2022-02-03 17:08:59.000000000","message":"so if this port is created in network_1 then why we need to add network_2 to the defined networks above?\n// later\nI removed it and the test still passes","commit_id":"209e0336b7fed3e947f9e7d64b09d3146ba391e2"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"38d3b8df0ac5fe0db888315419242c19560fa7ea","unresolved":true,"context_lines":[{"line_number":52,"context_line":"            \u0027binding:vif_details\u0027: {},"},{"line_number":53,"context_line":"            \u0027ip_allocation\u0027: \u0027none\u0027,"},{"line_number":54,"context_line":"        }"},{"line_number":55,"context_line":"        self.neutron.create_port({\u0027port\u0027: port})"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def test_boot_with_none_policy(self):"},{"line_number":58,"context_line":"        \"\"\"Create a port with the \u0027none\u0027 policy.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"92ce0456_995fd8bb","line":55,"updated":"2022-02-03 17:08:59.000000000","message":"self.port_id \u003d self.neutron.create_port({\u0027port\u0027: port})[\u0027port\u0027][\u0027id\u0027]","commit_id":"209e0336b7fed3e947f9e7d64b09d3146ba391e2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a92407c227a48b63e04b719ef9c94599f413393d","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            \u0027binding:vif_details\u0027: {},"},{"line_number":53,"context_line":"            \u0027ip_allocation\u0027: \u0027none\u0027,"},{"line_number":54,"context_line":"        }"},{"line_number":55,"context_line":"        self.neutron.create_port({\u0027port\u0027: port})"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def test_boot_with_none_policy(self):"},{"line_number":58,"context_line":"        \"\"\"Create a port with the \u0027none\u0027 policy.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"e58cc480_2e71bb17","line":55,"in_reply_to":"92ce0456_995fd8bb","updated":"2022-02-17 18:36:33.000000000","message":"Done","commit_id":"209e0336b7fed3e947f9e7d64b09d3146ba391e2"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"38d3b8df0ac5fe0db888315419242c19560fa7ea","unresolved":true,"context_lines":[{"line_number":57,"context_line":"    def test_boot_with_none_policy(self):"},{"line_number":58,"context_line":"        \"\"\"Create a port with the \u0027none\u0027 policy.\"\"\""},{"line_number":59,"context_line":"        self._create_server("},{"line_number":60,"context_line":"            networks\u003d[{\u0027port\u0027: uuids.port_with_none_ip_allocation}])"}],"source_content_type":"text/x-python","patch_set":4,"id":"40c768c4_d5169ace","line":60,"updated":"2022-02-03 17:08:59.000000000","message":"then\n\n          networks\u003d[{\u0027port\u0027: self.port_id}])\n\nso you don\u0027t need the fixture modification any more","commit_id":"209e0336b7fed3e947f9e7d64b09d3146ba391e2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a92407c227a48b63e04b719ef9c94599f413393d","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    def test_boot_with_none_policy(self):"},{"line_number":58,"context_line":"        \"\"\"Create a port with the \u0027none\u0027 policy.\"\"\""},{"line_number":59,"context_line":"        self._create_server("},{"line_number":60,"context_line":"            networks\u003d[{\u0027port\u0027: uuids.port_with_none_ip_allocation}])"}],"source_content_type":"text/x-python","patch_set":4,"id":"54e1e26c_3250ac1a","line":60,"in_reply_to":"40c768c4_d5169ace","updated":"2022-02-17 18:36:33.000000000","message":"Done","commit_id":"209e0336b7fed3e947f9e7d64b09d3146ba391e2"}]}