)]}'
{"nova/objects/floating_ip.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"3403f29cb794571312626eebbd24e7f01e67e59e","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                                                     fixed_address,"},{"line_number":77,"context_line":"                                                     host)"},{"line_number":78,"context_line":"        if db_fixed is None:"},{"line_number":79,"context_line":"            return None"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        floating \u003d FloatingIP("},{"line_number":82,"context_line":"            context\u003dcontext, address\u003dfloating_address, host\u003dhost,"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F%2FAtA%3D","line":79,"updated":"2014-01-19 07:45:42.000000000","message":"you can just use return. None is the default","commit_id":"f57ecd73673ab7ff9fafa14ade9dd93b2c3eb966"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"5575628308709e26ddaca9163f32acf3c8f0f757","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from nova.objects import fields"},{"line_number":19,"context_line":"from nova.objects import fixed_ip"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"OPTIONAL_ATTRS \u003d [\u0027fixed_ip\u0027]"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class FloatingIP(obj_base.NovaPersistentObject, obj_base.NovaObject):"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAUH%2F991U%3D","line":21,"updated":"2014-01-31 15:48:57.000000000","message":"Same naming nit like for fixed IPs but this is not a big deal","commit_id":"48899f8685ed4f188281bb96a94ed4b3669b7833"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"5575628308709e26ddaca9163f32acf3c8f0f757","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                                               auto_assigned\u003dauto_assigned)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    @obj_base.remotable_classmethod"},{"line_number":73,"context_line":"    def associate(cls, context, floating_address, fixed_address, host):"},{"line_number":74,"context_line":"        db_fixed \u003d db.floating_ip_fixed_ip_associate(context,"},{"line_number":75,"context_line":"                                                     floating_address,"},{"line_number":76,"context_line":"                                                     fixed_address,"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAUH%2F99yo%3D","line":73,"updated":"2014-01-31 15:48:57.000000000","message":"Again - why is this a class method. These are not nova-objects but nova-functions-stuck-in-a-class\u0027 then :)","commit_id":"48899f8685ed4f188281bb96a94ed4b3669b7833"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c9727b3cd2bd41131e84fd6469ce88da9902b393","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                                               auto_assigned\u003dauto_assigned)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    @obj_base.remotable_classmethod"},{"line_number":73,"context_line":"    def associate(cls, context, floating_address, fixed_address, host):"},{"line_number":74,"context_line":"        db_fixed \u003d db.floating_ip_fixed_ip_associate(context,"},{"line_number":75,"context_line":"                                                     floating_address,"},{"line_number":76,"context_line":"                                                     fixed_address,"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAUH%2F99hE%3D","line":73,"in_reply_to":"AAAAUH%2F99yo%3D","updated":"2014-01-31 16:32:53.000000000","message":"Same answer as before. The calling convention used in much of the network code is very classmethod-ish because of how the ip addresses are used as keys, which means objects are not fetched first, modified, and saved.","commit_id":"48899f8685ed4f188281bb96a94ed4b3669b7833"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"5575628308709e26ddaca9163f32acf3c8f0f757","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        return floating"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    @obj_base.remotable_classmethod"},{"line_number":90,"context_line":"    def deallocate(cls, context, address):"},{"line_number":91,"context_line":"        db.floating_ip_deallocate(context, address)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    @obj_base.remotable_classmethod"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAUH%2F99yg%3D","line":90,"updated":"2014-01-31 15:48:57.000000000","message":"Same... what am I missing here?","commit_id":"48899f8685ed4f188281bb96a94ed4b3669b7833"}]}