)]}'
{"nova/cmd/manage.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d9946304e9f9f575248544841352aa091dbabf96","unresolved":false,"context_lines":[{"line_number":1886,"context_line":"        succeeded \u003d []"},{"line_number":1887,"context_line":"        try:"},{"line_number":1888,"context_line":"            for port in ports_to_update:"},{"line_number":1889,"context_line":"                profile \u003d neutron_api.get_binding_profile(port)"},{"line_number":1890,"context_line":"                rp_uuid \u003d profile[constants.ALLOCATION]"},{"line_number":1891,"context_line":"                body \u003d {"},{"line_number":1892,"context_line":"                    \u0027port\u0027: {"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_64f45bd0","line":1889,"updated":"2019-07-09 14:07:11.000000000","message":"This one seems a bit unnecessary because we know binding:profile will be set on the port dict since we are accessing the \u0027allocation\u0027 key without any guard against KeyError here. It\u0027s fine, but not really necessary.","commit_id":"a5f56e10cd03fbb2c25f392e433d4a563ca7d211"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d9946304e9f9f575248544841352aa091dbabf96","unresolved":false,"context_lines":[{"line_number":1915,"context_line":"        manual_rollback_needed \u003d []"},{"line_number":1916,"context_line":"        last_exc \u003d None"},{"line_number":1917,"context_line":"        for port in ports_to_rollback:"},{"line_number":1918,"context_line":"            profile \u003d neutron_api.get_binding_profile(port)"},{"line_number":1919,"context_line":"            profile.pop(constants.ALLOCATION)"},{"line_number":1920,"context_line":"            body \u003d {"},{"line_number":1921,"context_line":"                \u0027port\u0027: {"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_641d3b0e","line":1918,"updated":"2019-07-09 14:07:11.000000000","message":"Same - this one is unnecessary since we know the binding:profile is in there otherwise we\u0027d get a KeyError when popping the \u0027allocation\u0027 key. It\u0027s OK to use the helper method for consistency though I guess.","commit_id":"a5f56e10cd03fbb2c25f392e433d4a563ca7d211"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"0b17833941816a2601855ad70844900232c103b4","unresolved":false,"context_lines":[{"line_number":1892,"context_line":"                profile \u003d neutron_api.get_binding_profile(port)"},{"line_number":1893,"context_line":"                body \u003d {"},{"line_number":1894,"context_line":"                    \u0027port\u0027: {"},{"line_number":1895,"context_line":"                        constants.BINDING_PROFILE: profile"},{"line_number":1896,"context_line":"                    }"},{"line_number":1897,"context_line":"                }"},{"line_number":1898,"context_line":"                output("}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_b229cb8a","line":1895,"updated":"2019-07-16 14:13:15.000000000","message":"PS4 manual rebase intervention here","commit_id":"ceeafc0a25de9f554bcb7b37aa6a6849a0a8d4ff"}],"nova/network/neutronv2/api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d9946304e9f9f575248544841352aa091dbabf96","unresolved":false,"context_lines":[{"line_number":1117,"context_line":"                                      \u0027device_owner\u0027: zone}}"},{"line_number":1118,"context_line":"            if (requested_ports_dict and"},{"line_number":1119,"context_line":"                request.port_id in requested_ports_dict and"},{"line_number":1120,"context_line":"                get_binding_profile(requested_ports_dict[request.port_id])):"},{"line_number":1121,"context_line":"                port_req_body[\u0027port\u0027][constants.BINDING_PROFILE] \u003d \\"},{"line_number":1122,"context_line":"                    get_binding_profile(requested_ports_dict[request.port_id])"},{"line_number":1123,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_64cbfb71","line":1120,"updated":"2019-07-09 14:07:11.000000000","message":"nit: it was this way before, but we could pull the profile variable out of the conditional so we don\u0027t have to get it twice.","commit_id":"a5f56e10cd03fbb2c25f392e433d4a563ca7d211"}]}