)]}'
{".coveragerc":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c5dbbe3d40203d40ad5d2e56db1f8cc97e1069b9","unresolved":false,"context_lines":[{"line_number":3,"context_line":"source \u003d nova"},{"line_number":4,"context_line":"omit \u003d nova/tests/*"},{"line_number":5,"context_line":"parallel \u003d True"},{"line_number":6,"context_line":"concurrency \u003d"},{"line_number":7,"context_line":"  eventlet"},{"line_number":8,"context_line":"  greenlet"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"[report]"},{"line_number":11,"context_line":"ignore_errors \u003d True"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7faddb67_7fc145e4","line":8,"range":{"start_line":6,"start_character":0,"end_line":8,"end_character":10},"updated":"2019-07-09 17:23:01.000000000","message":"enabling both should give you an error saying these are conflicting","commit_id":"6e3425d2ac77be896e528ea537f92e718dce0ee5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"552a20896a3abeccf8e08f1cec952e09db2153bc","unresolved":false,"context_lines":[{"line_number":3,"context_line":"source \u003d nova"},{"line_number":4,"context_line":"omit \u003d nova/tests/*"},{"line_number":5,"context_line":"parallel \u003d True"},{"line_number":6,"context_line":"concurrency \u003d"},{"line_number":7,"context_line":"  eventlet"},{"line_number":8,"context_line":"  greenlet"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"[report]"},{"line_number":11,"context_line":"ignore_errors \u003d True"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7faddb67_1084be0b","line":8,"range":{"start_line":6,"start_character":0,"end_line":8,"end_character":10},"in_reply_to":"7faddb67_70bf32d0","updated":"2019-07-09 20:02:54.000000000","message":"The docs aren\u0027t really clear but you\u0027re right about the code:\n\nhttps://github.com/nedbat/coveragepy/blob/6b72dcbd98c69a7e8c5333d2926c7f871161db7e/coverage/collector.py#L115\n\nI\u0027ll just make this eventlet.","commit_id":"6e3425d2ac77be896e528ea537f92e718dce0ee5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ee27bdda38fa6acc6639ac365f74d11d3f41507f","unresolved":false,"context_lines":[{"line_number":3,"context_line":"source \u003d nova"},{"line_number":4,"context_line":"omit \u003d nova/tests/*"},{"line_number":5,"context_line":"parallel \u003d True"},{"line_number":6,"context_line":"concurrency \u003d"},{"line_number":7,"context_line":"  eventlet"},{"line_number":8,"context_line":"  greenlet"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"[report]"},{"line_number":11,"context_line":"ignore_errors \u003d True"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7faddb67_f0e1e2fd","line":8,"range":{"start_line":6,"start_character":0,"end_line":8,"end_character":10},"in_reply_to":"7faddb67_7fc145e4","updated":"2019-07-09 19:57:25.000000000","message":"Why? It\u0027s a multi-line option and both are valid.","commit_id":"6e3425d2ac77be896e528ea537f92e718dce0ee5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d16ac690e3e342ef3d56dabc1898d16fc3ba88ac","unresolved":false,"context_lines":[{"line_number":3,"context_line":"source \u003d nova"},{"line_number":4,"context_line":"omit \u003d nova/tests/*"},{"line_number":5,"context_line":"parallel \u003d True"},{"line_number":6,"context_line":"concurrency \u003d"},{"line_number":7,"context_line":"  eventlet"},{"line_number":8,"context_line":"  greenlet"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"[report]"},{"line_number":11,"context_line":"ignore_errors \u003d True"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7faddb67_70bf32d0","line":8,"range":{"start_line":6,"start_character":0,"end_line":8,"end_character":10},"in_reply_to":"7faddb67_f0e1e2fd","updated":"2019-07-09 19:59:11.000000000","message":"Ah crap you\u0027re right:\n\nhttp://logs.openstack.org/12/669912/1/check/openstack-tox-cover/ca84571/job-output.txt.gz#_2019-07-09_19_25_14_216205\n\n2019-07-09 19:25:14.216205 | ubuntu-bionic | Conflicting concurrency settings: [\u0027eventlet\u0027, \u0027greenlet\u0027]\n\nNova uses both though so which should we use here? Just eventlet?","commit_id":"6e3425d2ac77be896e528ea537f92e718dce0ee5"}],"tox.ini":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"00a4a0d73f9610010dbb9eb88a44c68fecf2d400","unresolved":false,"context_lines":[{"line_number":140,"context_line":"envdir \u003d {toxworkdir}/shared"},{"line_number":141,"context_line":"setenv \u003d"},{"line_number":142,"context_line":"  {[testenv]setenv}"},{"line_number":143,"context_line":"  PYTHON\u003dcoverage run --source nova --parallel-mode"},{"line_number":144,"context_line":"commands \u003d"},{"line_number":145,"context_line":"  coverage erase"},{"line_number":146,"context_line":"  stestr run {posargs}"}],"source_content_type":"text/x-properties","patch_set":2,"id":"7faddb67_f299dc6d","side":"PARENT","line":143,"range":{"start_line":143,"start_character":1,"end_line":143,"end_character":22},"updated":"2019-07-10 12:42:15.000000000","message":"we might need at this bit as im seeing\nerrors for coverage statign there is no data\n\nwhen the current run finsihses ill try change stestr to coverage run stestr ... below in the commands section to get the same effect and see if that resolves\n\ncover run-test: commands[2] | coverage combine\n[9518] /home/sean/nova$ /home/sean/nova/.tox/shared/bin/coverage combine\nNo data to combine\nERROR: InvocationError for command /home/sean/nova/.tox/shared/bin/coverage combine (exited with code 1)","commit_id":"3769da1428c36d67855185f718af71495586024e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"916f29bd1415fb0cb81e78335f93608a6077510b","unresolved":false,"context_lines":[{"line_number":142,"context_line":"deps \u003d {[testenv:functional]deps}"},{"line_number":143,"context_line":"commands \u003d"},{"line_number":144,"context_line":"  coverage erase"},{"line_number":145,"context_line":"  stestr --test-path\u003d./nova/tests/ run {posargs}"},{"line_number":146,"context_line":"  coverage combine"},{"line_number":147,"context_line":"  coverage report"},{"line_number":148,"context_line":""}],"source_content_type":"text/x-properties","patch_set":2,"id":"7faddb67_48ae0299","line":145,"range":{"start_line":145,"start_character":2,"end_line":145,"end_character":48},"updated":"2019-07-10 11:54:44.000000000","message":"i was going to suggest spliting this into \n\nstestr --test-path\u003d./nova/tests/unit run {posargs}\nstestr --test-path\u003d./nova/tests/functional run --combine {posargs}\n\nin the above case but test suites run to complteion fine but\n\nthe coverage combine does not find the data and coverage report also does not work if i remove coverate combine\n\nif i change it to \n\nstestr --test-path\u003d./nova/tests/unit run {posargs}\nstestr --test-path\u003d./nova/tests/functional run {posargs}\n\ni still get the no data to combine error.\n\n\nwe could possibly use the --analyze-isolation  option try and find all test case interactions or use --isolated to make sure that there are none by reunning each test in its own python interperter instead of reusing them.","commit_id":"46f5947ba5e94ecd2544a8c0a05105e23b436d03"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"00a4a0d73f9610010dbb9eb88a44c68fecf2d400","unresolved":false,"context_lines":[{"line_number":142,"context_line":"deps \u003d {[testenv:functional]deps}"},{"line_number":143,"context_line":"commands \u003d"},{"line_number":144,"context_line":"  coverage erase"},{"line_number":145,"context_line":"  stestr --test-path\u003d./nova/tests/ run {posargs}"},{"line_number":146,"context_line":"  coverage combine"},{"line_number":147,"context_line":"  coverage report"},{"line_number":148,"context_line":""}],"source_content_type":"text/x-properties","patch_set":2,"id":"7faddb67_d279402f","line":145,"range":{"start_line":145,"start_character":2,"end_line":145,"end_character":48},"in_reply_to":"7faddb67_48ae0299","updated":"2019-07-10 12:42:15.000000000","message":"isolate disables all concurancy so its way to slow.\n\nim testing this small change which seams to allow most test to pass. i only got 4 failures.\n\n- p groups tests by class when executing them in parralel and --random asigns them to workers randomly instead of in alpabetical order. we have no timing data so it falls back to alpabetical order but i think random will give us better parallelisuim.\n \n\ndiff --git a/tox.ini b/tox.ini\nindex 56cf9fa6b4..ad2ebd7d84 100644\n--- a/tox.ini\n+++ b/tox.ini\n@@ -142,7 +142,8 @@ setenv \u003d\n deps \u003d {[testenv:functional]deps}\n commands \u003d\n   coverage erase\n-  stestr --test-path\u003d./nova/tests/ run {posargs}\n+  # - means ignore exit code we dont care if a test failed just that it ran.\n+  - stestr -p --test-path\u003d./nova/tests/ run --random {posargs}\n   coverage combine\n   coverage report","commit_id":"46f5947ba5e94ecd2544a8c0a05105e23b436d03"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"21bd8eadb14d8b068998902269157a8d1c4fb797","unresolved":false,"context_lines":[{"line_number":138,"context_line":"setenv \u003d"},{"line_number":139,"context_line":"  {[testenv]setenv}"},{"line_number":140,"context_line":"  OS_TEST_TIMEOUT\u003d30"},{"line_number":141,"context_line":"  PYTHON\u003dcoverage run"},{"line_number":142,"context_line":"# Make the functional tests work by re-using the same dependencies, i.e."},{"line_number":143,"context_line":"# importing placement to get the PlacementFixture."},{"line_number":144,"context_line":"deps \u003d {[testenv:functional]deps}"}],"source_content_type":"text/x-properties","patch_set":3,"id":"7faddb67_a64482b8","line":141,"range":{"start_line":141,"start_character":2,"end_line":141,"end_character":21},"updated":"2019-07-10 15:48:59.000000000","message":"this is needed even if we are using the new coverage\nbinary or we will not get any coverage data for the test runs.","commit_id":"7fffb11e37db92b57c1ddc230debe6764c2053b6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"21bd8eadb14d8b068998902269157a8d1c4fb797","unresolved":false,"context_lines":[{"line_number":145,"context_line":"commands \u003d"},{"line_number":146,"context_line":"  coverage erase"},{"line_number":147,"context_line":"  # - means ignore exit code we dont care if a test failed just that it ran."},{"line_number":148,"context_line":"  - timeout 600 stestr -p --test-path\u003d./nova/tests/ run --random {posargs}"},{"line_number":149,"context_line":"  coverage combine"},{"line_number":150,"context_line":"  coverage report"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-properties","patch_set":3,"id":"7faddb67_06a0f642","line":148,"range":{"start_line":148,"start_character":56,"end_line":148,"end_character":64},"updated":"2019-07-10 15:48:59.000000000","message":"TL;DR feel free to drop --random\n\n--random is proably not needed i think i was getting slightly better run times but well its random so im not sure.\n\nsince there is no timeing data in the vms by defualt it would be allocating the test groups to workers in alphabetical order near the end of the run this was causeing the test execution to slow down.\n\nthis still happens with --random but over all it seam better but in the gate it proably will make no difference. i was still seeing 3-4 thread active witout it near the end and in the gate that would be most of the cores\n\nits only noticable locally becasue i had 24 cores working on it and without it i seamed to end up with 1 or 2 thread proceeing the last few tests. but i also saw that in some runs of this locally becasue random.","commit_id":"7fffb11e37db92b57c1ddc230debe6764c2053b6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"21bd8eadb14d8b068998902269157a8d1c4fb797","unresolved":false,"context_lines":[{"line_number":145,"context_line":"commands \u003d"},{"line_number":146,"context_line":"  coverage erase"},{"line_number":147,"context_line":"  # - means ignore exit code we dont care if a test failed just that it ran."},{"line_number":148,"context_line":"  - timeout 600 stestr -p --test-path\u003d./nova/tests/ run --random {posargs}"},{"line_number":149,"context_line":"  coverage combine"},{"line_number":150,"context_line":"  coverage report"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-properties","patch_set":3,"id":"7faddb67_862f06a0","line":148,"range":{"start_line":148,"start_character":4,"end_line":148,"end_character":15},"updated":"2019-07-10 15:48:59.000000000","message":"i dont think stester or coverage are respecitng OS_TEST_TIME\n\ni had one case where i had a test that hung and it did not get killed after 30 second so just added a 10 minute timeout\nlooking at the gate times now that is proably way to short\ni was runing with 24 cores the gate uses 8 and takes about 3 times as long which makes sense so we proably want to trile this to 1800 this should not be needed but i would like to get some result if a test hangs instead of throwing away all the data","commit_id":"7fffb11e37db92b57c1ddc230debe6764c2053b6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"21bd8eadb14d8b068998902269157a8d1c4fb797","unresolved":false,"context_lines":[{"line_number":145,"context_line":"commands \u003d"},{"line_number":146,"context_line":"  coverage erase"},{"line_number":147,"context_line":"  # - means ignore exit code we dont care if a test failed just that it ran."},{"line_number":148,"context_line":"  - timeout 600 stestr -p --test-path\u003d./nova/tests/ run --random {posargs}"},{"line_number":149,"context_line":"  coverage combine"},{"line_number":150,"context_line":"  coverage report"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-properties","patch_set":3,"id":"7faddb67_86770603","line":148,"range":{"start_line":148,"start_character":23,"end_line":148,"end_character":25},"updated":"2019-07-10 15:48:59.000000000","message":"this groups test by class when executing them in parallel\n\nthis seems to remove most if not all the issues we were seeing.","commit_id":"7fffb11e37db92b57c1ddc230debe6764c2053b6"}]}