)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"abe951f01b8cd567d3f0b85ac039aeb967c50093","unresolved":false,"context_lines":[{"line_number":24,"context_line":"which should be very small for the time being.)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Test note: Existing tests in nova.tests.unit.compute.test_provider_tree"},{"line_number":27,"context_line":"thoroughly cover all the affected code paths. There was one usage of"},{"line_number":28,"context_line":"ProviderTree.roots that was untested and broken (even before this"},{"line_number":29,"context_line":"change) which is now fixed."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Conflicts (rocky backport):"},{"line_number":32,"context_line":"  nova/compute/provider_tree.py"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_4058d688","line":29,"range":{"start_line":27,"start_character":46,"end_line":29,"end_character":27},"updated":"2019-07-31 20:22:55.000000000","message":"This applies to https://review.opendev.org/#/c/670179/1/nova/virt/libvirt/driver.py which isn\u0027t part of the backport, right?","commit_id":"00e5e3a7443dd31720244497013b040729490dcd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"4f4d514ff5586e3fada7b76c0ddf49551bd66613","unresolved":false,"context_lines":[{"line_number":24,"context_line":"which should be very small for the time being.)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Test note: Existing tests in nova.tests.unit.compute.test_provider_tree"},{"line_number":27,"context_line":"thoroughly cover all the affected code paths. There was one usage of"},{"line_number":28,"context_line":"ProviderTree.roots that was untested and broken (even before this"},{"line_number":29,"context_line":"change) which is now fixed."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Conflicts (rocky backport):"},{"line_number":32,"context_line":"  nova/compute/provider_tree.py"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_a0cc2a35","line":29,"range":{"start_line":27,"start_character":46,"end_line":29,"end_character":27},"in_reply_to":"7faddb67_4058d688","updated":"2019-07-31 20:24:19.000000000","message":"True story. I\u0027m always afraid of editing the commit message for a backport, except for conflicts. Is it appropriate to remove this sentence in this case?","commit_id":"00e5e3a7443dd31720244497013b040729490dcd"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"28d5e6050ae6f7fa2a69f71eb7fb8a3843c29b0a","unresolved":false,"context_lines":[{"line_number":24,"context_line":"which should be very small for the time being.)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Test note: Existing tests in nova.tests.unit.compute.test_provider_tree"},{"line_number":27,"context_line":"thoroughly cover all the affected code paths. There was one usage of"},{"line_number":28,"context_line":"ProviderTree.roots that was untested and broken (even before this"},{"line_number":29,"context_line":"change) which is now fixed."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Conflicts (rocky backport):"},{"line_number":32,"context_line":"  nova/compute/provider_tree.py"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_80f00e69","line":29,"range":{"start_line":27,"start_character":46,"end_line":29,"end_character":27},"in_reply_to":"7faddb67_a0cc2a35","updated":"2019-07-31 20:26:25.000000000","message":"No it\u0027s fine I was just picking over this because it doesn\u0027t have any tests but as noted it\u0027s a refactor so existing tests cover it.","commit_id":"00e5e3a7443dd31720244497013b040729490dcd"}]}