)]}'
{"nova/scheduler/utils.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"c3b3684210fdb964a1798322ce29d50ec4cfbba2","unresolved":false,"context_lines":[{"line_number":327,"context_line":"                \"\u0027group_policy\u0027: \u0027isolate\u0027.\")"},{"line_number":328,"context_line":"        return parse.urlencode(sorted(qparams))"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    @property"},{"line_number":331,"context_line":"    def get_all_required_traits(self):"},{"line_number":332,"context_line":"        traits \u003d set()"},{"line_number":333,"context_line":"        for rr in self._rg_by_id.values():"},{"line_number":334,"context_line":"            traits \u003d traits.union(rr.required_traits)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_b92a4b29","line":331,"range":{"start_line":330,"start_character":4,"end_line":331,"end_character":31},"updated":"2019-07-11 22:09:28.000000000","message":"Either un-@property this or name it all_required_traits.","commit_id":"8baa118a120476a8e2aa1e0573369e2d99d032fa"},{"author":{"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},"change_message_id":"f8d161ffebd2f18f0a05250e6aee10a4c1fa7391","unresolved":false,"context_lines":[{"line_number":327,"context_line":"                \"\u0027group_policy\u0027: \u0027isolate\u0027.\")"},{"line_number":328,"context_line":"        return parse.urlencode(sorted(qparams))"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    @property"},{"line_number":331,"context_line":"    def get_all_required_traits(self):"},{"line_number":332,"context_line":"        traits \u003d set()"},{"line_number":333,"context_line":"        for rr in self._rg_by_id.values():"},{"line_number":334,"context_line":"            traits \u003d traits.union(rr.required_traits)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_e5ea500d","line":331,"range":{"start_line":330,"start_character":4,"end_line":331,"end_character":31},"in_reply_to":"7faddb67_b92a4b29","updated":"2019-07-12 05:05:55.000000000","message":"Done","commit_id":"8baa118a120476a8e2aa1e0573369e2d99d032fa"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5390dc8d69bc46b7d4557a5027f169002fd4dbdc","unresolved":false,"context_lines":[{"line_number":328,"context_line":"        return parse.urlencode(sorted(qparams))"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    @property"},{"line_number":331,"context_line":"    def all_required_traits(self):"},{"line_number":332,"context_line":"        traits \u003d set()"},{"line_number":333,"context_line":"        for rr in self._rg_by_id.values():"},{"line_number":334,"context_line":"            traits \u003d traits.union(rr.required_traits)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_043c12df","line":331,"range":{"start_line":331,"start_character":8,"end_line":331,"end_character":12},"updated":"2019-08-02 13:34:20.000000000","message":"This feels a bit unnecessary. Perhaps we could drop it in a follow-up?","commit_id":"2d4b32e1bd432a5cb6f8098edbce4b347a7ec035"}]}