)]}'
{"nova/scheduler/client/report.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"37c7e7c2d5c633927ed8ca1f22a3962dad33e1ad","unresolved":false,"context_lines":[{"line_number":263,"context_line":"        # media type to application/json for us. Placement API is"},{"line_number":264,"context_line":"        # more sensitive to this than other APIs in the OpenStack"},{"line_number":265,"context_line":"        # ecosystem."},{"line_number":266,"context_line":"        return self._client.put(url, json\u003ddata, microversion\u003dversion,"},{"line_number":267,"context_line":"                                global_request_id\u003dglobal_request_id)"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    def delete(self, url, version\u003dNone, global_request_id\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_662cff01","line":266,"range":{"start_line":266,"start_character":37,"end_line":266,"end_character":46},"updated":"2019-07-16 01:53:06.000000000","message":"Is it safe to potentially pass json\u003dNone here? Old code only included the \u0027json\u0027 kwarg if not None.","commit_id":"8068bb3f4a36c3347b9da45a6a624a2acf9d1cdc"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"665a1a1f4b9291cfc1e646be5ecff73d07c31700","unresolved":false,"context_lines":[{"line_number":263,"context_line":"        # media type to application/json for us. Placement API is"},{"line_number":264,"context_line":"        # more sensitive to this than other APIs in the OpenStack"},{"line_number":265,"context_line":"        # ecosystem."},{"line_number":266,"context_line":"        return self._client.put(url, json\u003ddata, microversion\u003dversion,"},{"line_number":267,"context_line":"                                global_request_id\u003dglobal_request_id)"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    def delete(self, url, version\u003dNone, global_request_id\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_66639f43","line":266,"range":{"start_line":266,"start_character":37,"end_line":266,"end_character":46},"in_reply_to":"7faddb67_662cff01","updated":"2019-07-16 02:03:38.000000000","message":"Yes, sorry, I meant to comment on this when I pushed it. I did trace the json kwarg through the stack into ksa and it\u0027s definitely the same behavior specifying None as leaving it out.","commit_id":"8068bb3f4a36c3347b9da45a6a624a2acf9d1cdc"}],"nova/tests/unit/scheduler/client/test_report.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"37c7e7c2d5c633927ed8ca1f22a3962dad33e1ad","unresolved":false,"context_lines":[{"line_number":2825,"context_line":"            **self.trait_api_kwargs)"},{"line_number":2826,"context_line":"        self.ks_adap_mock.put.assert_has_calls("},{"line_number":2827,"context_line":"            [mock.call(\u0027/traits/\u0027 + trait,"},{"line_number":2828,"context_line":"             global_request_id\u003dself.context.global_id, json\u003dNone,"},{"line_number":2829,"context_line":"             **self.trait_api_kwargs)"},{"line_number":2830,"context_line":"             for trait in custom_traits], any_order\u003dTrue)"},{"line_number":2831,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_8631fb5c","line":2828,"range":{"start_line":2828,"start_character":54,"end_line":2828,"end_character":64},"updated":"2019-07-16 01:53:06.000000000","message":"Note to self: this is new.","commit_id":"8068bb3f4a36c3347b9da45a6a624a2acf9d1cdc"}]}