)]}'
{"id":"openstack%2Fnova~671106","triplet_id":"openstack%2Fnova~master~I765d7bd735cffafb17369cae41e1cc23334363f2","project":"openstack/nova","branch":"master","topic":"debug-helper","hashtags":[],"change_id":"I765d7bd735cffafb17369cae41e1cc23334363f2","subject":"Increases the level of detail provided by the debug messages in pci_passthrough_filter.py.","status":"NEW","created":"2019-07-16 16:44:07.000000000","updated":"2019-07-17 02:00:11.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":true,"submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"c4cf8a9b7cb1cb8c0eec28f378dce06efaac1847","_number":671106,"virtual_id_number":671106,"owner":{"_account_id":30691,"name":"Mauricio Tavares","email":"raubvogel@gmail.com","username":"raub"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":-1,"date":"2019-07-16 23:33:40.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26490,"name":"Jason SUN","email":"sunjia@inspur.com","username":"sunjia"},{"value":0,"date":"2019-07-16 19:30:18.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":0,"date":"2019-07-16 19:48:53.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"date":"2019-07-16 19:14:39.000000000","_account_id":16898,"name":"Virtuozzo CI","email":"virtuozzo6-ci@virtuozzo.com","username":"virtuozzo6-ci","tags":["SERVICE_USER"]},{"_account_id":30691,"name":"Mauricio Tavares","email":"raubvogel@gmail.com","username":"raub"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":26490,"name":"Jason SUN","email":"sunjia@inspur.com","username":"sunjia"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-07-17 02:00:11.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":26490,"name":"Jason SUN","email":"sunjia@inspur.com","username":"sunjia"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":16898,"name":"Virtuozzo CI","email":"virtuozzo6-ci@virtuozzo.com","username":"virtuozzo6-ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":30691,"name":"Mauricio Tavares","email":"raubvogel@gmail.com","username":"raub"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26490,"name":"Jason SUN","email":"sunjia@inspur.com","username":"sunjia"},{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":16898,"name":"Virtuozzo CI","email":"virtuozzo6-ci@virtuozzo.com","username":"virtuozzo6-ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":30691,"name":"Mauricio Tavares","email":"raubvogel@gmail.com","username":"raub"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":26490,"name":"Jason SUN","email":"sunjia@inspur.com","username":"sunjia"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":16898,"name":"Virtuozzo CI","email":"virtuozzo6-ci@virtuozzo.com","username":"virtuozzo6-ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":30691,"name":"Mauricio Tavares","email":"raubvogel@gmail.com","username":"raub"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":16898,"name":"Virtuozzo CI","email":"virtuozzo6-ci@virtuozzo.com","username":"virtuozzo6-ci","tags":["SERVICE_USER"]},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"_account_id":26490,"name":"Jason SUN","email":"sunjia@inspur.com","username":"sunjia"},{"_account_id":30691,"name":"Mauricio Tavares","email":"raubvogel@gmail.com","username":"raub"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-07-16 16:44:20.000000000","updated_by":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"reviewer":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"state":"REVIEWER"},{"updated":"2019-07-16 19:14:39.000000000","updated_by":{"_account_id":16898,"name":"Virtuozzo CI","email":"virtuozzo6-ci@virtuozzo.com","username":"virtuozzo6-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":16898,"name":"Virtuozzo CI","email":"virtuozzo6-ci@virtuozzo.com","username":"virtuozzo6-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-07-16 19:30:18.000000000","updated_by":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"reviewer":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"state":"REVIEWER"},{"updated":"2019-07-16 19:48:53.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-07-16 23:33:40.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-07-17 02:00:11.000000000","updated_by":{"_account_id":26490,"name":"Jason SUN","email":"sunjia@inspur.com","username":"sunjia"},"reviewer":{"_account_id":26490,"name":"Jason SUN","email":"sunjia@inspur.com","username":"sunjia"},"state":"REVIEWER"}],"messages":[{"id":"ddebcd790a1b99a2b9062e27904391db62f8c59d","author":{"_account_id":30691,"name":"Mauricio Tavares","email":"raubvogel@gmail.com","username":"raub"},"date":"2019-07-16 16:44:07.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c16c9c2e9a6c08123bb3a3fcf4b33b8c141df065","author":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"date":"2019-07-16 16:44:20.000000000","message":"Patch Set 1:\n\nThank you for your first contribution to OpenStack.\n\nYour patch will now be tested automatically by OpenStack testing frameworks\nand once the automatic tests pass, it will be reviewed by other friendly\ndevelopers. They will give you feedback and may require you to refine it.\n\nPeople seldom get their patch approved on the first try, so don\u0027t be\nconcerned if requested to make corrections. Feel free to modify your patch\nand resubmit a new change-set.\n\nPatches usually take 3 to 7 days to be reviewed so be patient and be\navailable on IRC to ask and answer questions about your work. Also it\ntakes generally at least a couple of weeks for cores to get around to\nreviewing code. The more you participate in the community the more\nrewarding it is for you. You may also notice that the more you get to know\npeople and get to be known, the faster your patches will be reviewed and\neventually approved. Get to know others and become known by doing code\nreviews: anybody can do it, and it\u0027s a great way to learn the code base.\n\nThanks again for supporting OpenStack, we look forward to working with you.\n\nIRC: https://wiki.openstack.org/wiki/IRC\nWorkflow: https://docs.openstack.org/infra/manual/developers.html\nCommit Messages: https://wiki.openstack.org/wiki/GitCommitMessages","accounts_in_message":[],"_revision_number":1},{"id":"376dd2f9727a45c1372dc0520858cece599ec5ea","author":{"_account_id":30691,"name":"Mauricio Tavares","email":"raubvogel@gmail.com","username":"raub"},"date":"2019-07-16 16:45:53.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"61fda99d4a0350deefbb71de2afb706f79c28f65","author":{"_account_id":30691,"name":"Mauricio Tavares","email":"raubvogel@gmail.com","username":"raub"},"date":"2019-07-16 17:24:39.000000000","message":"Patch Set 2:\n\nBTW, I accidentally pushed my .gitreview. It has nothing to do with the request.","accounts_in_message":[],"_revision_number":2},{"id":"a3bf26ea335f27289644a0a2438710fefca21ee8","author":{"_account_id":30691,"name":"Mauricio Tavares","email":"raubvogel@gmail.com","username":"raub"},"date":"2019-07-16 18:25:30.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"ce896e424e6fec31d62c55ae0393435fb7edbb56","author":{"_account_id":16898,"name":"Virtuozzo CI","email":"virtuozzo6-ci@virtuozzo.com","username":"virtuozzo6-ci","tags":["SERVICE_USER"]},"date":"2019-07-16 19:14:39.000000000","message":"Patch Set 3:\n\nBuild failed\n\n- check-dsvm-tempest-vz7-exe-minimal http://openstack-3rd-party-virtuozzo-ci-logs.virtuozzo.com/06/671106/3/check/check-dsvm-tempest-vz7-exe-minimal/6d235b1 : FAILURE in 14m 25s\n\nFor information, see https://wiki.openstack.org/wiki/ThirdPartySystems/Virtuozzo_CI Make the comment \u0027run-Virtuozzo CI\u0027 to recheck","accounts_in_message":[],"_revision_number":3},{"id":"2a26613f79861d2c9555ceb7a5db45b6d9a46557","author":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"date":"2019-07-16 19:30:18.000000000","message":"Patch Set 3:\n\nTesting completed on the zVM Driver CI system check-nova pipeline and failed.  To recheck only the zVM driver plugins, submit a comment with only  zvm: recheck in the comment.. Contact information: zvmosci@us.ibm.com. For information see https://wiki.openstack.org/wiki/ZVMDriver.\n\n- check-nova-master http://extbasicopstackcilog01.podc.sl.edst.ibm.com/test_logs/jenkins-check-nova-master-33942 : FAILURE in 58m 39s","accounts_in_message":[],"_revision_number":3},{"id":"e3f7ba5562c3b5e69f95deba8aeae0a4db35f244","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2019-07-16 19:48:53.000000000","message":"Patch Set 3:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/06/671106/3/check/tempest-dsvm-full-xenial/7eb0491/ : FAILURE in 16m 41s\n- tempest-dsvm-full-xenial-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/06/671106/3/check/tempest-dsvm-full-xenial-py3/514f9fd/ : SUCCESS in 1h 22m 12s (non-voting)\n- grenade-dsvm-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/06/671106/3/check/grenade-dsvm-xenial/9d5159d/ : SUCCESS in 1h 18m 37s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"2673a5ac8086c7418eca7b0c364f98d3cf57920d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-16 23:33:40.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- grenade-py3 http://logs.openstack.org/06/671106/3/check/grenade-py3/246fdc4/ : SUCCESS in 1h 06m 41s\n- tempest-full-py3 http://logs.openstack.org/06/671106/3/check/tempest-full-py3/77595b3/ : SUCCESS in 1h 29m 50s\n- openstack-tox-cover http://logs.openstack.org/06/671106/3/check/openstack-tox-cover/97e28f7/ : FAILURE in 19m 01s\n- openstack-tox-lower-constraints http://logs.openstack.org/06/671106/3/check/openstack-tox-lower-constraints/31ffdf8/ : FAILURE in 18m 39s\n- openstack-tox-pep8 http://logs.openstack.org/06/671106/3/check/openstack-tox-pep8/9659805/ : FAILURE in 9m 59s\n- openstack-tox-py27 http://logs.openstack.org/06/671106/3/check/openstack-tox-py27/63e58e9/ : FAILURE in 14m 36s\n- openstack-tox-py36 http://logs.openstack.org/06/671106/3/check/openstack-tox-py36/adae726/ : FAILURE in 18m 49s\n- openstack-tox-py37 http://logs.openstack.org/06/671106/3/check/openstack-tox-py37/31515f2/ : FAILURE in 17m 54s\n- openstack-tox-docs http://logs.openstack.org/06/671106/3/check/openstack-tox-docs/fc18558/html/ : SUCCESS in 8m 32s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa http://logs.openstack.org/06/671106/3/check/ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa/3b21207/ : SUCCESS in 49m 00s (non-voting)\n- devstack-plugin-ceph-tempest http://logs.openstack.org/06/671106/3/check/devstack-plugin-ceph-tempest/e0e8efa/ : SUCCESS in 1h 19m 55s (non-voting)\n- neutron-grenade-multinode http://logs.openstack.org/06/671106/3/check/neutron-grenade-multinode/c057b6b/ : SUCCESS in 1h 24m 33s\n- nova-grenade-live-migration http://logs.openstack.org/06/671106/3/check/nova-grenade-live-migration/1d6ae67/ : SUCCESS in 1h 09m 02s\n- nova-live-migration http://logs.openstack.org/06/671106/3/check/nova-live-migration/a3b24ee/ : SUCCESS in 57m 05s\n- nova-multi-cell http://logs.openstack.org/06/671106/3/check/nova-multi-cell/cedda5b/ : SUCCESS in 1h 31m 35s (non-voting)\n- nova-next http://logs.openstack.org/06/671106/3/check/nova-next/ba66216/ : SUCCESS in 1h 46m 22s\n- nova-tox-functional http://logs.openstack.org/06/671106/3/check/nova-tox-functional/9bba394/ : SUCCESS in 25m 44s\n- nova-tox-functional-py36 http://logs.openstack.org/06/671106/3/check/nova-tox-functional-py36/d09e8c8/ : SUCCESS in 23m 38s\n- tempest-slow-py3 http://logs.openstack.org/06/671106/3/check/tempest-slow-py3/d1347fe/ : SUCCESS in 2h 30m 50s","accounts_in_message":[],"_revision_number":3},{"id":"6284b74ee87b548a2204309347b78f67628acc71","author":{"_account_id":26490,"name":"Jason SUN","email":"sunjia@inspur.com","username":"sunjia"},"date":"2019-07-17 02:00:11.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"a48d9e7a68eb2d793260e6d90a5f7d33cbbc3030","revisions":{"91abe52bc4fc418b0202f3c8f40fdfa93f91fcca":{"kind":"REWORK","_number":1,"created":"2019-07-16 16:44:07.000000000","uploader":{"_account_id":30691,"name":"Mauricio Tavares","email":"raubvogel@gmail.com","username":"raub"},"ref":"refs/changes/06/671106/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/06/671106/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/06/671106/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/06/671106/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/06/671106/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/06/671106/1"}}},"commit":{"parents":[{"commit":"0a62d9765bc67ac375a33e77e4633e90afe44331","subject":"Merge \"Remove Rocky-era min compute trusted certs compat check\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/0a62d9765bc67ac375a33e77e4633e90afe44331"}]}],"author":{"name":"Mauricio Tavares","email":"raubvogel@gmail.com","date":"2019-07-16 16:34:17.000000000","tz":-240},"committer":{"name":"Mauricio Tavares","email":"raubvogel@gmail.com","date":"2019-07-16 16:43:36.000000000","tz":-240},"subject":"   Author: Mauricio Tavares \u003craubvogel@gmail.com\u003e","message":"   Author: Mauricio Tavares \u003craubvogel@gmail.com\u003e\n\n   Increases the level of detail provided by the debug messages in\npci_passthrough_filter.py.\n\nCurrent debug output when pci passthrough filter test fails is something like\nthis:\n\n```\n2019-06-26 14:25:35.513 14352 DEBUG nova.scheduler.filters.pci_passthrough_filter\n[req-b5e116b8-e852-4b95-a72f-a56c111afdee 7808c002b9784def81d8a20b63a14b62\n93c6cce5fae8427bb4030a3eb8f43d4a - default default] (openstack-w1.example.com,\nopenstack-w1.example.com) ram: 63334MB disk: 124928MB io_ops: 0 instances: 3\ndoesn\u0027t have the required PCI devices (InstancePCIRequests(instance_uuid\u003d417592b3-71a1-485a-8209-a7e01fc7ad32,requests\u003d[InstancePCIRequest]))\nhost_passes /usr/lib/python2.7/site-packages/nova/scheduler/filters/pci_passthrough_filter.py:57\n```\n\nIn other words, it output the list of PCI devices requested as an instance_uuid\nthingie. If you look at the comments in the `pci_passthrough_filter.py` file,\n\n```\n    Filter that schedules instances on a host if the host has devices\n    to meet the device requests in the \u0027extra_specs\u0027 for the flavor.\n\n    PCI resource tracker provides updated summary information about the\n    PCI devices for each host, like::\n\n        | [{\"count\": 5, \"vendor_id\": \"8086\", \"product_id\": \"1520\",\n        |   \"extra_info\":\u0027{}\u0027}],\n\n   and VM requests PCI devices via PCI requests, like::\n\n        | [{\"count\": 1, \"vendor_id\": \"8086\", \"product_id\": \"1520\",}].\n```\n\nit implies the requests and pci device avilable in a host are lists. I propose\nnot only to output the pci device request as a list\n\n```\n2019-07-12 18:38:03.651 17858 DEBUG nova.scheduler.filters.pci_passthrough_filter\n[req-50f5cfa4-c233-437e-8c53-dca760abb1c6 7808c002b9784def81d8a20b63a14b62\n93c6cce5fae8427bb4030a3eb8f43d4a - default default] (openstack-w1.example,\nopenstack-w1.example.com) ram: 64870MB disk: 125952MB io_ops: 0 instances: 0\ndoesn\u0027t have the required PCI devices ([InstancePCIRequest(alias_name\u003d\u0027Netronome\u0027,\ncount\u003d1,is_new\u003d\u003c?\u003e,numa_policy\u003d\u0027legacy\u0027,request_id\u003dNone,requester_id\u003d\u003c?\u003e,\nspec\u003d[{dev_type\u003d\u0027type-PCI\u0027,product_id\u003d\u00274000\u0027,vendor_id\u003d\u002719ee\u0027}])]) host_passes\n/usr/lib/python2.7/site-packages/nova/scheduler/filters/pci_passthrough_filter.py:57\n```\n\nbut also the list of pci devices in the host,\n\n```\n2019-07-02 18:38:03.789 16776 DEBUG nova.scheduler.filters.pci_passthrough_filter\n[req-3fe1e6c3-6199-4abb-86e6-486386d67522 7808c002b9784def81d8a20b63a14b62\n93c6cce5fae8427bb4030a3eb8f43d4a - default default] (openstack-w1.example.com,\nopenstack-w1.example.com) ram: 64870MB disk: 128000MB io_ops: 0 instances: 0\nlist of PCI devices: ([{\u0027count\u0027: 1, \u0027product_id\u0027: u\u00274000\u0027, u\u0027dev_type\u0027:\nu\u0027type-PF\u0027, \u0027numa_node\u0027: 0, \u0027vendor_id\u0027: u\u002719ee\u0027}]) host_passes\n/usr/lib/python2.7/site-packages/nova/scheduler/filters/pci_passthrough_filter.py:55\n```\n\nso someone trying to figure out why the pci passthrough filter failed can\nsee exactly what is being asked and what the host have. In this example,\nthe dev-type was wrongly set to `type-PCI` in `nova.conf` file. With this\npatch, we can see exactly what nova thinks the card in question is.\n\nChange-Id: I765d7bd735cffafb17369cae41e1cc23334363f2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/91abe52bc4fc418b0202f3c8f40fdfa93f91fcca"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/91abe52bc4fc418b0202f3c8f40fdfa93f91fcca"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"0a62d9765bc67ac375a33e77e4633e90afe44331","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"2e57ba60e92bdb5ed97b8d2ce75791943930b8e0":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2019-07-16 16:45:53.000000000","uploader":{"_account_id":30691,"name":"Mauricio Tavares","email":"raubvogel@gmail.com","username":"raub"},"ref":"refs/changes/06/671106/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/06/671106/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/06/671106/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/06/671106/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/06/671106/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/06/671106/2"}}},"commit":{"parents":[{"commit":"0a62d9765bc67ac375a33e77e4633e90afe44331","subject":"Merge \"Remove Rocky-era min compute trusted certs compat check\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/0a62d9765bc67ac375a33e77e4633e90afe44331"}]}],"author":{"name":"Mauricio Tavares","email":"raubvogel@gmail.com","date":"2019-07-16 16:34:17.000000000","tz":-240},"committer":{"name":"Mauricio Tavares","email":"raubvogel@gmail.com","date":"2019-07-16 16:44:34.000000000","tz":-240},"subject":"   Author: Mauricio Tavares \u003craubvogel@gmail.com\u003e","message":"   Author: Mauricio Tavares \u003craubvogel@gmail.com\u003e\n\n   Increases the level of detail provided by the debug messages in\npci_passthrough_filter.py.\n\nCurrent debug output when pci passthrough filter test fails is something like\nthis:\n\n```\n2019-06-26 14:25:35.513 14352 DEBUG\nnova.scheduler.filters.pci_passthrough_filter\n[req-b5e116b8-e852-4b95-a72f-a56c111afdee 7808c002b9784def81d8a20b63a14b62\n93c6cce5fae8427bb4030a3eb8f43d4a - default default]\n(openstack-w1.example.com, openstack-w1.example.com) ram: 63334MB disk:\n124928MB io_ops: 0 instances: 3 doesn\u0027t have the required PCI devices\n(InstancePCIRequests(instance_uuid\u003d417592b3-71a1-485a-8209-a7e01fc7ad32,requests\u003d[InstancePCIRequest]))\nhost_passes\n/usr/lib/python2.7/site-packages/nova/scheduler/filters/pci_passthrough_filter.py:57\n```\n\nIn other words, it output the list of PCI devices requested as an instance_uuid\nthingie. If you look at the comments in the `pci_passthrough_filter.py` file,\n\n```\n    Filter that schedules instances on a host if the host has devices\n    to meet the device requests in the \u0027extra_specs\u0027 for the flavor.\n\n    PCI resource tracker provides updated summary information about the\n    PCI devices for each host, like::\n\n        | [{\"count\": 5, \"vendor_id\": \"8086\", \"product_id\": \"1520\",\n        |   \"extra_info\":\u0027{}\u0027}],\n\n   and VM requests PCI devices via PCI requests, like::\n\n        | [{\"count\": 1, \"vendor_id\": \"8086\", \"product_id\": \"1520\",}].\n```\n\nit implies the requests and pci device avilable in a host are lists. I propose\nnot only to output the pci device request as a list\n\n```\n2019-07-12 18:38:03.651 17858 DEBUG\nnova.scheduler.filters.pci_passthrough_filter\n[req-50f5cfa4-c233-437e-8c53-dca760abb1c6 7808c002b9784def81d8a20b63a14b62\n93c6cce5fae8427bb4030a3eb8f43d4a - default default] (openstack-w1.example,\nopenstack-w1.example.com) ram: 64870MB disk: 125952MB io_ops: 0 instances:\n0 doesn\u0027t have the required PCI devices\n([InstancePCIRequest(alias_name\u003d\u0027Netronome\u0027,\ncount\u003d1,is_new\u003d\u003c?\u003e,numa_policy\u003d\u0027legacy\u0027,request_id\u003dNone,requester_id\u003d\u003c?\u003e,\nspec\u003d[{dev_type\u003d\u0027type-PCI\u0027,product_id\u003d\u00274000\u0027,vendor_id\u003d\u002719ee\u0027}])])\nhost_passes\n/usr/lib/python2.7/site-packages/nova/scheduler/filters/pci_passthrough_filter.py:57\n```\n\nbut also the list of pci devices in the host,\n\n```\n2019-07-02 18:38:03.789 16776 DEBUG\nnova.scheduler.filters.pci_passthrough_filter\n[req-3fe1e6c3-6199-4abb-86e6-486386d67522 7808c002b9784def81d8a20b63a14b62\n93c6cce5fae8427bb4030a3eb8f43d4a - default default]\n(openstack-w1.example.com, openstack-w1.example.com) ram: 64870MB disk:\n128000MB io_ops: 0 instances: 0 list of PCI devices: ([{\u0027count\u0027: 1,\n\u0027product_id\u0027: u\u00274000\u0027, u\u0027dev_type\u0027: u\u0027type-PF\u0027, \u0027numa_node\u0027: 0,\n\u0027vendor_id\u0027: u\u002719ee\u0027}]) host_passes\n/usr/lib/python2.7/site-packages/nova/scheduler/filters/pci_passthrough_filter.py:55\n```\n\nso someone trying to figure out why the pci passthrough filter failed can\nsee exactly what is being asked and what the host have. In this example,\nthe dev-type was wrongly set to `type-PCI` in `nova.conf` file. With this\npatch, we can see exactly what nova thinks the card in question is.\n\nChange-Id: I765d7bd735cffafb17369cae41e1cc23334363f2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2e57ba60e92bdb5ed97b8d2ce75791943930b8e0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2e57ba60e92bdb5ed97b8d2ce75791943930b8e0"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"0a62d9765bc67ac375a33e77e4633e90afe44331","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"a48d9e7a68eb2d793260e6d90a5f7d33cbbc3030":{"kind":"REWORK","_number":3,"created":"2019-07-16 18:25:30.000000000","uploader":{"_account_id":30691,"name":"Mauricio Tavares","email":"raubvogel@gmail.com","username":"raub"},"ref":"refs/changes/06/671106/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/06/671106/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/06/671106/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/06/671106/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/06/671106/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/06/671106/3"}}},"commit":{"parents":[{"commit":"0a62d9765bc67ac375a33e77e4633e90afe44331","subject":"Merge \"Remove Rocky-era min compute trusted certs compat check\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/0a62d9765bc67ac375a33e77e4633e90afe44331"}]}],"author":{"name":"Mauricio Tavares","email":"raubvogel@gmail.com","date":"2019-07-16 16:34:17.000000000","tz":-240},"committer":{"name":"Mauricio Tavares","email":"raubvogel@gmail.com","date":"2019-07-16 18:25:28.000000000","tz":-240},"subject":"   Increases the level of detail provided by the debug messages in pci_passthrough_filter.py.","message":"   Increases the level of detail provided by the debug messages in\npci_passthrough_filter.py.\n\nCurrent debug output when pci passthrough filter test fails is something like\nthis:\n\n```\n2019-06-26 14:25:35.513 14352 DEBUG\nnova.scheduler.filters.pci_passthrough_filter\n[req-b5e116b8-e852-4b95-a72f-a56c111afdee 7808c002b9784def81d8a20b63a14b62\n93c6cce5fae8427bb4030a3eb8f43d4a - default default]\n(openstack-w1.example.com, openstack-w1.example.com) ram: 63334MB disk:\n124928MB io_ops: 0 instances: 3 doesn\u0027t have the required PCI devices\n(InstancePCIRequests(instance_uuid\u003d417592b3-71a1-485a-8209-a7e01fc7ad32,requests\u003d[InstancePCIRequest]))\nhost_passes\n/usr/lib/python2.7/site-packages/nova/scheduler/filters/pci_passthrough_filter.py:57\n```\n\nIn other words, it output the list of PCI devices requested as an instance_uuid\nthingie. If you look at the comments in the `pci_passthrough_filter.py` file,\n\n```\n    Filter that schedules instances on a host if the host has devices\n    to meet the device requests in the \u0027extra_specs\u0027 for the flavor.\n\n    PCI resource tracker provides updated summary information about the\n    PCI devices for each host, like::\n\n        | [{\"count\": 5, \"vendor_id\": \"8086\", \"product_id\": \"1520\",\n        |   \"extra_info\":\u0027{}\u0027}],\n\n   and VM requests PCI devices via PCI requests, like::\n\n        | [{\"count\": 1, \"vendor_id\": \"8086\", \"product_id\": \"1520\",}].\n```\n\nit implies the requests and pci device avilable in a host are lists. I propose\nnot only to output the pci device request as a list\n\n```\n2019-07-12 18:38:03.651 17858 DEBUG\nnova.scheduler.filters.pci_passthrough_filter\n[req-50f5cfa4-c233-437e-8c53-dca760abb1c6 7808c002b9784def81d8a20b63a14b62\n93c6cce5fae8427bb4030a3eb8f43d4a - default default] (openstack-w1.example,\nopenstack-w1.example.com) ram: 64870MB disk: 125952MB io_ops: 0 instances:\n0 doesn\u0027t have the required PCI devices\n([InstancePCIRequest(alias_name\u003d\u0027Netronome\u0027,\ncount\u003d1,is_new\u003d\u003c?\u003e,numa_policy\u003d\u0027legacy\u0027,request_id\u003dNone,requester_id\u003d\u003c?\u003e,\nspec\u003d[{dev_type\u003d\u0027type-PCI\u0027,product_id\u003d\u00274000\u0027,vendor_id\u003d\u002719ee\u0027}])])\nhost_passes\n/usr/lib/python2.7/site-packages/nova/scheduler/filters/pci_passthrough_filter.py:57\n```\n\nbut also the list of pci devices in the host,\n\n```\n2019-07-02 18:38:03.789 16776 DEBUG\nnova.scheduler.filters.pci_passthrough_filter\n[req-3fe1e6c3-6199-4abb-86e6-486386d67522 7808c002b9784def81d8a20b63a14b62\n93c6cce5fae8427bb4030a3eb8f43d4a - default default]\n(openstack-w1.example.com, openstack-w1.example.com) ram: 64870MB disk:\n128000MB io_ops: 0 instances: 0 list of PCI devices: ([{\u0027count\u0027: 1,\n\u0027product_id\u0027: u\u00274000\u0027, u\u0027dev_type\u0027: u\u0027type-PF\u0027, \u0027numa_node\u0027: 0,\n\u0027vendor_id\u0027: u\u002719ee\u0027}]) host_passes\n/usr/lib/python2.7/site-packages/nova/scheduler/filters/pci_passthrough_filter.py:55\n```\n\nso someone trying to figure out why the pci passthrough filter failed can\nsee exactly what is being asked and what the host have. In this example,\nthe dev-type was wrongly set to `type-PCI` in `nova.conf` file. With this\npatch, we can see exactly what nova thinks the card in question is.\n\nAuthor: Mauricio Tavares \u003craubvogel@gmail.com\u003e\nChange-Id: I765d7bd735cffafb17369cae41e1cc23334363f2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a48d9e7a68eb2d793260e6d90a5f7d33cbbc3030"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a48d9e7a68eb2d793260e6d90a5f7d33cbbc3030"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"0a62d9765bc67ac375a33e77e4633e90afe44331","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":26490,"name":"Jason SUN","email":"sunjia@inspur.com","username":"sunjia"}},{"label":"Workflow","status":"MAY"},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}
