)]}'
{"nova/virt/libvirt/device.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"e6cac457fdf48c79c9a17f41f3ffc51a2a88136a","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        if not vgpus_asked:"},{"line_number":80,"context_line":"            return"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        # The parent_device and requested_type can be None for"},{"line_number":83,"context_line":"        # backward-compatible."},{"line_number":84,"context_line":"        mdevs_available \u003d [mdev for mdev in self._mdev_list"},{"line_number":85,"context_line":"            if not mdev.is_assigned() and ("},{"line_number":86,"context_line":"                parent_device is None or mdev.parent \u003d\u003d parent_device) and"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_1359b633","line":83,"range":{"start_line":82,"start_character":8,"end_line":83,"end_character":30},"updated":"2019-07-17 09:32:38.000000000","message":"Can we drop the reshape for the vgpu?","commit_id":"4dfa2e6b1bd54891bdfd6dd828f84f05dfd23ee9"},{"author":{"_account_id":23598,"name":"Zhong Luyao","email":"luyao.zhong@intel.com","username":"ZhongLuyao"},"change_message_id":"86c3c6df4c65004a20725a455ac749639a2e9e4c","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    def unclaim_for_instance(self, instance):"},{"line_number":117,"context_line":"        self._unclaim_mdevs_for_instance(instance)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def _unclaim_mdevs_for_instance(self, instance):"},{"line_number":120,"context_line":"        for mdev in self._mdev_list:"},{"line_number":121,"context_line":"            if mdev.instance_uuid \u003d\u003d instance.uuid:"},{"line_number":122,"context_line":"                mdev.instance_uuid \u003d None"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_86c76a65","line":119,"range":{"start_line":119,"start_character":8,"end_line":119,"end_character":35},"updated":"2019-07-21 09:03:39.000000000","message":"when resize is on the same host, there is a problem that reverting resize will access here to release all mdevs but not new mdevs, and confirming resize also has the similar problem.","commit_id":"36fc7f906566f670dda2fd28cd71d5a39e0876e9"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"ef36529f1370c748f2102a32678bf77158d1c6cd","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    def unclaim_for_instance(self, instance):"},{"line_number":117,"context_line":"        self._unclaim_mdevs_for_instance(instance)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def _unclaim_mdevs_for_instance(self, instance):"},{"line_number":120,"context_line":"        for mdev in self._mdev_list:"},{"line_number":121,"context_line":"            if mdev.instance_uuid \u003d\u003d instance.uuid:"},{"line_number":122,"context_line":"                mdev.instance_uuid \u003d None"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_80342afd","line":119,"range":{"start_line":119,"start_character":8,"end_line":119,"end_character":35},"in_reply_to":"7faddb67_86c76a65","updated":"2019-07-22 09:49:47.000000000","message":"After discussing with Luyao, I\u0027m thinking of using the flavor id to distinguish the src and dest claim for the same host resize. \n\nSo we can pass the flavor_id to the claim/unclaim_for_instance when resize. Then we will identify the claim by the (instance_uuid, flavor_id).\n\nThere are two problems need to think about:\n* Only vmware driver supports cold migration to same host. For that case, the flavor_id is same for src and dest.\n* In the initial population the existing device from the hypervisor, I need to access the DB to get instance flavor id.\n\nThanks for Luyao\u0027s testing and spot this problem out.","commit_id":"36fc7f906566f670dda2fd28cd71d5a39e0876e9"}]}