)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6afa2938dfd79597966fe31e8ba008e547db011f","unresolved":false,"context_lines":[{"line_number":15,"context_line":"introduces needless delays in processing the migration. As"},{"line_number":16,"context_line":"get_machine_ips() is ony used to print a warning, this patch removes"},{"line_number":17,"context_line":"it and the warning entirely."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I58a4038b04d5a9c28927d914e71609e4deea3d9f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_a27b9525","line":18,"updated":"2019-07-18 12:32:04.000000000","message":"this needs a bug for backporting.","commit_id":"6973f30d9481bf160042a82454be938cefdc61d2"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"cead5ffa30c36a1a9fb22757f81f4880e01b9c00","unresolved":false,"context_lines":[{"line_number":15,"context_line":"introduces needless delays in processing the migration. As"},{"line_number":16,"context_line":"get_machine_ips() is ony used to print a warning, this patch removes"},{"line_number":17,"context_line":"it and the warning entirely."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I58a4038b04d5a9c28927d914e71609e4deea3d9f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_e8c3abeb","line":18,"in_reply_to":"7faddb67_a27b9525","updated":"2019-07-18 15:59:40.000000000","message":"Done","commit_id":"6973f30d9481bf160042a82454be938cefdc61d2"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"94af3f6263c7455ea94cf3f2f1a06b3301fc5b13","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Migrations use the libvirt driver\u0027s get_host_ip_addr() method to"},{"line_number":10,"context_line":"determine the dest_host field of the migration object."},{"line_number":11,"context_line":"get_host_ip_addr() checks whether CONF.my_ip is actually assigned to"},{"line_number":12,"context_line":"one of the host\u0027s interfaces. It does so my calling"},{"line_number":13,"context_line":"get_machine_ips(), which interates over all of the host\u0027s interfaces."},{"line_number":14,"context_line":"If the host has many interfaces, this can take a long time, and"},{"line_number":15,"context_line":"introduces needless delays in processing the migration. As"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_6bc3358a","line":12,"range":{"start_line":12,"start_character":41,"end_line":12,"end_character":43},"updated":"2019-07-18 20:26:44.000000000","message":"by","commit_id":"4a41e6bbe7b5d3fabc60f69afc397fc65f8e7781"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"c78053366edbfbe7f0b72847e4c5c2e98d2fe931","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Migrations use the libvirt driver\u0027s get_host_ip_addr() method to"},{"line_number":10,"context_line":"determine the dest_host field of the migration object."},{"line_number":11,"context_line":"get_host_ip_addr() checks whether CONF.my_ip is actually assigned to"},{"line_number":12,"context_line":"one of the host\u0027s interfaces. It does so my calling"},{"line_number":13,"context_line":"get_machine_ips(), which interates over all of the host\u0027s interfaces."},{"line_number":14,"context_line":"If the host has many interfaces, this can take a long time, and"},{"line_number":15,"context_line":"introduces needless delays in processing the migration. As"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_7f2a017f","line":12,"range":{"start_line":12,"start_character":41,"end_line":12,"end_character":43},"in_reply_to":"7faddb67_6bc3358a","updated":"2019-07-19 15:44:24.000000000","message":"Done","commit_id":"4a41e6bbe7b5d3fabc60f69afc397fc65f8e7781"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"94af3f6263c7455ea94cf3f2f1a06b3301fc5b13","unresolved":false,"context_lines":[{"line_number":10,"context_line":"determine the dest_host field of the migration object."},{"line_number":11,"context_line":"get_host_ip_addr() checks whether CONF.my_ip is actually assigned to"},{"line_number":12,"context_line":"one of the host\u0027s interfaces. It does so my calling"},{"line_number":13,"context_line":"get_machine_ips(), which interates over all of the host\u0027s interfaces."},{"line_number":14,"context_line":"If the host has many interfaces, this can take a long time, and"},{"line_number":15,"context_line":"introduces needless delays in processing the migration. As"},{"line_number":16,"context_line":"get_machine_ips() is ony used to print a warning, this patch removes"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_2bb9bd13","line":13,"range":{"start_line":13,"start_character":25,"end_line":13,"end_character":34},"updated":"2019-07-18 20:26:44.000000000","message":"iterates","commit_id":"4a41e6bbe7b5d3fabc60f69afc397fc65f8e7781"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"c78053366edbfbe7f0b72847e4c5c2e98d2fe931","unresolved":false,"context_lines":[{"line_number":10,"context_line":"determine the dest_host field of the migration object."},{"line_number":11,"context_line":"get_host_ip_addr() checks whether CONF.my_ip is actually assigned to"},{"line_number":12,"context_line":"one of the host\u0027s interfaces. It does so my calling"},{"line_number":13,"context_line":"get_machine_ips(), which interates over all of the host\u0027s interfaces."},{"line_number":14,"context_line":"If the host has many interfaces, this can take a long time, and"},{"line_number":15,"context_line":"introduces needless delays in processing the migration. As"},{"line_number":16,"context_line":"get_machine_ips() is ony used to print a warning, this patch removes"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_9f2d7d96","line":13,"range":{"start_line":13,"start_character":25,"end_line":13,"end_character":34},"in_reply_to":"7faddb67_2bb9bd13","updated":"2019-07-19 15:44:24.000000000","message":"Done","commit_id":"4a41e6bbe7b5d3fabc60f69afc397fc65f8e7781"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"94af3f6263c7455ea94cf3f2f1a06b3301fc5b13","unresolved":false,"context_lines":[{"line_number":13,"context_line":"get_machine_ips(), which interates over all of the host\u0027s interfaces."},{"line_number":14,"context_line":"If the host has many interfaces, this can take a long time, and"},{"line_number":15,"context_line":"introduces needless delays in processing the migration. As"},{"line_number":16,"context_line":"get_machine_ips() is ony used to print a warning, this patch removes"},{"line_number":17,"context_line":"it and the warning entirely."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"An alternative would have been to cache the result of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_8b3f9185","line":16,"range":{"start_line":16,"start_character":21,"end_line":16,"end_character":24},"updated":"2019-07-18 20:26:44.000000000","message":"only","commit_id":"4a41e6bbe7b5d3fabc60f69afc397fc65f8e7781"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"c78053366edbfbe7f0b72847e4c5c2e98d2fe931","unresolved":false,"context_lines":[{"line_number":13,"context_line":"get_machine_ips(), which interates over all of the host\u0027s interfaces."},{"line_number":14,"context_line":"If the host has many interfaces, this can take a long time, and"},{"line_number":15,"context_line":"introduces needless delays in processing the migration. As"},{"line_number":16,"context_line":"get_machine_ips() is ony used to print a warning, this patch removes"},{"line_number":17,"context_line":"it and the warning entirely."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"An alternative would have been to cache the result of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_3f20099b","line":16,"range":{"start_line":16,"start_character":21,"end_line":16,"end_character":24},"in_reply_to":"7faddb67_8b3f9185","updated":"2019-07-19 15:44:24.000000000","message":"Done","commit_id":"4a41e6bbe7b5d3fabc60f69afc397fc65f8e7781"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e2574d2ee5f6e5b165159f8143cc4cf2a3d58fbe","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"libvirt: move checking CONF.my_ip to init_host()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Migrations use the libvirt driver\u0027s get_host_ip_addr() method to"},{"line_number":10,"context_line":"determine the dest_host field of the migration object."},{"line_number":11,"context_line":"get_host_ip_addr() checks whether CONF.my_ip is actually assigned to"},{"line_number":12,"context_line":"one of the host\u0027s interfaces. It does so by calling"},{"line_number":13,"context_line":"get_machine_ips(), which iterates over all of the host\u0027s interfaces."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7faddb67_5a44d774","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":54},"updated":"2019-07-22 20:48:59.000000000","message":"Yar, in the case of evacuate:\n\nhttps://github.com/openstack/nova/blob/d5c67a3d954ddb571645886a23a0f251ae7dd2bb/nova/compute/resource_tracker.py#L368\n\nand in the case of resize/cold migrate:\n\nhttps://github.com/openstack/nova/blob/d5c67a3d954ddb571645886a23a0f251ae7dd2bb/nova/compute/resource_tracker.py#L393\n\nThe latter is an update because the Migration is created in conductor:\n\nhttps://github.com/openstack/nova/blob/d5c67a3d954ddb571645886a23a0f251ae7dd2bb/nova/conductor/tasks/migrate.py#L144\n\nNote that Migration.dest_host is basically vestigial at this point because it\u0027s only used by nova-network. Anyway, that doesn\u0027t really matter for the thing you\u0027re trying to resolve here.\n\nI guess it\u0027s also used here:\n\nhttps://github.com/openstack/nova/blob/d5c67a3d954ddb571645886a23a0f251ae7dd2bb/nova/virt/libvirt/driver.py#L8909\n\nwhich is called during resize/cold migrate:\n\nhttps://github.com/openstack/nova/blob/d5c67a3d954ddb571645886a23a0f251ae7dd2bb/nova/virt/libvirt/driver.py#L8963","commit_id":"30d8159d4ee51a26a03de1cb134ea64c6c07ffb2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e2574d2ee5f6e5b165159f8143cc4cf2a3d58fbe","unresolved":false,"context_lines":[{"line_number":18,"context_line":"way, a warning is still emitted at compute service startup, and"},{"line_number":19,"context_line":"migration progress is not needlessly slowed down."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"This patch also has a chicken and egg problem with the patch on top of"},{"line_number":22,"context_line":"it, which poisons use of netifaces.interfaces() in tests. While this"},{"line_number":23,"context_line":"patch fixes all the tests that break with that poison, it starts"},{"line_number":24,"context_line":"breaking different tests because of the move of get_machine_ips() into"},{"line_number":25,"context_line":"init_host(). Therefore, while not directly related to the bug, this"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7faddb67_bd02a508","line":22,"range":{"start_line":21,"start_character":46,"end_line":22,"end_character":2},"updated":"2019-07-22 20:48:59.000000000","message":"Too late now, but it would have been better to refer to the change ID here because I see you\u0027re backporting this change and the poison fixture is probably not going to be so it could be confusing later (in general I dislike people talking about relative changes in a gerrit series which later won\u0027t make sense when reading the git log).","commit_id":"30d8159d4ee51a26a03de1cb134ea64c6c07ffb2"}],"nova/compute/utils.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6afa2938dfd79597966fe31e8ba008e547db011f","unresolved":false,"context_lines":[{"line_number":971,"context_line":""},{"line_number":972,"context_line":"    :returns: list of Strings of ip addresses"},{"line_number":973,"context_line":"    \"\"\""},{"line_number":974,"context_line":"    addresses \u003d []"},{"line_number":975,"context_line":"    for interface in netifaces.interfaces():"},{"line_number":976,"context_line":"        try:"},{"line_number":977,"context_line":"            iface_data \u003d netifaces.ifaddresses(interface)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_e2850d08","side":"PARENT","line":974,"range":{"start_line":974,"start_character":4,"end_line":974,"end_character":14},"updated":"2019-07-18 12:32:04.000000000","message":"the alternative we discussed was to just cache adresses as a module global.\n\nthis function really is not adding much benifit so i think killing it is fine.","commit_id":"b7c98befdab1a88932f41f9c463358f91701ce4a"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"0dbd55feeec3601abe3e17aec61995e02d1d03b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7faddb67_3f5569fa","updated":"2019-07-19 15:47:39.000000000","message":"Being persnickety here, we should really have a unit test that asserts _check_my_ip (or its content) is called during init_host","commit_id":"b7a52bbc56d535b5f3b7df6169071408355ab6bf"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6afa2938dfd79597966fe31e8ba008e547db011f","unresolved":false,"context_lines":[{"line_number":3331,"context_line":"    def get_host_ip_addr(self):"},{"line_number":3332,"context_line":"        ips \u003d compute_utils.get_machine_ips()"},{"line_number":3333,"context_line":"        if CONF.my_ip not in ips:"},{"line_number":3334,"context_line":"            LOG.warning(\u0027my_ip address (%(my_ip)s) was not found on \u0027"},{"line_number":3335,"context_line":"                        \u0027any of the interfaces: %(ifaces)s\u0027,"},{"line_number":3336,"context_line":"                        {\u0027my_ip\u0027: CONF.my_ip, \u0027ifaces\u0027: \", \".join(ips)})"},{"line_number":3337,"context_line":"        return CONF.my_ip"},{"line_number":3338,"context_line":""},{"line_number":3339,"context_line":"    def get_vnc_console(self, context, instance):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_a292b555","side":"PARENT","line":3336,"range":{"start_line":3334,"start_character":12,"end_line":3336,"end_character":72},"updated":"2019-07-18 12:32:04.000000000","message":"given that we just logged and ignored it this really was not preventing any possible failrues.\n\nif our ip disapeard form the host it would break migration and other thing anyway so i think this is fine to remove.","commit_id":"b7c98befdab1a88932f41f9c463358f91701ce4a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2e0a84a3c44b8e6220806b9a1d8962b54b948688","unresolved":false,"context_lines":[{"line_number":3328,"context_line":"        # return logfile content"},{"line_number":3329,"context_line":"        return self._get_console_output_file(instance, console_path)"},{"line_number":3330,"context_line":""},{"line_number":3331,"context_line":"    def get_host_ip_addr(self):"},{"line_number":3332,"context_line":"        return CONF.my_ip"},{"line_number":3333,"context_line":""},{"line_number":3334,"context_line":"    def get_vnc_console(self, context, instance):"},{"line_number":3335,"context_line":"        def get_vnc_port_for_instance(instance_name):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_8ba31100","line":3332,"range":{"start_line":3331,"start_character":0,"end_line":3332,"end_character":25},"updated":"2019-07-18 16:05:36.000000000","message":"A future change could just remove this, assuming it\u0027s not provided by the base driver class","commit_id":"4a41e6bbe7b5d3fabc60f69afc397fc65f8e7781"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ad7cbe076831f314477f8931e0d9ae493d39ea46","unresolved":false,"context_lines":[{"line_number":3328,"context_line":"        # return logfile content"},{"line_number":3329,"context_line":"        return self._get_console_output_file(instance, console_path)"},{"line_number":3330,"context_line":""},{"line_number":3331,"context_line":"    def get_host_ip_addr(self):"},{"line_number":3332,"context_line":"        return CONF.my_ip"},{"line_number":3333,"context_line":""},{"line_number":3334,"context_line":"    def get_vnc_console(self, context, instance):"},{"line_number":3335,"context_line":"        def get_vnc_port_for_instance(instance_name):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_ab428d0d","line":3332,"range":{"start_line":3331,"start_character":0,"end_line":3332,"end_character":25},"in_reply_to":"7faddb67_8ba31100","updated":"2019-07-18 16:12:34.000000000","message":"this is one of the public apis that you are required to implement for the driver\n\nhttps://github.com/openstack/nova/blob/a5e3054e1d6df248fc4c00b9abd7289dde160393/nova/virt/driver.py#L516-L520\n\nso unless the conf would be valid for multiple virt driver i think this is the minimal implementaion we can use.","commit_id":"4a41e6bbe7b5d3fabc60f69afc397fc65f8e7781"}]}