)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"494bacb0ff80692b50449f44720b1b399ee868c1","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This depends on I13c5638f320b18c4f6f945528352471d2bb31313 so that the"},{"line_number":13,"context_line":"offending v1.1.0 version of noVNC is deployed by devstack when"},{"line_number":14,"context_line":"NOVNC_FROM_PACKAGE\u003dFalse."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Depends-On: https://review.opendev.org/#/c/669647/"},{"line_number":17,"context_line":"Change-Id: I04b306e975430cfe1d3d758827b27f650bacbce3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_4880bff5","line":14,"updated":"2019-07-18 15:30:33.000000000","message":"FWIW, you can just set NOVNC_BRANCH\u003dv1.1.0 alongside NOVNC_FROM_PACKAGE\u003dFalse instead of needing a change to devstack. Probably worth bumping it in devstack though.\n\nFor whatever reason, I was surprised that NOVNC_FROM_PACKAGE\u003dFalse doesn\u0027t use the master branch. I guess I\u0027m not sure how this will help catch issues if we\u0027ll always install v1.1.0 and never anything newer [when it appears]. At the same time, it might be too risky to install from master. Hmm.","commit_id":"243ed9854830ff178a22f4b691b81d53a498b8a7"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"2f40458a2f1c603d44b371b4e4bce2be7f9c4f59","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This depends on I13c5638f320b18c4f6f945528352471d2bb31313 so that the"},{"line_number":13,"context_line":"offending v1.1.0 version of noVNC is deployed by devstack when"},{"line_number":14,"context_line":"NOVNC_FROM_PACKAGE\u003dFalse."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Depends-On: https://review.opendev.org/#/c/669647/"},{"line_number":17,"context_line":"Change-Id: I04b306e975430cfe1d3d758827b27f650bacbce3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_0bbe41fe","line":14,"in_reply_to":"7faddb67_4880bff5","updated":"2019-07-18 16:11:22.000000000","message":"\u003e FWIW, you can just set NOVNC_BRANCH\u003dv1.1.0 alongside\n \u003e NOVNC_FROM_PACKAGE\u003dFalse instead of needing a change to devstack.\n \u003e Probably worth bumping it in devstack though.\n\nTure however we will need to bump this with each release of noVNC. So to me devstack just seemed like a better place to set the version instead of within a project specific zuul config.\n\n \u003e For whatever reason, I was surprised that NOVNC_FROM_PACKAGE\u003dFalse\n \u003e doesn\u0027t use the master branch. I guess I\u0027m not sure how this will\n \u003e help catch issues if we\u0027ll always install v1.1.0 and never anything\n \u003e newer [when it appears]. At the same time, it might be too risky to\n \u003e install from master. Hmm.\n\nYeah I think master is too risky and just bumping with each actual release is good enough for this job. FWIW v1.1.0 is still miles ahead of *most* packaged versions so there\u0027s still value in doing this for now.","commit_id":"243ed9854830ff178a22f4b691b81d53a498b8a7"}],"playbooks/legacy/nova-next/run.yaml":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"1f20860adeb107fe7866d161308be8ebabc1ea50","unresolved":false,"context_lines":[{"line_number":41,"context_line":"          NOVA_CONSOLE_PROXY_COMPUTE_TLS\u003dTrue"},{"line_number":42,"context_line":"          USE_PYTHON3\u003dTrue"},{"line_number":43,"context_line":"          ENABLE_VOLUME_MULTIATTACH\u003dTrue"},{"line_number":44,"context_line":"          NOVNC_FROM_PACKAGE\u003dFalse"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"          [[post-config|$NOVA_CONF]]"},{"line_number":47,"context_line":"          [compute]"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_cbc029e4","line":44,"updated":"2019-07-18 16:40:50.000000000","message":"Based on the error message, \"The /opt/stack/new/noVNC project was not found; if this is a gate job, add the project to the $PROJECTS variable in the job definition.\"\n\nI guess we could try adding PROJECTS\u003dnovnc/noVNC similar to what\u0027s shown here:\n\nhttps://opendev.org/openstack/devstack/src/commit/80725951501b4127f765291aa59e9aa4bfab20fc/doc/source/plugins.rst#legacy-project-config-jobs\n\nbut not sure if it will work.","commit_id":"243ed9854830ff178a22f4b691b81d53a498b8a7"}]}