)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"033dc528ec8eee90bd286eca4f06abda65505e34","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add \u0027[compute] cpu_dedicated_set\u0027 option"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add the option and the wall of text required to explain the potential"},{"line_number":10,"context_line":"upgrade implications of this, none of which actually applies yet since"},{"line_number":11,"context_line":"we haven\u0027t added the code to do the things (sooooon). This also means no"},{"line_number":12,"context_line":"release note is added here."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The \u0027vcpu_pin_set\u0027 option is also deprecated, while the help text for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"7faddb67_c531e2ee","line":11,"range":{"start_line":10,"start_character":30,"end_line":11,"end_character":52},"updated":"2019-08-21 21:30:28.000000000","message":"no","commit_id":"e7749776117b53bfbac199c6b4091e0347db2a08"}],"nova/conf/compute.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"396d43ee1c4cd2afdd0cbf9026e23e2f92f5c86e","unresolved":false,"context_lines":[{"line_number":396,"context_line":"Possible values:"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"* Any positive integer representing number of physical CPUs to reserve"},{"line_number":399,"context_line":"  for the host."},{"line_number":400,"context_line":"\"\"\"),"},{"line_number":401,"context_line":"]"},{"line_number":402,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_4d995b1d","line":399,"updated":"2019-07-24 16:17:58.000000000","message":"Probably need a note here saying that this is ignored if both \u0027cpu_shared_set\u0027 and \u0027cpu_dedicated_set\u0027 and configured, or ignored in general with the libvirt driver?","commit_id":"f9aa6e3c3949801110c98c2a9c2d8b1d68b0beb2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"22b52bb853fa7008817952bb54ee47da836a689c","unresolved":false,"context_lines":[{"line_number":392,"context_line":"reported back to the scheduler continuously from nova-compute running on the"},{"line_number":393,"context_line":"compute node. To prevent the host CPU from being considered as available,"},{"line_number":394,"context_line":"this option is used to reserve random pCPU(s) for the host."},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"Possible values:"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"* Any positive integer representing number of physical CPUs to reserve"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_fcecfff4","line":395,"updated":"2019-08-01 18:19:18.000000000","message":"Still need a note here stating that this isn\u0027t used if cpu_shared_set and/or cpu_dedicated_set are defined","commit_id":"f3c41953e0af65aac0ab131d088376a41dc161df"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"ce4a3d79fc7e81f74dff21e4017d2754cdb7a1c3","unresolved":false,"context_lines":[{"line_number":395,"context_line":"considered as available, this option is used to reserve random host CPUs for"},{"line_number":396,"context_line":"the host."},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"This option is ignored if using the libvirt virt driver. Use the ``[compute]"},{"line_number":399,"context_line":"cpu_shared_set`` and/or ``[compute] cpu_dedicated_set`` config options instead."},{"line_number":400,"context_line":"Any host CPUs not included in these values are considered reserved for the"},{"line_number":401,"context_line":"host."},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"Possible values:"},{"line_number":404,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_35619e3a","line":401,"range":{"start_line":398,"start_character":0,"end_line":401,"end_character":5},"updated":"2019-08-13 08:05:11.000000000","message":"should we deprecate this option also? according to this comment, cpu_dedicated_set and cpu_shared_set will replace this option","commit_id":"d250599c522dec90cf361eb0a4ad651e77f8e125"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"51975005f3c3aeef3c651e8b759be074f846e07a","unresolved":false,"context_lines":[{"line_number":395,"context_line":"considered as available, this option is used to reserve random host CPUs for"},{"line_number":396,"context_line":"the host."},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"This option is ignored if using the libvirt virt driver. Use the ``[compute]"},{"line_number":399,"context_line":"cpu_shared_set`` and/or ``[compute] cpu_dedicated_set`` config options instead."},{"line_number":400,"context_line":"Any host CPUs not included in these values are considered reserved for the"},{"line_number":401,"context_line":"host."},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"Possible values:"},{"line_number":404,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_389af5c4","line":401,"range":{"start_line":398,"start_character":0,"end_line":401,"end_character":5},"in_reply_to":"7faddb67_35619e3a","updated":"2019-08-13 08:32:45.000000000","message":"oh..other virt driver is still using this?","commit_id":"d250599c522dec90cf361eb0a4ad651e77f8e125"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8eb37feab16006a1f5a5dbf3650224a5fec1d93b","unresolved":false,"context_lines":[{"line_number":395,"context_line":"considered as available, this option is used to reserve random host CPUs for"},{"line_number":396,"context_line":"the host."},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"This option is ignored if using the libvirt virt driver. Use the ``[compute]"},{"line_number":399,"context_line":"cpu_shared_set`` and/or ``[compute] cpu_dedicated_set`` config options instead."},{"line_number":400,"context_line":"Any host CPUs not included in these values are considered reserved for the"},{"line_number":401,"context_line":"host."},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"Possible values:"},{"line_number":404,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_18161957","line":401,"range":{"start_line":398,"start_character":0,"end_line":401,"end_character":5},"in_reply_to":"7faddb67_389af5c4","updated":"2019-08-13 09:18:44.000000000","message":"Yeah, it\u0027s deprecated for nova but not all drivers, since many of them don\u0027t let you specify a list of host CPUs to use at all, let alone which ones should be used for pinning","commit_id":"d250599c522dec90cf361eb0a4ad651e77f8e125"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"35180f578df2280dbc0ca2f34d07fd33950ea7df","unresolved":false,"context_lines":[{"line_number":321,"context_line":"The behavior of this option depends on the definition of the ``[compute]"},{"line_number":322,"context_line":"cpu_dedicated_set`` and ``[compute] cpu_shared_set`` options."},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"* If both ``[compute] cpu_dedicated_set`` is defined, this option will always"},{"line_number":325,"context_line":"  be ignored."},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"* If ``[compute] cpu_dedicated_set`` is not defined, this option will be used"}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_71680620","line":324,"range":{"start_line":324,"start_character":2,"end_line":324,"end_character":41},"updated":"2019-08-21 07:02:40.000000000","message":"Since you have started the sentence with, If both ... you should add ``and [compute] cpu_shared_set`` as well.","commit_id":"e7749776117b53bfbac199c6b4091e0347db2a08"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"186659000cf8330ea69d6dc3246d93a1af77758c","unresolved":false,"context_lines":[{"line_number":321,"context_line":"The behavior of this option depends on the definition of the ``[compute]"},{"line_number":322,"context_line":"cpu_dedicated_set`` and ``[compute] cpu_shared_set`` options."},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"* If both ``[compute] cpu_dedicated_set`` is defined, this option will always"},{"line_number":325,"context_line":"  be ignored."},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"* If ``[compute] cpu_dedicated_set`` is not defined, this option will be used"}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_de32f40f","line":324,"range":{"start_line":324,"start_character":2,"end_line":324,"end_character":41},"in_reply_to":"7faddb67_71680620","updated":"2019-08-23 11:05:46.000000000","message":"\"both\" should have been removed. Done now","commit_id":"e7749776117b53bfbac199c6b4091e0347db2a08"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"033dc528ec8eee90bd286eca4f06abda65505e34","unresolved":false,"context_lines":[{"line_number":326,"context_line":""},{"line_number":327,"context_line":"* If ``[compute] cpu_dedicated_set`` is not defined, this option will be used"},{"line_number":328,"context_line":"  to determine where to allocate both ``VCPU`` and ``PCPU`` resources from."},{"line_number":329,"context_line":"  This will result in a host CPU being reported twice, a both a ``VCPU``"},{"line_number":330,"context_line":"  resource and a ``PCPU`` resource, and will require host aggregates to ensures"},{"line_number":331,"context_line":"  all instances on a given host request a single type of CPU resource."},{"line_number":332,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_4a6981f5","line":329,"range":{"start_line":329,"start_character":55,"end_line":329,"end_character":56},"updated":"2019-08-21 21:30:28.000000000","message":"as","commit_id":"e7749776117b53bfbac199c6b4091e0347db2a08"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"186659000cf8330ea69d6dc3246d93a1af77758c","unresolved":false,"context_lines":[{"line_number":326,"context_line":""},{"line_number":327,"context_line":"* If ``[compute] cpu_dedicated_set`` is not defined, this option will be used"},{"line_number":328,"context_line":"  to determine where to allocate both ``VCPU`` and ``PCPU`` resources from."},{"line_number":329,"context_line":"  This will result in a host CPU being reported twice, a both a ``VCPU``"},{"line_number":330,"context_line":"  resource and a ``PCPU`` resource, and will require host aggregates to ensures"},{"line_number":331,"context_line":"  all instances on a given host request a single type of CPU resource."},{"line_number":332,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_be48588a","line":329,"range":{"start_line":329,"start_character":55,"end_line":329,"end_character":56},"in_reply_to":"7faddb67_4a6981f5","updated":"2019-08-23 11:05:46.000000000","message":"Done","commit_id":"e7749776117b53bfbac199c6b4091e0347db2a08"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"033dc528ec8eee90bd286eca4f06abda65505e34","unresolved":false,"context_lines":[{"line_number":327,"context_line":"* If ``[compute] cpu_dedicated_set`` is not defined, this option will be used"},{"line_number":328,"context_line":"  to determine where to allocate both ``VCPU`` and ``PCPU`` resources from."},{"line_number":329,"context_line":"  This will result in a host CPU being reported twice, a both a ``VCPU``"},{"line_number":330,"context_line":"  resource and a ``PCPU`` resource, and will require host aggregates to ensures"},{"line_number":331,"context_line":"  all instances on a given host request a single type of CPU resource."},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_0a7709d6","line":330,"range":{"start_line":330,"start_character":72,"end_line":330,"end_character":79},"updated":"2019-08-21 21:30:28.000000000","message":"ensure","commit_id":"e7749776117b53bfbac199c6b4091e0347db2a08"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"186659000cf8330ea69d6dc3246d93a1af77758c","unresolved":false,"context_lines":[{"line_number":327,"context_line":"* If ``[compute] cpu_dedicated_set`` is not defined, this option will be used"},{"line_number":328,"context_line":"  to determine where to allocate both ``VCPU`` and ``PCPU`` resources from."},{"line_number":329,"context_line":"  This will result in a host CPU being reported twice, a both a ``VCPU``"},{"line_number":330,"context_line":"  resource and a ``PCPU`` resource, and will require host aggregates to ensures"},{"line_number":331,"context_line":"  all instances on a given host request a single type of CPU resource."},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_de4d149a","line":330,"range":{"start_line":330,"start_character":72,"end_line":330,"end_character":79},"in_reply_to":"7faddb67_0a7709d6","updated":"2019-08-23 11:05:46.000000000","message":"Done","commit_id":"e7749776117b53bfbac199c6b4091e0347db2a08"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"033dc528ec8eee90bd286eca4f06abda65505e34","unresolved":false,"context_lines":[{"line_number":395,"context_line":"considered as available, this option is used to reserve random host CPUs for"},{"line_number":396,"context_line":"the host."},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"This option is ignored if using the libvirt virt driver. Use the ``[compute]"},{"line_number":399,"context_line":"cpu_shared_set`` and/or ``[compute] cpu_dedicated_set`` config options instead."},{"line_number":400,"context_line":"Any host CPUs not included in these values are considered reserved for the"},{"line_number":401,"context_line":"host."},{"line_number":402,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_6a3a3de6","line":399,"range":{"start_line":398,"start_character":65,"end_line":399,"end_character":55},"updated":"2019-08-21 21:30:28.000000000","message":"are these now worthy of being `Related Options`?","commit_id":"e7749776117b53bfbac199c6b4091e0347db2a08"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"186659000cf8330ea69d6dc3246d93a1af77758c","unresolved":false,"context_lines":[{"line_number":395,"context_line":"considered as available, this option is used to reserve random host CPUs for"},{"line_number":396,"context_line":"the host."},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"This option is ignored if using the libvirt virt driver. Use the ``[compute]"},{"line_number":399,"context_line":"cpu_shared_set`` and/or ``[compute] cpu_dedicated_set`` config options instead."},{"line_number":400,"context_line":"Any host CPUs not included in these values are considered reserved for the"},{"line_number":401,"context_line":"host."},{"line_number":402,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_de1bd47d","line":399,"range":{"start_line":398,"start_character":65,"end_line":399,"end_character":55},"in_reply_to":"7faddb67_6a3a3de6","updated":"2019-08-23 11:05:46.000000000","message":"Done","commit_id":"e7749776117b53bfbac199c6b4091e0347db2a08"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"033dc528ec8eee90bd286eca4f06abda65505e34","unresolved":false,"context_lines":[{"line_number":767,"context_line":"\"\"\"),"},{"line_number":768,"context_line":"   cfg.StrOpt(\u0027cpu_shared_set\u0027,"},{"line_number":769,"context_line":"        help\u003d\"\"\""},{"line_number":770,"context_line":"Defines which host CPUs will be used for allocating ``VCPU`` resources and to"},{"line_number":771,"context_line":"host emulator threads when using the ``share`` emulator thread policy"},{"line_number":772,"context_line":"(``hw:emulator_threads_policy\u003dshare``)."},{"line_number":773,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_2a7205e4","line":770,"range":{"start_line":770,"start_character":71,"end_line":770,"end_character":77},"updated":"2019-08-21 21:30:28.000000000","message":"missing word? or `and` extraneous?","commit_id":"e7749776117b53bfbac199c6b4091e0347db2a08"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"186659000cf8330ea69d6dc3246d93a1af77758c","unresolved":false,"context_lines":[{"line_number":767,"context_line":"\"\"\"),"},{"line_number":768,"context_line":"   cfg.StrOpt(\u0027cpu_shared_set\u0027,"},{"line_number":769,"context_line":"        help\u003d\"\"\""},{"line_number":770,"context_line":"Defines which host CPUs will be used for allocating ``VCPU`` resources and to"},{"line_number":771,"context_line":"host emulator threads when using the ``share`` emulator thread policy"},{"line_number":772,"context_line":"(``hw:emulator_threads_policy\u003dshare``)."},{"line_number":773,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_3e0a2827","line":770,"range":{"start_line":770,"start_character":71,"end_line":770,"end_character":77},"in_reply_to":"7faddb67_2a7205e4","updated":"2019-08-23 11:05:46.000000000","message":"host in this case meant hold (i.e. host a party). I\u0027ll reword since that\u0027s probably not the best choice of word, heh","commit_id":"e7749776117b53bfbac199c6b4091e0347db2a08"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"033dc528ec8eee90bd286eca4f06abda65505e34","unresolved":false,"context_lines":[{"line_number":781,"context_line":"  cpu_dedicated_set`` is not, ``[compute] cpu_shared_set`` will only be used to"},{"line_number":782,"context_line":"  place guest emulator threads and ``vcpu_pin_set`` will be used instead to"},{"line_number":783,"context_line":"  determine where to allocate both ``VCPU`` and ``PCPU`` resources from. This"},{"line_number":784,"context_line":"  will result in a host CPU being reported twice, a both a ``VCPU`` resource"},{"line_number":785,"context_line":"  and a ``PCPU`` resource, and will require host aggregates to ensures all"},{"line_number":786,"context_line":"  instances on a given host request a single type of CPU resource."},{"line_number":787,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_2a5be553","line":784,"range":{"start_line":784,"start_character":50,"end_line":784,"end_character":51},"updated":"2019-08-21 21:30:28.000000000","message":"as","commit_id":"e7749776117b53bfbac199c6b4091e0347db2a08"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"186659000cf8330ea69d6dc3246d93a1af77758c","unresolved":false,"context_lines":[{"line_number":781,"context_line":"  cpu_dedicated_set`` is not, ``[compute] cpu_shared_set`` will only be used to"},{"line_number":782,"context_line":"  place guest emulator threads and ``vcpu_pin_set`` will be used instead to"},{"line_number":783,"context_line":"  determine where to allocate both ``VCPU`` and ``PCPU`` resources from. This"},{"line_number":784,"context_line":"  will result in a host CPU being reported twice, a both a ``VCPU`` resource"},{"line_number":785,"context_line":"  and a ``PCPU`` resource, and will require host aggregates to ensures all"},{"line_number":786,"context_line":"  instances on a given host request a single type of CPU resource."},{"line_number":787,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_fe03300f","line":784,"range":{"start_line":784,"start_character":50,"end_line":784,"end_character":51},"in_reply_to":"7faddb67_2a5be553","updated":"2019-08-23 11:05:46.000000000","message":"Done","commit_id":"e7749776117b53bfbac199c6b4091e0347db2a08"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"033dc528ec8eee90bd286eca4f06abda65505e34","unresolved":false,"context_lines":[{"line_number":782,"context_line":"  place guest emulator threads and ``vcpu_pin_set`` will be used instead to"},{"line_number":783,"context_line":"  determine where to allocate both ``VCPU`` and ``PCPU`` resources from. This"},{"line_number":784,"context_line":"  will result in a host CPU being reported twice, a both a ``VCPU`` resource"},{"line_number":785,"context_line":"  and a ``PCPU`` resource, and will require host aggregates to ensures all"},{"line_number":786,"context_line":"  instances on a given host request a single type of CPU resource."},{"line_number":787,"context_line":""},{"line_number":788,"context_line":"* If ``[compute] cpu_dedicated_set`` is defined but ``[compute]"}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_ca55711f","line":785,"range":{"start_line":785,"start_character":63,"end_line":785,"end_character":70},"updated":"2019-08-21 21:30:28.000000000","message":"ensure","commit_id":"e7749776117b53bfbac199c6b4091e0347db2a08"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"186659000cf8330ea69d6dc3246d93a1af77758c","unresolved":false,"context_lines":[{"line_number":782,"context_line":"  place guest emulator threads and ``vcpu_pin_set`` will be used instead to"},{"line_number":783,"context_line":"  determine where to allocate both ``VCPU`` and ``PCPU`` resources from. This"},{"line_number":784,"context_line":"  will result in a host CPU being reported twice, a both a ``VCPU`` resource"},{"line_number":785,"context_line":"  and a ``PCPU`` resource, and will require host aggregates to ensures all"},{"line_number":786,"context_line":"  instances on a given host request a single type of CPU resource."},{"line_number":787,"context_line":""},{"line_number":788,"context_line":"* If ``[compute] cpu_dedicated_set`` is defined but ``[compute]"}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_1e016c07","line":785,"range":{"start_line":785,"start_character":63,"end_line":785,"end_character":70},"in_reply_to":"7faddb67_ca55711f","updated":"2019-08-23 11:05:46.000000000","message":"Done","commit_id":"e7749776117b53bfbac199c6b4091e0347db2a08"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"033dc528ec8eee90bd286eca4f06abda65505e34","unresolved":false,"context_lines":[{"line_number":795,"context_line":"Possible values:"},{"line_number":796,"context_line":""},{"line_number":797,"context_line":"* A comma-separated list of physical CPU numbers that instance VCPUs can be"},{"line_number":798,"context_line":"  allocated to by default. Each element should be either a single CPU number,"},{"line_number":799,"context_line":"  a range of CPU numbers, or a caret followed by a CPU number to be"},{"line_number":800,"context_line":"  excluded from a previous range. For example::"},{"line_number":801,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_8528ca85","line":798,"range":{"start_line":798,"start_character":12,"end_line":798,"end_character":14},"updated":"2019-08-21 21:30:28.000000000","message":"from?","commit_id":"e7749776117b53bfbac199c6b4091e0347db2a08"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"033dc528ec8eee90bd286eca4f06abda65505e34","unresolved":false,"context_lines":[{"line_number":795,"context_line":"Possible values:"},{"line_number":796,"context_line":""},{"line_number":797,"context_line":"* A comma-separated list of physical CPU numbers that instance VCPUs can be"},{"line_number":798,"context_line":"  allocated to by default. Each element should be either a single CPU number,"},{"line_number":799,"context_line":"  a range of CPU numbers, or a caret followed by a CPU number to be"},{"line_number":800,"context_line":"  excluded from a previous range. For example::"},{"line_number":801,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_65082e26","line":798,"range":{"start_line":798,"start_character":15,"end_line":798,"end_character":25},"updated":"2019-08-21 21:30:28.000000000","message":"what does `by default` imply here?","commit_id":"e7749776117b53bfbac199c6b4091e0347db2a08"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"186659000cf8330ea69d6dc3246d93a1af77758c","unresolved":false,"context_lines":[{"line_number":795,"context_line":"Possible values:"},{"line_number":796,"context_line":""},{"line_number":797,"context_line":"* A comma-separated list of physical CPU numbers that instance VCPUs can be"},{"line_number":798,"context_line":"  allocated to by default. Each element should be either a single CPU number,"},{"line_number":799,"context_line":"  a range of CPU numbers, or a caret followed by a CPU number to be"},{"line_number":800,"context_line":"  excluded from a previous range. For example::"},{"line_number":801,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_b1fba913","line":798,"range":{"start_line":798,"start_character":15,"end_line":798,"end_character":25},"in_reply_to":"7faddb67_65082e26","updated":"2019-08-23 11:05:46.000000000","message":"\u003e what does `by default` imply here?\n\nNothing. Dropped (it was copy-pasted from vcpu_pin_set)","commit_id":"e7749776117b53bfbac199c6b4091e0347db2a08"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"033dc528ec8eee90bd286eca4f06abda65505e34","unresolved":false,"context_lines":[{"line_number":826,"context_line":"  cpu_dedicated_set`` is not, ``[compute] cpu_shared_set`` will only be used to"},{"line_number":827,"context_line":"  place guest emulator threads and ``vcpu_pin_set`` will be used instead to"},{"line_number":828,"context_line":"  determine where to allocate both ``VCPU`` and ``PCPU`` resources from. This"},{"line_number":829,"context_line":"  will result in a host CPU being reported twice, a both a ``VCPU`` resource"},{"line_number":830,"context_line":"  and a ``PCPU`` resource, and will require host aggregates to ensures all"},{"line_number":831,"context_line":"  instances on a given host request a single type of CPU resource."},{"line_number":832,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_0a0e293a","line":829,"range":{"start_line":829,"start_character":50,"end_line":829,"end_character":51},"updated":"2019-08-21 21:30:28.000000000","message":"as","commit_id":"e7749776117b53bfbac199c6b4091e0347db2a08"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"186659000cf8330ea69d6dc3246d93a1af77758c","unresolved":false,"context_lines":[{"line_number":826,"context_line":"  cpu_dedicated_set`` is not, ``[compute] cpu_shared_set`` will only be used to"},{"line_number":827,"context_line":"  place guest emulator threads and ``vcpu_pin_set`` will be used instead to"},{"line_number":828,"context_line":"  determine where to allocate both ``VCPU`` and ``PCPU`` resources from. This"},{"line_number":829,"context_line":"  will result in a host CPU being reported twice, a both a ``VCPU`` resource"},{"line_number":830,"context_line":"  and a ``PCPU`` resource, and will require host aggregates to ensures all"},{"line_number":831,"context_line":"  instances on a given host request a single type of CPU resource."},{"line_number":832,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_71053110","line":829,"range":{"start_line":829,"start_character":50,"end_line":829,"end_character":51},"in_reply_to":"7faddb67_0a0e293a","updated":"2019-08-23 11:05:46.000000000","message":"Done","commit_id":"e7749776117b53bfbac199c6b4091e0347db2a08"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"033dc528ec8eee90bd286eca4f06abda65505e34","unresolved":false,"context_lines":[{"line_number":827,"context_line":"  place guest emulator threads and ``vcpu_pin_set`` will be used instead to"},{"line_number":828,"context_line":"  determine where to allocate both ``VCPU`` and ``PCPU`` resources from. This"},{"line_number":829,"context_line":"  will result in a host CPU being reported twice, a both a ``VCPU`` resource"},{"line_number":830,"context_line":"  and a ``PCPU`` resource, and will require host aggregates to ensures all"},{"line_number":831,"context_line":"  instances on a given host request a single type of CPU resource."},{"line_number":832,"context_line":""},{"line_number":833,"context_line":"This behavior will be simplified in a future release when ``vcpu_pin_set`` is"}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_2a09a52f","line":830,"range":{"start_line":830,"start_character":63,"end_line":830,"end_character":70},"updated":"2019-08-21 21:30:28.000000000","message":"ensure","commit_id":"e7749776117b53bfbac199c6b4091e0347db2a08"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"186659000cf8330ea69d6dc3246d93a1af77758c","unresolved":false,"context_lines":[{"line_number":827,"context_line":"  place guest emulator threads and ``vcpu_pin_set`` will be used instead to"},{"line_number":828,"context_line":"  determine where to allocate both ``VCPU`` and ``PCPU`` resources from. This"},{"line_number":829,"context_line":"  will result in a host CPU being reported twice, a both a ``VCPU`` resource"},{"line_number":830,"context_line":"  and a ``PCPU`` resource, and will require host aggregates to ensures all"},{"line_number":831,"context_line":"  instances on a given host request a single type of CPU resource."},{"line_number":832,"context_line":""},{"line_number":833,"context_line":"This behavior will be simplified in a future release when ``vcpu_pin_set`` is"}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_910a2d1e","line":830,"range":{"start_line":830,"start_character":63,"end_line":830,"end_character":70},"in_reply_to":"7faddb67_2a09a52f","updated":"2019-08-23 11:05:46.000000000","message":"Done","commit_id":"e7749776117b53bfbac199c6b4091e0347db2a08"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"033dc528ec8eee90bd286eca4f06abda65505e34","unresolved":false,"context_lines":[{"line_number":836,"context_line":"Possible values:"},{"line_number":837,"context_line":""},{"line_number":838,"context_line":"* A comma-separated list of physical CPU numbers that instance VCPUs can be"},{"line_number":839,"context_line":"  allocated to by default. Each element should be either a single CPU number,"},{"line_number":840,"context_line":"  a range of CPU numbers, or a caret followed by a CPU number to be"},{"line_number":841,"context_line":"  excluded from a previous range. For example::"},{"line_number":842,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_250eb631","line":839,"range":{"start_line":839,"start_character":15,"end_line":839,"end_character":25},"updated":"2019-08-21 21:30:28.000000000","message":"ditto above","commit_id":"e7749776117b53bfbac199c6b4091e0347db2a08"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"033dc528ec8eee90bd286eca4f06abda65505e34","unresolved":false,"context_lines":[{"line_number":836,"context_line":"Possible values:"},{"line_number":837,"context_line":""},{"line_number":838,"context_line":"* A comma-separated list of physical CPU numbers that instance VCPUs can be"},{"line_number":839,"context_line":"  allocated to by default. Each element should be either a single CPU number,"},{"line_number":840,"context_line":"  a range of CPU numbers, or a caret followed by a CPU number to be"},{"line_number":841,"context_line":"  excluded from a previous range. For example::"},{"line_number":842,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_c5180277","line":839,"range":{"start_line":839,"start_character":12,"end_line":839,"end_character":14},"updated":"2019-08-21 21:30:28.000000000","message":"from?","commit_id":"e7749776117b53bfbac199c6b4091e0347db2a08"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"186659000cf8330ea69d6dc3246d93a1af77758c","unresolved":false,"context_lines":[{"line_number":836,"context_line":"Possible values:"},{"line_number":837,"context_line":""},{"line_number":838,"context_line":"* A comma-separated list of physical CPU numbers that instance VCPUs can be"},{"line_number":839,"context_line":"  allocated to by default. Each element should be either a single CPU number,"},{"line_number":840,"context_line":"  a range of CPU numbers, or a caret followed by a CPU number to be"},{"line_number":841,"context_line":"  excluded from a previous range. For example::"},{"line_number":842,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_f1184177","line":839,"range":{"start_line":839,"start_character":12,"end_line":839,"end_character":14},"in_reply_to":"7faddb67_c5180277","updated":"2019-08-23 11:05:46.000000000","message":"Done","commit_id":"e7749776117b53bfbac199c6b4091e0347db2a08"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"033dc528ec8eee90bd286eca4f06abda65505e34","unresolved":false,"context_lines":[{"line_number":844,"context_line":""},{"line_number":845,"context_line":"Related options:"},{"line_number":846,"context_line":""},{"line_number":847,"context_line":"* ``[compute] cpu_dedicated_set``: This is the counterpart option for defining"},{"line_number":848,"context_line":"  where ``PCPU`` resources should be allocated from."},{"line_number":849,"context_line":"* ``vcpu_pin_set``: A legacy option which will be ignored if this option is"},{"line_number":850,"context_line":"  defined."}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_a52b867f","line":847,"range":{"start_line":847,"start_character":18,"end_line":847,"end_character":27},"updated":"2019-08-21 21:30:28.000000000","message":"shared","commit_id":"e7749776117b53bfbac199c6b4091e0347db2a08"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"186659000cf8330ea69d6dc3246d93a1af77758c","unresolved":false,"context_lines":[{"line_number":844,"context_line":""},{"line_number":845,"context_line":"Related options:"},{"line_number":846,"context_line":""},{"line_number":847,"context_line":"* ``[compute] cpu_dedicated_set``: This is the counterpart option for defining"},{"line_number":848,"context_line":"  where ``PCPU`` resources should be allocated from."},{"line_number":849,"context_line":"* ``vcpu_pin_set``: A legacy option which will be ignored if this option is"},{"line_number":850,"context_line":"  defined."}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_310fb930","line":847,"range":{"start_line":847,"start_character":18,"end_line":847,"end_character":27},"in_reply_to":"7faddb67_a52b867f","updated":"2019-08-23 11:05:46.000000000","message":"Done","commit_id":"e7749776117b53bfbac199c6b4091e0347db2a08"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"033dc528ec8eee90bd286eca4f06abda65505e34","unresolved":false,"context_lines":[{"line_number":845,"context_line":"Related options:"},{"line_number":846,"context_line":""},{"line_number":847,"context_line":"* ``[compute] cpu_dedicated_set``: This is the counterpart option for defining"},{"line_number":848,"context_line":"  where ``PCPU`` resources should be allocated from."},{"line_number":849,"context_line":"* ``vcpu_pin_set``: A legacy option which will be ignored if this option is"},{"line_number":850,"context_line":"  defined."},{"line_number":851,"context_line":"\"\"\"),"}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_053cdac5","line":848,"range":{"start_line":848,"start_character":10,"end_line":848,"end_character":14},"updated":"2019-08-21 21:30:28.000000000","message":"VCPU","commit_id":"e7749776117b53bfbac199c6b4091e0347db2a08"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"186659000cf8330ea69d6dc3246d93a1af77758c","unresolved":false,"context_lines":[{"line_number":845,"context_line":"Related options:"},{"line_number":846,"context_line":""},{"line_number":847,"context_line":"* ``[compute] cpu_dedicated_set``: This is the counterpart option for defining"},{"line_number":848,"context_line":"  where ``PCPU`` resources should be allocated from."},{"line_number":849,"context_line":"* ``vcpu_pin_set``: A legacy option which will be ignored if this option is"},{"line_number":850,"context_line":"  defined."},{"line_number":851,"context_line":"\"\"\"),"}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_510cb538","line":848,"range":{"start_line":848,"start_character":10,"end_line":848,"end_character":14},"in_reply_to":"7faddb67_053cdac5","updated":"2019-08-23 11:05:46.000000000","message":"Done","commit_id":"e7749776117b53bfbac199c6b4091e0347db2a08"}]}
