)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"6ad2e93e6d84ada03d71444a1c741b1fc7ddf8e5","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Yet another function that has outstayed its welcome. This one had to"},{"line_number":10,"context_line":"handle random object types that may have had a \u0027numa_topology\u0027 field or"},{"line_number":11,"context_line":"key, which, if present, contained an instance NUMA topology in either"},{"line_number":12,"context_line":"string, dict or object form. This was only called in two places, both of"},{"line_number":13,"context_line":"which don\u0027t need this complexity as described below, meaning we can"},{"line_number":14,"context_line":"remove this function."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"7faddb67_0274e634","line":12,"range":{"start_line":12,"start_character":29,"end_line":12,"end_character":63},"updated":"2019-08-20 22:21:08.000000000","message":"I take it the second one you\u0027re referring to here is the one you removed in https://review.opendev.org/#/c/671797/13/nova/virt/hardware.py\n\nWouldn\u0027t hurt to redo this commit message to avoid confusing future-me.","commit_id":"0b6da44a15978d230690cbd3763e4940b77d559f"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"4cffd2866a13fbb22c6f8234f2f78ef93960f54c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Yet another function that has outstayed its welcome. This one had to"},{"line_number":10,"context_line":"handle random object types that may have had a \u0027numa_topology\u0027 field or"},{"line_number":11,"context_line":"key, which, if present, contained an instance NUMA topology in either"},{"line_number":12,"context_line":"string, dict or object form. This was only called in two places, both of"},{"line_number":13,"context_line":"which don\u0027t need this complexity as described below, meaning we can"},{"line_number":14,"context_line":"remove this function."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"7faddb67_a2ff1264","line":12,"range":{"start_line":12,"start_character":29,"end_line":12,"end_character":63},"in_reply_to":"7faddb67_0274e634","updated":"2019-08-20 22:29:03.000000000","message":"Okay, never mind, this is a tad confusing, but the two places (as described below) both funnel through a single actual call.","commit_id":"0b6da44a15978d230690cbd3763e4940b77d559f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ecc207fda064722c3387d908658905969911db3c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Yet another function that has outstayed its welcome. This one had to"},{"line_number":10,"context_line":"handle random object types that may have had a \u0027numa_topology\u0027 field or"},{"line_number":11,"context_line":"key, which, if present, contained an instance NUMA topology in either"},{"line_number":12,"context_line":"string, dict or object form. This was only called in two places, both of"},{"line_number":13,"context_line":"which don\u0027t need this complexity as described below, meaning we can"},{"line_number":14,"context_line":"remove this function."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"7faddb67_f3fe33ad","line":12,"range":{"start_line":12,"start_character":29,"end_line":12,"end_character":63},"in_reply_to":"7faddb67_a2ff1264","updated":"2019-08-21 14:21:28.000000000","message":"Yeah. It was a tough one to trace and even more difficult to explain /o\\","commit_id":"0b6da44a15978d230690cbd3763e4940b77d559f"}],"nova/objects/request_spec.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"3f53aaf9cce5d0aaffa0447058f335e1ec05c682","unresolved":false,"context_lines":[{"line_number":215,"context_line":"            self.pci_requests \u003d pci_requests"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    def _from_instance_numa_topology(self, numa_topology):"},{"line_number":218,"context_line":"        if isinstance(numa_topology, six.string_types):"},{"line_number":219,"context_line":"            numa_topology \u003d objects.InstanceNUMATopology.obj_from_primitive("},{"line_number":220,"context_line":"                jsonutils.loads(numa_topology))"},{"line_number":221,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_70efe7b0","line":218,"range":{"start_line":218,"start_character":37,"end_line":218,"end_character":53},"updated":"2019-08-16 05:01:32.000000000","message":"emm....I\u0027m not sure is there anywhere we still pass string numa topology.","commit_id":"da092dde7beb02c29173296ca24c50689f20c70f"}]}