)]}'
{"id":"openstack%2Fnova~672038","triplet_id":"openstack%2Fnova~stable%2Fstein~Id3c847be32d8a1037722d08bf52e4b88dc5adc97","project":"openstack/nova","branch":"stable/stein","topic":"bug/1834712","hashtags":[],"change_id":"Id3c847be32d8a1037722d08bf52e4b88dc5adc97","subject":"Restore RT.old_resources if ComputeNode.save() fails","status":"MERGED","created":"2019-07-22 13:14:10.000000000","updated":"2019-08-01 13:06:14.000000000","submitted":"2019-08-01 13:06:14.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"672038-1564664774657-154fa80f","meta_rev_id":"25a8b136e96b655f41a016f05084ef38fb64c9ca","_number":672038,"virtual_id_number":672038,"owner":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"date":"2019-07-22 16:26:58.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"date":"2019-07-23 00:25:43.000000000","_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},{"value":0,"date":"2019-07-22 14:40:38.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"date":"2019-07-22 19:09:45.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":2,"date":"2019-08-01 13:06:14.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":30381,"name":"Jean-Pierre REN","email":"renzp@awcloud.com","username":"jpren"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"all":[{"value":2,"date":"2019-07-24 18:03:42.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":2,"date":"2019-08-01 10:20:37.000000000","_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-07-24 22:41:55.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":30381,"name":"Jean-Pierre REN","email":"renzp@awcloud.com","username":"jpren"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"all":[{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":1,"date":"2019-08-01 10:20:37.000000000","_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":30381,"name":"Jean-Pierre REN","email":"renzp@awcloud.com","username":"jpren"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":30381,"name":"Jean-Pierre REN","email":"renzp@awcloud.com","username":"jpren"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"_account_id":30381,"name":"Jean-Pierre REN","email":"renzp@awcloud.com","username":"jpren"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-07-22 14:40:38.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-07-22 16:26:58.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2019-07-23 00:25:43.000000000","updated_by":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-07-24 18:03:42.000000000","updated_by":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"reviewer":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"state":"REVIEWER"},{"updated":"2019-07-24 22:41:55.000000000","updated_by":{"_account_id":30381,"name":"Jean-Pierre REN","email":"renzp@awcloud.com","username":"jpren"},"reviewer":{"_account_id":30381,"name":"Jean-Pierre REN","email":"renzp@awcloud.com","username":"jpren"},"state":"REVIEWER"},{"updated":"2019-08-01 10:20:37.000000000","updated_by":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"reviewer":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"state":"REVIEWER"},{"updated":"2019-08-01 13:06:14.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"915537d1ebb870af667ce35f30639c688487e8d1","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-07-22 13:14:10.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"c4b1857d0cf55d9d80100d3a2911d8b4fcc17d1b","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-07-22 13:14:17.000000000","message":"Topic changed from bug/1834712-stable/stein to bug/1834712","accounts_in_message":[],"_revision_number":1},{"id":"29d0056d2ade2a7ae3e6b45d8cb94629dccaf858","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2019-07-22 14:40:38.000000000","message":"Patch Set 1:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/38/672038/1/check/tempest-dsvm-full-xenial/10a9137/ : FAILURE in 1h 25m 21s\n- tempest-dsvm-full-xenial-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/38/672038/1/check/tempest-dsvm-full-xenial-py3/af9b2aa/ : SUCCESS in 1h 25m 15s (non-voting)\n- grenade-dsvm-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/38/672038/1/check/grenade-dsvm-xenial/6bd122b/ : SUCCESS in 1h 07m 49s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"a5cd08401ed6bdcb31b98ce81cf8f5ffe8332693","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-07-22 16:26:58.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/672038/1 : FAILURE in 2h 25m 54s","accounts_in_message":[],"_revision_number":1},{"id":"7e00da109922c7c460f059951701e613f3c17e94","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-22 16:27:01.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade-py3 http://logs.openstack.org/38/672038/1/check/grenade-py3/6fa2e5f/ : SUCCESS in 58m 46s\n- tempest-full-py3 http://logs.openstack.org/38/672038/1/check/tempest-full-py3/ea745d1/ : SUCCESS in 1h 39m 13s\n- openstack-tox-cover http://logs.openstack.org/38/672038/1/check/openstack-tox-cover/7e34c79/cover/ : SUCCESS in 15m 02s\n- openstack-tox-lower-constraints http://logs.openstack.org/38/672038/1/check/openstack-tox-lower-constraints/f9f8012/ : SUCCESS in 11m 32s\n- openstack-tox-pep8 http://logs.openstack.org/38/672038/1/check/openstack-tox-pep8/cd5c2eb/ : SUCCESS in 12m 05s\n- openstack-tox-py27 http://logs.openstack.org/38/672038/1/check/openstack-tox-py27/73ee775/ : SUCCESS in 14m 17s\n- openstack-tox-py35 http://logs.openstack.org/38/672038/1/check/openstack-tox-py35/700d6b6/ : SUCCESS in 15m 38s\n- openstack-tox-py36 http://logs.openstack.org/38/672038/1/check/openstack-tox-py36/4f742df/ : SUCCESS in 12m 59s\n- openstack-tox-py37 http://logs.openstack.org/38/672038/1/check/openstack-tox-py37/2933c77/ : SUCCESS in 14m 18s\n- openstack-tox-docs http://logs.openstack.org/38/672038/1/check/openstack-tox-docs/272dbf8/html/ : SUCCESS in 7m 42s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa http://logs.openstack.org/38/672038/1/check/ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa/ccc34f6/ : SUCCESS in 58m 20s (non-voting)\n- devstack-plugin-ceph-tempest http://logs.openstack.org/38/672038/1/check/devstack-plugin-ceph-tempest/13d6955/ : FAILURE in 1h 30m 47s (non-voting)\n- neutron-grenade-multinode http://logs.openstack.org/38/672038/1/check/neutron-grenade-multinode/adddffe/ : SUCCESS in 1h 14m 07s\n- nova-grenade-live-migration http://logs.openstack.org/38/672038/1/check/nova-grenade-live-migration/4e951f1/ : SUCCESS in 1h 08m 39s\n- nova-live-migration http://logs.openstack.org/38/672038/1/check/nova-live-migration/ac193b7/ : SUCCESS in 54m 32s\n- nova-next http://logs.openstack.org/38/672038/1/check/nova-next/4fe0c75/ : SUCCESS in 1h 43m 43s\n- nova-tox-functional http://logs.openstack.org/38/672038/1/check/nova-tox-functional/afa1f43/ : SUCCESS in 27m 45s\n- nova-tox-functional-py35 http://logs.openstack.org/38/672038/1/check/nova-tox-functional-py35/a61a20c/ : SUCCESS in 20m 54s\n- tempest-multinode-full http://logs.openstack.org/38/672038/1/check/tempest-multinode-full/b7fb137/ : SUCCESS in 2h 11m 51s (non-voting)\n- tempest-slow-py3 http://logs.openstack.org/38/672038/1/check/tempest-slow-py3/014c661/ : SUCCESS in 2h 19m 40s","accounts_in_message":[],"_revision_number":1},{"id":"7359f7be6638c05c8479d543a28e02475953d980","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2019-07-22 18:20:13.000000000","message":"Patch Set 1: Code-Review-1\n\nThis looks good but based on local cherry-picking this had a conflict on the unit test that\u0027s not noted in the commit message.","accounts_in_message":[],"_revision_number":1},{"id":"759ab55c5241f20799217647e93ccfdf88ea2e78","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-07-22 19:09:45.000000000","message":"Patch Set 1:\n\n\u003e This looks good but based on local cherry-picking this had a conflict on the unit test that\u0027s not noted in the commit message.\n\nI cherry picked this using the Gerrit UI which didn\u0027t complain at all so I\u0027m not sure what you\u0027re seeing but it must not be a merge conflict - or the Gerrit UI is doing something.","accounts_in_message":[],"_revision_number":1},{"id":"1196e21c8ff64590c962b89a3445249a2ba43a28","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2019-07-22 19:41:57.000000000","message":"Patch Set 1: -Code-Review\n\nApparently the gerrit ui thinks there\u0027s not a merge conflict but git-review does think there\u0027s a merge conflict. I dunno.","accounts_in_message":[],"_revision_number":1},{"id":"2a49bd32e61834e4f34fdd3814b2345f39500e04","author":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"date":"2019-07-23 00:25:43.000000000","message":"Patch Set 1:\n\nBuild succeeded.\n\n- Nova-ML2-Sriov http://13.74.249.42/38/672038/1/check-nova/Nova-ML2-Sriov/e5e798d : SUCCESS in 1h 24m 09s (non-voting)\n- Nova-MACVTAP-ML2-Sriov http://13.74.249.42/38/672038/1/check-nova/Nova-MACVTAP-ML2-Sriov/175fc37 : SUCCESS in 1h 03m 47s (non-voting)\n\nTo re-run the job post \u0027recheck nova-mlnx\u0027 comment. For more information visit https://wiki.openstack.org/wiki/ThirdPartySystems/Mellanox_CI","accounts_in_message":[],"_revision_number":1},{"id":"2868b2d5b40f63008ea6e3cbc7d021ec3f9a2b23","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2019-07-24 18:03:42.000000000","message":"Patch Set 1: Code-Review+2\n\nLooks OK to me","accounts_in_message":[],"_revision_number":1},{"id":"a88a6490c6950813729057f2a4f287595bfe0d29","author":{"_account_id":30381,"name":"Jean-Pierre REN","email":"renzp@awcloud.com","username":"jpren"},"date":"2019-07-24 22:41:55.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"2ce960a24b128febe67ea59e14bfce204891da5c","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2019-08-01 10:20:37.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nLGTM","accounts_in_message":[],"_revision_number":1},{"id":"9c09c216642154df0696424447637b5dcc10aafb","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-01 10:25:29.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"12618ed5a7fda559dcfadcc183d145521c28ce03","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-01 13:06:14.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"25a8b136e96b655f41a016f05084ef38fb64c9ca","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-01 13:06:14.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- grenade-py3 https://logs.opendev.org/38/672038/1/gate/grenade-py3/433e491/ : SUCCESS in 1h 04m 35s\n- tempest-full-py3 https://logs.opendev.org/38/672038/1/gate/tempest-full-py3/d6c2823/ : SUCCESS in 1h 32m 23s\n- openstack-tox-lower-constraints https://logs.opendev.org/38/672038/1/gate/openstack-tox-lower-constraints/5c87dd2/ : SUCCESS in 12m 00s\n- openstack-tox-pep8 https://logs.opendev.org/38/672038/1/gate/openstack-tox-pep8/f6a0677/ : SUCCESS in 10m 19s\n- openstack-tox-py27 https://logs.opendev.org/38/672038/1/gate/openstack-tox-py27/8ef6d7e/ : SUCCESS in 13m 36s\n- openstack-tox-py35 https://logs.opendev.org/38/672038/1/gate/openstack-tox-py35/f99baf9/ : SUCCESS in 18m 53s\n- openstack-tox-py36 https://logs.opendev.org/38/672038/1/gate/openstack-tox-py36/e5af8eb/ : SUCCESS in 12m 53s\n- openstack-tox-py37 https://logs.opendev.org/38/672038/1/gate/openstack-tox-py37/6628951/ : SUCCESS in 14m 12s\n- openstack-tox-docs https://logs.opendev.org/38/672038/1/gate/openstack-tox-docs/8e39c5f/html/ : SUCCESS in 6m 30s\n- nova-grenade-live-migration https://logs.opendev.org/38/672038/1/gate/nova-grenade-live-migration/6f0b623/ : SUCCESS in 1h 02m 51s\n- nova-live-migration https://logs.opendev.org/38/672038/1/gate/nova-live-migration/6499dbe/ : SUCCESS in 51m 31s\n- nova-tox-functional https://logs.opendev.org/38/672038/1/gate/nova-tox-functional/6dbe43c/ : SUCCESS in 23m 47s\n- nova-tox-functional-py35 https://logs.opendev.org/38/672038/1/gate/nova-tox-functional-py35/31db2cb/ : SUCCESS in 19m 23s\n- nova-next https://logs.opendev.org/38/672038/1/gate/nova-next/6faf0c0/ : SUCCESS in 1h 32m 40s\n- tempest-slow-py3 https://logs.opendev.org/38/672038/1/gate/tempest-slow-py3/da1a61a/ : SUCCESS in 2h 26m 00s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"39ed79ea09fbab590092ef6b1bd4899270f19c9b","revisions":{"39ed79ea09fbab590092ef6b1bd4899270f19c9b":{"kind":"REWORK","_number":1,"created":"2019-07-22 13:14:10.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/38/672038/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/38/672038/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/38/672038/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/38/672038/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/38/672038/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/38/672038/1"}}},"commit":{"parents":[{"commit":"950e044af1ba58894f0860039b5d62b913e3e0b4","subject":"Merge \"Ignore hw_vif_type for direct, direct-physical vNIC types\" into stable/stein","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/950e044af1ba58894f0860039b5d62b913e3e0b4"}]}],"author":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-06-28 22:50:33.000000000","tz":-240},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-07-22 13:14:10.000000000","tz":0},"subject":"Restore RT.old_resources if ComputeNode.save() fails","message":"Restore RT.old_resources if ComputeNode.save() fails\n\nWhen starting nova-compute for the first time with a new node,\nthe ResourceTracker will create a new ComputeNode record in\n_init_compute_node but without all of the fields set on the\nComputeNode, for example \"free_disk_gb\".\n\nLater _update_usage_from_instances will set some fields on the\nComputeNode record (even if there are no instances on the node,\nwhy - I don\u0027t know) like free_disk_gb.\n\nThis will make the eventual call from _update() to _resource_change()\nupdate the value in the old_resouces dict and return True, and then\n_update() will try to update those ComputeNode changes to the database.\nIf that update fails, for example due to a DBConnectionError, the\nvalue in old_resources will still be for the current version of the node\nin memory but not what is actually in the database.\n\nNote that this failure does not result in the compute service failing\nto start because ComputeManager._update_available_resource_for_node\ntraps the Exception and just logs it.\n\nA subsequent trip through the RT._update() method - because of the\nupdate_available_resource periodic task - will call _resource_change\nbut because old_resource matches the current state of the node, it\nreturns False and the RT does not attempt to persist the changes to\nthe DB. _update() will then go on to call _update_to_placement\nwhich will create the resource provider in placement along with its\ninventory, making it potentially a candidate for scheduling.\n\nThis can be a problem later in the scheduler because the\nHostState._update_from_compute_node method may skip setting fields\non the HostState object if free_disk_gb is not set in the\nComputeNode record - which can then break filters and weighers\nlater in the scheduling process (see bug 1834691 and bug 1834694).\n\nThe fix proposed here is simple: if the ComputeNode.save() in\nRT._update() fails, restore the previous value in old_resources\nso that the subsequent run through _resource_change will compare the\ncorrect state of the object and retry the update.\n\nAn alternative to this would be killing the compute service on startup\nif there is a DB error but that could have unintended side effects,\nespecially if the DB error is transient and can be fixed on the next\ntry.\n\nObviously the scheduler code needs to be more robust also, but those\nimprovements are left for separate changes related to the other bugs\nmentioned above.\n\nAlso, ComputeNode.update_from_virt_driver could be updated to set\nfree_disk_gb if possible to workaround the tight coupling in the\nHostState._update_from_compute_node code, but that\u0027s also sort of\na whack-a-mole type change best made separately.\n\nChange-Id: Id3c847be32d8a1037722d08bf52e4b88dc5adc97\nCloses-Bug: #1834712\n(cherry picked from commit 11cb42f396fdbc1d973e1a1b592c00896f646015)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/39ed79ea09fbab590092ef6b1bd4899270f19c9b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/39ed79ea09fbab590092ef6b1bd4899270f19c9b"}]},"branch":"refs/heads/stable/stein"}},"requirements":[],"submit_records":[],"submit_requirements":[]}