)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ce822f2d344f036ff8147594e96b31e86f443f89","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"cellv2: make update_cell to support cell0"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The transport and db connection URLs should be considered as special"},{"line_number":10,"context_line":"case."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Related-Bug: #1835037"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7faddb67_aa824e51","line":9,"updated":"2019-07-23 12:41:32.000000000","message":"Could you explain what the issue is and how this fixes it?","commit_id":"d75c0737d473fce833b3d0c7689b7b94ac535d39"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"ba624504b743828f932c2d66ecf0123f96b4d8e6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"cellv2: make update_cell to support cell0"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The transport and db connection URLs should be considered as special"},{"line_number":10,"context_line":"case."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Related-Bug: #1835037"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7faddb67_4a207ab1","line":9,"in_reply_to":"7faddb67_aa824e51","updated":"2019-07-23 13:20:37.000000000","message":"Sure I added clarifications I hope that makes sense.","commit_id":"d75c0737d473fce833b3d0c7689b7b94ac535d39"}],"nova/cmd/manage.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"747ee0efec5f8e10c5459158d3732dc8088bc5f4","unresolved":false,"context_lines":[{"line_number":1516,"context_line":"            cell_mapping.name \u003d name"},{"line_number":1517,"context_line":""},{"line_number":1518,"context_line":"        if cell_mapping.uuid \u003d\u003d objects.CellMapping.CELL0_UUID:"},{"line_number":1519,"context_line":"            # TODO(sahid): We should not allow to update transport_url"},{"line_number":1520,"context_line":"            # if cell0 is requested, an error message + return code"},{"line_number":1521,"context_line":"            # would be better than just an override."},{"line_number":1522,"context_line":"            transport_url \u003d \"none:///\""}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_ea8fe672","line":1519,"updated":"2019-07-23 12:42:10.000000000","message":"Like this?\n\nhttps://review.opendev.org/#/c/605414/","commit_id":"d75c0737d473fce833b3d0c7689b7b94ac535d39"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"a6b5a462a62a30c91180eb4561ef000ebd2e701e","unresolved":false,"context_lines":[{"line_number":1516,"context_line":"            cell_mapping.name \u003d name"},{"line_number":1517,"context_line":""},{"line_number":1518,"context_line":"        if cell_mapping.uuid \u003d\u003d objects.CellMapping.CELL0_UUID:"},{"line_number":1519,"context_line":"            # TODO(sahid): We should not allow to update transport_url"},{"line_number":1520,"context_line":"            # if cell0 is requested, an error message + return code"},{"line_number":1521,"context_line":"            # would be better than just an override."},{"line_number":1522,"context_line":"            transport_url \u003d \"none:///\""}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_4a095a2f","line":1519,"in_reply_to":"7faddb67_aa29eef2","updated":"2019-07-23 13:23:51.000000000","message":"Yep Surya, your patch is doing some interesting work around --transport_url which makes sense and would be a geat complement.","commit_id":"d75c0737d473fce833b3d0c7689b7b94ac535d39"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"5dfc7696f6b46276fee8fcaa9ee44ca93589d661","unresolved":false,"context_lines":[{"line_number":1516,"context_line":"            cell_mapping.name \u003d name"},{"line_number":1517,"context_line":""},{"line_number":1518,"context_line":"        if cell_mapping.uuid \u003d\u003d objects.CellMapping.CELL0_UUID:"},{"line_number":1519,"context_line":"            # TODO(sahid): We should not allow to update transport_url"},{"line_number":1520,"context_line":"            # if cell0 is requested, an error message + return code"},{"line_number":1521,"context_line":"            # would be better than just an override."},{"line_number":1522,"context_line":"            transport_url \u003d \"none:///\""}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_aa29eef2","line":1519,"in_reply_to":"7faddb67_ea8fe672","updated":"2019-07-23 13:13:45.000000000","message":"From the commit message and the \"TODO\" I am not really sure what\u0027s the problem and the fix, but the part mentioned in this \"TODO\" of not allowing update of transport_url is what my patch does and proposes. It would be useful to have that in since in the past we have had operators run into this issue at CERN.","commit_id":"d75c0737d473fce833b3d0c7689b7b94ac535d39"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"5dfc7696f6b46276fee8fcaa9ee44ca93589d661","unresolved":false,"context_lines":[{"line_number":1520,"context_line":"            # if cell0 is requested, an error message + return code"},{"line_number":1521,"context_line":"            # would be better than just an override."},{"line_number":1522,"context_line":"            transport_url \u003d \"none:///\""},{"line_number":1523,"context_line":"            db_connection \u003d db_connection or self.cell0_default_connection()"},{"line_number":1524,"context_line":"        else:"},{"line_number":1525,"context_line":"            transport_url \u003d transport_url or CONF.transport_url"},{"line_number":1526,"context_line":"            db_connection \u003d db_connection or CONF.database.connection"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_8a8672db","line":1523,"range":{"start_line":1523,"start_character":12,"end_line":1523,"end_character":76},"updated":"2019-07-23 13:13:45.000000000","message":"as for this part, I don\u0027t think the database_url needs special treatment since its like for the other cells coming from the config file, so if people have it wrong in the config file then they have to fix it anyways. When specifying update_cell command one has to be aware of which config file they are running it against. By default the nova.conf has the transport_url set to the global MQ which is why transport_url needs special treatment (which is also my my patch deals only with transport_url) as usually cell0\u0027s MQ gets updated pointing to the global one when running against the default config file.","commit_id":"d75c0737d473fce833b3d0c7689b7b94ac535d39"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"a6b5a462a62a30c91180eb4561ef000ebd2e701e","unresolved":false,"context_lines":[{"line_number":1520,"context_line":"            # if cell0 is requested, an error message + return code"},{"line_number":1521,"context_line":"            # would be better than just an override."},{"line_number":1522,"context_line":"            transport_url \u003d \"none:///\""},{"line_number":1523,"context_line":"            db_connection \u003d db_connection or self.cell0_default_connection()"},{"line_number":1524,"context_line":"        else:"},{"line_number":1525,"context_line":"            transport_url \u003d transport_url or CONF.transport_url"},{"line_number":1526,"context_line":"            db_connection \u003d db_connection or CONF.database.connection"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_c5021b0a","line":1523,"range":{"start_line":1523,"start_character":12,"end_line":1523,"end_character":76},"in_reply_to":"7faddb67_8a8672db","updated":"2019-07-23 13:23:51.000000000","message":"Actually, there is a special case for the database URL. Please consider my change in the commit message.","commit_id":"d75c0737d473fce833b3d0c7689b7b94ac535d39"}]}