)]}'
{"nova/db/sqlalchemy/api.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ceb844b028bae2962c7f106ea7b8a23171ccd577","unresolved":false,"context_lines":[{"line_number":1139,"context_line":"            fixed_ip_ref.network_id \u003d network_id"},{"line_number":1140,"context_line":"        fixed_ip_ref.instance_uuid \u003d instance_uuid"},{"line_number":1141,"context_line":"        session.add(fixed_ip_ref)"},{"line_number":1142,"context_line":"    return fixed_ip_ref"},{"line_number":1143,"context_line":""},{"line_number":1144,"context_line":""},{"line_number":1145,"context_line":"@require_admin_context"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2FAs4%3D","line":1142,"updated":"2014-01-19 07:49:01.000000000","message":"Not sure about this. This may break code with an upgrade. That is, say someone has 2 nova-network nodes and the one is still running whilst the other is updated to work with the object. The former may access data that is not the expected type. Unless I have misunderstood something here","commit_id":"1a6f72ac00295a51a298b3bd58798e6a5ba51908"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"0c94d129410bad9f848ad629c44c8d67edaab17f","unresolved":false,"context_lines":[{"line_number":1139,"context_line":"            fixed_ip_ref.network_id \u003d network_id"},{"line_number":1140,"context_line":"        fixed_ip_ref.instance_uuid \u003d instance_uuid"},{"line_number":1141,"context_line":"        session.add(fixed_ip_ref)"},{"line_number":1142,"context_line":"    return fixed_ip_ref"},{"line_number":1143,"context_line":""},{"line_number":1144,"context_line":""},{"line_number":1145,"context_line":"@require_admin_context"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2B%2F0M%3D","line":1142,"in_reply_to":"AAAAUH%2F%2FAs4%3D","updated":"2014-01-19 19:01:38.000000000","message":"If the old nova-network is running old code... then it has the old version of this method :)  It would only be an issue if it broke RPC.","commit_id":"1a6f72ac00295a51a298b3bd58798e6a5ba51908"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ceb844b028bae2962c7f106ea7b8a23171ccd577","unresolved":false,"context_lines":[{"line_number":1140,"context_line":"        fixed_ip_ref.instance_uuid \u003d instance_uuid"},{"line_number":1141,"context_line":"        session.add(fixed_ip_ref)"},{"line_number":1142,"context_line":"    return fixed_ip_ref"},{"line_number":1143,"context_line":""},{"line_number":1144,"context_line":""},{"line_number":1145,"context_line":"@require_admin_context"},{"line_number":1146,"context_line":"def fixed_ip_associate_pool(context, network_id, instance_uuid\u003dNone,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2FAs0%3D","line":1143,"updated":"2014-01-19 07:49:01.000000000","message":"it would also be nice if there were database tests for these","commit_id":"1a6f72ac00295a51a298b3bd58798e6a5ba51908"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"0c94d129410bad9f848ad629c44c8d67edaab17f","unresolved":false,"context_lines":[{"line_number":1140,"context_line":"        fixed_ip_ref.instance_uuid \u003d instance_uuid"},{"line_number":1141,"context_line":"        session.add(fixed_ip_ref)"},{"line_number":1142,"context_line":"    return fixed_ip_ref"},{"line_number":1143,"context_line":""},{"line_number":1144,"context_line":""},{"line_number":1145,"context_line":"@require_admin_context"},{"line_number":1146,"context_line":"def fixed_ip_associate_pool(context, network_id, instance_uuid\u003dNone,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2B%2F0I%3D","line":1143,"in_reply_to":"AAAAUH%2F%2FAs0%3D","updated":"2014-01-19 19:01:38.000000000","message":"Would be nice.. but I think should be separate.","commit_id":"1a6f72ac00295a51a298b3bd58798e6a5ba51908"}]}