)]}'
{"id":"openstack%2Fnova~672154","triplet_id":"openstack%2Fnova~stable%2Fstein~I58a4038b04d5a9c28927d914e71609e4deea3d9f","project":"openstack/nova","branch":"stable/stein","topic":"bug/1837075","hashtags":[],"change_id":"I58a4038b04d5a9c28927d914e71609e4deea3d9f","subject":"libvirt: move checking CONF.my_ip to init_host()","status":"MERGED","created":"2019-07-22 19:44:26.000000000","updated":"2019-07-24 20:20:27.000000000","submitted":"2019-07-24 20:20:27.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"672154-1563999627673-c3a5ce02","meta_rev_id":"3b0ed9e108cdb6b4a587d0834977fb1860139c2e","_number":672154,"virtual_id_number":672154,"owner":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"date":"2019-07-22 22:09:43.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"date":"2019-07-22 21:21:24.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":2,"date":"2019-07-24 20:20:27.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":30381,"name":"Jean-Pierre REN","email":"renzp@awcloud.com","username":"jpren"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"all":[{"value":2,"date":"2019-07-24 18:01:57.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":2,"date":"2019-07-22 20:51:31.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-07-22 22:24:50.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":30381,"name":"Jean-Pierre REN","email":"renzp@awcloud.com","username":"jpren"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"all":[{"value":1,"date":"2019-07-24 18:01:57.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":30381,"name":"Jean-Pierre REN","email":"renzp@awcloud.com","username":"jpren"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":30381,"name":"Jean-Pierre REN","email":"renzp@awcloud.com","username":"jpren"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"_account_id":30381,"name":"Jean-Pierre REN","email":"renzp@awcloud.com","username":"jpren"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-07-22 20:51:31.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2019-07-22 21:21:24.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-07-22 22:09:43.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2019-07-22 22:24:50.000000000","updated_by":{"_account_id":30381,"name":"Jean-Pierre REN","email":"renzp@awcloud.com","username":"jpren"},"reviewer":{"_account_id":30381,"name":"Jean-Pierre REN","email":"renzp@awcloud.com","username":"jpren"},"state":"REVIEWER"},{"updated":"2019-07-24 18:01:57.000000000","updated_by":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"reviewer":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"state":"REVIEWER"},{"updated":"2019-07-24 20:20:27.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"62dff25195dfd1413d0899996d17fb13e3e9804e","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2019-07-22 19:44:26.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"cfdaa43990c87af2ef3db4c93e18add731e8232a","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2019-07-22 19:44:52.000000000","message":"Topic set to bug/1837075","accounts_in_message":[],"_revision_number":1},{"id":"a1bd3a6e9c206bb5233fda0d65382db4e1f8d885","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2019-07-22 19:47:12.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"11c7c77affacdcbaef9887e99e7057615a3f0232","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2019-07-22 19:48:20.000000000","message":"Uploaded patch set 3: Commit message was updated.","accounts_in_message":[],"_revision_number":3},{"id":"502f12041fc7da472edd779b3c57fcd5008d6cd4","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-07-22 20:51:31.000000000","message":"Patch Set 3: Code-Review+2\n\n(1 comment)\n\nClean backport and the confusing thing in the commit message for the backport is called out so lgtm.","accounts_in_message":[],"_revision_number":3},{"id":"4111743f2bfa1c513a45237dd4263f0f5f7c7794","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2019-07-22 21:21:24.000000000","message":"Patch Set 3:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/54/672154/3/check/tempest-dsvm-full-xenial/a6b3dea/ : SUCCESS in 1h 17m 39s\n- tempest-dsvm-full-xenial-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/54/672154/3/check/tempest-dsvm-full-xenial-py3/ee98342/ : SUCCESS in 1h 31m 46s (non-voting)\n- grenade-dsvm-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/54/672154/3/check/grenade-dsvm-xenial/ab80f45/ : SUCCESS in 1h 08m 07s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"d1a6b2b765dcd664fe4adb38534c4944ab6f69fb","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-07-22 22:09:43.000000000","message":"Patch Set 3:\n\nBuild succeeded.\n\n- nova http://cloudbase-ci.com/nova/672154/3 : SUCCESS in 2h 20m 20s","accounts_in_message":[],"_revision_number":3},{"id":"df52c0c2cd742d60066296357415e16bec5295d7","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-22 22:23:57.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade-py3 http://logs.openstack.org/54/672154/3/check/grenade-py3/11f0ef2/ : SUCCESS in 46m 59s\n- tempest-full-py3 http://logs.openstack.org/54/672154/3/check/tempest-full-py3/f8bd435/ : SUCCESS in 1h 35m 27s\n- openstack-tox-cover http://logs.openstack.org/54/672154/3/check/openstack-tox-cover/5b343be/cover/ : SUCCESS in 18m 01s\n- openstack-tox-lower-constraints http://logs.openstack.org/54/672154/3/check/openstack-tox-lower-constraints/e5719e9/ : SUCCESS in 15m 12s\n- openstack-tox-pep8 http://logs.openstack.org/54/672154/3/check/openstack-tox-pep8/7c80ded/ : SUCCESS in 9m 38s\n- openstack-tox-py27 http://logs.openstack.org/54/672154/3/check/openstack-tox-py27/74ee756/ : SUCCESS in 12m 36s\n- openstack-tox-py35 http://logs.openstack.org/54/672154/3/check/openstack-tox-py35/5e481d1/ : SUCCESS in 14m 33s\n- openstack-tox-py36 http://logs.openstack.org/54/672154/3/check/openstack-tox-py36/245e237/ : SUCCESS in 16m 36s\n- openstack-tox-py37 http://logs.openstack.org/54/672154/3/check/openstack-tox-py37/1170319/ : SUCCESS in 14m 37s\n- openstack-tox-docs http://logs.openstack.org/54/672154/3/check/openstack-tox-docs/c5ffeab/html/ : SUCCESS in 6m 57s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa http://logs.openstack.org/54/672154/3/check/ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa/e7b4a1b/ : SUCCESS in 43m 19s (non-voting)\n- devstack-plugin-ceph-tempest http://logs.openstack.org/54/672154/3/check/devstack-plugin-ceph-tempest/b76e301/ : SUCCESS in 1h 22m 27s (non-voting)\n- neutron-grenade-multinode http://logs.openstack.org/54/672154/3/check/neutron-grenade-multinode/910bb3d/ : SUCCESS in 1h 15m 45s\n- nova-grenade-live-migration http://logs.openstack.org/54/672154/3/check/nova-grenade-live-migration/342ac0c/ : SUCCESS in 1h 10m 32s\n- nova-live-migration http://logs.openstack.org/54/672154/3/check/nova-live-migration/4083030/ : SUCCESS in 59m 59s\n- nova-lvm http://logs.openstack.org/54/672154/3/check/nova-lvm/4276ce2/ : SUCCESS in 58m 57s (non-voting)\n- nova-next http://logs.openstack.org/54/672154/3/check/nova-next/96e0984/ : SUCCESS in 1h 21m 25s\n- nova-tox-functional http://logs.openstack.org/54/672154/3/check/nova-tox-functional/44f693f/ : SUCCESS in 21m 21s\n- nova-tox-functional-py35 http://logs.openstack.org/54/672154/3/check/nova-tox-functional-py35/219eb59/ : SUCCESS in 21m 10s\n- tempest-multinode-full http://logs.openstack.org/54/672154/3/check/tempest-multinode-full/1e2319c/ : SUCCESS in 1h 47m 08s (non-voting)\n- tempest-slow-py3 http://logs.openstack.org/54/672154/3/check/tempest-slow-py3/fad8c94/ : SUCCESS in 2h 28m 19s","accounts_in_message":[],"_revision_number":3},{"id":"9480a5d4401fa30d567b4c81f4b77810059be9f0","author":{"_account_id":30381,"name":"Jean-Pierre REN","email":"renzp@awcloud.com","username":"jpren"},"date":"2019-07-22 22:24:50.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"c06bbf2fd7b0fe2101d8eae450d44c653a10eebf","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2019-07-24 18:01:57.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1\n\nLGTM","accounts_in_message":[],"_revision_number":3},{"id":"c931b39e1a973ee20f6db3f3b75599c560898132","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-24 18:04:15.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"4169a88132fa3abf4531e56614942e1a278c50b0","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-24 20:20:27.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3},{"id":"3b0ed9e108cdb6b4a587d0834977fb1860139c2e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-24 20:20:27.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- grenade-py3 http://logs.openstack.org/54/672154/3/gate/grenade-py3/cec6e60/ : SUCCESS in 50m 07s\n- tempest-full-py3 http://logs.openstack.org/54/672154/3/gate/tempest-full-py3/468f192/ : SUCCESS in 1h 42m 18s\n- openstack-tox-lower-constraints http://logs.openstack.org/54/672154/3/gate/openstack-tox-lower-constraints/e8c929f/ : SUCCESS in 13m 35s\n- openstack-tox-pep8 http://logs.openstack.org/54/672154/3/gate/openstack-tox-pep8/fdc0250/ : SUCCESS in 11m 13s\n- openstack-tox-py27 http://logs.openstack.org/54/672154/3/gate/openstack-tox-py27/e162486/ : SUCCESS in 12m 43s\n- openstack-tox-py35 http://logs.openstack.org/54/672154/3/gate/openstack-tox-py35/a0999c1/ : SUCCESS in 15m 18s\n- openstack-tox-py36 http://logs.openstack.org/54/672154/3/gate/openstack-tox-py36/16c98e9/ : SUCCESS in 13m 27s\n- openstack-tox-py37 http://logs.openstack.org/54/672154/3/gate/openstack-tox-py37/5892efc/ : SUCCESS in 14m 04s\n- openstack-tox-docs http://logs.openstack.org/54/672154/3/gate/openstack-tox-docs/b406557/html/ : SUCCESS in 7m 48s\n- nova-grenade-live-migration http://logs.openstack.org/54/672154/3/gate/nova-grenade-live-migration/39d7bff/ : SUCCESS in 1h 13m 40s\n- nova-live-migration http://logs.openstack.org/54/672154/3/gate/nova-live-migration/6e40696/ : SUCCESS in 53m 19s\n- nova-tox-functional http://logs.openstack.org/54/672154/3/gate/nova-tox-functional/23483ea/ : SUCCESS in 19m 58s\n- nova-tox-functional-py35 http://logs.openstack.org/54/672154/3/gate/nova-tox-functional-py35/d352510/ : SUCCESS in 18m 48s\n- nova-next http://logs.openstack.org/54/672154/3/gate/nova-next/5551c94/ : SUCCESS in 1h 13m 53s\n- tempest-slow-py3 http://logs.openstack.org/54/672154/3/gate/tempest-slow-py3/915739d/ : SUCCESS in 2h 06m 58s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"560317c766afc4a4c4c5017ecfc9ce432fe63ea7","revisions":{"2274f7c259c55ca43eb4a937cdb4d1af152b67db":{"kind":"REWORK","_number":1,"created":"2019-07-22 19:44:26.000000000","uploader":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"ref":"refs/changes/54/672154/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/54/672154/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/54/672154/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/54/672154/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/54/672154/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/54/672154/1"}}},"commit":{"parents":[{"commit":"950e044af1ba58894f0860039b5d62b913e3e0b4","subject":"Merge \"Ignore hw_vif_type for direct, direct-physical vNIC types\" into stable/stein","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/950e044af1ba58894f0860039b5d62b913e3e0b4"}]}],"author":{"name":"Artom Lifshitz","email":"alifshit@redhat.com","date":"2019-07-19 15:35:24.000000000","tz":-240},"committer":{"name":"Artom Lifshitz","email":"alifshit@redhat.com","date":"2019-07-22 19:44:17.000000000","tz":-240},"subject":"libvirt: move checking CONF.my_ip to init_host()","message":"libvirt: move checking CONF.my_ip to init_host()\n\nMigrations use the libvirt driver\u0027s get_host_ip_addr() method to\ndetermine the dest_host field of the migration object.\nget_host_ip_addr() checks whether CONF.my_ip is actually assigned to\none of the host\u0027s interfaces. It does so by calling\nget_machine_ips(), which iterates over all of the host\u0027s interfaces.\nIf the host has many interfaces, this can take a long time, and\nintroduces needless delays in processing the migration.\nget_machine_ips() is only used to print a warning, so this patch moves\nthe get_machine_ips() call to a single method in init_host(). This\nway, a warning is still emitted at compute service startup, and\nmigration progress is not needlessly slowed down.\n\nThis patch also has a chicken and egg problem with the patch on top of\nit, which poisons use of netifaces.interfaces() in tests. While this\npatch fixes all the tests that break with that poison, it starts\nbreaking different tests because of the move of get_machine_ips() into\ninit_host(). Therefore, while not directly related to the bug, this\npatch also preventatively mocks or stubs out any use of\nget_machine_ips() that will get poisoned with the subsequent patch.\n\nCloses-bug: 1837075\nChange-Id: I58a4038b04d5a9c28927d914e71609e4deea3d9f\n(cherry picked from commit 30d8159d4ee51a26a03de1cb134ea64c6c07ffb2)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2274f7c259c55ca43eb4a937cdb4d1af152b67db"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2274f7c259c55ca43eb4a937cdb4d1af152b67db"}]},"branch":"refs/heads/stable/stein"},"5da3f6cede32005336b5ec0d152f32b5da374728":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2019-07-22 19:47:12.000000000","uploader":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"ref":"refs/changes/54/672154/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/54/672154/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/54/672154/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/54/672154/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/54/672154/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/54/672154/2"}}},"commit":{"parents":[{"commit":"950e044af1ba58894f0860039b5d62b913e3e0b4","subject":"Merge \"Ignore hw_vif_type for direct, direct-physical vNIC types\" into stable/stein","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/950e044af1ba58894f0860039b5d62b913e3e0b4"}]}],"author":{"name":"Artom Lifshitz","email":"alifshit@redhat.com","date":"2019-07-19 15:35:24.000000000","tz":-240},"committer":{"name":"Artom Lifshitz","email":"alifshit@redhat.com","date":"2019-07-22 19:45:58.000000000","tz":-240},"subject":"libvirt: move checking CONF.my_ip to init_host()","message":"libvirt: move checking CONF.my_ip to init_host()\n\nMigrations use the libvirt driver\u0027s get_host_ip_addr() method to\ndetermine the dest_host field of the migration object.\nget_host_ip_addr() checks whether CONF.my_ip is actually assigned to\none of the host\u0027s interfaces. It does so by calling\nget_machine_ips(), which iterates over all of the host\u0027s interfaces.\nIf the host has many interfaces, this can take a long time, and\nintroduces needless delays in processing the migration.\nget_machine_ips() is only used to print a warning, so this patch moves\nthe get_machine_ips() call to a single method in init_host(). This\nway, a warning is still emitted at compute service startup, and\nmigration progress is not needlessly slowed down.\n\nNOTE(artom) While the following paragraph still applies, the poison\npatch will not be backported. Stubbing out use of\nnetiface.interfaces() is still a good thing to do, however.\n\nThis patch also has a chicken and egg problem with the patch on top of\nit, which poisons use of netifaces.interfaces() in tests. While this\npatch fixes all the tests that break with that poison, it starts\nbreaking different tests because of the move of get_machine_ips() into\ninit_host(). Therefore, while not directly related to the bug, this\npatch also preventatively mocks or stubs out any use of\nget_machine_ips() that will get poisoned with the subsequent patch.\n\nCloses-bug: 1837075\nChange-Id: I58a4038b04d5a9c28927d914e71609e4deea3d9f\n(cherry picked from commit 30d8159d4ee51a26a03de1cb134ea64c6c07ffb2)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/5da3f6cede32005336b5ec0d152f32b5da374728"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/5da3f6cede32005336b5ec0d152f32b5da374728"}]},"branch":"refs/heads/stable/stein"},"560317c766afc4a4c4c5017ecfc9ce432fe63ea7":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2019-07-22 19:48:20.000000000","uploader":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"ref":"refs/changes/54/672154/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/54/672154/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/54/672154/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/54/672154/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/54/672154/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/54/672154/3"}}},"commit":{"parents":[{"commit":"950e044af1ba58894f0860039b5d62b913e3e0b4","subject":"Merge \"Ignore hw_vif_type for direct, direct-physical vNIC types\" into stable/stein","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/950e044af1ba58894f0860039b5d62b913e3e0b4"}]}],"author":{"name":"Artom Lifshitz","email":"alifshit@redhat.com","date":"2019-07-19 15:35:24.000000000","tz":-240},"committer":{"name":"Artom Lifshitz","email":"alifshit@redhat.com","date":"2019-07-22 19:48:09.000000000","tz":-240},"subject":"libvirt: move checking CONF.my_ip to init_host()","message":"libvirt: move checking CONF.my_ip to init_host()\n\nMigrations use the libvirt driver\u0027s get_host_ip_addr() method to\ndetermine the dest_host field of the migration object.\nget_host_ip_addr() checks whether CONF.my_ip is actually assigned to\none of the host\u0027s interfaces. It does so by calling\nget_machine_ips(), which iterates over all of the host\u0027s interfaces.\nIf the host has many interfaces, this can take a long time, and\nintroduces needless delays in processing the migration.\nget_machine_ips() is only used to print a warning, so this patch moves\nthe get_machine_ips() call to a single method in init_host(). This\nway, a warning is still emitted at compute service startup, and\nmigration progress is not needlessly slowed down.\n\nNOTE(artom) While the following paragraph still applies, the poison\npatch will not be backported. Stubbing out use of\nnetifaces.interfaces() is still a good thing to do, however.\n\nThis patch also has a chicken and egg problem with the patch on top of\nit, which poisons use of netifaces.interfaces() in tests. While this\npatch fixes all the tests that break with that poison, it starts\nbreaking different tests because of the move of get_machine_ips() into\ninit_host(). Therefore, while not directly related to the bug, this\npatch also preventatively mocks or stubs out any use of\nget_machine_ips() that will get poisoned with the subsequent patch.\n\nCloses-bug: 1837075\nChange-Id: I58a4038b04d5a9c28927d914e71609e4deea3d9f\n(cherry picked from commit 30d8159d4ee51a26a03de1cb134ea64c6c07ffb2)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/560317c766afc4a4c4c5017ecfc9ce432fe63ea7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/560317c766afc4a4c4c5017ecfc9ce432fe63ea7"}]},"branch":"refs/heads/stable/stein"}},"requirements":[],"submit_records":[],"submit_requirements":[]}