)]}'
{"id":"openstack%2Fnova~672155","triplet_id":"openstack%2Fnova~stable%2Frocky~I58a4038b04d5a9c28927d914e71609e4deea3d9f","project":"openstack/nova","branch":"stable/rocky","topic":"bug/1837075","hashtags":[],"change_id":"I58a4038b04d5a9c28927d914e71609e4deea3d9f","subject":"libvirt: move checking CONF.my_ip to init_host()","status":"MERGED","created":"2019-07-22 19:47:43.000000000","updated":"2019-08-01 21:31:38.000000000","submitted":"2019-08-01 21:31:38.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"672155-1564695098095-e5490da1","meta_rev_id":"a1409cf0624c9e8cf98430977b1b7efb427083dc","_number":672155,"virtual_id_number":672155,"owner":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2019-07-22 21:10:35.000000000","_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"date":"2019-07-22 21:54:38.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"date":"2019-07-22 21:05:03.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":2,"date":"2019-08-01 21:31:37.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"all":[{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":2,"date":"2019-08-01 11:29:56.000000000","_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":2,"date":"2019-07-31 20:09:45.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"all":[{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":1,"date":"2019-08-01 11:29:56.000000000","_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-07-22 21:05:03.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-07-22 21:10:35.000000000","updated_by":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-07-22 21:54:38.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2019-07-31 20:09:45.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2019-08-01 11:29:56.000000000","updated_by":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"reviewer":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"state":"REVIEWER"},{"updated":"2019-08-01 21:31:37.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"db5e4dc9cfe8b857858a09cf29d3b61dedf06110","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2019-07-22 19:47:43.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6079b6a0222d7d11decea272cc4a0e621de23bf5","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2019-07-22 19:49:10.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"2f503c648c60d9c714d1c6ea28442ead230cd675","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2019-07-22 19:49:33.000000000","message":"Topic set to bug/1837075","accounts_in_message":[],"_revision_number":2},{"id":"0fa77c90e81bbf1bc8197c860a7695d7c2164243","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2019-07-22 21:05:03.000000000","message":"Patch Set 2:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/55/672155/2/check/tempest-dsvm-full-xenial/6f4a1ee/ : SUCCESS in 1h 14m 58s\n- tempest-dsvm-full-xenial-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/55/672155/2/check/tempest-dsvm-full-xenial-py3/18be1a0/ : SUCCESS in 1h 11m 51s (non-voting)\n- grenade-dsvm-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/55/672155/2/check/grenade-dsvm-xenial/4344bdd/ : SUCCESS in 58m 14s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"d2f2a9d7a4aafedefad9518ec19fefd658e34ecc","author":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"date":"2019-07-22 21:10:35.000000000","message":"Patch Set 2:\n\nBuild failed. Comment \u0027powervm: recheck\u0027 to recheck.\n For 3rd party CI contact info: https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_PowerVM_CI\n\n- nova-out-of-tree-pvm http://184.172.12.213/55/672155/2/check/nova-out-of-tree-pvm/678c7a4 : FAILURE in 22m 52s\n- nova-in-tree-pvm http://184.172.12.213/55/672155/2/check/nova-in-tree-pvm/a1ca868 : FAILURE in 23m 48s","accounts_in_message":[],"_revision_number":2},{"id":"d557281584bd7cbc59484a4426f14281ac49b21b","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-07-22 21:54:38.000000000","message":"Patch Set 2:\n\nBuild succeeded.\n\n- nova http://cloudbase-ci.com/nova/672155/2 : SUCCESS in 2h 04m 37s","accounts_in_message":[],"_revision_number":2},{"id":"5699fde88640f27a496b27904dde60726ca4826c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-22 22:04:29.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/55/672155/2/check/openstack-tox-pep8/4f42a9d/ : SUCCESS in 9m 58s\n- openstack-tox-py27 http://logs.openstack.org/55/672155/2/check/openstack-tox-py27/b24d3bd/ : SUCCESS in 17m 13s\n- openstack-tox-py35 http://logs.openstack.org/55/672155/2/check/openstack-tox-py35/9b10452/ : SUCCESS in 13m 49s\n- build-openstack-sphinx-docs http://logs.openstack.org/55/672155/2/check/build-openstack-sphinx-docs/9294787/html/ : SUCCESS in 8m 07s\n- tempest-full http://logs.openstack.org/55/672155/2/check/tempest-full/ca5b7cc/ : SUCCESS in 1h 25m 12s\n- neutron-grenade http://logs.openstack.org/55/672155/2/check/neutron-grenade/c5029ef/ : SUCCESS in 1h 00m 22s\n- tempest-full-py3 http://logs.openstack.org/55/672155/2/check/tempest-full-py3/a1b2ffa/ : SUCCESS in 1h 26m 25s\n- ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa http://logs.openstack.org/55/672155/2/check/ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa/d77132b/ : SUCCESS in 1h 00m 22s (non-voting)\n- nova-cells-v1 http://logs.openstack.org/55/672155/2/check/nova-cells-v1/2542d72/ : SUCCESS in 1h 09m 08s\n- nova-grenade-live-migration http://logs.openstack.org/55/672155/2/check/nova-grenade-live-migration/dcd279b/ : SUCCESS in 1h 14m 35s (non-voting)\n- nova-live-migration http://logs.openstack.org/55/672155/2/check/nova-live-migration/f8f256d/ : SUCCESS in 46m 31s\n- nova-lvm http://logs.openstack.org/55/672155/2/check/nova-lvm/63f06cc/ : FAILURE in 59m 33s (non-voting)\n- nova-multiattach http://logs.openstack.org/55/672155/2/check/nova-multiattach/84f26e1/ : SUCCESS in 1h 17m 26s\n- nova-next http://logs.openstack.org/55/672155/2/check/nova-next/edc54d2/ : SUCCESS in 1h 27m 12s\n- tempest-slow http://logs.openstack.org/55/672155/2/check/tempest-slow/83d8339/ : SUCCESS in 2h 12m 10s\n- nova-tox-functional http://logs.openstack.org/55/672155/2/check/nova-tox-functional/a75a7d7/ : SUCCESS in 19m 37s\n- nova-tox-functional-py35 http://logs.openstack.org/55/672155/2/check/nova-tox-functional-py35/9000994/ : SUCCESS in 17m 53s\n- openstack-tox-lower-constraints http://logs.openstack.org/55/672155/2/check/openstack-tox-lower-constraints/e107120/ : SUCCESS in 12m 39s\n- neutron-grenade-multinode http://logs.openstack.org/55/672155/2/check/neutron-grenade-multinode/ebf4646/ : SUCCESS in 57m 43s\n- devstack-plugin-ceph-tempest http://logs.openstack.org/55/672155/2/check/devstack-plugin-ceph-tempest/84097a8/ : SUCCESS in 1h 00m 19s (non-voting)\n- tempest-multinode-full http://logs.openstack.org/55/672155/2/check/tempest-multinode-full/436c48e/ : SUCCESS in 1h 47m 23s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"a0337ebb30ce3c375cd50663caa50ecbc89bc648","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-07-31 20:09:45.000000000","message":"Patch Set 2: Code-Review+2\n\nClean backport from stable/stein, lgtm.","accounts_in_message":[],"_revision_number":2},{"id":"49fefddeba95997c893492811221bebdd649257f","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2019-08-01 11:29:56.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nLGTM","accounts_in_message":[],"_revision_number":2},{"id":"9e5da2b0318cb4ecd52d47628531a015a3d9173b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-01 12:42:44.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"a1f849f57e92cff0451fadba99058ef8ed7d905b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-01 15:04:07.000000000","message":"Patch Set 2:\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"e65b525f377c214038d88271e13a8f97b471b553","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-01 21:31:37.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://logs.opendev.org/55/672155/2/gate/openstack-tox-pep8/c1ee7d3/ : SUCCESS in 10m 22s\n- openstack-tox-py27 https://logs.opendev.org/55/672155/2/gate/openstack-tox-py27/b6a17f4/ : SUCCESS in 15m 16s\n- openstack-tox-py35 https://logs.opendev.org/55/672155/2/gate/openstack-tox-py35/6fd06d4/ : SUCCESS in 19m 12s\n- build-openstack-sphinx-docs https://logs.opendev.org/55/672155/2/gate/build-openstack-sphinx-docs/04600ab/html/ : SUCCESS in 9m 31s\n- tempest-full https://logs.opendev.org/55/672155/2/gate/tempest-full/52ef406/ : SUCCESS in 1h 33m 42s\n- neutron-grenade https://logs.opendev.org/55/672155/2/gate/neutron-grenade/e0b9e5c/ : SUCCESS in 58m 54s\n- tempest-full-py3 https://logs.opendev.org/55/672155/2/gate/tempest-full-py3/e2ee534/ : SUCCESS in 1h 32m 45s\n- nova-cells-v1 https://logs.opendev.org/55/672155/2/gate/nova-cells-v1/849a0d5/ : SUCCESS in 1h 02m 45s\n- nova-live-migration https://logs.opendev.org/55/672155/2/gate/nova-live-migration/5f041cf/ : SUCCESS in 47m 48s\n- nova-multiattach https://logs.opendev.org/55/672155/2/gate/nova-multiattach/d9076fa/ : SUCCESS in 1h 05m 05s\n- nova-next https://logs.opendev.org/55/672155/2/gate/nova-next/5725db2/ : SUCCESS in 1h 22m 58s\n- tempest-slow https://logs.opendev.org/55/672155/2/gate/tempest-slow/8b44d55/ : SUCCESS in 2h 13m 19s\n- nova-tox-functional https://logs.opendev.org/55/672155/2/gate/nova-tox-functional/a5494f6/ : SUCCESS in 18m 59s\n- nova-tox-functional-py35 https://logs.opendev.org/55/672155/2/gate/nova-tox-functional-py35/9c89ce5/ : SUCCESS in 16m 31s\n- openstack-tox-lower-constraints https://logs.opendev.org/55/672155/2/gate/openstack-tox-lower-constraints/e53feb9/ : SUCCESS in 13m 34s","accounts_in_message":[],"_revision_number":2},{"id":"a1409cf0624c9e8cf98430977b1b7efb427083dc","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-01 21:31:38.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"65d2e455e323a627ef228ed57a1f0c86d8252665","revisions":{"2d9376f46395df70b08bb6d7558bf264243dfd8e":{"kind":"REWORK","_number":1,"created":"2019-07-22 19:47:43.000000000","uploader":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"ref":"refs/changes/55/672155/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/55/672155/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/55/672155/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/55/672155/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/55/672155/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/55/672155/1"}}},"commit":{"parents":[{"commit":"b8a2323c64c833128fad93d9db6faf662d63211e","subject":"Merge \"Ignore hw_vif_type for direct, direct-physical vNIC types\" into stable/rocky","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b8a2323c64c833128fad93d9db6faf662d63211e"}]}],"author":{"name":"Artom Lifshitz","email":"alifshit@redhat.com","date":"2019-07-19 15:35:24.000000000","tz":-240},"committer":{"name":"Artom Lifshitz","email":"alifshit@redhat.com","date":"2019-07-22 19:47:37.000000000","tz":-240},"subject":"libvirt: move checking CONF.my_ip to init_host()","message":"libvirt: move checking CONF.my_ip to init_host()\n\nMigrations use the libvirt driver\u0027s get_host_ip_addr() method to\ndetermine the dest_host field of the migration object.\nget_host_ip_addr() checks whether CONF.my_ip is actually assigned to\none of the host\u0027s interfaces. It does so by calling\nget_machine_ips(), which iterates over all of the host\u0027s interfaces.\nIf the host has many interfaces, this can take a long time, and\nintroduces needless delays in processing the migration.\nget_machine_ips() is only used to print a warning, so this patch moves\nthe get_machine_ips() call to a single method in init_host(). This\nway, a warning is still emitted at compute service startup, and\nmigration progress is not needlessly slowed down.\n\nNOTE(artom) While the following paragraph still applies, the poison\npatch will not be backported. Stubbing out use of\nnetiface.interfaces() is still a good thing to do, however.\n\nThis patch also has a chicken and egg problem with the patch on top of\nit, which poisons use of netifaces.interfaces() in tests. While this\npatch fixes all the tests that break with that poison, it starts\nbreaking different tests because of the move of get_machine_ips() into\ninit_host(). Therefore, while not directly related to the bug, this\npatch also preventatively mocks or stubs out any use of\nget_machine_ips() that will get poisoned with the subsequent patch.\n\nCloses-bug: 1837075\nChange-Id: I58a4038b04d5a9c28927d914e71609e4deea3d9f\n(cherry picked from commit 30d8159d4ee51a26a03de1cb134ea64c6c07ffb2)\n(cherry picked from commit 5da3f6cede32005336b5ec0d152f32b5da374728)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2d9376f46395df70b08bb6d7558bf264243dfd8e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2d9376f46395df70b08bb6d7558bf264243dfd8e"}]},"branch":"refs/heads/stable/rocky"},"65d2e455e323a627ef228ed57a1f0c86d8252665":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2019-07-22 19:49:10.000000000","uploader":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"ref":"refs/changes/55/672155/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/55/672155/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/55/672155/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/55/672155/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/55/672155/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/55/672155/2"}}},"commit":{"parents":[{"commit":"b8a2323c64c833128fad93d9db6faf662d63211e","subject":"Merge \"Ignore hw_vif_type for direct, direct-physical vNIC types\" into stable/rocky","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b8a2323c64c833128fad93d9db6faf662d63211e"}]}],"author":{"name":"Artom Lifshitz","email":"alifshit@redhat.com","date":"2019-07-19 15:35:24.000000000","tz":-240},"committer":{"name":"Artom Lifshitz","email":"alifshit@redhat.com","date":"2019-07-22 19:48:43.000000000","tz":-240},"subject":"libvirt: move checking CONF.my_ip to init_host()","message":"libvirt: move checking CONF.my_ip to init_host()\n\nMigrations use the libvirt driver\u0027s get_host_ip_addr() method to\ndetermine the dest_host field of the migration object.\nget_host_ip_addr() checks whether CONF.my_ip is actually assigned to\none of the host\u0027s interfaces. It does so by calling\nget_machine_ips(), which iterates over all of the host\u0027s interfaces.\nIf the host has many interfaces, this can take a long time, and\nintroduces needless delays in processing the migration.\nget_machine_ips() is only used to print a warning, so this patch moves\nthe get_machine_ips() call to a single method in init_host(). This\nway, a warning is still emitted at compute service startup, and\nmigration progress is not needlessly slowed down.\n\nNOTE(artom) While the following paragraph still applies, the poison\npatch will not be backported. Stubbing out use of\nnetifaces.interfaces() is still a good thing to do, however.\n\nThis patch also has a chicken and egg problem with the patch on top of\nit, which poisons use of netifaces.interfaces() in tests. While this\npatch fixes all the tests that break with that poison, it starts\nbreaking different tests because of the move of get_machine_ips() into\ninit_host(). Therefore, while not directly related to the bug, this\npatch also preventatively mocks or stubs out any use of\nget_machine_ips() that will get poisoned with the subsequent patch.\n\nCloses-bug: 1837075\nChange-Id: I58a4038b04d5a9c28927d914e71609e4deea3d9f\n(cherry picked from commit 30d8159d4ee51a26a03de1cb134ea64c6c07ffb2)\n(cherry picked from commit 560317c766afc4a4c4c5017ecfc9ce432fe63ea7)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/65d2e455e323a627ef228ed57a1f0c86d8252665"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/65d2e455e323a627ef228ed57a1f0c86d8252665"}]},"branch":"refs/heads/stable/rocky"}},"requirements":[],"submit_records":[],"submit_requirements":[]}