)]}'
{"nova/network/manager.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"f094cd74d9bf5c82cb65b281f41e8ff109a1b318","unresolved":false,"context_lines":[{"line_number":876,"context_line":""},{"line_number":877,"context_line":"            if self._validate_instance_zone_for_dns_domain(context, instance):"},{"line_number":878,"context_line":"                self.instance_dns_manager.create_entry("},{"line_number":879,"context_line":"                    name, str(fip.address), \"A\", self.instance_dns_domain)"},{"line_number":880,"context_line":"                self.instance_dns_manager.create_entry("},{"line_number":881,"context_line":"                    instance_id, str(fip.address), \"A\","},{"line_number":882,"context_line":"                    self.instance_dns_domain)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUH%2F%2FAsM%3D","line":879,"updated":"2014-01-19 07:55:09.000000000","message":"why do we need this to be changed to str?\nIs this due to the fact that it was once a string and now it is netaddr?\nIt may be worth considering changing the dns_manager_create_entry to work with this datastructure","commit_id":"5fad654c781f2740d59b590d5cc84085a721e392"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"22e82341c6e5790a6dd28a77dfc4c373398cc520","unresolved":false,"context_lines":[{"line_number":858,"context_line":"                vif \u003d vif_obj.VirtualInterface.get_by_instance_and_network("},{"line_number":859,"context_line":"                        context, instance_id, network[\u0027id\u0027])"},{"line_number":860,"context_line":"                values \u003d {\u0027allocated\u0027: True,"},{"line_number":861,"context_line":"                          \u0027virtual_interface_id\u0027: vif[\u0027id\u0027]}"},{"line_number":862,"context_line":"                self.db.fixed_ip_update(context, str(fip.address), values)"},{"line_number":863,"context_line":"                self._do_trigger_security_group_members_refresh_for_instance("},{"line_number":864,"context_line":"                    instance_id)"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAUH%2F9oOQ%3D","line":861,"updated":"2014-02-05 14:56:34.000000000","message":"why not vif.id - this is an object?","commit_id":"f93d97a15795c349bd93a4cf9605f2bfd27c510c"},{"author":{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},"change_message_id":"031432a415ceb5a67880a03eacc2551234af5662","unresolved":false,"context_lines":[{"line_number":858,"context_line":"                vif \u003d vif_obj.VirtualInterface.get_by_instance_and_network("},{"line_number":859,"context_line":"                        context, instance_id, network[\u0027id\u0027])"},{"line_number":860,"context_line":"                values \u003d {\u0027allocated\u0027: True,"},{"line_number":861,"context_line":"                          \u0027virtual_interface_id\u0027: vif[\u0027id\u0027]}"},{"line_number":862,"context_line":"                self.db.fixed_ip_update(context, str(fip.address), values)"},{"line_number":863,"context_line":"                self._do_trigger_security_group_members_refresh_for_instance("},{"line_number":864,"context_line":"                    instance_id)"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAUH%2F9ewI%3D","line":861,"in_reply_to":"AAAAUH%2F9mY8%3D","updated":"2014-02-06 16:23:26.000000000","message":"Seconded, but it looks like some overzealous refactoring more than anything. I\u0027m not worried about it, personally.","commit_id":"f93d97a15795c349bd93a4cf9605f2bfd27c510c"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"e98961b94c3f5ea106ef7a216e64acff8ceb151f","unresolved":false,"context_lines":[{"line_number":858,"context_line":"                vif \u003d vif_obj.VirtualInterface.get_by_instance_and_network("},{"line_number":859,"context_line":"                        context, instance_id, network[\u0027id\u0027])"},{"line_number":860,"context_line":"                values \u003d {\u0027allocated\u0027: True,"},{"line_number":861,"context_line":"                          \u0027virtual_interface_id\u0027: vif[\u0027id\u0027]}"},{"line_number":862,"context_line":"                self.db.fixed_ip_update(context, str(fip.address), values)"},{"line_number":863,"context_line":"                self._do_trigger_security_group_members_refresh_for_instance("},{"line_number":864,"context_line":"                    instance_id)"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAUH%2F9mY8%3D","line":861,"in_reply_to":"AAAAUH%2F9oOQ%3D","updated":"2014-02-05 18:49:50.000000000","message":"It does seem a little strange to change the access method for this, since it\u0027s unrelated to the other work here.","commit_id":"f93d97a15795c349bd93a4cf9605f2bfd27c510c"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"22e82341c6e5790a6dd28a77dfc4c373398cc520","unresolved":false,"context_lines":[{"line_number":859,"context_line":"                        context, instance_id, network[\u0027id\u0027])"},{"line_number":860,"context_line":"                values \u003d {\u0027allocated\u0027: True,"},{"line_number":861,"context_line":"                          \u0027virtual_interface_id\u0027: vif[\u0027id\u0027]}"},{"line_number":862,"context_line":"                self.db.fixed_ip_update(context, str(fip.address), values)"},{"line_number":863,"context_line":"                self._do_trigger_security_group_members_refresh_for_instance("},{"line_number":864,"context_line":"                    instance_id)"},{"line_number":865,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAUH%2F9oN8%3D","line":862,"updated":"2014-02-05 14:56:34.000000000","message":"any reason not use an object here - or is that a later patch set?","commit_id":"f93d97a15795c349bd93a4cf9605f2bfd27c510c"},{"author":{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},"change_message_id":"031432a415ceb5a67880a03eacc2551234af5662","unresolved":false,"context_lines":[{"line_number":859,"context_line":"                        context, instance_id, network[\u0027id\u0027])"},{"line_number":860,"context_line":"                values \u003d {\u0027allocated\u0027: True,"},{"line_number":861,"context_line":"                          \u0027virtual_interface_id\u0027: vif[\u0027id\u0027]}"},{"line_number":862,"context_line":"                self.db.fixed_ip_update(context, str(fip.address), values)"},{"line_number":863,"context_line":"                self._do_trigger_security_group_members_refresh_for_instance("},{"line_number":864,"context_line":"                    instance_id)"},{"line_number":865,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAUH%2F9exo%3D","line":862,"in_reply_to":"AAAAUH%2F9oN8%3D","updated":"2014-02-06 16:23:26.000000000","message":"He mentions in the comment this patch is only for the associate* calls","commit_id":"f93d97a15795c349bd93a4cf9605f2bfd27c510c"}]}