)]}'
{"id":"openstack%2Fnova~672559","triplet_id":"openstack%2Fnova~master~I7d761dc269f8c12c4a76ba14201ccdd82a04d01d","project":"openstack/nova","branch":"master","topic":"bug/1195361","hashtags":[],"change_id":"I7d761dc269f8c12c4a76ba14201ccdd82a04d01d","subject":"Revert \"[libvirt] Filter hypervisor_type by virt_type\"","status":"MERGED","created":"2019-07-24 16:22:52.000000000","updated":"2019-07-25 17:24:56.000000000","submitted":"2019-07-25 14:01:04.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"672559-1564063265067-67437c28","meta_rev_id":"c720066d0ab0af2bdab8a8103c2134457a52d630","_number":672559,"virtual_id_number":672559,"owner":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2019-07-24 20:22:04.000000000","_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"date":"2019-07-24 22:43:46.000000000","_account_id":16898,"name":"Virtuozzo CI","email":"virtuozzo6-ci@virtuozzo.com","username":"virtuozzo6-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"date":"2019-07-24 21:11:22.000000000","_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":21030,"name":"massimo.sgaravatto","email":"massimo.sgaravatto@gmail.com"},{"value":0,"date":"2019-07-24 19:32:51.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"date":"2019-07-24 20:55:09.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"value":0,"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},{"value":2,"date":"2019-07-25 14:01:04.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},{"value":0,"date":"2019-07-25 03:21:12.000000000","_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"value":0,"date":"2019-07-25 17:24:56.000000000","post_submit":true,"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"date":"2019-07-24 21:12:43.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":15286,"name":"XenProject CI","email":"openstack-ci@xenproject.org","username":"XenProject-CI","tags":["SERVICE_USER"]},{"value":0,"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":0,"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":16898,"name":"Virtuozzo CI","email":"virtuozzo6-ci@virtuozzo.com","username":"virtuozzo6-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":21030,"name":"massimo.sgaravatto","email":"massimo.sgaravatto@gmail.com"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":2,"date":"2019-07-25 11:12:45.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"value":0,"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},{"value":0,"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"value":0,"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":1,"date":"2019-07-25 03:40:04.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":2,"date":"2019-07-24 21:30:24.000000000","_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":15286,"name":"XenProject CI","email":"openstack-ci@xenproject.org","username":"XenProject-CI","tags":["SERVICE_USER"]},{"value":1,"date":"2019-07-25 11:15:41.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":1,"date":"2019-07-25 05:47:43.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":0,"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":16898,"name":"Virtuozzo CI","email":"virtuozzo6-ci@virtuozzo.com","username":"virtuozzo6-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"value":0,"date":"2019-07-24 16:30:01.000000000","_account_id":21030,"name":"massimo.sgaravatto","email":"massimo.sgaravatto@gmail.com"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":1,"date":"2019-07-25 11:12:45.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"value":0,"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},{"value":0,"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"value":0,"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":15286,"name":"XenProject CI","email":"openstack-ci@xenproject.org","username":"XenProject-CI","tags":["SERVICE_USER"]},{"value":0,"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":0,"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":16898,"name":"Virtuozzo CI","email":"virtuozzo6-ci@virtuozzo.com","username":"virtuozzo6-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":21030,"name":"massimo.sgaravatto","email":"massimo.sgaravatto@gmail.com"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"value":0,"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},{"value":0,"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"value":0,"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":15286,"name":"XenProject CI","email":"openstack-ci@xenproject.org","username":"XenProject-CI","tags":["SERVICE_USER"]},{"value":0,"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":0,"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"_account_id":15286,"name":"XenProject CI","email":"openstack-ci@xenproject.org","username":"XenProject-CI","tags":["SERVICE_USER"]},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"_account_id":16898,"name":"Virtuozzo CI","email":"virtuozzo6-ci@virtuozzo.com","username":"virtuozzo6-ci","tags":["SERVICE_USER"]},{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},{"_account_id":21030,"name":"massimo.sgaravatto","email":"massimo.sgaravatto@gmail.com"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-07-24 16:22:52.000000000","updated_by":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"reviewer":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"state":"REVIEWER"},{"updated":"2019-07-24 16:22:52.000000000","updated_by":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"reviewer":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"state":"REVIEWER"},{"updated":"2019-07-24 16:22:52.000000000","updated_by":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"reviewer":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"state":"REVIEWER"},{"updated":"2019-07-24 16:22:52.000000000","updated_by":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"reviewer":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"state":"REVIEWER"},{"updated":"2019-07-24 16:22:52.000000000","updated_by":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"reviewer":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"state":"REVIEWER"},{"updated":"2019-07-24 16:22:52.000000000","updated_by":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-07-24 16:22:52.000000000","updated_by":{"_account_id":15286,"name":"XenProject CI","email":"openstack-ci@xenproject.org","username":"XenProject-CI","tags":["SERVICE_USER"]},"reviewer":{"_account_id":15286,"name":"XenProject CI","email":"openstack-ci@xenproject.org","username":"XenProject-CI","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-07-24 16:22:52.000000000","updated_by":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"reviewer":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"state":"REVIEWER"},{"updated":"2019-07-24 16:30:01.000000000","updated_by":{"_account_id":21030,"name":"massimo.sgaravatto","email":"massimo.sgaravatto@gmail.com"},"reviewer":{"_account_id":21030,"name":"massimo.sgaravatto","email":"massimo.sgaravatto@gmail.com"},"state":"REVIEWER"},{"updated":"2019-07-24 19:32:51.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-07-24 20:22:04.000000000","updated_by":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-07-24 20:55:09.000000000","updated_by":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"reviewer":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"state":"REVIEWER"},{"updated":"2019-07-24 21:11:22.000000000","updated_by":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-07-24 21:12:43.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2019-07-24 21:30:24.000000000","updated_by":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"reviewer":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"state":"REVIEWER"},{"updated":"2019-07-24 22:43:46.000000000","updated_by":{"_account_id":16898,"name":"Virtuozzo CI","email":"virtuozzo6-ci@virtuozzo.com","username":"virtuozzo6-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":16898,"name":"Virtuozzo CI","email":"virtuozzo6-ci@virtuozzo.com","username":"virtuozzo6-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-07-25 03:21:12.000000000","updated_by":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-07-25 03:40:04.000000000","updated_by":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"reviewer":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"state":"REVIEWER"},{"updated":"2019-07-25 05:47:43.000000000","updated_by":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"reviewer":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"state":"REVIEWER"},{"updated":"2019-07-25 11:12:45.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2019-07-25 11:15:41.000000000","updated_by":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"reviewer":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"state":"REVIEWER"},{"updated":"2019-07-25 14:01:04.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-07-25 17:24:56.000000000","updated_by":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"d3657b55510130ccb632b98ab595c121c3757f43","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-07-24 16:22:52.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a1781e3710167debc7264771fe92aa4b87b76c05","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-24 16:25:08.000000000","message":"Patch Set 1: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":1},{"id":"93b27fcdf6c3239dd810c215b4a1c536b109858e","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-07-24 16:25:10.000000000","message":"Patch Set 1: Workflow-1\n\nRebasing.","accounts_in_message":[],"_revision_number":1},{"id":"f81d214073216b2ecd680a165241a6ab898be879","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-07-24 16:28:34.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"752d595b25f161011af37f45730a1dc09b29cad9","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2019-07-24 19:32:51.000000000","message":"Patch Set 2:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/59/672559/2/check/tempest-dsvm-full-xenial/0a13a11/ : SUCCESS in 1h 26m 03s\n- tempest-dsvm-full-xenial-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/59/672559/2/check/tempest-dsvm-full-xenial-py3/6813b79/ : SUCCESS in 1h 39m 29s (non-voting)\n- grenade-dsvm-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/59/672559/2/check/grenade-dsvm-xenial/4a2a941/ : SUCCESS in 1h 22m 04s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"97b734b52d05e917f17367249f8e9d881d59177c","author":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"date":"2019-07-24 20:22:04.000000000","message":"Patch Set 2:\n\nBuild failed. Comment \u0027powervm: recheck\u0027 to recheck.\n For 3rd party CI contact info: https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_PowerVM_CI\n\n- nova-out-of-tree-pvm http://184.172.12.213/59/672559/2/check/nova-out-of-tree-pvm/9a27cd4 : FAILURE in 3h 45m 13s\n- nova-in-tree-pvm http://184.172.12.213/59/672559/2/check/nova-in-tree-pvm/0032275 : FAILURE in 1m 43s","accounts_in_message":[],"_revision_number":2},{"id":"7d4bfa610704830fd54711a8dcaf06a98bf0fc92","author":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"date":"2019-07-24 20:55:09.000000000","message":"Patch Set 2:\n\nTesting completed on the zVM Driver CI system check-nova pipeline and failed.  To recheck only the zVM driver plugins, submit a comment with only  zvm: recheck in the comment.. Contact information: zvmosci@us.ibm.com. For information see https://wiki.openstack.org/wiki/ZVMDriver.\n\n- check-nova-master http://extbasicopstackcilog01.podc.sl.edst.ibm.com/test_logs/jenkins-check-nova-master-34244 : FAILURE in 2h 18m 08s","accounts_in_message":[],"_revision_number":2},{"id":"a21abf227e73dfcad8b681fd222c6f15f2c19f7c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-24 21:10:52.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade-py3 http://logs.openstack.org/59/672559/2/check/grenade-py3/dce7518/ : SUCCESS in 1h 09m 42s\n- tempest-full-py3 http://logs.openstack.org/59/672559/2/check/tempest-full-py3/1156016/ : SUCCESS in 1h 43m 28s\n- openstack-tox-cover http://logs.openstack.org/59/672559/2/check/openstack-tox-cover/ae72f99/cover/ : SUCCESS in 17m 46s\n- openstack-tox-lower-constraints http://logs.openstack.org/59/672559/2/check/openstack-tox-lower-constraints/b4aa415/ : SUCCESS in 20m 11s\n- openstack-tox-pep8 http://logs.openstack.org/59/672559/2/check/openstack-tox-pep8/9676442/ : SUCCESS in 10m 27s\n- openstack-tox-py27 http://logs.openstack.org/59/672559/2/check/openstack-tox-py27/9dea88b/ : SUCCESS in 22m 10s\n- openstack-tox-py36 http://logs.openstack.org/59/672559/2/check/openstack-tox-py36/41ff183/ : SUCCESS in 16m 37s\n- openstack-tox-py37 http://logs.openstack.org/59/672559/2/check/openstack-tox-py37/cab5cf3/ : SUCCESS in 17m 37s\n- openstack-tox-docs http://logs.openstack.org/59/672559/2/check/openstack-tox-docs/5b909cf/html/ : SUCCESS in 7m 13s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa http://logs.openstack.org/59/672559/2/check/ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa/4317102/ : SUCCESS in 48m 43s (non-voting)\n- devstack-plugin-ceph-tempest http://logs.openstack.org/59/672559/2/check/devstack-plugin-ceph-tempest/abec54f/ : SUCCESS in 1h 06m 03s (non-voting)\n- neutron-grenade-multinode http://logs.openstack.org/59/672559/2/check/neutron-grenade-multinode/082dc56/ : SUCCESS in 1h 14m 54s\n- nova-grenade-live-migration http://logs.openstack.org/59/672559/2/check/nova-grenade-live-migration/5ef525f/ : SUCCESS in 1h 06m 49s\n- nova-live-migration http://logs.openstack.org/59/672559/2/check/nova-live-migration/d23d19a/ : SUCCESS in 52m 44s\n- nova-lvm http://logs.openstack.org/59/672559/2/check/nova-lvm/c6dad52/ : SUCCESS in 50m 06s (non-voting)\n- nova-multi-cell http://logs.openstack.org/59/672559/2/check/nova-multi-cell/18a944d/ : SUCCESS in 1h 50m 26s (non-voting)\n- nova-next http://logs.openstack.org/59/672559/2/check/nova-next/f2a2055/ : SUCCESS in 1h 31m 07s\n- nova-tox-functional http://logs.openstack.org/59/672559/2/check/nova-tox-functional/4ce1748/ : SUCCESS in 25m 09s\n- nova-tox-functional-py36 http://logs.openstack.org/59/672559/2/check/nova-tox-functional-py36/a67eb20/ : SUCCESS in 21m 54s\n- tempest-slow-py3 http://logs.openstack.org/59/672559/2/check/tempest-slow-py3/52a1138/ : SUCCESS in 2h 33m 29s","accounts_in_message":[],"_revision_number":2},{"id":"3df5e926d520a264da10cad1e2f29f2931c5e20e","author":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"date":"2019-07-24 21:11:22.000000000","message":"Patch Set 2:\n\nBuild failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\n- EMC_VxFlexOS_NOVA http://publiclogs.emc.com/59/672559/2/check/EMC_VxFlexOS_NOVA/d3b0a06/EMC_VxFlexOS_NOVA/None : NOT_REGISTERED\n\nLeave a comment with \u0027run-DellEMC VxFlexOS CI\u0027 to trigger a recheck. For more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_VxFlexOS_CI","accounts_in_message":[],"_revision_number":2},{"id":"a956ec235b66022a7a2b7f6292b20b77489243bb","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-07-24 21:12:43.000000000","message":"Patch Set 2:\n\nBuild succeeded.\n\n- nova http://cloudbase-ci.com/nova/672559/2 : SUCCESS in 2h 26m 30s","accounts_in_message":[],"_revision_number":2},{"id":"1e04ca500aa8ebc3d98788c4570ba1c3a4c2b4b6","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-07-24 21:30:24.000000000","message":"Patch Set 2: Code-Review+2\n\nThe problem is real, the revert is clean (given I5d95bd502), lgtm.","accounts_in_message":[],"_revision_number":2},{"id":"8f76e3166f003c65d1b364803feeb47762071928","author":{"_account_id":16898,"name":"Virtuozzo CI","email":"virtuozzo6-ci@virtuozzo.com","username":"virtuozzo6-ci","tags":["SERVICE_USER"]},"date":"2019-07-24 22:43:46.000000000","message":"Patch Set 2:\n\nBuild failed\n\n- check-dsvm-tempest-vz7-exe-minimal http://openstack-3rd-party-virtuozzo-ci-logs.virtuozzo.com/59/672559/2/check/check-dsvm-tempest-vz7-exe-minimal/f01f770 : FAILURE in 16m 27s\n- check-dsvm-tempest-vz7-exe-multinode http://openstack-3rd-party-virtuozzo-ci-logs.virtuozzo.com/59/672559/2/check/check-dsvm-tempest-vz7-exe-multinode/8dbb6bb : FAILURE in 12m 05s\n\nFor information, see https://wiki.openstack.org/wiki/ThirdPartySystems/Virtuozzo_CI Make the comment \u0027run-Virtuozzo CI\u0027 to recheck","accounts_in_message":[],"_revision_number":2},{"id":"611f870216e05c80ad1e20dadc98efc2fb19c6b6","author":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"date":"2019-07-25 03:21:12.000000000","message":"Patch Set 2:\n\n* nova-quobyteci-dsvm-volume http://78.46.57.153:8081/refs-changes-59-672559-2 : SUCCESS \n\nhttps://wiki.openstack.org/wiki/ThirdPartySystems/Quobyte_CI","accounts_in_message":[],"_revision_number":2},{"id":"1e280499ac2c731616596456ea4c70e4d0eec104","author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"date":"2019-07-25 03:40:04.000000000","message":"Patch Set 2: Code-Review+1\n\nLGTM","accounts_in_message":[],"_revision_number":2},{"id":"eb5e6660e9cff11a8b46dcb9d69630005a1c8f59","author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"date":"2019-07-25 05:47:43.000000000","message":"Patch Set 2: Code-Review+1\n\nlgtm","accounts_in_message":[],"_revision_number":2},{"id":"064843113afe1caab7434cb2f9ce5306b5a2f0d7","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2019-07-25 11:12:45.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"8b10671e596f6380ff48205f450ee5391682823a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-25 11:15:19.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"34d0667dacdc37721b5d0889a2904cb4e12e08c8","author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"date":"2019-07-25 11:15:41.000000000","message":"Patch Set 2: Code-Review+1\n\nRight, we have several ways to work around to distinguish qemu vs. kvm hosts, while it is harder to keep the \"hypervisor_type\u003dQEMU\" filter backward compatible.\n\nAn alternative could be to change kvm hosts to say that they support both qemu and kvm for backward compat and qemu hosts to say that they just support qemu, but I don\u0027t think that\u0027s a great idea since instances that land on kvm hosts are always accelerated by kvm. No release note issued in Rocky about this. I am agreed to revert. Thank you for remembering this change m(__)m","accounts_in_message":[],"_revision_number":2},{"id":"cafeee64e3c0c0a398b1e0dd02faebe1608baec6","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-25 14:01:04.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- grenade-py3 http://logs.openstack.org/59/672559/2/gate/grenade-py3/10af1b2/ : SUCCESS in 1h 08m 37s\n- tempest-full-py3 http://logs.openstack.org/59/672559/2/gate/tempest-full-py3/a1a7b93/ : SUCCESS in 1h 18m 32s\n- openstack-tox-lower-constraints http://logs.openstack.org/59/672559/2/gate/openstack-tox-lower-constraints/1b2b8e4/ : SUCCESS in 19m 48s\n- openstack-tox-pep8 http://logs.openstack.org/59/672559/2/gate/openstack-tox-pep8/9ccf345/ : SUCCESS in 11m 35s\n- openstack-tox-py27 http://logs.openstack.org/59/672559/2/gate/openstack-tox-py27/13ef983/ : SUCCESS in 17m 35s\n- openstack-tox-py36 http://logs.openstack.org/59/672559/2/gate/openstack-tox-py36/fe0ffe1/ : SUCCESS in 15m 47s\n- openstack-tox-py37 http://logs.openstack.org/59/672559/2/gate/openstack-tox-py37/788f8be/ : SUCCESS in 17m 18s\n- openstack-tox-docs http://logs.openstack.org/59/672559/2/gate/openstack-tox-docs/247a409/html/ : SUCCESS in 7m 19s\n- nova-grenade-live-migration http://logs.openstack.org/59/672559/2/gate/nova-grenade-live-migration/e4b1504/ : SUCCESS in 1h 10m 00s\n- nova-live-migration http://logs.openstack.org/59/672559/2/gate/nova-live-migration/f8bc7b9/ : SUCCESS in 55m 19s\n- nova-tox-functional http://logs.openstack.org/59/672559/2/gate/nova-tox-functional/887a49a/ : SUCCESS in 25m 11s\n- nova-tox-functional-py36 http://logs.openstack.org/59/672559/2/gate/nova-tox-functional-py36/5a0220c/ : SUCCESS in 21m 55s\n- nova-next http://logs.openstack.org/59/672559/2/gate/nova-next/df24733/ : SUCCESS in 1h 21m 23s\n- tempest-slow-py3 http://logs.openstack.org/59/672559/2/gate/tempest-slow-py3/b96314a/ : SUCCESS in 2h 28m 34s","accounts_in_message":[],"_revision_number":2},{"id":"5c02d17e565633b1b060a6b5f0cf407fbffebbdb","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-25 14:01:05.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"ce016a015ded5a9402ecc05719df1fa04d325652","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2019-07-25 17:24:56.000000000","message":"Patch Set 2:\n\nBuild succeeded\n\n- dsvm-nova http://207.189.188.190/logs/59/672559/2/check-vote/ext-nova-zuul/a989d40 : SUCCESS in 51m 02s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"743dc083bb5628554d9abfa82665738233ed47e9","revisions":{"81a82d9d8036a324e879e0805af4564722ee1e00":{"kind":"REWORK","_number":1,"created":"2019-07-24 16:22:52.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/59/672559/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/59/672559/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/59/672559/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/59/672559/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/59/672559/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/59/672559/1"}}},"commit":{"parents":[{"commit":"eaa766ee2093c24fd61c61e52f46bdd9ff9e93d2","subject":"[libvirt] Filter hypervisor_type by virt_type","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/eaa766ee2093c24fd61c61e52f46bdd9ff9e93d2"}]}],"author":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-07-24 16:22:52.000000000","tz":0},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-07-24 16:22:52.000000000","tz":0},"subject":"Revert \"[libvirt] Filter hypervisor_type by virt_type\"","message":"Revert \"[libvirt] Filter hypervisor_type by virt_type\"\n\nThis reverts commit eaa766ee2093c24fd61c61e52f46bdd9ff9e93d2.\n\nThe change regressed the behavior of the ImagePropertiesFilter\nbecause existing images with hypervisor_type\u003dQEMU, which would\nmatch what is reported for hypervisor_type in the API for both\nqemu/kvm virt_type nodes, will now get filtered out for hosts\nwhere the configured virt_type is kvm.\n\nNote that both the ImagePropertiesFilter docs [1] and\nhypervisor_type image property docs [2] mention that for both\nqemu and kvm nodes the value to use is qemu since that is the\nactual hypervisor.\n\nPresumably the change was made for a deployment with some\nhosts configured with virt_type\u003dqemu and other hosts configured\nwith virt_type\u003dkvm and there were separate images with\nhypervisor_type\u003dqemu and hypervisor_type\u003dkvm to match those hosts\nfor scheduler filter, but as noted this was a regression in\nbehavior for something that could have been achieved using\nhost aggregates and the AggregateImagePropertiesIsolation filter.\n\nWe could even use traits and a placement request pre-filter these\ndays for a more modern approach.\n\nAlso, since the API continues to report hypervisor_type\u003dQEMU it\u0027s\ndoubly confusing for operators to have to configure their images\nto use hypervisor_type\u003dkvm (despite the docs).\n\nAnd finally, any existing instances which have hypervisor_type\u003dqemu\nembedded in their RequestSpec can no longer be migrated to kvm\nhosts without manually fixing the entries in the request_specs\ntable in the API DB.\n\n[1] https://docs.openstack.org/nova/latest/admin/configuration/schedulers.html#imagepropertiesfilter\n[2] https://docs.openstack.org/glance/latest/admin/useful-image-properties.html\n\nChange-Id: I7d761dc269f8c12c4a76ba14201ccdd82a04d01d\nCloses-Bug: #1837756\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/81a82d9d8036a324e879e0805af4564722ee1e00"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/81a82d9d8036a324e879e0805af4564722ee1e00"}]},"branch":"refs/heads/master"},"743dc083bb5628554d9abfa82665738233ed47e9":{"kind":"REWORK","_number":2,"created":"2019-07-24 16:28:34.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/59/672559/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/59/672559/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/59/672559/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/59/672559/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/59/672559/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/59/672559/2"}}},"commit":{"parents":[{"commit":"0c39090bd7d45ee86bd4b399e39295f5fc723972","subject":"Merge \"Remove test_pre_live_migration_instance_has_no_fixed_ip\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/0c39090bd7d45ee86bd4b399e39295f5fc723972"}]}],"author":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-07-24 16:22:52.000000000","tz":0},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-07-24 16:25:34.000000000","tz":-240},"subject":"Revert \"[libvirt] Filter hypervisor_type by virt_type\"","message":"Revert \"[libvirt] Filter hypervisor_type by virt_type\"\n\nThis reverts commit eaa766ee2093c24fd61c61e52f46bdd9ff9e93d2.\n\nThe change regressed the behavior of the ImagePropertiesFilter\nbecause existing images with hypervisor_type\u003dQEMU, which would\nmatch what is reported for hypervisor_type in the API for both\nqemu/kvm virt_type nodes, will now get filtered out for hosts\nwhere the configured virt_type is kvm.\n\nNote that both the ImagePropertiesFilter docs [1] and\nhypervisor_type image property docs [2] mention that for both\nqemu and kvm nodes the value to use is qemu since that is the\nactual hypervisor.\n\nPresumably the change was made for a deployment with some\nhosts configured with virt_type\u003dqemu and other hosts configured\nwith virt_type\u003dkvm and there were separate images with\nhypervisor_type\u003dqemu and hypervisor_type\u003dkvm to match those hosts\nfor scheduler filter, but as noted this was a regression in\nbehavior for something that could have been achieved using\nhost aggregates and the AggregateImagePropertiesIsolation filter.\n\nWe could even use traits and a placement request pre-filter these\ndays for a more modern approach.\n\nAlso, since the API continues to report hypervisor_type\u003dQEMU it\u0027s\ndoubly confusing for operators to have to configure their images\nto use hypervisor_type\u003dkvm (despite the docs).\n\nAnd finally, any existing instances which have hypervisor_type\u003dqemu\nembedded in their RequestSpec can no longer be migrated to kvm\nhosts without manually fixing the entries in the request_specs\ntable in the API DB.\n\nNote that this is not a clean revert because of change\nI5d95bd50279a6bf903a5793ad5f3ae9d06f085f4 made in Stein.\n\n[1] https://docs.openstack.org/nova/latest/admin/configuration/schedulers.html#imagepropertiesfilter\n[2] https://docs.openstack.org/glance/latest/admin/useful-image-properties.html\n\nChange-Id: I7d761dc269f8c12c4a76ba14201ccdd82a04d01d\nCloses-Bug: #1837756\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/743dc083bb5628554d9abfa82665738233ed47e9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/743dc083bb5628554d9abfa82665738233ed47e9"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
