)]}'
{"gate/post_test_hook.sh":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3e0dde2ddabd4b5c205cf76fad3a147dfd912cb4","unresolved":false,"context_lines":[{"line_number":10,"context_line":"        return 1"},{"line_number":11,"context_line":"    fi"},{"line_number":12,"context_line":"    for i in `seq 30`; do"},{"line_number":13,"context_line":"        $MANAGE $* db archive_deleted_rows --verbose --max_rows 1000 --before \"$(date -d tomorrow)\" --all-cells"},{"line_number":14,"context_line":"        RET\u003d$?"},{"line_number":15,"context_line":"        if [[ $RET -gt 1 ]]; then"},{"line_number":16,"context_line":"            echo Archiving failed with result $RET"}],"source_content_type":"text/x-sh","patch_set":4,"id":"7faddb67_525e0177","line":13,"updated":"2019-08-07 20:30:14.000000000","message":"Thinking about this again, we lose the non-all-cells behavior coverage with this change. The call above doesn\u0027t get into the actual archive because it\u0027s testing that --before with yesterday won\u0027t find anything.\n\nWould it be worthwhile to call archive without --all-cells when $i \u003d\u003d 1? That would hit cell0 specifically and then the next iterations would use --all-cells. The only danger there is if that first and only call returns 0 then we\u0027d stop below. We could probably mitigate that by passing in a low --max_rows value.","commit_id":"e5fe0c911b65bbfa7d5e304e90da4fb2a5a48ef4"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"f6c78e2b3645fa5a0271d55b9bc29afe21b20a78","unresolved":false,"context_lines":[{"line_number":10,"context_line":"        return 1"},{"line_number":11,"context_line":"    fi"},{"line_number":12,"context_line":"    for i in `seq 30`; do"},{"line_number":13,"context_line":"        $MANAGE $* db archive_deleted_rows --verbose --max_rows 1000 --before \"$(date -d tomorrow)\" --all-cells"},{"line_number":14,"context_line":"        RET\u003d$?"},{"line_number":15,"context_line":"        if [[ $RET -gt 1 ]]; then"},{"line_number":16,"context_line":"            echo Archiving failed with result $RET"}],"source_content_type":"text/x-sh","patch_set":4,"id":"7faddb67_d2c79c44","line":13,"in_reply_to":"7faddb67_525e0177","updated":"2019-08-19 18:53:24.000000000","message":"Yeah, I\u0027m not sure. I notice \u0027nova-manage db purge\u0027 is only being called with --all-cells currently, so just to note that we\u0027re not testing purge without --all-cells either.\n\nI\u0027ll add another archive call without --all-cells, just so we get some coverage.","commit_id":"e5fe0c911b65bbfa7d5e304e90da4fb2a5a48ef4"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3e0dde2ddabd4b5c205cf76fad3a147dfd912cb4","unresolved":false,"context_lines":[{"line_number":36,"context_line":"BASE\u003d${BASE:-/opt/stack}"},{"line_number":37,"context_line":"source ${BASE}/new/devstack/functions-common"},{"line_number":38,"context_line":"source ${BASE}/new/devstack/lib/nova"},{"line_number":39,"context_line":"cell_conf\u003d$(conductor_conf 1)"},{"line_number":40,"context_line":"# NOTE(danms): We need to pass the main config to get the api db"},{"line_number":41,"context_line":"# bits, and then also the cell config for the cell1 db (instead of"},{"line_number":42,"context_line":"# the cell0 config that is in the main config file). Later files"},{"line_number":43,"context_line":"# take precedence."},{"line_number":44,"context_line":"conf\u003d\"--config-file $NOVA_CONF --config-file $cell_conf\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"archive_deleted_rows $conf"},{"line_number":47,"context_line":"purge_db"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"set -e"}],"source_content_type":"text/x-sh","patch_set":4,"id":"7faddb67_92c0f9e2","line":46,"range":{"start_line":39,"start_character":0,"end_line":46,"end_character":26},"updated":"2019-08-07 20:30:14.000000000","message":"I think we should be able to remove this now, right? This was added so that we\u0027re cleaning up entries from cell1 but also have the API DB config from nova.conf.","commit_id":"e5fe0c911b65bbfa7d5e304e90da4fb2a5a48ef4"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"307b0eeba4bbad3b17203a70145f2007f5fd7867","unresolved":false,"context_lines":[{"line_number":36,"context_line":"BASE\u003d${BASE:-/opt/stack}"},{"line_number":37,"context_line":"source ${BASE}/new/devstack/functions-common"},{"line_number":38,"context_line":"source ${BASE}/new/devstack/lib/nova"},{"line_number":39,"context_line":"cell_conf\u003d$(conductor_conf 1)"},{"line_number":40,"context_line":"# NOTE(danms): We need to pass the main config to get the api db"},{"line_number":41,"context_line":"# bits, and then also the cell config for the cell1 db (instead of"},{"line_number":42,"context_line":"# the cell0 config that is in the main config file). Later files"},{"line_number":43,"context_line":"# take precedence."},{"line_number":44,"context_line":"conf\u003d\"--config-file $NOVA_CONF --config-file $cell_conf\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"archive_deleted_rows $conf"},{"line_number":47,"context_line":"purge_db"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"set -e"}],"source_content_type":"text/x-sh","patch_set":4,"id":"7faddb67_3d2b4a95","line":46,"range":{"start_line":39,"start_character":0,"end_line":46,"end_character":26},"in_reply_to":"7faddb67_1d2c4e97","updated":"2019-08-20 20:46:34.000000000","message":"*facepalm* thank you.","commit_id":"e5fe0c911b65bbfa7d5e304e90da4fb2a5a48ef4"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"f6c78e2b3645fa5a0271d55b9bc29afe21b20a78","unresolved":false,"context_lines":[{"line_number":36,"context_line":"BASE\u003d${BASE:-/opt/stack}"},{"line_number":37,"context_line":"source ${BASE}/new/devstack/functions-common"},{"line_number":38,"context_line":"source ${BASE}/new/devstack/lib/nova"},{"line_number":39,"context_line":"cell_conf\u003d$(conductor_conf 1)"},{"line_number":40,"context_line":"# NOTE(danms): We need to pass the main config to get the api db"},{"line_number":41,"context_line":"# bits, and then also the cell config for the cell1 db (instead of"},{"line_number":42,"context_line":"# the cell0 config that is in the main config file). Later files"},{"line_number":43,"context_line":"# take precedence."},{"line_number":44,"context_line":"conf\u003d\"--config-file $NOVA_CONF --config-file $cell_conf\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"archive_deleted_rows $conf"},{"line_number":47,"context_line":"purge_db"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"set -e"}],"source_content_type":"text/x-sh","patch_set":4,"id":"7faddb67_f2a738bb","line":46,"range":{"start_line":39,"start_character":0,"end_line":46,"end_character":26},"in_reply_to":"7faddb67_92c0f9e2","updated":"2019-08-19 18:53:24.000000000","message":"Yeah, looks like this should be removed.","commit_id":"e5fe0c911b65bbfa7d5e304e90da4fb2a5a48ef4"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"eb256b253bdb756fc8ab717b659edf28a4b86e5e","unresolved":false,"context_lines":[{"line_number":36,"context_line":"BASE\u003d${BASE:-/opt/stack}"},{"line_number":37,"context_line":"source ${BASE}/new/devstack/functions-common"},{"line_number":38,"context_line":"source ${BASE}/new/devstack/lib/nova"},{"line_number":39,"context_line":"cell_conf\u003d$(conductor_conf 1)"},{"line_number":40,"context_line":"# NOTE(danms): We need to pass the main config to get the api db"},{"line_number":41,"context_line":"# bits, and then also the cell config for the cell1 db (instead of"},{"line_number":42,"context_line":"# the cell0 config that is in the main config file). Later files"},{"line_number":43,"context_line":"# take precedence."},{"line_number":44,"context_line":"conf\u003d\"--config-file $NOVA_CONF --config-file $cell_conf\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"archive_deleted_rows $conf"},{"line_number":47,"context_line":"purge_db"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"set -e"}],"source_content_type":"text/x-sh","patch_set":4,"id":"7faddb67_1d2c4e97","line":46,"range":{"start_line":39,"start_character":0,"end_line":46,"end_character":26},"in_reply_to":"7faddb67_f2a738bb","updated":"2019-08-20 20:07:48.000000000","message":"TBC, remove the $conf, not the actual call (that\u0027s why PS8 is failing).","commit_id":"e5fe0c911b65bbfa7d5e304e90da4fb2a5a48ef4"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"829b7f60cad407eff7c26eac1c9fd53e01d4923a","unresolved":false,"context_lines":[{"line_number":41,"context_line":"source ${BASE}/devstack/functions-common"},{"line_number":42,"context_line":"source ${BASE}/devstack/lib/nova"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"purge_db"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"set -e"},{"line_number":47,"context_line":"# We need to get the admin credentials to run the OSC CLIs for Placement."}],"source_content_type":"text/x-sh","patch_set":8,"id":"7faddb67_fdfff2fd","line":44,"updated":"2019-08-20 20:06:59.000000000","message":"Note that since you\u0027ve moved the archive after the purge, purge now fails since it doesn\u0027t purge anything since nothing was archived:\n\n+ /usr/local/bin/nova-manage db purge --all --verbose --all-cells\n+ RET\u003d3\n+ [[ 3 -eq 0 ]]\n+ echo Purge failed with result 3\n\nThe nova-next job doesn\u0027t fail because set -e comes after this, but it\u0027s not really what we want, right?\n\nSo we should probably also move the purge_db call.","commit_id":"c619a7db98451ae82e4f3df3021340b863896527"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"829b7f60cad407eff7c26eac1c9fd53e01d4923a","unresolved":false,"context_lines":[{"line_number":55,"context_line":"deleted_servers\u003d$(openstack server list --deleted --all-projects -c ID -f value)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"# Fail if any deleted servers were found."},{"line_number":58,"context_line":"if [[ \"$deleted_servers\" !\u003d \"\" ]]; then"},{"line_number":59,"context_line":"    echo \"There were unarchived instances found after archiving; failing.\""},{"line_number":60,"context_line":"    exit 1"},{"line_number":61,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":8,"id":"7faddb67_7d13025d","line":58,"updated":"2019-08-20 20:06:59.000000000","message":"This fails because you removed the call to archive:\n\nhttps://object-storage-ca-ymq-1.vexxhost.net/v1/86bbbcfa8ad043109d2d7af530225c72/logs_40/672840/8/check/nova-next/9d13cfb/ara-report/result/d13f888f-d187-4c3b-b5ab-9326f611e534/","commit_id":"c619a7db98451ae82e4f3df3021340b863896527"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"307b0eeba4bbad3b17203a70145f2007f5fd7867","unresolved":false,"context_lines":[{"line_number":55,"context_line":"deleted_servers\u003d$(openstack server list --deleted --all-projects -c ID -f value)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"# Fail if any deleted servers were found."},{"line_number":58,"context_line":"if [[ \"$deleted_servers\" !\u003d \"\" ]]; then"},{"line_number":59,"context_line":"    echo \"There were unarchived instances found after archiving; failing.\""},{"line_number":60,"context_line":"    exit 1"},{"line_number":61,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":8,"id":"7faddb67_3dd7caf0","line":58,"in_reply_to":"7faddb67_7d13025d","updated":"2019-08-20 20:46:34.000000000","message":"Argh, I\u0027m dumb. I forgot the archive commands were in a function right after seeing that they were in a function.","commit_id":"c619a7db98451ae82e4f3df3021340b863896527"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"54f0936ccba2584864605a27cfbbdab81211d2ee","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"set -e"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"archive_deleted_rows"},{"line_number":47,"context_line":"purge_db"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"# We need to get the admin credentials to run the OSC CLIs for Placement."}],"source_content_type":"text/x-sh","patch_set":9,"id":"7faddb67_c562583e","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":20},"updated":"2019-08-21 00:08:57.000000000","message":"Looks like this does actually have to go before \u0027set -e\u0027 because otherwise, it fails the script after the first nova-manage run that returns 1.","commit_id":"beb9ffae1913816d3adbcf8511df01fadfbcedd3"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"dea116629149b7520989f633e99d68b25fce36d1","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"set -e"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"archive_deleted_rows"},{"line_number":47,"context_line":"purge_db"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"# We need to get the admin credentials to run the OSC CLIs for Placement."}],"source_content_type":"text/x-sh","patch_set":9,"id":"7faddb67_c806ef86","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":20},"in_reply_to":"7faddb67_28bd43b0","updated":"2019-08-21 01:44:59.000000000","message":"Note this didn\u0027t make the job say \"FAILED\" though, it says \"POST_FAILURE\" instead.","commit_id":"beb9ffae1913816d3adbcf8511df01fadfbcedd3"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"3ab4a75f3a385696198cc144fd5a7fca4b6d3c0d","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"set -e"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"archive_deleted_rows"},{"line_number":47,"context_line":"purge_db"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"# We need to get the admin credentials to run the OSC CLIs for Placement."}],"source_content_type":"text/x-sh","patch_set":9,"id":"7faddb67_28bd43b0","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":20},"in_reply_to":"7faddb67_c562583e","updated":"2019-08-21 01:41:18.000000000","message":"\u003e Looks like this does actually have to go before \u0027set -e\u0027 because\n \u003e otherwise, it fails the script after the first nova-manage run that\n \u003e returns 1.\n\nhttps://zuul.opendev.org/t/openstack/build/707d40fa5ad54efd8e8ea4ea9d10812e","commit_id":"beb9ffae1913816d3adbcf8511df01fadfbcedd3"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"2d239ac986b979f6eb07fd41716b2d140126e9fa","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"set -e"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"archive_deleted_rows"},{"line_number":47,"context_line":"purge_db"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"# We need to get the admin credentials to run the OSC CLIs for Placement."}],"source_content_type":"text/x-sh","patch_set":9,"id":"7faddb67_d931d5ee","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":20},"in_reply_to":"7faddb67_c806ef86","updated":"2019-08-21 17:37:59.000000000","message":"\u003e Note this didn\u0027t make the job say \"FAILED\" though, it says\n \u003e \"POST_FAILURE\" instead.\n\nI asked in #openstack-infra and was informed that this is expected and normal. Jobs that fail in the post-run stage can only fail with POST_FAILURE:\n\nhttps://zuul-ci.org/docs/zuul/user/jobs.html#build-status","commit_id":"beb9ffae1913816d3adbcf8511df01fadfbcedd3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c6804f83baa22f0314bf64d7894eb98b221738c3","unresolved":false,"context_lines":[{"line_number":10,"context_line":"        return 1"},{"line_number":11,"context_line":"    fi"},{"line_number":12,"context_line":"    for i in `seq 30`; do"},{"line_number":13,"context_line":"        if [[ $i -eq 1 ]]; then"},{"line_number":14,"context_line":"            $MANAGE $* db archive_deleted_rows --verbose --max_rows 50 --before \"$(date -d tomorrow)\""},{"line_number":15,"context_line":"        else"},{"line_number":16,"context_line":"            $MANAGE $* db archive_deleted_rows --verbose --max_rows 1000 --before \"$(date -d tomorrow)\" --all-cells"}],"source_content_type":"text/x-sh","patch_set":11,"id":"7faddb67_d94475ba","line":13,"updated":"2019-08-21 18:17:33.000000000","message":"We should have a comment here - I think this is just a test wrinkle to make sure we\u0027re covering the non-all-cells (cell0) case. This only hits cell0 because we don\u0027t pass in the cell1 config.","commit_id":"eb9e38e1cbd4afedde5f66d6bd9a83bd8c0fd539"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7ac02788e18f06b2c5fd7c5e5aa3c4e2ff812f74","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"set -e"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"purge_db"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"# We need to get the admin credentials to run the OSC CLIs for Placement."},{"line_number":54,"context_line":"set +x"}],"source_content_type":"text/x-sh","patch_set":11,"id":"7faddb67_59fc0571","line":51,"updated":"2019-08-21 18:11:19.000000000","message":"Moving this after set -e is technically unrelated, right? Might be worth doing separately or at least mention in the commit message.","commit_id":"eb9e38e1cbd4afedde5f66d6bd9a83bd8c0fd539"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c6804f83baa22f0314bf64d7894eb98b221738c3","unresolved":false,"context_lines":[{"line_number":61,"context_line":"deleted_servers\u003d$(openstack server list --deleted --all-projects -c ID -f value)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"# Fail if any deleted servers were found."},{"line_number":64,"context_line":"if [[ \"$deleted_servers\" !\u003d \"\" ]]; then"},{"line_number":65,"context_line":"    echo \"There were unarchived instances found after archiving; failing.\""},{"line_number":66,"context_line":"    exit 1"},{"line_number":67,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":11,"id":"7faddb67_1928cddf","line":64,"updated":"2019-08-21 18:17:33.000000000","message":"I think this could also just be:\n\n  if [ \"$deleted_servers\" ]; then\n\nor\n\n  if [ -n \"$deleted_servers\" ]; then","commit_id":"eb9e38e1cbd4afedde5f66d6bd9a83bd8c0fd539"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"4f4d6881cecc8d1551f4b49464f87ba6b16aab92","unresolved":false,"context_lines":[{"line_number":119,"context_line":"# Make sure the allocations are gone."},{"line_number":120,"context_line":"allocations\u003d$(openstack resource provider allocation show ${server_id} \\"},{"line_number":121,"context_line":"              -c resources -f value)"},{"line_number":122,"context_line":"if [[ \"$allocations\" !\u003d \"\" ]]; then"},{"line_number":123,"context_line":"    echo \"Server allocations were not deleted.\""},{"line_number":124,"context_line":"    exit 2"},{"line_number":125,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":11,"id":"7faddb67_bd37d3af","line":122,"updated":"2019-08-27 06:06:57.000000000","message":"Note: this is the precedent I used for the condition on L64.","commit_id":"eb9e38e1cbd4afedde5f66d6bd9a83bd8c0fd539"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a66c904c68d7652b02116064a2f8c488cf2118d1","unresolved":false,"context_lines":[{"line_number":119,"context_line":"# Make sure the allocations are gone."},{"line_number":120,"context_line":"allocations\u003d$(openstack resource provider allocation show ${server_id} \\"},{"line_number":121,"context_line":"              -c resources -f value)"},{"line_number":122,"context_line":"if [[ \"$allocations\" !\u003d \"\" ]]; then"},{"line_number":123,"context_line":"    echo \"Server allocations were not deleted.\""},{"line_number":124,"context_line":"    exit 2"},{"line_number":125,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":11,"id":"7faddb67_b1892c70","line":122,"in_reply_to":"7faddb67_bd37d3af","updated":"2019-08-27 20:55:16.000000000","message":"Heh, and this was probably mine. Do as I say not as I do...","commit_id":"eb9e38e1cbd4afedde5f66d6bd9a83bd8c0fd539"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a66c904c68d7652b02116064a2f8c488cf2118d1","unresolved":false,"context_lines":[{"line_number":5,"context_line":"function archive_deleted_rows {"},{"line_number":6,"context_line":"    # NOTE(danms): Run this a few times to make sure that we end"},{"line_number":7,"context_line":"    # up with nothing more to archive"},{"line_number":8,"context_line":"    if ! $MANAGE $* db archive_deleted_rows --verbose --before \"$(date -d yesterday)\" 2\u003e\u00261 | grep \u0027Nothing was archived\u0027; then"},{"line_number":9,"context_line":"        echo \"Archiving yesterday data should have done nothing\""},{"line_number":10,"context_line":"        return 1"},{"line_number":11,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":12,"id":"7faddb67_31f3fc0b","line":8,"range":{"start_line":8,"start_character":17,"end_line":8,"end_character":19},"updated":"2019-08-27 20:55:16.000000000","message":"Technically we don\u0027t need these anymore either, but we can remove those in a follow up.","commit_id":"1c9de9c7779b1faf9d9542b3e5bd20da70067365"}]}