)]}'
{"nova/network/manager.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"76e43727fc11a54013390fd1b80fc0f08afa3d67","unresolved":false,"context_lines":[{"line_number":441,"context_line":"            for fixed_ip in fixed_ips:"},{"line_number":442,"context_line":"                if not fixed_ip or not fixed_ip.address:"},{"line_number":443,"context_line":"                    continue"},{"line_number":444,"context_line":"                if str(fixed_ip.address) \u003d\u003d fixed_ip_filter:"},{"line_number":445,"context_line":"                    results.append({\u0027instance_uuid\u0027: vif.instance_uuid,"},{"line_number":446,"context_line":"                                    \u0027ip\u0027: fixed_ip.address})"},{"line_number":447,"context_line":"                    continue"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAUH%2F9oPU%3D","line":444,"updated":"2014-02-05 14:54:01.000000000","message":"would it not be more efficient to comvert the fixed_ip_filter to a network ip object and then the comparison is quicker","commit_id":"6c3da23f1803347130b18aa4e4817332e97606b2"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"fc20171c9c3bfee37c6ac111836f64d57c6491c8","unresolved":false,"context_lines":[{"line_number":441,"context_line":"            for fixed_ip in fixed_ips:"},{"line_number":442,"context_line":"                if not fixed_ip or not fixed_ip.address:"},{"line_number":443,"context_line":"                    continue"},{"line_number":444,"context_line":"                if str(fixed_ip.address) \u003d\u003d fixed_ip_filter:"},{"line_number":445,"context_line":"                    results.append({\u0027instance_uuid\u0027: vif.instance_uuid,"},{"line_number":446,"context_line":"                                    \u0027ip\u0027: fixed_ip.address})"},{"line_number":447,"context_line":"                    continue"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAUH%2F9oLA%3D","line":444,"in_reply_to":"AAAAUH%2F9oPU%3D","updated":"2014-02-05 15:03:06.000000000","message":"Um, sure, but I think it\u0027s *really* not worth blocking this whole set over.","commit_id":"6c3da23f1803347130b18aa4e4817332e97606b2"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"76e43727fc11a54013390fd1b80fc0f08afa3d67","unresolved":false,"context_lines":[{"line_number":445,"context_line":"                    results.append({\u0027instance_uuid\u0027: vif.instance_uuid,"},{"line_number":446,"context_line":"                                    \u0027ip\u0027: fixed_ip.address})"},{"line_number":447,"context_line":"                    continue"},{"line_number":448,"context_line":"                if ip_filter.match(str(fixed_ip.address)):"},{"line_number":449,"context_line":"                    results.append({\u0027instance_uuid\u0027: vif.instance_uuid,"},{"line_number":450,"context_line":"                                    \u0027ip\u0027: fixed_ip.address})"},{"line_number":451,"context_line":"                    continue"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAUH%2F9oPM%3D","line":448,"updated":"2014-02-05 14:54:01.000000000","message":"ditto","commit_id":"6c3da23f1803347130b18aa4e4817332e97606b2"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"76e43727fc11a54013390fd1b80fc0f08afa3d67","unresolved":false,"context_lines":[{"line_number":452,"context_line":"                for floating_ip in fixed_ip.floating_ips:"},{"line_number":453,"context_line":"                    if not floating_ip or not floating_ip.address:"},{"line_number":454,"context_line":"                        continue"},{"line_number":455,"context_line":"                    if ip_filter.match(str(floating_ip.address)):"},{"line_number":456,"context_line":"                        results.append({\u0027instance_uuid\u0027: vif.instance_uuid,"},{"line_number":457,"context_line":"                                        \u0027ip\u0027: floating_ip.address})"},{"line_number":458,"context_line":"                        continue"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAUH%2F9oPE%3D","line":455,"updated":"2014-02-05 14:54:01.000000000","message":"ditto","commit_id":"6c3da23f1803347130b18aa4e4817332e97606b2"}]}
