)]}'
{"nova/conf/libvirt.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"909dc8a2f1d2281f9e8120b68725de84d28b2b82","unresolved":false,"context_lines":[{"line_number":552,"context_line":"Possible values:"},{"line_number":553,"context_line":""},{"line_number":554,"context_line":"* The named CPU models listed in ``/usr/share/libvirt/cpu_map.xml`` for"},{"line_number":555,"context_line":"libvirt prior to version 4.7.0 or ``/usr/share/libvirt/cpu_map/*.xml``"},{"line_number":556,"context_line":"for version 4.7.0 and higher."},{"line_number":557,"context_line":""},{"line_number":558,"context_line":"Related options:"},{"line_number":559,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_65418039","line":556,"range":{"start_line":555,"start_character":0,"end_line":556,"end_character":29},"updated":"2019-07-30 13:52:48.000000000","message":"You need to indent these by two spaces or this won\u0027t render as rST","commit_id":"235670e34262e2fd4f8daa63688249406ef7c14b"},{"author":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"change_message_id":"2bb4e102df48c49cf5b4b61e1f19dcb5c811796f","unresolved":false,"context_lines":[{"line_number":552,"context_line":"Possible values:"},{"line_number":553,"context_line":""},{"line_number":554,"context_line":"* The named CPU models listed in ``/usr/share/libvirt/cpu_map.xml`` for"},{"line_number":555,"context_line":"libvirt prior to version 4.7.0 or ``/usr/share/libvirt/cpu_map/*.xml``"},{"line_number":556,"context_line":"for version 4.7.0 and higher."},{"line_number":557,"context_line":""},{"line_number":558,"context_line":"Related options:"},{"line_number":559,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_1e56a85d","line":556,"range":{"start_line":555,"start_character":0,"end_line":556,"end_character":29},"in_reply_to":"7faddb67_65418039","updated":"2019-08-02 08:53:24.000000000","message":"Done","commit_id":"235670e34262e2fd4f8daa63688249406ef7c14b"}],"nova/virt/libvirt/utils.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"909dc8a2f1d2281f9e8120b68725de84d28b2b82","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"RESIZE_SNAPSHOT_NAME \u003d \u0027nova-resize\u0027"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"# Mapping used to convert libvirt cpu features to traits, for more details, see"},{"line_number":48,"context_line":"# https://github.com/libvirt/libvirt/blob/master/src/cpu/cpu_map.xml for libvirt"},{"line_number":49,"context_line":"# prior to version 4.7.0 or"},{"line_number":50,"context_line":"# https://github.com/libvirt/libvirt/blob/master/src/cpu/cpu_map/*.xml thereafter."},{"line_number":51,"context_line":"CPU_TRAITS_MAPPING \u003d {"},{"line_number":52,"context_line":"    \u00273dnow\u0027: os_traits.HW_CPU_X86_3DNOW,"},{"line_number":53,"context_line":"    \u0027abm\u0027: os_traits.HW_CPU_X86_ABM,"},{"line_number":54,"context_line":"    \u0027aes\u0027: os_traits.HW_CPU_X86_AESNI,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_656ae0b3","line":51,"range":{"start_line":47,"start_character":0,"end_line":51,"end_character":22},"updated":"2019-07-30 13:52:48.000000000","message":"This doesn\u0027t really make sense. Just say\n\n  # Mapping used to convert libvirt cpu features to traits, for more details, see\n  # https://github.com/libvirt/libvirt/blob/master/src/cpu/cpu_map/\n\nIt\u0027s GitHub so people can follow the git history for older versions","commit_id":"235670e34262e2fd4f8daa63688249406ef7c14b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"76c93fdeff6dd65da502740ec5dbbb9200c31963","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"RESIZE_SNAPSHOT_NAME \u003d \u0027nova-resize\u0027"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"# Mapping used to convert libvirt cpu features to traits, for more details, see"},{"line_number":48,"context_line":"# https://github.com/libvirt/libvirt/blob/master/src/cpu/cpu_map.xml for libvirt"},{"line_number":49,"context_line":"# prior to version 4.7.0 or"},{"line_number":50,"context_line":"# https://github.com/libvirt/libvirt/blob/master/src/cpu/cpu_map/*.xml thereafter."},{"line_number":51,"context_line":"CPU_TRAITS_MAPPING \u003d {"},{"line_number":52,"context_line":"    \u00273dnow\u0027: os_traits.HW_CPU_X86_3DNOW,"},{"line_number":53,"context_line":"    \u0027abm\u0027: os_traits.HW_CPU_X86_ABM,"},{"line_number":54,"context_line":"    \u0027aes\u0027: os_traits.HW_CPU_X86_AESNI,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_6b2871e1","line":51,"range":{"start_line":47,"start_character":0,"end_line":51,"end_character":22},"in_reply_to":"7faddb67_50f7645a","updated":"2019-07-30 15:51:25.000000000","message":"To be clear, I was only suggesting changes for this entry, which references a GitHub URL rather than a local path. Providing the additional context for the other comments makes sense, since these reference local paths where git log isn\u0027t possible","commit_id":"235670e34262e2fd4f8daa63688249406ef7c14b"},{"author":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"change_message_id":"2bb4e102df48c49cf5b4b61e1f19dcb5c811796f","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"RESIZE_SNAPSHOT_NAME \u003d \u0027nova-resize\u0027"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"# Mapping used to convert libvirt cpu features to traits, for more details, see"},{"line_number":48,"context_line":"# https://github.com/libvirt/libvirt/blob/master/src/cpu/cpu_map.xml for libvirt"},{"line_number":49,"context_line":"# prior to version 4.7.0 or"},{"line_number":50,"context_line":"# https://github.com/libvirt/libvirt/blob/master/src/cpu/cpu_map/*.xml thereafter."},{"line_number":51,"context_line":"CPU_TRAITS_MAPPING \u003d {"},{"line_number":52,"context_line":"    \u00273dnow\u0027: os_traits.HW_CPU_X86_3DNOW,"},{"line_number":53,"context_line":"    \u0027abm\u0027: os_traits.HW_CPU_X86_ABM,"},{"line_number":54,"context_line":"    \u0027aes\u0027: os_traits.HW_CPU_X86_AESNI,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_39f61ed9","line":51,"range":{"start_line":47,"start_character":0,"end_line":51,"end_character":22},"in_reply_to":"7faddb67_656ae0b3","updated":"2019-08-02 08:53:24.000000000","message":"Done","commit_id":"235670e34262e2fd4f8daa63688249406ef7c14b"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"0c3799f65429f0ae7eafe4b814c11811245d00e4","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"RESIZE_SNAPSHOT_NAME \u003d \u0027nova-resize\u0027"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"# Mapping used to convert libvirt cpu features to traits, for more details, see"},{"line_number":48,"context_line":"# https://github.com/libvirt/libvirt/blob/master/src/cpu/cpu_map.xml for libvirt"},{"line_number":49,"context_line":"# prior to version 4.7.0 or"},{"line_number":50,"context_line":"# https://github.com/libvirt/libvirt/blob/master/src/cpu/cpu_map/*.xml thereafter."},{"line_number":51,"context_line":"CPU_TRAITS_MAPPING \u003d {"},{"line_number":52,"context_line":"    \u00273dnow\u0027: os_traits.HW_CPU_X86_3DNOW,"},{"line_number":53,"context_line":"    \u0027abm\u0027: os_traits.HW_CPU_X86_ABM,"},{"line_number":54,"context_line":"    \u0027aes\u0027: os_traits.HW_CPU_X86_AESNI,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_50f7645a","line":51,"range":{"start_line":47,"start_character":0,"end_line":51,"end_character":22},"in_reply_to":"7faddb67_656ae0b3","updated":"2019-07-30 15:11:23.000000000","message":"FWIW, that\u0027s more or less what was here before, but I complained that on my system (ubuntu bionic with libvirt 4.0.0-1ubuntu8.12, it would seem) I still saw the xml file.\n\nUsing the github link it\u0027s fine actually; it\u0027s more in the other files which cite a file system path, which could be different for different installations.\n\nSo yeah, I agree that this one could just be the one link as you describe, and the other ones can get specific about the version, as they are.","commit_id":"235670e34262e2fd4f8daa63688249406ef7c14b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f8bc42732ffde7a6f70c66a90c5e0e580815d295","unresolved":false,"context_lines":[{"line_number":45,"context_line":"RESIZE_SNAPSHOT_NAME \u003d \u0027nova-resize\u0027"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"# Mapping used to convert libvirt cpu features to traits, for more details, see"},{"line_number":48,"context_line":"# https://github.com/libvirt/libvirt/blob/master/src/cpu/cpu_map/"},{"line_number":49,"context_line":"CPU_TRAITS_MAPPING \u003d {"},{"line_number":50,"context_line":"    \u00273dnow\u0027: os_traits.HW_CPU_X86_3DNOW,"},{"line_number":51,"context_line":"    \u0027abm\u0027: os_traits.HW_CPU_X86_ABM,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_543ddf8b","line":48,"range":{"start_line":48,"start_character":53,"end_line":48,"end_character":57},"updated":"2019-08-02 09:55:23.000000000","message":"drop this","commit_id":"8b2e2a19ac66ca9422893a9528e280f57840c8ac"},{"author":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"change_message_id":"c934c13d3094e3035ab6bdf785cc64cb9a5f5757","unresolved":false,"context_lines":[{"line_number":45,"context_line":"RESIZE_SNAPSHOT_NAME \u003d \u0027nova-resize\u0027"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"# Mapping used to convert libvirt cpu features to traits, for more details, see"},{"line_number":48,"context_line":"# https://github.com/libvirt/libvirt/blob/master/src/cpu/cpu_map/"},{"line_number":49,"context_line":"CPU_TRAITS_MAPPING \u003d {"},{"line_number":50,"context_line":"    \u00273dnow\u0027: os_traits.HW_CPU_X86_3DNOW,"},{"line_number":51,"context_line":"    \u0027abm\u0027: os_traits.HW_CPU_X86_ABM,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_81b1d446","line":48,"range":{"start_line":48,"start_character":53,"end_line":48,"end_character":57},"in_reply_to":"7faddb67_543ddf8b","updated":"2019-08-02 12:10:15.000000000","message":"My bad. cpu_map is the sub-directory of src/\n\nThanks","commit_id":"8b2e2a19ac66ca9422893a9528e280f57840c8ac"}]}