)]}'
{"id":"openstack%2Fnova~673349","triplet_id":"openstack%2Fnova~master~I4c3f400cad73264d089fc0bcb1eaee066f4b6097","project":"openstack/nova","branch":"master","topic":"doc-update","hashtags":[],"change_id":"I4c3f400cad73264d089fc0bcb1eaee066f4b6097","subject":"Update config doc policy file type","status":"ABANDONED","created":"2019-07-29 19:00:03.000000000","updated":"2019-11-22 17:34:07.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"1bdf4e09e14fde00a8b6abdbbb5bbe419ad677cc","_number":673349,"virtual_id_number":673349,"owner":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":1,"date":"2019-07-29 19:33:53.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"date":"2019-07-29 20:10:40.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"date":"2019-07-29 20:16:36.000000000","_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},{"date":"2019-07-29 20:28:52.000000000","_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"_account_id":27665,"name":"Markus Hentsch","email":"markus.hentsch@cloudandheat.com","username":"mhen"},{"date":"2019-07-29 21:25:56.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":-1,"date":"2019-08-02 15:15:48.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"value":2,"date":"2019-07-30 09:46:47.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":-1,"date":"2019-07-30 21:48:40.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"value":-1,"date":"2019-08-01 14:54:01.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":27665,"name":"Markus Hentsch","email":"markus.hentsch@cloudandheat.com","username":"mhen"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"_account_id":27665,"name":"Markus Hentsch","email":"markus.hentsch@cloudandheat.com","username":"mhen"},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":27665,"name":"Markus Hentsch","email":"markus.hentsch@cloudandheat.com","username":"mhen"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"_account_id":27665,"name":"Markus Hentsch","email":"markus.hentsch@cloudandheat.com","username":"mhen"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-07-29 19:33:53.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-07-29 20:10:40.000000000","updated_by":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"reviewer":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"state":"REVIEWER"},{"updated":"2019-07-29 20:16:36.000000000","updated_by":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"reviewer":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"state":"REVIEWER"},{"updated":"2019-07-29 20:28:52.000000000","updated_by":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-07-29 21:25:56.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2019-07-30 09:46:47.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2019-07-30 21:48:40.000000000","updated_by":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"reviewer":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"state":"REVIEWER"},{"updated":"2019-08-01 14:54:01.000000000","updated_by":{"_account_id":27665,"name":"Markus Hentsch","email":"markus.hentsch@cloudandheat.com","username":"mhen"},"reviewer":{"_account_id":27665,"name":"Markus Hentsch","email":"markus.hentsch@cloudandheat.com","username":"mhen"},"state":"REVIEWER"},{"updated":"2019-08-02 15:15:48.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"}],"messages":[{"id":"10fa266cf63d76ad3813d779a99b8f9113181e8a","author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"date":"2019-07-29 19:00:03.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a980531400619255daae3bf8f199b1ff4fef778c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-29 19:33:53.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/49/673349/1/check/openstack-tox-pep8/c81695e/ : SUCCESS in 10m 36s\n- openstack-tox-docs http://logs.openstack.org/49/673349/1/check/openstack-tox-docs/d5a6c78/html/ : SUCCESS in 6m 15s","accounts_in_message":[],"_revision_number":1},{"id":"93e7cd0661355e4937a1551dbcc0a0c2c36a36e0","author":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"date":"2019-07-29 20:10:40.000000000","message":"Patch Set 1:\n\nTesting completed on the zVM Driver CI system check-nova pipeline.  To recheck only the zVM driver plugins, submit a comment with only zvm: recheck in the comment. Contact information: zvmosci@us.ibm.com. For information see https://wiki.openstack.org/wiki/ZVMDriver.\n\n- check-nova-master http://extbasicopstackcilog01.podc.sl.edst.ibm.com/test_logs/jenkins-check-nova-master-34462 : SUCCESS in 1h 10m 07s","accounts_in_message":[],"_revision_number":1},{"id":"5f23e3560ba0590debd9eadc99bfc824ab0ed171","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-07-29 20:16:36.000000000","message":"Patch Set 1:\n\nI\u0027m certainly no expert, but the sample [1] looks more like json than yaml to me. Should we be generating it differently?\n\n[1] http://logs.openstack.org/49/673349/1/check/openstack-tox-docs/d5a6c78/html/configuration/sample-policy.html","accounts_in_message":[],"_revision_number":1},{"id":"fd3d147202a5b9ff4b866b00a6357861f680ae57","author":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"date":"2019-07-29 20:28:52.000000000","message":"Patch Set 1:\n\n* nova-quobyteci-dsvm-volume http://78.46.57.153:8081/refs-changes-49-673349-1 : SUCCESS \n\nhttps://wiki.openstack.org/wiki/ThirdPartySystems/Quobyte_CI","accounts_in_message":[],"_revision_number":1},{"id":"4e59277ac06caa168457e427848f1af4d69cb00d","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-07-29 21:25:56.000000000","message":"Patch Set 1:\n\nBuild succeeded.\n\n- nova http://cloudbase-ci.com/nova/673349/1 : SUCCESS in 2h 24m 38s","accounts_in_message":[],"_revision_number":1},{"id":"f848c81d3279db7b9d443d70731b3316fb0ae6bc","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2019-07-30 09:46:47.000000000","message":"Patch Set 1: Code-Review+2\n\nInteresting","accounts_in_message":[],"_revision_number":1},{"id":"4601f8021d7035d7a72fd1cb9e2116e4369ed616","author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"date":"2019-07-30 21:48:40.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"d225d5d3e25e7aba375d6170193c9caf1c104303","author":{"_account_id":27665,"name":"Markus Hentsch","email":"markus.hentsch@cloudandheat.com","username":"mhen"},"date":"2019-08-01 14:54:01.000000000","message":"Patch Set 1: Code-Review-1\n\nI don\u0027t think this change addresses the current confusion appropriately, which exists mainly due to differing default behavior between Nova and Cinder in addition to the misleading or wrong documentation.\n\nNova is still loading the JSON format by default, because it inherits the default variable from oslo.policy [1]. So unless an operator explicitly sets the \u0027policy_file\u0027 variable to \u0027policy.yaml\u0027, the default is still JSON.\nFurthermore, when \u0027tox -egenconfig\u0027 is used, the generated file contains the following line:\n\n\u003e #policy_file \u003d policy.json\n\nWhich additionally hints at JSON being the default, which is still the case. The only case where Nova defaults to a YAML format at all is via \u0027tox -egenpolicy\u0027 which outputs a YAML policy sample file.\nFrom my perspective, the changes to the documentation are partially misleading and only add more confusion.\n\nNote that the initial confusion regarding this topic stemmed from the fact that Cinder is explicitly overriding the aforementioned oslo.policy variable [2] and changes the default to YAML format. Nova doesn\u0027t do this override, which leads to the fact that in a default environment: 1) Nova will look for \u0027policy.json\u0027 ignoring \u0027policy.yaml\u0027 and 2) Cinder will look for \u0027policy.yaml\u0027 and ignore \u0027policy.json\u0027 (the other way around).\n\nAn operator who is not aware of this fact might tend to deploy either only JSON or YAML for all services under the assumption that one of them is the default across OpenStack.\nBoth formats are supported by Nova and Cinder but the services will ignore their respective non-default format unless explicitly overriden in the configuration.\n\n---\n\n[1] https://github.com/openstack/oslo.policy/blob/b7da7a92ad558947d6a133800f6049578e450b6a/oslo_policy/opts.py#L38\n\n[2] https://github.com/openstack/cinder/blob/bbb3aa2452de3742ae2a6ecf4e72d0f2ae1603d1/cinder/policy.py#L32","accounts_in_message":[],"_revision_number":1},{"id":"2725c0f87147384320dfe670ab766782ae81dfc6","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-08-02 15:15:48.000000000","message":"Patch Set 1: Code-Review-1\n\n\u003e I\u0027m certainly no expert, but the sample [1] looks more like json than yaml to me. Should we be generating it differently?\n\nA json sample wouldn\u0027t have comments in it.\n\nAs for this change, I agree with both Ken\u0027ichi on the API reference docs saying policy.json all over the place and Markus in that nova\u0027s getting the default policy_file config from oslo.policy which defaults to policy.json.\n\nSince we moved policy in code several releases ago [1] by default you don\u0027t need any policy file unlike years past where you had to generate a policy file and have it read. With policy-in-code you only generate and configure nova to load/read from that file when you want to override the default policy.\n\nThe defaults between nova and cinder is confusing for sure, but what are the defaults in other projects besides cinder? If they are pulling options from oslo.policy then their default is policy.json as well and in that case cinder is the outlier concerning defaults. I think policy.yaml would be a nicer default since you can actually document the thing if you\u0027re overriding policy, but OpenStack as a community hasn\u0027t made changing that default change a priority - maybe that\u0027s a potential community wide goal candidate for the U release?\n\n[1] https://specs.openstack.org/openstack/nova-specs/specs/newton/implemented/policy-in-code.html","accounts_in_message":[],"_revision_number":1},{"id":"ebd104eae7e615d007f293763e328957ccd6e932","author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"date":"2019-11-22 17:34:07.000000000","message":"Abandoned\n\nThis change seems stuck, feel free to re-open and resolve the discussion, but going to abondon this so its out of the review queue for now.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"6945b524d794209f9acb031f320164a9a047b85d","revisions":{"6945b524d794209f9acb031f320164a9a047b85d":{"kind":"REWORK","_number":1,"created":"2019-07-29 19:00:03.000000000","uploader":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"ref":"refs/changes/49/673349/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/49/673349/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/49/673349/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/49/673349/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/49/673349/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/49/673349/1"}}},"commit":{"parents":[{"commit":"1599e3cf68779eafaaa2b13a273d3bebd1379c19","subject":"Merge \"Remove unused FP device creation and deletion methods.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/1599e3cf68779eafaaa2b13a273d3bebd1379c19"}]}],"author":{"name":"Gage Hugo","email":"gagehugo@gmail.com","date":"2019-07-29 18:48:28.000000000","tz":-300},"committer":{"name":"Gage Hugo","email":"gagehugo@gmail.com","date":"2019-07-29 18:59:18.000000000","tz":-300},"subject":"Update config doc policy file type","message":"Update config doc policy file type\n\nThe current guide for nova configuration specified that the two\nmain files for nova static configuration live in \"nova.conf\" and\n\"policy.json\". Since Nova appears to generate a policy.yaml now,\nthis has confused some operators about whether they need to provide\na json vs yaml file for their policy configurations.\n\nThis change updates the reference from \"policy.json\" to\n\"policy.yaml\" in order to accurately reflect the current usage\nof policy file format that is supported/generate by nova.\n\nAlso added a short note explaining that existing policy.yaml\nand/or policy.json files are still supported.\n\nChange-Id: I4c3f400cad73264d089fc0bcb1eaee066f4b6097\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/6945b524d794209f9acb031f320164a9a047b85d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/6945b524d794209f9acb031f320164a9a047b85d"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}