)]}'
{"nova/network/manager.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"c4ba8df91361afd09ff6796d0442d33915a4cbf4","unresolved":false,"context_lines":[{"line_number":1903,"context_line":"                self.driver.kill_dhcp(dev)"},{"line_number":1904,"context_line":"                self.l3driver.remove_gateway(network)"},{"line_number":1905,"context_line":"                if not CONF.share_dhcp_address:"},{"line_number":1906,"context_line":"                    fip \u003d fixed_ip_obj.FixedIP.get_by_address("},{"line_number":1907,"context_line":"                        context, network.dhcp_server)"},{"line_number":1908,"context_line":"                    fip.allocated \u003d False"},{"line_number":1909,"context_line":"                    fip.host \u003d None"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAUH%2F9oMU%3D","line":1906,"updated":"2014-02-05 14:59:10.000000000","message":"this seems like 2 database reads instead of one update. did I understand","commit_id":"41901d7b9aa04ad947259abfcddbe6dbd153566f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7bbe99069d891c59d6f68c080cf0e03828637e73","unresolved":false,"context_lines":[{"line_number":1903,"context_line":"                self.driver.kill_dhcp(dev)"},{"line_number":1904,"context_line":"                self.l3driver.remove_gateway(network)"},{"line_number":1905,"context_line":"                if not CONF.share_dhcp_address:"},{"line_number":1906,"context_line":"                    fip \u003d fixed_ip_obj.FixedIP.get_by_address("},{"line_number":1907,"context_line":"                        context, network.dhcp_server)"},{"line_number":1908,"context_line":"                    fip.allocated \u003d False"},{"line_number":1909,"context_line":"                    fip.host \u003d None"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAUX%2F%2Fyc4%3D","line":1906,"in_reply_to":"AAAAUH%2F9oMU%3D","updated":"2014-02-10 20:07:45.000000000","message":"So, this is a case where we need to basically apply no-db-compute type cleanups where we stop just passing IDs around and making random update calls. Long-term, we should clean this up and pass in the objects like this so that we don\u0027t have to load them.\n\nSince this nova-network set was all rushed, we decided not to refactor everything ideally before getting the things merged that we needed to accomplish the \"make it use conductor\" goal.","commit_id":"41901d7b9aa04ad947259abfcddbe6dbd153566f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"4c691350029e083227efdb988a6dbc3abb1dfb0d","unresolved":false,"context_lines":[{"line_number":1733,"context_line":"                fip \u003d fixed_ip_obj.FixedIP.associate_pool(context,"},{"line_number":1734,"context_line":"                                                          network[\u0027id\u0027],"},{"line_number":1735,"context_line":"                                                          instance_id)"},{"line_number":1736,"context_line":"        address \u003d fip.address"},{"line_number":1737,"context_line":""},{"line_number":1738,"context_line":"        vif \u003d vif_obj.VirtualInterface.get_by_instance_and_network("},{"line_number":1739,"context_line":"            context, instance_id, network[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUX%2F%2FhI8%3D","line":1736,"updated":"2014-02-12 16:37:45.000000000","message":"is this fixing a bug? something is odd here\ndoes the test check the address returned?","commit_id":"542958fac7445a14deaae146b0d4047aa90a2fab"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d2462f55f724ca5cb1e0789ecefb9e792486f40b","unresolved":false,"context_lines":[{"line_number":1733,"context_line":"                fip \u003d fixed_ip_obj.FixedIP.associate_pool(context,"},{"line_number":1734,"context_line":"                                                          network[\u0027id\u0027],"},{"line_number":1735,"context_line":"                                                          instance_id)"},{"line_number":1736,"context_line":"        address \u003d fip.address"},{"line_number":1737,"context_line":""},{"line_number":1738,"context_line":"        vif \u003d vif_obj.VirtualInterface.get_by_instance_and_network("},{"line_number":1739,"context_line":"            context, instance_id, network[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUX%2F%2FfNU%3D","line":1736,"in_reply_to":"AAAAUX%2F%2FhI8%3D","updated":"2014-02-12 20:40:48.000000000","message":"I don\u0027t know what you\u0027re trying to say. Can you explain more please?","commit_id":"542958fac7445a14deaae146b0d4047aa90a2fab"}]}