)]}'
{"id":"openstack%2Fnova~673533","triplet_id":"openstack%2Fnova~stable%2Fstein~I6a2c63a4c33e783100208fd3f45eb52aad49e3d6","project":"openstack/nova","branch":"stable/stein","topic":"bug/1837955","hashtags":[],"change_id":"I6a2c63a4c33e783100208fd3f45eb52aad49e3d6","subject":"Cleanup when hitting MaxRetriesExceeded from no host_available","status":"MERGED","created":"2019-07-30 14:16:07.000000000","updated":"2019-08-01 13:41:27.000000000","submitted":"2019-08-01 13:41:27.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"673533-1564666887578-efd57ca1","meta_rev_id":"1957b2504ae21a599ea57ddb19d8a2799d7a7565","_number":673533,"virtual_id_number":673533,"owner":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2019-07-30 16:53:46.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"date":"2019-07-30 16:03:51.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":2,"date":"2019-08-01 13:41:27.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"all":[{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":2,"date":"2019-08-01 10:44:26.000000000","_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-07-30 22:16:05.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"all":[{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":1,"date":"2019-08-01 10:44:26.000000000","_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-07-30 16:03:51.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-07-30 16:53:46.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2019-07-30 22:16:05.000000000","updated_by":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"reviewer":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"state":"REVIEWER"},{"updated":"2019-08-01 10:44:26.000000000","updated_by":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"reviewer":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"state":"REVIEWER"},{"updated":"2019-08-01 13:41:27.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"b8219a553c39593da6c2287c9802edde8491a79c","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-07-30 14:16:07.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"81ca289616a9bb0b841285330739d4ef0e85513f","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2019-07-30 16:03:51.000000000","message":"Patch Set 1:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/33/673533/1/check/tempest-dsvm-full-xenial/9bee84b/ : SUCCESS in 1h 21m 57s\n- tempest-dsvm-full-xenial-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/33/673533/1/check/tempest-dsvm-full-xenial-py3/309f9ad/ : SUCCESS in 1h 46m 08s (non-voting)\n- grenade-dsvm-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/33/673533/1/check/grenade-dsvm-xenial/3690172/ : SUCCESS in 1h 10m 26s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"6da30b568e9bfc52936fc878453764fc36ee310e","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-07-30 16:53:46.000000000","message":"Patch Set 1:\n\nBuild succeeded.\n\n- nova http://cloudbase-ci.com/nova/673533/1 : SUCCESS in 2h 35m 55s","accounts_in_message":[],"_revision_number":1},{"id":"1e8f82c4c69fc994e11b63f97479d225631f2c56","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-30 19:24:47.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade-py3 http://logs.openstack.org/33/673533/1/check/grenade-py3/d5c6c7f/ : SUCCESS in 1h 00m 55s\n- tempest-full-py3 http://logs.openstack.org/33/673533/1/check/tempest-full-py3/8a08a6a/ : SUCCESS in 1h 37m 13s\n- openstack-tox-cover http://logs.openstack.org/33/673533/1/check/openstack-tox-cover/372ec2d/cover/ : SUCCESS in 18m 08s\n- openstack-tox-lower-constraints http://logs.openstack.org/33/673533/1/check/openstack-tox-lower-constraints/9ba1dd9/ : SUCCESS in 12m 43s\n- openstack-tox-pep8 http://logs.openstack.org/33/673533/1/check/openstack-tox-pep8/81992be/ : SUCCESS in 10m 37s\n- openstack-tox-py27 http://logs.openstack.org/33/673533/1/check/openstack-tox-py27/963090a/ : SUCCESS in 13m 50s\n- openstack-tox-py35 http://logs.openstack.org/33/673533/1/check/openstack-tox-py35/41d2686/ : SUCCESS in 14m 35s\n- openstack-tox-py36 http://logs.openstack.org/33/673533/1/check/openstack-tox-py36/501fec0/ : SUCCESS in 13m 42s\n- openstack-tox-py37 http://logs.openstack.org/33/673533/1/check/openstack-tox-py37/1892758/ : SUCCESS in 14m 12s\n- openstack-tox-docs http://logs.openstack.org/33/673533/1/check/openstack-tox-docs/ae084eb/html/ : SUCCESS in 6m 25s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa http://logs.openstack.org/33/673533/1/check/ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa/fb8313e/ : SUCCESS in 57m 53s (non-voting)\n- devstack-plugin-ceph-tempest http://logs.openstack.org/33/673533/1/check/devstack-plugin-ceph-tempest/964042c/ : SUCCESS in 1h 30m 30s (non-voting)\n- neutron-grenade-multinode http://logs.openstack.org/33/673533/1/check/neutron-grenade-multinode/bb9fa71/ : SUCCESS in 1h 12m 46s\n- nova-grenade-live-migration http://logs.openstack.org/33/673533/1/check/nova-grenade-live-migration/9c4c376/ : SUCCESS in 1h 15m 11s\n- nova-live-migration http://logs.openstack.org/33/673533/1/check/nova-live-migration/694be92/ : SUCCESS in 1h 06m 15s\n- nova-next http://logs.openstack.org/33/673533/1/check/nova-next/cedd1a9/ : SUCCESS in 1h 48m 14s\n- nova-tox-functional http://logs.openstack.org/33/673533/1/check/nova-tox-functional/b7b9a97/ : SUCCESS in 21m 56s\n- nova-tox-functional-py35 http://logs.openstack.org/33/673533/1/check/nova-tox-functional-py35/5d61e52/ : SUCCESS in 18m 05s\n- tempest-multinode-full http://logs.openstack.org/33/673533/1/check/tempest-multinode-full/6c4c355/ : SUCCESS in 2h 08m 51s (non-voting)\n- tempest-slow-py3 http://logs.openstack.org/33/673533/1/check/tempest-slow-py3/f285315/ : SUCCESS in 2h 34m 58s","accounts_in_message":[],"_revision_number":1},{"id":"da3747d6b87a7bcc2649a7e8a1d8d3c639dc7482","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2019-07-30 22:16:05.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"53c1923b46049ef424510d558311edeb2a6bb2ba","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2019-08-01 10:44:26.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nLGTM, a clean and well tested bugfix. Approving as this is from another stable Nova core.","accounts_in_message":[],"_revision_number":1},{"id":"476d48a2077137a8432d2175fcb6a38c1082c86d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-01 10:47:10.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"8c5f4bc79fc903e82d49fe5fa2749fa852389a17","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-01 13:41:27.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"77ad44cce39043fed1f10f2a91fbb225ce62243f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-01 13:41:27.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- grenade-py3 https://logs.opendev.org/33/673533/1/gate/grenade-py3/916be2e/ : SUCCESS in 1h 10m 15s\n- tempest-full-py3 https://logs.opendev.org/33/673533/1/gate/tempest-full-py3/8d944fa/ : SUCCESS in 1h 38m 29s\n- openstack-tox-lower-constraints https://logs.opendev.org/33/673533/1/gate/openstack-tox-lower-constraints/ad55ef0/ : SUCCESS in 11m 36s\n- openstack-tox-pep8 https://logs.opendev.org/33/673533/1/gate/openstack-tox-pep8/63ab4ce/ : SUCCESS in 9m 02s\n- openstack-tox-py27 https://logs.opendev.org/33/673533/1/gate/openstack-tox-py27/a750b05/ : SUCCESS in 11m 35s\n- openstack-tox-py35 https://logs.opendev.org/33/673533/1/gate/openstack-tox-py35/5459ee3/ : SUCCESS in 12m 23s\n- openstack-tox-py36 https://logs.opendev.org/33/673533/1/gate/openstack-tox-py36/ed2172d/ : SUCCESS in 11m 51s\n- openstack-tox-py37 https://logs.opendev.org/33/673533/1/gate/openstack-tox-py37/d13563d/ : SUCCESS in 11m 28s\n- openstack-tox-docs https://logs.opendev.org/33/673533/1/gate/openstack-tox-docs/e092404/html/ : SUCCESS in 6m 31s\n- nova-grenade-live-migration https://logs.opendev.org/33/673533/1/gate/nova-grenade-live-migration/c8aea59/ : SUCCESS in 1h 15m 24s\n- nova-live-migration https://logs.opendev.org/33/673533/1/gate/nova-live-migration/fabf5f7/ : SUCCESS in 59m 52s\n- nova-tox-functional https://logs.opendev.org/33/673533/1/gate/nova-tox-functional/15ca634/ : SUCCESS in 20m 19s\n- nova-tox-functional-py35 https://logs.opendev.org/33/673533/1/gate/nova-tox-functional-py35/fef9318/ : SUCCESS in 20m 50s\n- nova-next https://logs.opendev.org/33/673533/1/gate/nova-next/bac688a/ : SUCCESS in 1h 38m 50s\n- tempest-slow-py3 https://logs.opendev.org/33/673533/1/gate/tempest-slow-py3/92dfe93/ : SUCCESS in 2h 16m 10s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"fcc2b9e33ed2b3d9f469b458e0f46011fe9883ac","revisions":{"fcc2b9e33ed2b3d9f469b458e0f46011fe9883ac":{"kind":"REWORK","_number":1,"created":"2019-07-30 14:16:07.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/33/673533/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/33/673533/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/33/673533/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/33/673533/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/33/673533/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/33/673533/1"}}},"commit":{"parents":[{"commit":"0d2e27fd018e08617964dc38321ebfa8f1a5a4f9","subject":"Add functional regression test for bug 1837955","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/0d2e27fd018e08617964dc38321ebfa8f1a5a4f9"}]}],"author":{"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","date":"2019-07-26 03:19:40.000000000","tz":-420},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-07-30 14:10:17.000000000","tz":-240},"subject":"Cleanup when hitting MaxRetriesExceeded from no host_available","message":"Cleanup when hitting MaxRetriesExceeded from no host_available\n\nPrior to this patch there was a condition when no\nhost_available was true and an exception would get\nraised without first cleaning up the instance.\nThis causes instances to get indefinitely stuck in\na scheduling state.\n\nThis patch fixes this by calling the clean up function\nand then exits build_instances using a return statement.\n\nThe related functional regression recreate test is updated\nto show this fixes the bug.\n\nChange-Id: I6a2c63a4c33e783100208fd3f45eb52aad49e3d6\nCloses-bug: #1837955\n(cherry picked from commit b98d4ba6d54f5ca2999a8fe6b6d7dfcc134061df)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/fcc2b9e33ed2b3d9f469b458e0f46011fe9883ac"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/fcc2b9e33ed2b3d9f469b458e0f46011fe9883ac"}]},"branch":"refs/heads/stable/stein"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
