)]}'
{"id":"openstack%2Fnova~673553","triplet_id":"openstack%2Fnova~stable%2Frocky~I6a2c63a4c33e783100208fd3f45eb52aad49e3d6","project":"openstack/nova","branch":"stable/rocky","topic":"bug/1837955","hashtags":[],"change_id":"I6a2c63a4c33e783100208fd3f45eb52aad49e3d6","subject":"Cleanup when hitting MaxRetriesExceeded from no host_available","status":"MERGED","created":"2019-07-30 15:05:21.000000000","updated":"2019-08-08 16:22:10.000000000","submitted":"2019-08-08 16:22:10.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"673553-1565281330952-62203689","meta_rev_id":"18de345f2a08e3e973e12d320cac21362d20d854","_number":673553,"virtual_id_number":673553,"owner":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"date":"2019-07-30 18:50:37.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"date":"2019-07-30 17:34:06.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"date":"2019-07-30 16:19:11.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":2,"date":"2019-08-08 16:22:10.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"recommended":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"all":[{"value":1,"date":"2019-08-05 07:42:17.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":2,"date":"2019-08-08 13:58:20.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-07-30 16:19:46.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"all":[{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":1,"date":"2019-08-08 13:58:20.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-07-30 16:19:46.000000000","updated_by":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"reviewer":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"state":"REVIEWER"},{"updated":"2019-07-30 17:34:06.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-07-30 18:50:37.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2019-08-05 07:42:17.000000000","updated_by":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"reviewer":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"state":"REVIEWER"},{"updated":"2019-08-08 13:58:20.000000000","updated_by":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"reviewer":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"state":"REVIEWER"},{"updated":"2019-08-08 16:22:10.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"c4f41f07be3ce5566c6b62ca0d559f464b4a88ff","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-07-30 15:05:21.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"618a7b62f68832d8e38debb5b5a464749d436cab","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-07-30 15:20:16.000000000","message":"Patch Set 1: Workflow-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"575c5030eaa7018267ceafe19dbc21f164f134da","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-07-30 15:35:27.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"1e711d09c25e314254e7a13570d6736499585d55","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-07-30 15:56:59.000000000","message":"Patch Set 2: Workflow-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"35bb0139a038554574e2c1ce47670d66b59e9b61","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-07-30 16:17:50.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"dd71cbac6c6050ec954e0b6282e5d42b8f2e1a65","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-07-30 16:19:11.000000000","message":"Patch Set 3:\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"1082dfd1c1957e747cde99bb215855f969dc8210","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2019-07-30 16:19:46.000000000","message":"Patch Set 3: Code-Review+1\n\nThanks! LGTM","accounts_in_message":[],"_revision_number":3},{"id":"c79bcf114fe395308128e758658037ac26af63ad","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2019-07-30 17:34:06.000000000","message":"Patch Set 3:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/53/673553/3/check/tempest-dsvm-full-xenial/8242590/ : SUCCESS in 1h 05m 47s\n- tempest-dsvm-full-xenial-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/53/673553/3/check/tempest-dsvm-full-xenial-py3/60c635d/ : FAILURE in 1h 14m 58s (non-voting)\n- grenade-dsvm-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/53/673553/3/check/grenade-dsvm-xenial/5157620/ : SUCCESS in 1h 03m 49s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"46e7375b70f7594052ee1b3c6f9718ff5b72647a","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-07-30 18:50:37.000000000","message":"Patch Set 3:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/673553/3 : FAILURE in 2h 31m 01s","accounts_in_message":[],"_revision_number":3},{"id":"20a72edf935f6e18134e963815dd07a1ac3cc97f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-30 21:21:10.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/53/673553/3/check/openstack-tox-pep8/747f490/ : SUCCESS in 11m 10s\n- openstack-tox-py27 http://logs.openstack.org/53/673553/3/check/openstack-tox-py27/e460d69/ : SUCCESS in 14m 28s\n- openstack-tox-py35 http://logs.openstack.org/53/673553/3/check/openstack-tox-py35/d2babaa/ : SUCCESS in 15m 49s\n- build-openstack-sphinx-docs http://logs.openstack.org/53/673553/3/check/build-openstack-sphinx-docs/f5e930a/html/ : SUCCESS in 8m 13s\n- tempest-full http://logs.openstack.org/53/673553/3/check/tempest-full/3b8111f/ : SUCCESS in 1h 45m 22s\n- neutron-grenade http://logs.openstack.org/53/673553/3/check/neutron-grenade/c526979/ : SUCCESS in 55m 49s\n- tempest-full-py3 http://logs.openstack.org/53/673553/3/check/tempest-full-py3/15f372e/ : SUCCESS in 1h 17m 13s\n- ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa http://logs.openstack.org/53/673553/3/check/ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa/dd2a891/ : SUCCESS in 52m 03s (non-voting)\n- nova-cells-v1 http://logs.openstack.org/53/673553/3/check/nova-cells-v1/7512c79/ : SUCCESS in 1h 02m 27s\n- nova-grenade-live-migration http://logs.openstack.org/53/673553/3/check/nova-grenade-live-migration/7d7cb68/ : SUCCESS in 1h 06m 18s (non-voting)\n- nova-live-migration http://logs.openstack.org/53/673553/3/check/nova-live-migration/2555973/ : SUCCESS in 1h 04m 24s\n- nova-multiattach http://logs.openstack.org/53/673553/3/check/nova-multiattach/22907fc/ : SUCCESS in 1h 02m 39s\n- nova-next http://logs.openstack.org/53/673553/3/check/nova-next/267e619/ : SUCCESS in 1h 17m 42s\n- tempest-slow http://logs.openstack.org/53/673553/3/check/tempest-slow/a6a13e3/ : SUCCESS in 2h 10m 37s\n- nova-tox-functional http://logs.openstack.org/53/673553/3/check/nova-tox-functional/417d8e4/ : SUCCESS in 19m 51s\n- nova-tox-functional-py35 http://logs.openstack.org/53/673553/3/check/nova-tox-functional-py35/ae24a3c/ : SUCCESS in 19m 19s\n- openstack-tox-lower-constraints http://logs.openstack.org/53/673553/3/check/openstack-tox-lower-constraints/d90561a/ : SUCCESS in 13m 44s\n- neutron-grenade-multinode http://logs.openstack.org/53/673553/3/check/neutron-grenade-multinode/4c27b04/ : SUCCESS in 1h 09m 15s\n- devstack-plugin-ceph-tempest http://logs.openstack.org/53/673553/3/check/devstack-plugin-ceph-tempest/c8fd24e/ : SUCCESS in 1h 12m 21s (non-voting)\n- tempest-multinode-full http://logs.openstack.org/53/673553/3/check/tempest-multinode-full/4a160dd/ : SUCCESS in 1h 42m 26s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"4963cbc41a8966d5f940369100576bc393c0a902","author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"date":"2019-08-05 07:42:17.000000000","message":"Patch Set 3: Code-Review+1\n\nlgtm","accounts_in_message":[],"_revision_number":3},{"id":"2de626cd68dd1552d6a55f89aeab2a08453c1286","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2019-08-08 13:58:20.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"fc959648e3d680e186d4f1c1eb3c681c6a49e4ba","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-08 13:58:44.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"713ba43c7a8810a2fb78b9065fcd449806a2be67","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-08 16:22:10.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://logs.opendev.org/53/673553/3/gate/openstack-tox-pep8/b62a892/ : SUCCESS in 9m 15s\n- openstack-tox-py27 https://logs.opendev.org/53/673553/3/gate/openstack-tox-py27/a78c9a3/ : SUCCESS in 14m 14s\n- openstack-tox-py35 https://logs.opendev.org/53/673553/3/gate/openstack-tox-py35/056a907/ : SUCCESS in 16m 58s\n- build-openstack-sphinx-docs https://logs.opendev.org/53/673553/3/gate/build-openstack-sphinx-docs/8fb571f/html/ : SUCCESS in 8m 24s\n- tempest-full https://logs.opendev.org/53/673553/3/gate/tempest-full/57e15a5/ : SUCCESS in 1h 19m 37s\n- neutron-grenade https://logs.opendev.org/53/673553/3/gate/neutron-grenade/03d5ee1/ : SUCCESS in 1h 07m 53s\n- tempest-full-py3 https://logs.opendev.org/53/673553/3/gate/tempest-full-py3/2afe50f/ : SUCCESS in 1h 26m 10s\n- nova-cells-v1 https://logs.opendev.org/53/673553/3/gate/nova-cells-v1/a51fc76/ : SUCCESS in 1h 14m 20s\n- nova-live-migration https://logs.opendev.org/53/673553/3/gate/nova-live-migration/f644e63/ : SUCCESS in 49m 36s\n- nova-multiattach https://logs.opendev.org/53/673553/3/gate/nova-multiattach/5c931b8/ : SUCCESS in 1h 11m 28s\n- nova-next https://logs.opendev.org/53/673553/3/gate/nova-next/06c6edd/ : SUCCESS in 1h 39m 43s\n- tempest-slow https://logs.opendev.org/53/673553/3/gate/tempest-slow/1dc5f8c/ : SUCCESS in 2h 13m 52s\n- nova-tox-functional https://logs.opendev.org/53/673553/3/gate/nova-tox-functional/fef57cf/ : SUCCESS in 21m 18s\n- nova-tox-functional-py35 https://logs.opendev.org/53/673553/3/gate/nova-tox-functional-py35/a1427ab/ : SUCCESS in 19m 59s\n- openstack-tox-lower-constraints https://logs.opendev.org/53/673553/3/gate/openstack-tox-lower-constraints/1717602/ : SUCCESS in 16m 34s","accounts_in_message":[],"_revision_number":3},{"id":"4e9499e9262d3198f35f05970e34649f1417c8ce","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-08 16:22:10.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"e3b68a1c8bbedd877cfc988898f7e458ab067f28","revisions":{"923b6c45ee276946790d98449e0b8b35bf6b806f":{"kind":"REWORK","_number":1,"created":"2019-07-30 15:05:21.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/53/673553/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/53/673553/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/53/673553/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/53/673553/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/53/673553/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/53/673553/1"}}},"commit":{"parents":[{"commit":"c5501d3c404ffacbd333b5e6bb0aa8c735123445","subject":"Handle placement error during re-schedule","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c5501d3c404ffacbd333b5e6bb0aa8c735123445"}]}],"author":{"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","date":"2019-07-26 03:19:40.000000000","tz":-420},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-07-30 15:03:33.000000000","tz":-240},"subject":"Cleanup when hitting MaxRetriesExceeded from no host_available","message":"Cleanup when hitting MaxRetriesExceeded from no host_available\n\nPrior to this patch there was a condition when no\nhost_available was true and an exception would get\nraised without first cleaning up the instance.\nThis causes instances to get indefinitely stuck in\na scheduling state.\n\nThis patch fixes this by calling the clean up function\nand then exits build_instances using a return statement.\n\nThe related functional regression recreate test is updated\nto show this fixes the bug.\n\nNOTE(mriedem): There are two changes in this backport. First,\nthe conductor manager.py call to _cleanup_when_reschedule_fails\nchanges to pass request_spec since there is no legacy_request_spec\nsince change If8a13f74d2b3c99f05365eb49dcfa01d9042fefa is not in\nRocky. The test_bug_1837955 setUp needed to stub notifications\nsince change I017d1a31139c9300642dd706eadc265f7c954ca8 is not\nin Rocky to do that in ProviderUsageBaseTestCase.\n\nChange-Id: I6a2c63a4c33e783100208fd3f45eb52aad49e3d6\nCloses-bug: #1837955\n(cherry picked from commit b98d4ba6d54f5ca2999a8fe6b6d7dfcc134061df)\n(cherry picked from commit fcc2b9e33ed2b3d9f469b458e0f46011fe9883ac)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/923b6c45ee276946790d98449e0b8b35bf6b806f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/923b6c45ee276946790d98449e0b8b35bf6b806f"}]},"branch":"refs/heads/stable/rocky"},"f2a4c9cecee924af85aa7d743a9ccbd7b47ecb44":{"kind":"REWORK","_number":2,"created":"2019-07-30 15:35:27.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/53/673553/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/53/673553/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/53/673553/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/53/673553/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/53/673553/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/53/673553/2"}}},"commit":{"parents":[{"commit":"c5501d3c404ffacbd333b5e6bb0aa8c735123445","subject":"Handle placement error during re-schedule","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c5501d3c404ffacbd333b5e6bb0aa8c735123445"}]}],"author":{"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","date":"2019-07-26 03:19:40.000000000","tz":-420},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-07-30 15:34:00.000000000","tz":-240},"subject":"Cleanup when hitting MaxRetriesExceeded from no host_available","message":"Cleanup when hitting MaxRetriesExceeded from no host_available\n\nPrior to this patch there was a condition when no\nhost_available was true and an exception would get\nraised without first cleaning up the instance.\nThis causes instances to get indefinitely stuck in\na scheduling state.\n\nThis patch fixes this by calling the clean up function\nand then exits build_instances using a return statement.\n\nThe related functional regression recreate test is updated\nto show this fixes the bug.\n\nNOTE(mriedem): There are three changes in this backport. First,\nthe conductor manager.py call to _cleanup_when_reschedule_fails\nchanges to pass request_spec since there is no legacy_request_spec\nsince change If8a13f74d2b3c99f05365eb49dcfa01d9042fefa is not in\nRocky. Second, the test_bug_1837955 setUp needed to stub notifications\nsince change I017d1a31139c9300642dd706eadc265f7c954ca8 is not\nin Rocky to do that in ProviderUsageBaseTestCase. Third, the unit\ntest is changed to mock _set_vm_state_and_notify since\nchange Ibfb0a6db5920d921c4fc7cabf3f4d2838ea7f421 is not in Rocky\nfor compute utils to call notify_about_compute_task_error.\n\nChange-Id: I6a2c63a4c33e783100208fd3f45eb52aad49e3d6\nCloses-bug: #1837955\n(cherry picked from commit b98d4ba6d54f5ca2999a8fe6b6d7dfcc134061df)\n(cherry picked from commit fcc2b9e33ed2b3d9f469b458e0f46011fe9883ac)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f2a4c9cecee924af85aa7d743a9ccbd7b47ecb44"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f2a4c9cecee924af85aa7d743a9ccbd7b47ecb44"}]},"branch":"refs/heads/stable/rocky"},"e3b68a1c8bbedd877cfc988898f7e458ab067f28":{"kind":"REWORK","_number":3,"created":"2019-07-30 16:17:50.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/53/673553/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/53/673553/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/53/673553/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/53/673553/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/53/673553/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/53/673553/3"}}},"commit":{"parents":[{"commit":"f292a92a89b452c66b5799ac309a5f623ee7b16c","subject":"Add functional regression test for bug 1837955","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f292a92a89b452c66b5799ac309a5f623ee7b16c"}]}],"author":{"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","date":"2019-07-26 03:19:40.000000000","tz":-420},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-07-30 16:16:15.000000000","tz":-240},"subject":"Cleanup when hitting MaxRetriesExceeded from no host_available","message":"Cleanup when hitting MaxRetriesExceeded from no host_available\n\nPrior to this patch there was a condition when no\nhost_available was true and an exception would get\nraised without first cleaning up the instance.\nThis causes instances to get indefinitely stuck in\na scheduling state.\n\nThis patch fixes this by calling the clean up function\nand then exits build_instances using a return statement.\n\nThe related functional regression recreate test is updated\nto show this fixes the bug.\n\nNOTE(mriedem): There are three changes in this backport. First,\nsince bug 1819460 and change I78fc2312274471a7bd85a263de12cc5a0b19fd10\ndo not apply to Rocky, _cleanup_when_reschedule_fails is added here.\nSecond, the test_bug_1837955 setUp needed to stub notifications\nsince change I017d1a31139c9300642dd706eadc265f7c954ca8 is not\nin Rocky to do that in ProviderUsageBaseTestCase. Third, the unit\ntest is changed to mock _set_vm_state_and_notify since\nchange Ibfb0a6db5920d921c4fc7cabf3f4d2838ea7f421 is not in Rocky\nfor compute utils to call notify_about_compute_task_error.\n\nChange-Id: I6a2c63a4c33e783100208fd3f45eb52aad49e3d6\nCloses-bug: #1837955\n(cherry picked from commit b98d4ba6d54f5ca2999a8fe6b6d7dfcc134061df)\n(cherry picked from commit fcc2b9e33ed2b3d9f469b458e0f46011fe9883ac)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/e3b68a1c8bbedd877cfc988898f7e458ab067f28"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/e3b68a1c8bbedd877cfc988898f7e458ab067f28"}]},"branch":"refs/heads/stable/rocky"}},"requirements":[],"submit_records":[],"submit_requirements":[]}