)]}'
{"id":"openstack%2Fnova~673824","triplet_id":"openstack%2Fnova~stable%2Fqueens~I4d60da26fcf0a77628d1fdf4e818884614fa4f02","project":"openstack/nova","branch":"stable/queens","topic":"bug/1764556","hashtags":[],"change_id":"I4d60da26fcf0a77628d1fdf4e818884614fa4f02","subject":"Add functional recreate test for bug 1764556","status":"MERGED","created":"2019-07-31 14:00:38.000000000","updated":"2019-08-09 17:32:30.000000000","submitted":"2019-08-09 17:32:30.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"673824-1565371950425-e4a4d76b","meta_rev_id":"bd7c4197d7019cd345b0c678633cdb199c222f9a","_number":673824,"virtual_id_number":673824,"owner":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-08-09 17:32:30.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"date":"2019-07-31 20:21:56.000000000","_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},{"value":0,"date":"2019-07-31 15:11:45.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"date":"2019-07-31 16:18:28.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-08-09 15:21:25.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-08-09 15:21:25.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-07-31 15:11:45.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-07-31 16:18:28.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2019-07-31 20:21:56.000000000","updated_by":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-08-09 15:21:25.000000000","updated_by":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"reviewer":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"state":"REVIEWER"},{"updated":"2019-08-09 17:32:30.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"fd7c13ddd0b14b49d514cebd714c26039da58791","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-07-31 14:00:38.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"484c170af4b62d81ce5a6547b9b0b1e1260f92d7","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2019-07-31 15:11:45.000000000","message":"Patch Set 1:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/24/673824/1/check/tempest-dsvm-full-xenial/fd4dff7/ : SUCCESS in 1h 09m 39s\n- tempest-dsvm-full-xenial-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/24/673824/1/check/tempest-dsvm-full-xenial-py3/f13ed9d/ : FAILURE in 1h 07m 49s (non-voting)\n- grenade-dsvm-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/24/673824/1/check/grenade-dsvm-xenial/7a8d060/ : SUCCESS in 1h 04m 49s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"37a295fdf16c0f4ea85adae17edca1e8729b969b","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-07-31 16:18:28.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/673824/1 : FAILURE in 38m 55s","accounts_in_message":[],"_revision_number":1},{"id":"a61403829cca99cbaa61d9c3cc9744d00165b0ed","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-31 18:23:26.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/24/673824/1/check/openstack-tox-pep8/a71fc25/ : SUCCESS in 10m 49s\n- openstack-tox-py27 http://logs.openstack.org/24/673824/1/check/openstack-tox-py27/b96e0c4/ : SUCCESS in 13m 00s\n- openstack-tox-py35 http://logs.openstack.org/24/673824/1/check/openstack-tox-py35/3158794/ : SUCCESS in 14m 56s\n- build-openstack-sphinx-docs http://logs.openstack.org/24/673824/1/check/build-openstack-sphinx-docs/6134878/html/ : SUCCESS in 7m 08s\n- tempest-full http://logs.openstack.org/24/673824/1/check/tempest-full/b4b6d70/ : SUCCESS in 1h 21m 08s\n- neutron-grenade http://logs.openstack.org/24/673824/1/check/neutron-grenade/b411544/ : SUCCESS in 1h 02m 47s\n- tempest-full-py3 http://logs.openstack.org/24/673824/1/check/tempest-full-py3/b1e1a48/ : SUCCESS in 1h 23m 44s\n- ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa http://logs.openstack.org/24/673824/1/check/ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa/ea31f2f/ : SUCCESS in 47m 14s (non-voting)\n- nova-cells-v1 http://logs.openstack.org/24/673824/1/check/nova-cells-v1/217a7a4/ : SUCCESS in 50m 54s\n- nova-grenade-live-migration http://logs.openstack.org/24/673824/1/check/nova-grenade-live-migration/e67e4bc/ : SUCCESS in 1h 01m 47s (non-voting)\n- nova-live-migration http://logs.openstack.org/24/673824/1/check/nova-live-migration/443008e/ : SUCCESS in 43m 46s\n- nova-multiattach http://logs.openstack.org/24/673824/1/check/nova-multiattach/d770d33/ : SUCCESS in 1h 09m 34s\n- nova-next http://logs.openstack.org/24/673824/1/check/nova-next/3908bfc/ : SUCCESS in 1h 35m 26s\n- tempest-slow http://logs.openstack.org/24/673824/1/check/tempest-slow/facc0f4/ : SUCCESS in 2h 03m 19s\n- nova-tox-functional http://logs.openstack.org/24/673824/1/check/nova-tox-functional/525cff3/ : SUCCESS in 19m 31s\n- nova-tox-functional-py35 http://logs.openstack.org/24/673824/1/check/nova-tox-functional-py35/97b1a39/ : SUCCESS in 20m 22s\n- neutron-grenade-multinode http://logs.openstack.org/24/673824/1/check/neutron-grenade-multinode/0d6211d/ : SUCCESS in 1h 12m 14s\n- devstack-plugin-ceph-tempest http://logs.openstack.org/24/673824/1/check/devstack-plugin-ceph-tempest/a4370d5/ : SUCCESS in 1h 15m 52s (non-voting)\n- tempest-multinode-full http://logs.openstack.org/24/673824/1/check/tempest-multinode-full/ccfaaab/ : SUCCESS in 1h 41m 34s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"d1f0cac82fb9eb0881014167b7158e9691df4abf","author":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"date":"2019-07-31 20:21:56.000000000","message":"Patch Set 1:\n\nBuild succeeded.\n\n- Nova-ML2-Sriov http://13.74.249.42/24/673824/1/check-nova/Nova-ML2-Sriov/85332b1 : FAILURE in 29m 59s (non-voting)\n\nTo re-run the job post \u0027recheck nova-mlnx\u0027 comment. For more information visit https://wiki.openstack.org/wiki/ThirdPartySystems/Mellanox_CI","accounts_in_message":[],"_revision_number":1},{"id":"782f082f408c816e629c6e073ecf68eae1cff026","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2019-08-09 15:21:25.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"41071d52c144385afde233d346d5c4e8c703f869","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-09 15:23:47.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"ab26868891cbb9677953b50d45ab218ca329d74f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-09 17:32:30.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"881ffda0de63ef1a6a0943975801a5d2bf7b84a9","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-09 17:32:30.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://logs.opendev.org/24/673824/1/gate/openstack-tox-pep8/5d2cefe/ : SUCCESS in 9m 05s\n- openstack-tox-py27 https://logs.opendev.org/24/673824/1/gate/openstack-tox-py27/5b1ac43/ : SUCCESS in 17m 45s\n- openstack-tox-py35 https://logs.opendev.org/24/673824/1/gate/openstack-tox-py35/48c4552/ : SUCCESS in 14m 55s\n- build-openstack-sphinx-docs https://logs.opendev.org/24/673824/1/gate/build-openstack-sphinx-docs/30e9ce7/html/ : SUCCESS in 7m 43s\n- tempest-full https://logs.opendev.org/24/673824/1/gate/tempest-full/f58557e/ : SUCCESS in 1h 22m 41s\n- neutron-grenade https://logs.opendev.org/24/673824/1/gate/neutron-grenade/1bc9898/ : SUCCESS in 48m 54s\n- tempest-full-py3 https://logs.opendev.org/24/673824/1/gate/tempest-full-py3/d720b5c/ : SUCCESS in 1h 21m 34s\n- nova-cells-v1 https://logs.opendev.org/24/673824/1/gate/nova-cells-v1/0f55ac9/ : SUCCESS in 53m 07s\n- nova-live-migration https://logs.opendev.org/24/673824/1/gate/nova-live-migration/5de7210/ : SUCCESS in 49m 54s\n- nova-multiattach https://logs.opendev.org/24/673824/1/gate/nova-multiattach/f1cf3d9/ : SUCCESS in 1h 13m 33s\n- nova-next https://logs.opendev.org/24/673824/1/gate/nova-next/b0d81c8/ : SUCCESS in 1h 26m 28s\n- tempest-slow https://logs.opendev.org/24/673824/1/gate/tempest-slow/8561cf0/ : SUCCESS in 2h 01m 11s\n- nova-tox-functional https://logs.opendev.org/24/673824/1/gate/nova-tox-functional/35e0735/ : SUCCESS in 22m 17s\n- nova-tox-functional-py35 https://logs.opendev.org/24/673824/1/gate/nova-tox-functional-py35/eac74a4/ : SUCCESS in 18m 58s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"de035bbfccbfd5a3e7516434171e89e9df7d08fa","revisions":{"de035bbfccbfd5a3e7516434171e89e9df7d08fa":{"kind":"REWORK","_number":1,"created":"2019-07-31 14:00:38.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/24/673824/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/24/673824/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/24/673824/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/24/673824/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/24/673824/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/24/673824/1"}}},"commit":{"parents":[{"commit":"95a35cbee44f8e97aa6d3a04820175c052f03cb3","subject":"Merge \"Init HostState.failed_builds\" into stable/queens","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/95a35cbee44f8e97aa6d3a04820175c052f03cb3"}]}],"author":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2018-04-17 20:20:53.000000000","tz":-240},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-07-31 14:00:20.000000000","tz":-240},"subject":"Add functional recreate test for bug 1764556","message":"Add functional recreate test for bug 1764556\n\nThis attempts to recreate the following scenario:\n\n1) boot instance on ocata host where the compute service\n   does not have a uuid\n2) migrate instance\n3) delete the ocata service (thus deleting the compute node)\n4) start compute service with the same name\n5) migrate instance to newly-created compute node\n6) upgrade to pike where services.uuid data migration happens\n7) list instances as admin to join on the services table\n\nThe failure occurs when listing instances because the deleted\nservice with the same name as the compute host that the instance\nis running on gets pulled from the DB and the Service object\nattempts to set a uuid on it, which fails since it\u0027s not using\na read_deleted\u003d\"yes\" context.\n\nWhile working on this, the service_get_all_by_binary DB API\nmethod had to be fixed to not hard-code read_deleted\u003d\"no\" since\nthe test needs to be able to read deleted services, which it can\ncontrol via its own context object (note that\nRequestContext.read_deleted already defaults to \"no\" so the\nhard-coding in the DB API is unnecessarily restrictive).\n\nChange-Id: I4d60da26fcf0a77628d1fdf4e818884614fa4f02\nRelated-Bug: #1764556\n(cherry picked from commit 81f05f53d357a546c7f9a53cae6ef45b92e28bc1)\n(cherry picked from commit 44709cfb5cfa6a8a384eb391ad520de55b2fa247)\n(cherry picked from commit eadd78efe39e1958d14319cfcdbda15862485845)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/de035bbfccbfd5a3e7516434171e89e9df7d08fa"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/de035bbfccbfd5a3e7516434171e89e9df7d08fa"}]},"parents_data":[{"branch_name":"refs/heads/stable/queens","commit_id":"95a35cbee44f8e97aa6d3a04820175c052f03cb3","is_merged_in_target_branch":false}],"branch":"refs/heads/stable/queens"}},"requirements":[],"submit_records":[],"submit_requirements":[]}