)]}'
{"nova/api/openstack/compute/schemas/server_external_events.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8ea00ba81afc6194e0f6f24eedb9d3342c3a4deb","unresolved":false,"context_lines":[{"line_number":33,"context_line":"                            \u0027network-vif-plugged\u0027,"},{"line_number":34,"context_line":"                            \u0027network-vif-unplugged\u0027,"},{"line_number":35,"context_line":"                            \u0027network-vif-deleted\u0027,"},{"line_number":36,"context_line":"                            \u0027cyborg-acc-changed\u0027,"},{"line_number":37,"context_line":"                            \u0027cyborg-acc-attached\u0027,"},{"line_number":38,"context_line":"                            \u0027cyborg-acc-detached\u0027"},{"line_number":39,"context_line":"                        ],"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_2a0a0525","line":36,"range":{"start_line":36,"start_character":29,"end_line":36,"end_character":40},"updated":"2019-08-06 18:22:08.000000000","message":"I think you should take cyborg out of here. Just like we don\u0027t mention neutron here. This is an event for \"the accelerator service\" to send, not cyborg specifically.","commit_id":"5bd8292c73c086293cca73b25660724579b3e44e"}],"nova/conf/compute.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8ea00ba81afc6194e0f6f24eedb9d3342c3a4deb","unresolved":false,"context_lines":[{"line_number":170,"context_line":"  ``vif_plugging_is_fatal`` is False, events should not be expected to"},{"line_number":171,"context_line":"  arrive at all."},{"line_number":172,"context_line":"\"\"\"),"},{"line_number":173,"context_line":"    cfg.BoolOpt(\u0027acc_prepare_is_fatal\u0027,"},{"line_number":174,"context_line":"        default\u003dTrue,"},{"line_number":175,"context_line":"        help\u003d\"\"\""},{"line_number":176,"context_line":"Determine if instance should boot or fail on acc preparing timeout."}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_e5141e43","line":173,"updated":"2019-08-06 18:22:08.000000000","message":"Remove this. The vif plugging fatal flag is there only for historical reasons, because not all network backends have been updated to support it, as this interaction was added after neutron was already designed and implemented.\n\nWe should never consider the prepare to be optional if requested, so this should always be \"fatal\".","commit_id":"5bd8292c73c086293cca73b25660724579b3e44e"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8ea00ba81afc6194e0f6f24eedb9d3342c3a4deb","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        default\u003d300,"},{"line_number":197,"context_line":"        min\u003d0,"},{"line_number":198,"context_line":"        help\u003d\"\"\""},{"line_number":199,"context_line":"Timeout for Cyborg Accelerator attaching event message arrival."},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"Number of seconds to wait for Cyborg preparing accelerators before"},{"line_number":202,"context_line":"continuing or failing (see \u0027acc_prepare_is_fatal\u0027)."}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_053dbac2","line":199,"range":{"start_line":199,"start_character":12,"end_line":199,"end_character":18},"updated":"2019-08-06 18:22:08.000000000","message":"I would also s/Cyborg// here, although I\u0027m less concerned about easily-changed conf docs than I am the codified names in the schema. We mention neutron above, so I\u0027ll give you a pass on this :)","commit_id":"5bd8292c73c086293cca73b25660724579b3e44e"}],"nova/exception.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8ea00ba81afc6194e0f6f24eedb9d3342c3a4deb","unresolved":false,"context_lines":[{"line_number":138,"context_line":"class PrepareAcceleratorException(NovaException):"},{"line_number":139,"context_line":"    msg_fmt \u003d _(\"Preparation of Acclerator by Cyborg \""},{"line_number":140,"context_line":"                \"failed\")"},{"line_number":141,"context_line":"                "},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"class VirtualInterfaceUnplugException(NovaException):"},{"line_number":144,"context_line":"    msg_fmt \u003d _(\"Failed to unplug virtual interface: %(reason)s\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_c53242f2","line":141,"updated":"2019-08-06 18:22:08.000000000","message":"!","commit_id":"5bd8292c73c086293cca73b25660724579b3e44e"}],"nova/objects/external_event.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8ea00ba81afc6194e0f6f24eedb9d3342c3a4deb","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    \u0027network-vif-deleted\u0027,"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    # Accelerator Preparation Notification"},{"line_number":28,"context_line":"    \u0027cyborg-acc-changed\u0027,"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    # Volume was extended for this instance, tag is volume_id"},{"line_number":31,"context_line":"    \u0027volume-extended\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_85776aa0","line":28,"updated":"2019-08-06 18:22:08.000000000","message":"You\u0027ve added three values in the schema, but only one here. That means the api will accept those three values and try to stick them into the object, which will then fail. Either add all of them in both places (better I think), or only add what is here to the api right now.","commit_id":"5bd8292c73c086293cca73b25660724579b3e44e"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8ea00ba81afc6194e0f6f24eedb9d3342c3a4deb","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    #              Supports network-changed and vif-plugged"},{"line_number":41,"context_line":"    # Version 1.1: adds network-vif-deleted event"},{"line_number":42,"context_line":"    # Version 1.2: adds volume-extended event"},{"line_number":43,"context_line":"    # Version 1.3: adds cyborg-extended event"},{"line_number":44,"context_line":"    VERSION \u003d \u00271.2\u0027"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    fields \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_a57aa684","line":43,"range":{"start_line":43,"start_character":24,"end_line":43,"end_character":39},"updated":"2019-08-06 18:22:08.000000000","message":"This is not what you\u0027re adding.","commit_id":"5bd8292c73c086293cca73b25660724579b3e44e"}]}