)]}'
{"id":"openstack%2Fnova~674629","triplet_id":"openstack%2Fnova~master~Ic4cbbaf81938fc88980e44c4a17fe388f9c2b92b","project":"openstack/nova","branch":"master","topic":"bp/amd-sev-libvirt-support","hashtags":[],"change_id":"Ic4cbbaf81938fc88980e44c4a17fe388f9c2b92b","subject":"Fix libvirt driver tests to use LibvirtConfigCapsGuest instances","status":"MERGED","created":"2019-08-05 15:02:55.000000000","updated":"2019-08-16 19:12:17.000000000","submitted":"2019-08-16 19:12:17.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"674629-1565982737552-3f7c88c0","meta_rev_id":"9d2393318ebfc7eb6b9c860078863a0a6564fd02","_number":674629,"virtual_id_number":674629,"owner":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2019-08-16 08:21:26.000000000","_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},{"value":0,"date":"2019-08-16 04:25:06.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"date":"2019-08-15 19:14:11.000000000","_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"date":"2019-08-15 22:56:30.000000000","_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},{"value":0,"date":"2019-08-15 18:33:59.000000000","_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":0,"date":"2019-08-16 01:55:31.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"value":2,"date":"2019-08-16 19:12:16.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"recommended":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"all":[{"value":0,"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":1,"date":"2019-08-15 18:32:41.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"value":2,"date":"2019-08-15 18:32:41.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":2,"date":"2019-08-16 18:08:29.000000000","_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},{"value":0,"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"all":[{"value":0,"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":1,"date":"2019-08-16 18:08:29.000000000","_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},{"value":0,"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},{"value":0,"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-05 15:36:02.000000000","updated_by":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"reviewer":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"state":"REVIEWER"},{"updated":"2019-08-08 23:02:59.000000000","updated_by":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-08-09 13:20:38.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2019-08-10 10:57:40.000000000","updated_by":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-08-15 18:33:59.000000000","updated_by":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-08-15 19:14:11.000000000","updated_by":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-08-15 22:56:30.000000000","updated_by":{"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},"reviewer":{"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-08-16 01:55:31.000000000","updated_by":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"reviewer":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"state":"REVIEWER"},{"updated":"2019-08-16 04:25:06.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2019-08-16 08:21:26.000000000","updated_by":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-08-16 18:08:29.000000000","updated_by":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"reviewer":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"state":"REVIEWER"},{"updated":"2019-08-16 19:12:16.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"768ba46bb9694493a929e9966ba13d39de0ab37e","author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"date":"2019-08-05 15:02:55.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c5f342fb0eea4bc9abfdf0210baeaa1c01d0145e","author":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"date":"2019-08-05 15:04:29.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- tempest-dsvm-intel-nfv-xenial tempest-dsvm-intel-nfv-xenial : SKIPPED (non-voting)\n- tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial : SKIPPED (non-voting)\n- tempest-dsvm-ovsdpdk-nfv-networking-xenial tempest-dsvm-ovsdpdk-nfv-networking-xenial : SKIPPED (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"7070532b3ea2bab225987ee956320ed2af3213d1","author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"date":"2019-08-05 15:36:02.000000000","message":"Patch Set 1: Code-Review+1\n\nThanks for splitting it out.","accounts_in_message":[],"_revision_number":1},{"id":"57ec93571597a05246dbf1ca2e85dbd9a27c98c0","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-05 15:49:17.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://logs.opendev.org/29/674629/1/check/openstack-tox-cover/b62e24d/cover/ : SUCCESS in 19m 44s\n- openstack-tox-lower-constraints https://logs.opendev.org/29/674629/1/check/openstack-tox-lower-constraints/f06c556/ : SUCCESS in 20m 06s\n- openstack-tox-pep8 https://logs.opendev.org/29/674629/1/check/openstack-tox-pep8/989eb74/ : SUCCESS in 11m 25s\n- openstack-tox-py27 https://logs.opendev.org/29/674629/1/check/openstack-tox-py27/80cfc3f/ : SUCCESS in 18m 06s\n- openstack-tox-py36 https://logs.opendev.org/29/674629/1/check/openstack-tox-py36/a07b39f/ : SUCCESS in 15m 58s\n- openstack-tox-py37 https://logs.opendev.org/29/674629/1/check/openstack-tox-py37/f3dc639/ : SUCCESS in 16m 11s\n- openstack-tox-docs https://logs.opendev.org/29/674629/1/check/openstack-tox-docs/f9f9543/html/ : SUCCESS in 8m 06s\n- nova-tox-functional https://logs.opendev.org/29/674629/1/check/nova-tox-functional/c0126d4/ : SUCCESS in 26m 07s\n- nova-tox-functional-py36 https://logs.opendev.org/29/674629/1/check/nova-tox-functional-py36/5c13dbf/ : SUCCESS in 22m 52s","accounts_in_message":[],"_revision_number":1},{"id":"8ba81b4fd90d4b68250d1ef885d13083bf049e7b","author":{"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},"date":"2019-08-05 15:53:24.000000000","message":"Patch Set 1:\n\n* pci-test http://52.27.155.124/pci/674629/1 : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"dae7e1953ab9182b2af29a0aff46df1cbee9c41b","author":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"date":"2019-08-05 16:30:52.000000000","message":"Patch Set 1:\n\nTesting completed on the zVM Driver CI system check-nova pipeline.  To recheck only the zVM driver plugins, submit a comment with only zvm: recheck in the comment. Contact information: zvmosci@us.ibm.com. For information see https://wiki.openstack.org/wiki/ZVMDriver.\n\n- check-nova-master http://extbasicopstackcilog01.podc.sl.edst.ibm.com/test_logs/jenkins-check-nova-master-34699 : SUCCESS in 1h 26m 20s","accounts_in_message":[],"_revision_number":1},{"id":"86e8a338722e895e004e32159d4caf018307dbc4","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2019-08-05 16:36:13.000000000","message":"Patch Set 1:\n\nBuild failed\n\n- dsvm-nova http://207.189.188.190/logs/29/674629/1/check-vote/ext-nova-zuul/91bb4ac : FAILURE in 2m 28s","accounts_in_message":[],"_revision_number":1},{"id":"2362bee4010016c3a177ed34b50b945a8d758d61","author":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"date":"2019-08-05 16:53:01.000000000","message":"Patch Set 1:\n\n* nova-quobyteci-dsvm-volume http://78.46.57.153:8081/refs-changes-29-674629-1 : SUCCESS \n\nhttps://wiki.openstack.org/wiki/ThirdPartySystems/Quobyte_CI","accounts_in_message":[],"_revision_number":1},{"id":"7c65ce20ca8dcf1316ef42ff70c279cd75efa4ee","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-08-05 17:26:11.000000000","message":"Patch Set 1:\n\nBuild succeeded.\n\n- nova http://cloudbase-ci.com/nova/674629/1 : SUCCESS in 2h 20m 21s","accounts_in_message":[],"_revision_number":1},{"id":"0d6930f24bd90548db8c12703ed79699fddebda5","author":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"date":"2019-08-05 20:05:27.000000000","message":"Patch Set 1:\n\nBuild failed. Comment \u0027powervm: recheck\u0027 to recheck.\n For 3rd party CI contact info: https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_PowerVM_CI\n\n- nova-out-of-tree-pvm http://184.172.12.213/29/674629/1/check/nova-out-of-tree-pvm/b5efe80 : FAILURE in 2h 58m 25s\n- nova-in-tree-pvm http://184.172.12.213/29/674629/1/check/nova-in-tree-pvm/a3ffd61 : FAILURE in 5h 01m 10s","accounts_in_message":[],"_revision_number":1},{"id":"7c161600e09c49e7136ff5a3cd9fd31385cd7726","author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"date":"2019-08-08 16:52:05.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"bd416c2d26084defde2de38bb8b7f922a113bb41","author":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"date":"2019-08-08 16:57:49.000000000","message":"Patch Set 2:\n\nBuild succeeded (check pipeline).\n\n- tempest-dsvm-intel-nfv-xenial tempest-dsvm-intel-nfv-xenial : SKIPPED (non-voting)\n- tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial : SKIPPED (non-voting)\n- tempest-dsvm-ovsdpdk-nfv-networking-xenial tempest-dsvm-ovsdpdk-nfv-networking-xenial : SKIPPED (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"58f5af9dd1facc79966a59acbe41fcac4c5d07e1","author":{"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},"date":"2019-08-08 18:13:28.000000000","message":"Patch Set 2:\n\n* pci-test http://52.27.155.124/pci/674629/2 : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"47931c270a77473347ad7887ec36da42eff611d2","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-08-08 18:57:32.000000000","message":"Patch Set 2:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/674629/2 : FAILURE in 47s","accounts_in_message":[],"_revision_number":2},{"id":"6570153b2a8e0c85e9bfedd3d434d526e326f89b","author":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"date":"2019-08-08 19:06:43.000000000","message":"Patch Set 2:\n\nTesting completed on the zVM Driver CI system check-nova pipeline.  To recheck only the zVM driver plugins, submit a comment with only zvm: recheck in the comment. Contact information: zvmosci@us.ibm.com. For information see https://wiki.openstack.org/wiki/ZVMDriver.\n\n- check-nova-master http://extbasicopstackcilog01.podc.sl.edst.ibm.com/test_logs/jenkins-check-nova-master-34943 : SUCCESS in 1h 34m 13s","accounts_in_message":[],"_revision_number":2},{"id":"00291bd106e188b2feb89b331af4562f651ae294","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-08 21:26:56.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://logs.opendev.org/29/674629/2/check/openstack-tox-cover/afa043f/cover/ : SUCCESS in 20m 24s\n- openstack-tox-lower-constraints https://logs.opendev.org/29/674629/2/check/openstack-tox-lower-constraints/68e6450/ : SUCCESS in 20m 00s\n- openstack-tox-pep8 https://logs.opendev.org/29/674629/2/check/openstack-tox-pep8/6af023a/ : SUCCESS in 11m 07s\n- openstack-tox-py27 https://logs.opendev.org/29/674629/2/check/openstack-tox-py27/bf2ec24/ : SUCCESS in 21m 46s\n- openstack-tox-py36 https://logs.opendev.org/29/674629/2/check/openstack-tox-py36/819ea92/ : SUCCESS in 15m 05s\n- openstack-tox-py37 https://logs.opendev.org/29/674629/2/check/openstack-tox-py37/7df7fe4/ : SUCCESS in 19m 22s\n- openstack-tox-docs https://logs.opendev.org/29/674629/2/check/openstack-tox-docs/aa0afd2/html/ : SUCCESS in 6m 44s\n- nova-tox-functional https://logs.opendev.org/29/674629/2/check/nova-tox-functional/5382e15/ : SUCCESS in 25m 38s\n- nova-tox-functional-py36 https://logs.opendev.org/29/674629/2/check/nova-tox-functional-py36/984336f/ : SUCCESS in 22m 36s","accounts_in_message":[],"_revision_number":2},{"id":"b2b37d0107b7cccf2f9398360270fcd8b18c073a","author":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"date":"2019-08-08 21:27:42.000000000","message":"Patch Set 2:\n\nBuild failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\n- EMC_VxFlexOS_NOVA http://publiclogs.emc.com/29/674629/2/check/EMC_VxFlexOS_NOVA/8c92fb0/EMC_VxFlexOS_NOVA/None : NOT_REGISTERED\n\nLeave a comment with \u0027run-DellEMC VxFlexOS CI\u0027 to trigger a recheck. For more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_VxFlexOS_CI","accounts_in_message":[],"_revision_number":2},{"id":"dc930290ec3756410715d98b5e1f115bdf81b207","author":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"date":"2019-08-08 23:02:59.000000000","message":"Patch Set 2:\n\nBuild failed. Comment \u0027powervm: recheck\u0027 to recheck.\n For 3rd party CI contact info: https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_PowerVM_CI\n\n- nova-out-of-tree-pvm http://184.172.12.213/29/674629/2/check/nova-out-of-tree-pvm/0b1fc59 : FAILURE in 5h 05m 56s\n- nova-in-tree-pvm http://184.172.12.213/29/674629/2/check/nova-in-tree-pvm/2e33ff5 : FAILURE in 4h 01m 03s","accounts_in_message":[],"_revision_number":2},{"id":"c9fba801de334452bac943881833aa39b5b5a406","author":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"date":"2019-08-08 23:46:12.000000000","message":"Patch Set 2:\n\n* nova-quobyteci-dsvm-volume http://78.46.57.153:8081/refs-changes-29-674629-2 : FAILURE \n\nSee https://wiki.openstack.org/wiki/ThirdPartySystems/Quobyte_CI for rechecking and info.","accounts_in_message":[],"_revision_number":2},{"id":"663e5cd14a94d794baca06f3784fbd1e5a09514c","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2019-08-09 13:20:38.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)\n\nWhoops","accounts_in_message":[],"_revision_number":2},{"id":"e9dba638f08ba4f8afb538a778233ecf69a5e342","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2019-08-10 10:57:40.000000000","message":"Patch Set 2:\n\nBuild failed\n\n- dsvm-nova http://207.189.188.190/logs/29/674629/2/check-vote/ext-nova-zuul/fa63007 : FAILURE in 2m 40s","accounts_in_message":[],"_revision_number":2},{"id":"93680cf9555b755452422b4aa92c1975365a1943","author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"date":"2019-08-15 18:32:41.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"f5bd68c336b2c0358ea00e6cfb26dbffd7d893c3","author":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"date":"2019-08-15 18:33:59.000000000","message":"Patch Set 3:\n\nBuild succeeded (check pipeline).\n\n- tempest-dsvm-intel-nfv-xenial tempest-dsvm-intel-nfv-xenial : SKIPPED (non-voting)\n- tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial : SKIPPED (non-voting)\n- tempest-dsvm-ovsdpdk-nfv-networking-xenial tempest-dsvm-ovsdpdk-nfv-networking-xenial : SKIPPED (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"45a68ce7e4b14e647c256b5ac50dc1c1eb6907f9","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-15 19:13:34.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/4f97cd2f23b84fad9980330af3d9a93b : SUCCESS in 20m 20s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/54308dd345454df2ac887fcbf421d0c7 : SUCCESS in 24m 23s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/67979eec4689411a98e5f07bc88d71aa : SUCCESS in 10m 54s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/343b09bfdcfd4225b8225fa922af40e5 : SUCCESS in 17m 47s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/7ed512072cab477a89b9c4af303eacd7 : SUCCESS in 13m 37s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/a6e446c3b3e0430c8ef708ea92bc08cf : SUCCESS in 20m 49s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0f985a4fc22c44aea270065aa6e74bd8 : SUCCESS in 8m 15s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/0bcfe8e660e34602a7696aa78fa05519 : SUCCESS in 19m 56s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/2d132e0d7f5a4221b4dcd192ec19e53a : SUCCESS in 16m 22s","accounts_in_message":[],"_revision_number":3},{"id":"ed562d96452f5f4ee396adb36f5eb082dd9989c2","author":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"date":"2019-08-15 19:14:11.000000000","message":"Patch Set 3:\n\nBuild failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\n- EMC_VxFlexOS_NOVA http://publiclogs.emc.com/29/674629/3/check/EMC_VxFlexOS_NOVA/069a353/EMC_VxFlexOS_NOVA/None : NOT_REGISTERED\n\nLeave a comment with \u0027run-DellEMC VxFlexOS CI\u0027 to trigger a recheck. For more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_VxFlexOS_CI","accounts_in_message":[],"_revision_number":3},{"id":"5b15155d795748dc78e6d580ccf70d5bb0f3409f","author":{"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},"date":"2019-08-15 22:56:30.000000000","message":"Patch Set 3:\n\n* pci-test http://52.27.155.124/pci/674629/3 : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"312b0e22c4bbbc7305d33832925ab291f2029a98","author":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"date":"2019-08-16 01:55:31.000000000","message":"Patch Set 3:\n\nTesting completed on the zVM Driver CI system check-nova pipeline and failed.  To recheck only the zVM driver plugins, submit a comment with only  zvm: recheck in the comment.. Contact information: zvmosci@us.ibm.com. For information see https://wiki.openstack.org/wiki/ZVMDriver.\n\n- check-nova-master http://extbasicopstackcilog01.podc.sl.edst.ibm.com/test_logs/jenkins-check-nova-master-35227 : FAILURE in 1h 54m 42s","accounts_in_message":[],"_revision_number":3},{"id":"a1f508d738c8342a2b7ebae434c87d968916038e","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-08-16 04:25:06.000000000","message":"Patch Set 3:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/674629/3 : FAILURE in 2h 25m 01s","accounts_in_message":[],"_revision_number":3},{"id":"bffe43db202d95ce9b888e215fbbb8ace01633c1","author":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"date":"2019-08-16 08:21:26.000000000","message":"Patch Set 3:\n\n* nova-quobyteci-dsvm-volume http://78.46.57.153:8081/refs-changes-29-674629-3 : SUCCESS \n\nhttps://wiki.openstack.org/wiki/ThirdPartySystems/Quobyte_CI","accounts_in_message":[],"_revision_number":3},{"id":"244dcb70039cf768f0692d7041ff50a77ae5f1df","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-08-16 18:08:29.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"fb9ca9259430bf652ef44772fe33c3803da8efb9","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-16 18:12:10.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"bc83abca65b86899ca7ea866f360dd0d4d9443c5","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-16 19:12:16.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/69e0b4718ff34aa088acd99c6ad488c8 : SUCCESS in 16m 02s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f2764c621bd347bb9f3909316cab770d : SUCCESS in 9m 33s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/8fb51e8861664f92b61dd35ad2b20cc6 : SUCCESS in 14m 10s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/0b4825f7103143cfa3e03feccba3f454 : SUCCESS in 12m 25s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/58c386991f2141deb7ed2ae3d8e87071 : SUCCESS in 15m 56s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/dc02f9555b6748afba5e434cf3e318a8 : SUCCESS in 7m 55s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/f41ab63e65154156b8ceffe626597993 : SUCCESS in 23m 50s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/d6a23dc682c048b987b7bd084d77d906 : SUCCESS in 16m 35s","accounts_in_message":[],"_revision_number":3},{"id":"df0bd88910260f52bf1f10d5a5bb833410b97068","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-16 19:12:17.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"d5b9b0052a25a7a448df0b2523b48e9f2ff279e0","revisions":{"3fb59df5ae2af93650cf8923e577b93d783135e1":{"kind":"REWORK","_number":1,"created":"2019-08-05 15:02:55.000000000","uploader":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"ref":"refs/changes/29/674629/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/29/674629/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/29/674629/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/29/674629/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/29/674629/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/29/674629/1"}}},"commit":{"parents":[{"commit":"d7a4d0d7fef6e5be17fc89fd48d0b21eecae1ae3","subject":"Allow assertXmlEqual() to pass options to matchers.XMLMatches","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d7a4d0d7fef6e5be17fc89fd48d0b21eecae1ae3"}]}],"author":{"name":"Adam Spiers","email":"aspiers@suse.com","date":"2019-08-05 14:39:41.000000000","tz":60},"committer":{"name":"Adam Spiers","email":"aspiers@suse.com","date":"2019-08-05 15:01:14.000000000","tz":60},"subject":"Fix libvirt driver tests to use LibvirtConfigCapsGuest instances","message":"Fix libvirt driver tests to use LibvirtConfigCapsGuest instances\n\ntest_driver.LibvirtConnTestCase.test_cpu_info() and\ntest_driver.LibvirtConnTestCase.test_get_instance_capabilities() were\nincorrectly adding LibvirtConfigGuest fixture objects to the guests\nattribute of LibvirtConfigCaps, rather than LibvirtConfigCapsGuest\nobjects which is what the parse_dom() method of LibvirtConfigCaps\ndoes.  LibvirtConfigCaps is intended to capture all useful information\nreturned by libvirt\u0027s getCapabilities API call, and\nLibvirtConfigCapsGuest is intended to capture a small subset of that.\nIn contrast, LibvirtConfigGuest is intended for holding the entire\nconfiguration of a libvirt guest domain.\n\nSo fix this to instead add LibvirtConfigCapsGuest fixtures.\n\nNote that despite this bug, the tests previously passed through\nduck-typing because LibvirtConfigCaps does not define __slots__ or any\nother mechanism for limiting how attributes can be set on instances.\n\nThis is required by another commit in the SEV series in the near\nfuture which will alter the fields within LibvirtConfigCapsGuest.\n\nblueprint: amd-sev-libvirt-support\nChange-Id: Ic4cbbaf81938fc88980e44c4a17fe388f9c2b92b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3fb59df5ae2af93650cf8923e577b93d783135e1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3fb59df5ae2af93650cf8923e577b93d783135e1"}]},"branch":"refs/heads/master"},"8ba15355c505ac3c27b928beba7586101a8ced5d":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2019-08-08 16:52:05.000000000","uploader":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"ref":"refs/changes/29/674629/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/29/674629/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/29/674629/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/29/674629/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/29/674629/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/29/674629/2"}}},"commit":{"parents":[{"commit":"e208c9bf20559baf1767b04a730250255c9cf765","subject":"Allow assertXmlEqual() to pass options to matchers.XMLMatches","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/e208c9bf20559baf1767b04a730250255c9cf765"}]}],"author":{"name":"Adam Spiers","email":"aspiers@suse.com","date":"2019-08-05 14:39:41.000000000","tz":60},"committer":{"name":"Adam Spiers","email":"aspiers@suse.com","date":"2019-08-08 16:47:59.000000000","tz":60},"subject":"Fix libvirt driver tests to use LibvirtConfigCapsGuest instances","message":"Fix libvirt driver tests to use LibvirtConfigCapsGuest instances\n\ntest_driver.LibvirtConnTestCase.test_cpu_info() and\ntest_driver.LibvirtConnTestCase.test_get_instance_capabilities() were\nincorrectly adding LibvirtConfigGuest fixture objects to the guests\nattribute of LibvirtConfigCaps, rather than LibvirtConfigCapsGuest\nobjects which is what the parse_dom() method of LibvirtConfigCaps\ndoes.  LibvirtConfigCaps is intended to capture all useful information\nreturned by libvirt\u0027s getCapabilities API call, and\nLibvirtConfigCapsGuest is intended to capture a small subset of that.\nIn contrast, LibvirtConfigGuest is intended for holding the entire\nconfiguration of a libvirt guest domain.\n\nSo fix this to instead add LibvirtConfigCapsGuest fixtures.\n\nNote that despite this bug, the tests previously passed through\nduck-typing because LibvirtConfigCaps does not define __slots__ or any\nother mechanism for limiting how attributes can be set on instances.\n\nThis is required by another commit in the SEV series in the near\nfuture which will alter the fields within LibvirtConfigCapsGuest.\n\nblueprint: amd-sev-libvirt-support\nChange-Id: Ic4cbbaf81938fc88980e44c4a17fe388f9c2b92b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/8ba15355c505ac3c27b928beba7586101a8ced5d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/8ba15355c505ac3c27b928beba7586101a8ced5d"}]},"branch":"refs/heads/master"},"d5b9b0052a25a7a448df0b2523b48e9f2ff279e0":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2019-08-15 18:32:41.000000000","uploader":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"ref":"refs/changes/29/674629/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/29/674629/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/29/674629/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/29/674629/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/29/674629/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/29/674629/3"}}},"commit":{"parents":[{"commit":"1e05b9e61c24d90cc93d4507832e45a8036b6d33","subject":"Allow assertXmlEqual() to pass options to matchers.XMLMatches","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/1e05b9e61c24d90cc93d4507832e45a8036b6d33"}]}],"author":{"name":"Adam Spiers","email":"aspiers@suse.com","date":"2019-08-05 14:39:41.000000000","tz":60},"committer":{"name":"Adam Spiers","email":"aspiers@suse.com","date":"2019-08-15 18:24:26.000000000","tz":60},"subject":"Fix libvirt driver tests to use LibvirtConfigCapsGuest instances","message":"Fix libvirt driver tests to use LibvirtConfigCapsGuest instances\n\ntest_driver.LibvirtConnTestCase.test_cpu_info() and\ntest_driver.LibvirtConnTestCase.test_get_instance_capabilities() were\nincorrectly adding LibvirtConfigGuest fixture objects to the guests\nattribute of LibvirtConfigCaps, rather than LibvirtConfigCapsGuest\nobjects which is what the parse_dom() method of LibvirtConfigCaps\ndoes.  LibvirtConfigCaps is intended to capture all useful information\nreturned by libvirt\u0027s getCapabilities API call, and\nLibvirtConfigCapsGuest is intended to capture a small subset of that.\nIn contrast, LibvirtConfigGuest is intended for holding the entire\nconfiguration of a libvirt guest domain.\n\nSo fix this to instead add LibvirtConfigCapsGuest fixtures.\n\nNote that despite this bug, the tests previously passed through\nduck-typing because LibvirtConfigCaps does not define __slots__ or any\nother mechanism for limiting how attributes can be set on instances.\n\nThis is required by another commit in the SEV series in the near\nfuture which will alter the fields within LibvirtConfigCapsGuest.\n\nblueprint: amd-sev-libvirt-support\nChange-Id: Ic4cbbaf81938fc88980e44c4a17fe388f9c2b92b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d5b9b0052a25a7a448df0b2523b48e9f2ff279e0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d5b9b0052a25a7a448df0b2523b48e9f2ff279e0"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}