)]}'
{"id":"openstack%2Fnova~674636","triplet_id":"openstack%2Fnova~stable%2Fqueens~Ie217523a8969326b27930d7f74e50e9b352ab7a1","project":"openstack/nova","branch":"stable/queens","topic":"bug/1835070","hashtags":[],"change_id":"Ie217523a8969326b27930d7f74e50e9b352ab7a1","subject":"Stabilize unshelve notification sample tests","status":"MERGED","created":"2019-08-05 15:33:46.000000000","updated":"2019-08-09 14:38:24.000000000","submitted":"2019-08-09 14:38:23.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"674636-1565361504259-c4f9ddb8","meta_rev_id":"befb16bce0c9bc61f0e0a54c47f760be6718ef13","_number":674636,"virtual_id_number":674636,"owner":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-08-09 14:38:23.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"date":"2019-08-05 15:55:33.000000000","_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"date":"2019-08-05 16:18:54.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-08-09 13:20:18.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":1,"date":"2019-08-08 13:23:28.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-08-09 13:20:18.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-05 15:55:33.000000000","updated_by":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-08-05 16:18:54.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2019-08-08 13:23:28.000000000","updated_by":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"reviewer":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"state":"REVIEWER"},{"updated":"2019-08-09 13:20:18.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2019-08-09 14:38:23.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"d16976ec2377a0cc75522e52740e678bd2f6a4e2","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2019-08-05 15:33:46.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"69b53dbef5e02f89e092574cc5c9e2e7039ff9ec","author":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"date":"2019-08-05 15:55:33.000000000","message":"Patch Set 1:\n\nBuild failed. Comment \u0027powervm: recheck\u0027 to recheck.\n For 3rd party CI contact info: https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_PowerVM_CI\n\n- nova-out-of-tree-pvm http://184.172.12.213/36/674636/1/check/nova-out-of-tree-pvm/630c1e5 : FAILURE in 20m 15s\n- nova-in-tree-pvm http://184.172.12.213/36/674636/1/check/nova-in-tree-pvm/5ad69cb : FAILURE in 21m 07s","accounts_in_message":[],"_revision_number":1},{"id":"c76f5b23fcd89f1cdc5b292f04a2034c75cd2e3d","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-08-05 16:18:54.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/674636/1 : FAILURE in 43m 59s","accounts_in_message":[],"_revision_number":1},{"id":"c426110a10e6c2681361fd49d6f92b950ac5f812","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-05 16:25:59.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://logs.opendev.org/36/674636/1/check/openstack-tox-pep8/97899b5/ : SUCCESS in 10m 13s\n- openstack-tox-py27 https://logs.opendev.org/36/674636/1/check/openstack-tox-py27/8544547/ : SUCCESS in 13m 51s\n- openstack-tox-py35 https://logs.opendev.org/36/674636/1/check/openstack-tox-py35/f34d7ed/ : SUCCESS in 13m 53s\n- build-openstack-sphinx-docs https://logs.opendev.org/36/674636/1/check/build-openstack-sphinx-docs/02678a8/html/ : SUCCESS in 7m 30s\n- nova-tox-functional https://logs.opendev.org/36/674636/1/check/nova-tox-functional/cbd68e7/ : SUCCESS in 24m 23s\n- nova-tox-functional-py35 https://logs.opendev.org/36/674636/1/check/nova-tox-functional-py35/c7e7ff4/ : SUCCESS in 19m 34s","accounts_in_message":[],"_revision_number":1},{"id":"b9b0e7f739db6d404d48371cc133aca81da8b6f5","author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"date":"2019-08-08 13:23:28.000000000","message":"Patch Set 1: Code-Review+1\n\nlgtm","accounts_in_message":[],"_revision_number":1},{"id":"6663457383ccc1dc1cf3fca1b2e13fd49d31b070","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-08-09 13:20:18.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nSimple backport for a test stability fix, conflict is noted, I\u0027m going to fast approve since this is trivial and test-only.","accounts_in_message":[],"_revision_number":1},{"id":"ffeecf382a0f981d1a51bb8bef38b8553d18583e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-09 13:23:52.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"92bc85ff7ee2b34fb4de1fa04ea89311904a1b85","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-09 14:38:23.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://logs.opendev.org/36/674636/1/gate/openstack-tox-pep8/c4e39ce/ : SUCCESS in 9m 56s\n- openstack-tox-py27 https://logs.opendev.org/36/674636/1/gate/openstack-tox-py27/94a381d/ : SUCCESS in 14m 48s\n- openstack-tox-py35 https://logs.opendev.org/36/674636/1/gate/openstack-tox-py35/f803199/ : SUCCESS in 14m 20s\n- build-openstack-sphinx-docs https://logs.opendev.org/36/674636/1/gate/build-openstack-sphinx-docs/afc89fd/html/ : SUCCESS in 8m 54s\n- nova-tox-functional https://logs.opendev.org/36/674636/1/gate/nova-tox-functional/cb2b9cd/ : SUCCESS in 19m 22s\n- nova-tox-functional-py35 https://logs.opendev.org/36/674636/1/gate/nova-tox-functional-py35/73990b2/ : SUCCESS in 17m 35s","accounts_in_message":[],"_revision_number":1},{"id":"3877b2373c248d6c6b2a14f5d2cde84934bf4f54","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-09 14:38:24.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"8afc39a2c748a8fde070493dd5633788f782c69a","revisions":{"8afc39a2c748a8fde070493dd5633788f782c69a":{"kind":"REWORK","_number":1,"created":"2019-08-05 15:33:46.000000000","uploader":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"ref":"refs/changes/36/674636/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/36/674636/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/36/674636/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/36/674636/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/36/674636/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/36/674636/1"}}},"commit":{"parents":[{"commit":"95a35cbee44f8e97aa6d3a04820175c052f03cb3","subject":"Merge \"Init HostState.failed_builds\" into stable/queens","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/95a35cbee44f8e97aa6d3a04820175c052f03cb3"}]}],"author":{"name":"Balazs Gibizer","email":"balazs.gibizer@est.tech","date":"2019-07-02 12:56:40.000000000","tz":120},"committer":{"name":"Balazs Gibizer","email":"balazs.gibizer@est.tech","date":"2019-08-05 15:15:55.000000000","tz":120},"subject":"Stabilize unshelve notification sample tests","message":"Stabilize unshelve notification sample tests\n\nThe notification sample test for unshelve waits for the instance to\nreach ACTIVE state and then asserts if unshelve.end notification is\nemitted properly. However the instance.vm_state is set to ACTIVE earlier[1]\nthan emitting the unshelve.end notification[2]. This can cause two\ndifferent test case failure.\n\n1) _test_unshelve_server() fails with no ushelve.end notification\nreceived.\n\n2) _test_shelve_and_shelve_offload_server() also has a unshelve action\nat the end and that test step also only waits for the the ACTIVE state.\nSo the unshelve.end notification from the end of\n_test_shelve_and_shelve_offload_server() can bleed into the\n_test_unshelve_server() step causing that it receive one more\nnotifications.\n\nSo this patch adds an extra\nself._wait_for_notification(\u0027instance.unshelve.end\u0027) call to each test\nstep to prevent the instability.\n\n[1] https://github.com/openstack/nova/blob/5c6c1f8f/nova/compute/manager.py#L5322-L5326\n[2] https://github.com/openstack/nova/blob/5c6c1f8f/nova/compute/manager.py#L5329\n[3] https://github.com/openstack/nova/blob/5c6c1f8f/nova/tests/functional/notification_sample_tests/test_instance.py#L836\n\nConflicts:\n      nova/tests/functional/notification_sample_tests/test_instance.py\nConflicts due to:\n* I1a0afa0e8740c229db77c18b932e316196880de5\n\nCloses-Bug: #1835070\n\nChange-Id: Ie217523a8969326b27930d7f74e50e9b352ab7a1\n(cherry picked from commit 40f1e7c4c22dc6023614b34f28bb7fc416b668a8)\n(cherry picked from commit 3bc6ff029ff24083844db363010988d8d08cff00)\n(cherry picked from commit a85ce04fa39e60e672e4fa2d7912f6880079c6ef)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/8afc39a2c748a8fde070493dd5633788f782c69a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/8afc39a2c748a8fde070493dd5633788f782c69a"}]},"branch":"refs/heads/stable/queens"}},"requirements":[],"submit_records":[],"submit_requirements":[]}