)]}'
{"id":"openstack%2Fnova~674770","triplet_id":"openstack%2Fnova~stable%2Frocky~I745aecb008f0867fcda2d3d2c7691621dd8f6168","project":"openstack/nova","branch":"stable/rocky","topic":"bug/1788527","hashtags":[],"change_id":"I745aecb008f0867fcda2d3d2c7691621dd8f6168","subject":"Remove redundant group host setup","status":"ABANDONED","created":"2019-08-06 10:32:55.000000000","updated":"2019-12-17 21:08:42.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"25c3fe77d48de4ed006dd2eac0b1ad5de317f111","_number":674770,"virtual_id_number":674770,"owner":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"date":"2019-08-06 11:53:24.000000000","_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"date":"2019-08-06 13:52:25.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"date":"2019-08-06 14:46:47.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":1,"date":"2019-08-06 15:39:09.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":-1,"date":"2019-11-27 11:31:15.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"date":"2019-08-08 14:08:50.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"date":"2019-10-10 12:15:05.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-06 11:53:24.000000000","updated_by":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-08-06 13:52:25.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2019-08-06 14:46:47.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-08-06 15:39:09.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-08-08 14:08:50.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2019-10-10 12:15:05.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"REVIEWER"},{"updated":"2019-11-27 11:31:15.000000000","updated_by":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"reviewer":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"state":"REVIEWER"}],"messages":[{"id":"910701e874a408ab7c5395d7f2de950347992e4f","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2019-08-06 10:32:55.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f56540f51b9fa7bd67b4fdd30d6697e5b9229842","author":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"date":"2019-08-06 11:53:24.000000000","message":"Patch Set 1:\n\nBuild failed. Comment \u0027powervm: recheck\u0027 to recheck.\n For 3rd party CI contact info: https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_PowerVM_CI\n\n- nova-out-of-tree-pvm http://184.172.12.213/70/674770/1/check/nova-out-of-tree-pvm/f4cfbad : FAILURE in 22m 14s\n- nova-in-tree-pvm http://184.172.12.213/70/674770/1/check/nova-in-tree-pvm/985ffc9 : FAILURE in 22m 01s","accounts_in_message":[],"_revision_number":1},{"id":"d75a851cf2dd21f83fd1cd89e4fecb0bc8e9ddfd","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-08-06 13:52:25.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/674770/1 : FAILURE in 2h 15m 52s","accounts_in_message":[],"_revision_number":1},{"id":"8c4f3ed108cdcbba2dc999c327851136eeed6020","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2019-08-06 14:46:47.000000000","message":"Patch Set 1:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/70/674770/1/check/tempest-dsvm-full-xenial/34e736b/ : SUCCESS in 1h 16m 24s\n- tempest-dsvm-full-xenial-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/70/674770/1/check/tempest-dsvm-full-xenial-py3/fb4b642/ : FAILURE in 1h 15m 42s (non-voting)\n- grenade-dsvm-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/70/674770/1/check/grenade-dsvm-xenial/60b78b9/ : SUCCESS in 1h 02m 19s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"792039091b7702c0f721c28ef80ac0176d6690f4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-06 15:39:09.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://logs.opendev.org/70/674770/1/check/openstack-tox-pep8/bd8d06a/ : SUCCESS in 11m 12s\n- openstack-tox-py27 https://logs.opendev.org/70/674770/1/check/openstack-tox-py27/475cc44/ : SUCCESS in 16m 05s\n- openstack-tox-py35 https://logs.opendev.org/70/674770/1/check/openstack-tox-py35/2e5da08/ : SUCCESS in 27m 36s\n- build-openstack-sphinx-docs https://logs.opendev.org/70/674770/1/check/build-openstack-sphinx-docs/88b322a/html/ : SUCCESS in 10m 10s\n- tempest-full https://logs.opendev.org/70/674770/1/check/tempest-full/7db4677/ : SUCCESS in 1h 48m 49s\n- neutron-grenade https://logs.opendev.org/70/674770/1/check/neutron-grenade/f5bea98/ : SUCCESS in 50m 00s\n- tempest-full-py3 https://logs.opendev.org/70/674770/1/check/tempest-full-py3/328e674/ : SUCCESS in 1h 26m 42s\n- ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://logs.opendev.org/70/674770/1/check/ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa/e42c53d/ : SUCCESS in 58m 07s (non-voting)\n- nova-cells-v1 https://logs.opendev.org/70/674770/1/check/nova-cells-v1/5ba031b/ : SUCCESS in 1h 08m 13s\n- nova-grenade-live-migration https://logs.opendev.org/70/674770/1/check/nova-grenade-live-migration/9241806/ : SUCCESS in 1h 13m 16s (non-voting)\n- nova-live-migration https://logs.opendev.org/70/674770/1/check/nova-live-migration/2f55cd7/ : SUCCESS in 46m 18s\n- nova-multiattach https://logs.opendev.org/70/674770/1/check/nova-multiattach/537f68a/ : SUCCESS in 1h 16m 12s\n- nova-next https://logs.opendev.org/70/674770/1/check/nova-next/b293752/ : SUCCESS in 1h 35m 13s\n- tempest-slow https://logs.opendev.org/70/674770/1/check/tempest-slow/a60c73a/ : SUCCESS in 2h 21m 16s\n- nova-tox-functional https://logs.opendev.org/70/674770/1/check/nova-tox-functional/db90826/ : SUCCESS in 30m 00s\n- nova-tox-functional-py35 https://logs.opendev.org/70/674770/1/check/nova-tox-functional-py35/fd156fc/ : SUCCESS in 29m 47s\n- openstack-tox-lower-constraints https://logs.opendev.org/70/674770/1/check/openstack-tox-lower-constraints/d7ef5cf/ : SUCCESS in 12m 13s\n- neutron-grenade-multinode https://logs.opendev.org/70/674770/1/check/neutron-grenade-multinode/cbe6552/ : SUCCESS in 1h 13m 51s\n- devstack-plugin-ceph-tempest https://logs.opendev.org/70/674770/1/check/devstack-plugin-ceph-tempest/5c4f2c5/ : SUCCESS in 1h 24m 00s (non-voting)\n- tempest-multinode-full https://logs.opendev.org/70/674770/1/check/tempest-multinode-full/5b0d76c/ : SUCCESS in 1h 37m 17s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"72e089034e9037fd24afee0cce93ee1f27d76972","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-08-08 13:54:37.000000000","message":"Patch Set 1: Code-Review+2\n\nClean backport for a low priority fix. This is fine but I probably wouldn\u0027t take this past rocky to queens.","accounts_in_message":[],"_revision_number":1},{"id":"6ce371010c3faab60a70f3f892776cfe55d7c7c5","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-08-08 14:08:50.000000000","message":"Patch Set 1: -Code-Review\n\nActually once dansmith started looking at this he pointed out we\u0027re still calling the DB to load the group hosts for members of the group, which means this patch is just code cleanup, not really fixing a redundant DB call. I think the proper fix would have probably been to change to:\n\n  group_hosts \u003d group.hosts","accounts_in_message":[],"_revision_number":1},{"id":"ba97c3545b981246fd584355849c3f0f013ac2f7","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2019-11-27 11:31:15.000000000","message":"Patch Set 1: Code-Review-1\n\n-1 given Matt\u0027s feedback here from Dan.","accounts_in_message":[],"_revision_number":1},{"id":"4b15f514d7c30c6da166c08857df735e1121f53e","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-12-17 21:08:42.000000000","message":"Abandoned\n\nLet\u0027s just drop this.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"730ddc5b005259f3aa54e70a06cfe2c4c3d0d301","revisions":{"730ddc5b005259f3aa54e70a06cfe2c4c3d0d301":{"kind":"REWORK","_number":1,"created":"2019-08-06 10:32:55.000000000","uploader":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"ref":"refs/changes/70/674770/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/70/674770/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/70/674770/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/70/674770/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/70/674770/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/70/674770/1"}}},"commit":{"parents":[{"commit":"fa12df80fde59afd437c251057f9d428fb9f328a","subject":"Merge \"Fix python3 compatibility of rbd get_fsid\" into stable/rocky","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/fa12df80fde59afd437c251057f9d428fb9f328a"}]}],"author":{"name":"Balazs Gibizer","email":"balazs.gibizer@est.tech","date":"2019-06-18 11:17:27.000000000","tz":120},"committer":{"name":"Balazs Gibizer","email":"balazs.gibizer@est.tech","date":"2019-08-06 10:23:53.000000000","tz":120},"subject":"Remove redundant group host setup","message":"Remove redundant group host setup\n\nIt seems that all the code path that ends up calling [1] goes through\n[2] before so setting up group host at [1] is redundant.\n\n[1] https://github.com/openstack/nova/blob/c7e9e667426a6d88d396a59cb40d30763a3265f9/nova/scheduler/utils.py#L944-L950\n[2] https://github.com/openstack/nova/blob/c7e9e667426a6d88d396a59cb40d30763a3265f9/nova/scheduler/utils.py#L996-L1000\n\nChange-Id: I745aecb008f0867fcda2d3d2c7691621dd8f6168\nCloses-Bug: #1788527\n(cherry picked from commit f108d7967636ec1afceff0be386da15d70e2ca37)\n(cherry picked from commit 0313d8143309157067aa85f7333d0d177a5b6609)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/730ddc5b005259f3aa54e70a06cfe2c4c3d0d301"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/730ddc5b005259f3aa54e70a06cfe2c4c3d0d301"}]},"branch":"refs/heads/stable/rocky"}},"requirements":[],"submit_records":[],"submit_requirements":[]}