)]}'
{"doc/source/contributor/index.rst":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dc07940ef2e7cf148e7ea16c1733b2aa52bdfe26","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"  * :doc:`/contributor/testing/down-cell`"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"  * :doc:`/contributor/testing/eventlet-profiling`"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"The Nova API"},{"line_number":86,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7faddb67_448098bf","line":83,"updated":"2019-08-06 17:05:01.000000000","message":"I\u0027d probably put this in a new \"section\" like:\n\n  * **Profiling Guides**: These are guides to profiling nova.\n\n    * :doc:`/contributor/testing/eventlet-profiling`\n\nBecause they are a bit different from the other testing guides above and at some point I\u0027d like to have some docs in here about configuring nova with osprofiler for doing profiling, or at least also mentioning the new nova-osprofiler-redis job and how to run it and read the results.","commit_id":"36be360fc4521bc6567d3c6fa90a83a1c62d99db"}],"doc/source/contributor/testing/eventlet-profiling.rst":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dc07940ef2e7cf148e7ea16c1733b2aa52bdfe26","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"The process for profiling is:"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"1. Identify the method to be profiled"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"1. Populate the environment with sufficient resources to exercise the code. For"},{"line_number":43,"context_line":"   example you may wish to use the ``FakeVirtDriver`` to have nova aware of"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7faddb67_e4518431","line":40,"range":{"start_line":40,"start_character":29,"end_line":40,"end_character":37},"updated":"2019-08-06 17:05:01.000000000","message":"profiled.","commit_id":"36be360fc4521bc6567d3c6fa90a83a1c62d99db"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dc07940ef2e7cf148e7ea16c1733b2aa52bdfe26","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"1. Identify the method to be profiled"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"1. Populate the environment with sufficient resources to exercise the code. For"},{"line_number":43,"context_line":"   example you may wish to use the ``FakeVirtDriver`` to have nova aware of"},{"line_number":44,"context_line":"   multiple ``nova-compute`` processes. Or you may wish to launch many"},{"line_number":45,"context_line":"   instances if you are evaluating a method that loops over instances."}],"source_content_type":"text/x-rst","patch_set":1,"id":"7faddb67_c404881a","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":1},"updated":"2019-08-06 17:05:01.000000000","message":"Clearly the copy/paste of 1.\u0027s isn\u0027t probably correct, maybe just use #.?","commit_id":"36be360fc4521bc6567d3c6fa90a83a1c62d99db"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dc07940ef2e7cf148e7ea16c1733b2aa52bdfe26","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"1. Identify the method to be profiled"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"1. Populate the environment with sufficient resources to exercise the code. For"},{"line_number":43,"context_line":"   example you may wish to use the ``FakeVirtDriver`` to have nova aware of"},{"line_number":44,"context_line":"   multiple ``nova-compute`` processes. Or you may wish to launch many"},{"line_number":45,"context_line":"   instances if you are evaluating a method that loops over instances."}],"source_content_type":"text/x-rst","patch_set":1,"id":"7faddb67_2421dcb4","line":42,"updated":"2019-08-06 17:05:01.000000000","message":"Maybe we can link to the devstack docs on using the fake driver:\n\nhttps://docs.openstack.org/devstack/latest/guides/nova.html#fake-virt-driver\n\nor below...","commit_id":"36be360fc4521bc6567d3c6fa90a83a1c62d99db"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"ff60d3fd527de078eaa01fff5b5214da1346c8ca","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"1. Identify the method to be profiled"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"1. Populate the environment with sufficient resources to exercise the code. For"},{"line_number":43,"context_line":"   example you may wish to use the ``FakeVirtDriver`` to have nova aware of"},{"line_number":44,"context_line":"   multiple ``nova-compute`` processes. Or you may wish to launch many"},{"line_number":45,"context_line":"   instances if you are evaluating a method that loops over instances."}],"source_content_type":"text/x-rst","patch_set":1,"id":"7faddb67_0ff06dfd","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":1},"in_reply_to":"7faddb67_c404881a","updated":"2019-08-07 09:04:16.000000000","message":"I think I must have been channeling markdown here.","commit_id":"36be360fc4521bc6567d3c6fa90a83a1c62d99db"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dc07940ef2e7cf148e7ea16c1733b2aa52bdfe26","unresolved":false,"context_lines":[{"line_number":47,"context_line":"1. At the start of that method, change the code to instantiate a ``Profile``"},{"line_number":48,"context_line":"   object and ``start()`` it."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"1. At the end of that method, change the code to to ``stop()`` profiling and"},{"line_number":51,"context_line":"   write the data (with ``dump_stats()``) to a reasonable location."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"1. Restart the service."}],"source_content_type":"text/x-rst","patch_set":1,"id":"7faddb67_e42664cb","line":50,"range":{"start_line":50,"start_character":46,"end_line":50,"end_character":51},"updated":"2019-08-06 17:05:01.000000000","message":"to","commit_id":"36be360fc4521bc6567d3c6fa90a83a1c62d99db"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dc07940ef2e7cf148e7ea16c1733b2aa52bdfe26","unresolved":false,"context_lines":[{"line_number":68,"context_line":"presented with too many candidate results from the Placement service. We\u0027d like"},{"line_number":69,"context_line":"to know why."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"We\u0027ll configure and run devstack with ``FakeVirtDriver`` so there are several"},{"line_number":72,"context_line":"candidate hypervisors (the following ``local.conf`` is also useful for other"},{"line_number":73,"context_line":"profiling and benchmarking scenarios so not all changes are relevant here):"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7faddb67_ff13515a","line":71,"updated":"2019-08-06 17:05:01.000000000","message":"...or link to https://docs.openstack.org/devstack/latest/guides/nova.html#fake-virt-driver from here","commit_id":"36be360fc4521bc6567d3c6fa90a83a1c62d99db"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dc07940ef2e7cf148e7ea16c1733b2aa52bdfe26","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    SERVICE_PASSWORD\u003d$ADMIN_PASSWORD"},{"line_number":82,"context_line":"    USE_PYTHON3\u003dTrue"},{"line_number":83,"context_line":"    VIRT_DRIVER\u003dfake"},{"line_number":84,"context_line":"    NUMBER_FAKE_NOVA_COMPUTE\u003d50"},{"line_number":85,"context_line":"    disable_service cinder"},{"line_number":86,"context_line":"    disable_service horizon"},{"line_number":87,"context_line":"    disable_service dstat"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7faddb67_3f1fa95b","line":84,"updated":"2019-08-06 17:05:01.000000000","message":"This would be too much for me so we should maybe have a comment about that? Or drop to 10 or something more reasonable by default? The devstack docs also talk about this.","commit_id":"36be360fc4521bc6567d3c6fa90a83a1c62d99db"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dc07940ef2e7cf148e7ea16c1733b2aa52bdfe26","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    [[post-config|$NOVA_CONF]]"},{"line_number":91,"context_line":"    rpc_response_timeout \u003d 300"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    [quota]"},{"line_number":94,"context_line":"    driver \u003d \"nova.quota.NoopQuotaDriver\""},{"line_number":95,"context_line":"    [filter_scheduler]"},{"line_number":96,"context_line":"    enabled_filters \u003d \u0027\"\"\u0027"},{"line_number":97,"context_line":"    [notifications]"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7faddb67_bf47194c","line":94,"range":{"start_line":93,"start_character":4,"end_line":94,"end_character":41},"updated":"2019-08-06 17:05:01.000000000","message":"Devstack should handle this automatically for you when using the fake driver.\n\nhttps://github.com/openstack/devstack/blob/master/lib/nova_plugins/hypervisor-fake#L41","commit_id":"36be360fc4521bc6567d3c6fa90a83a1c62d99db"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dc07940ef2e7cf148e7ea16c1733b2aa52bdfe26","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    [quota]"},{"line_number":94,"context_line":"    driver \u003d \"nova.quota.NoopQuotaDriver\""},{"line_number":95,"context_line":"    [filter_scheduler]"},{"line_number":96,"context_line":"    enabled_filters \u003d \u0027\"\"\u0027"},{"line_number":97,"context_line":"    [notifications]"},{"line_number":98,"context_line":"    notification_format \u003d unversioned"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7faddb67_3f6d69cb","line":96,"updated":"2019-08-06 17:05:01.000000000","message":"I\u0027ve never thought about just setting to \"\". The AllHostsFilter would do the same trick I\u0027d think - it just accepts everything.\n\nhttps://docs.openstack.org/nova/latest/admin/configuration/schedulers.html#allhostsfilter","commit_id":"36be360fc4521bc6567d3c6fa90a83a1c62d99db"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"ff60d3fd527de078eaa01fff5b5214da1346c8ca","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    [quota]"},{"line_number":94,"context_line":"    driver \u003d \"nova.quota.NoopQuotaDriver\""},{"line_number":95,"context_line":"    [filter_scheduler]"},{"line_number":96,"context_line":"    enabled_filters \u003d \u0027\"\"\u0027"},{"line_number":97,"context_line":"    [notifications]"},{"line_number":98,"context_line":"    notification_format \u003d unversioned"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7faddb67_0f570dcd","line":96,"in_reply_to":"7faddb67_3f6d69cb","updated":"2019-08-07 09:04:16.000000000","message":"I think this is a leftover from back in the days of https://anticdent.org/placement-scale-fun.html when I was trying to remove filtering as a factor at all, so I think I can just remove this entirely as for many people filtering is something they would want to see in these tests.\n\nActually I comment about that.","commit_id":"36be360fc4521bc6567d3c6fa90a83a1c62d99db"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dc07940ef2e7cf148e7ea16c1733b2aa52bdfe26","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                 allocation_request_version\u003dNone, return_alternates\u003dFalse):"},{"line_number":113,"context_line":"             \"\"\"Returns a list of lists of Selection objects, which represent the"},{"line_number":114,"context_line":"             hosts and (optionally) alternates for each instance."},{"line_number":115,"context_line":"     "},{"line_number":116,"context_line":"             :param context: The RequestContext object"},{"line_number":117,"context_line":"             :param spec_obj: The RequestSpec object"},{"line_number":118,"context_line":"             :param instance_uuids: List of UUIDs, one for each value of the spec"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7faddb67_c48fa8ca","line":115,"updated":"2019-08-06 17:05:01.000000000","message":"whitespace damage","commit_id":"36be360fc4521bc6567d3c6fa90a83a1c62d99db"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dc07940ef2e7cf148e7ea16c1733b2aa52bdfe26","unresolved":false,"context_lines":[{"line_number":155,"context_line":"                 context\u003dcontext, request_spec\u003dspec_obj,"},{"line_number":156,"context_line":"                 action\u003dfields_obj.NotificationAction.SELECT_DESTINATIONS,"},{"line_number":157,"context_line":"                 phase\u003dfields_obj.NotificationPhase.START)"},{"line_number":158,"context_line":"     "},{"line_number":159,"context_line":"             host_selections \u003d self._schedule(context, spec_obj, instance_uuids,"},{"line_number":160,"context_line":"                     alloc_reqs_by_rp_uuid, provider_summaries,"},{"line_number":161,"context_line":"                     allocation_request_version, return_alternates)"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7faddb67_e48ae4b9","line":158,"updated":"2019-08-06 17:05:01.000000000","message":"same","commit_id":"36be360fc4521bc6567d3c6fa90a83a1c62d99db"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dc07940ef2e7cf148e7ea16c1733b2aa52bdfe26","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    +"},{"line_number":172,"context_line":"             return host_selections"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"Make the ``/tmp/select_destinations`` directory, where output will go."},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"Restart the scheduler service. Note that ``systemctl restart`` may not kill"},{"line_number":177,"context_line":"things sufficiently dead, so::"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7faddb67_5fa5c501","line":174,"range":{"start_line":174,"start_character":38,"end_line":174,"end_character":47},"updated":"2019-08-06 17:05:01.000000000","message":"writable?","commit_id":"36be360fc4521bc6567d3c6fa90a83a1c62d99db"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dc07940ef2e7cf148e7ea16c1733b2aa52bdfe26","unresolved":false,"context_lines":[{"line_number":182,"context_line":""},{"line_number":183,"context_line":"Create a server (which will call ``select_destinations``)::"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    openstack server create --image cirros-0.4.0-x86_64-disk --flavor c1 x1"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"In ``/tmp/select_destinations`` there should be a file with a name using the"},{"line_number":188,"context_line":"uuid of the created server with a ``.prof`` extension."}],"source_content_type":"text/x-rst","patch_set":1,"id":"7faddb67_bf8e3976","line":185,"updated":"2019-08-06 17:05:01.000000000","message":"If we wanted to free up more space on the devstack node we could disable neutron and use:\n\n--os-compute-api-version 2.37 and --nic none\n\nwith the openstack server create command, but I\u0027m guessing the compute API refuses to function well when neutron isn\u0027t available even if the servers aren\u0027t using it (the view builder likely needs it for asking for ports and security groups on any servers it shows). Plus OSC might think nova-network is being used if neutron isn\u0027t in the service catalog.","commit_id":"36be360fc4521bc6567d3c6fa90a83a1c62d99db"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"ff60d3fd527de078eaa01fff5b5214da1346c8ca","unresolved":false,"context_lines":[{"line_number":182,"context_line":""},{"line_number":183,"context_line":"Create a server (which will call ``select_destinations``)::"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    openstack server create --image cirros-0.4.0-x86_64-disk --flavor c1 x1"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"In ``/tmp/select_destinations`` there should be a file with a name using the"},{"line_number":188,"context_line":"uuid of the created server with a ``.prof`` extension."}],"source_content_type":"text/x-rst","patch_set":1,"id":"7faddb67_4f2bc532","line":185,"in_reply_to":"7faddb67_bf8e3976","updated":"2019-08-07 09:04:16.000000000","message":"Yeah, in this case I was after the fewest args","commit_id":"36be360fc4521bc6567d3c6fa90a83a1c62d99db"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dc07940ef2e7cf148e7ea16c1733b2aa52bdfe26","unresolved":false,"context_lines":[{"line_number":217,"context_line":"           50    0.001    0.000    0.776    0.016 /mnt/share/opt/stack/nova/nova/objects/host_mapping.py:99(get_by_host)"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"From this we can infer that whatever is happening in ``get_by_host`` is being"},{"line_number":220,"context_line":"done once for every ``nova-compute`` and is consuming about 40% of total time."},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"Several other sort modes can be used. List those that are available by entering"},{"line_number":223,"context_line":"``sort`` without arguments."}],"source_content_type":"text/x-rst","patch_set":1,"id":"7faddb67_9f649dba","line":220,"range":{"start_line":220,"start_character":60,"end_line":220,"end_character":63},"updated":"2019-08-06 17:05:01.000000000","message":"How do you get at the 40% number?","commit_id":"36be360fc4521bc6567d3c6fa90a83a1c62d99db"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dc07940ef2e7cf148e7ea16c1733b2aa52bdfe26","unresolved":false,"context_lines":[{"line_number":217,"context_line":"           50    0.001    0.000    0.776    0.016 /mnt/share/opt/stack/nova/nova/objects/host_mapping.py:99(get_by_host)"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"From this we can infer that whatever is happening in ``get_by_host`` is being"},{"line_number":220,"context_line":"done once for every ``nova-compute`` and is consuming about 40% of total time."},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"Several other sort modes can be used. List those that are available by entering"},{"line_number":223,"context_line":"``sort`` without arguments."}],"source_content_type":"text/x-rst","patch_set":1,"id":"7faddb67_bfbcf905","line":220,"range":{"start_line":220,"start_character":5,"end_line":220,"end_character":36},"updated":"2019-08-06 17:05:01.000000000","message":"To the untrained this might be confusing, but it\u0027s because you have NUMBER_FAKE_NOVA_COMPUTE\u003d50 in devstack.","commit_id":"36be360fc4521bc6567d3c6fa90a83a1c62d99db"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"ff60d3fd527de078eaa01fff5b5214da1346c8ca","unresolved":false,"context_lines":[{"line_number":217,"context_line":"           50    0.001    0.000    0.776    0.016 /mnt/share/opt/stack/nova/nova/objects/host_mapping.py:99(get_by_host)"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"From this we can infer that whatever is happening in ``get_by_host`` is being"},{"line_number":220,"context_line":"done once for every ``nova-compute`` and is consuming about 40% of total time."},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"Several other sort modes can be used. List those that are available by entering"},{"line_number":223,"context_line":"``sort`` without arguments."}],"source_content_type":"text/x-rst","patch_set":1,"id":"7faddb67_0f25cd5c","line":220,"range":{"start_line":220,"start_character":5,"end_line":220,"end_character":36},"in_reply_to":"7faddb67_bfbcf905","updated":"2019-08-07 09:04:16.000000000","message":"I\u0027ll clarify both of these points.","commit_id":"36be360fc4521bc6567d3c6fa90a83a1c62d99db"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"692208a9e440874e2210deeed28fa2060577ed39","unresolved":false,"context_lines":[{"line_number":221,"context_line":""},{"line_number":222,"context_line":"From this we can make a couple of useful inferences about ``get_by_host``:"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"* It is called once for each of the 50 ``FakeVirtDriver`` hypervisors."},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"* It (and the methods it calls internally) consumes about 40% of the entire"},{"line_number":227,"context_line":"  time spent running (``0.776 / 1.957``) the ``select_destinations`` method"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_5f17d346","line":224,"range":{"start_line":224,"start_character":24,"end_line":224,"end_character":69},"updated":"2019-08-08 19:44:11.000000000","message":"It was 25 on L86?","commit_id":"0217107a5c00ff5fab1e2da963026f20d795e7da"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"e4aad715b362761313c16807c77f06e760dcb8c3","unresolved":false,"context_lines":[{"line_number":221,"context_line":""},{"line_number":222,"context_line":"From this we can make a couple of useful inferences about ``get_by_host``:"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"* It is called once for each of the 50 ``FakeVirtDriver`` hypervisors."},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"* It (and the methods it calls internally) consumes about 40% of the entire"},{"line_number":227,"context_line":"  time spent running (``0.776 / 1.957``) the ``select_destinations`` method"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_71676353","line":224,"range":{"start_line":224,"start_character":24,"end_line":224,"end_character":69},"in_reply_to":"7faddb67_5f17d346","updated":"2019-08-08 21:33:47.000000000","message":"Yeah, I need to change that. I updated the conf example based on matt\u0027s input, but didn\u0027t rerun the profile. I need to make the comment more explicit about what I did versus what someone else might want to do.","commit_id":"0217107a5c00ff5fab1e2da963026f20d795e7da"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"53b2255bc9d48819d5c6b54e636aa6cb65426f0c","unresolved":false,"context_lines":[{"line_number":33,"context_line":"service that can be associated with an identifier. For example,"},{"line_number":34,"context_line":"``select_destinations`` in the ``FilterScheduler`` can be associated with the"},{"line_number":35,"context_line":"list of ``instance_uuids`` passed to it and it runs only once for that set of"},{"line_number":36,"context_line":"instance uuids."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"The process for profiling is:"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7faddb67_a97f8e64","line":36,"updated":"2019-08-12 09:28:54.000000000","message":"should context.request_id not work here, thats a separate converstation I guess, and your example works better here.","commit_id":"886142b17aeb678680ea62a98b4f6f853fd3ae57"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"7b81e840f8bc7487bd3487cbcba79ef4f5c993dd","unresolved":false,"context_lines":[{"line_number":33,"context_line":"service that can be associated with an identifier. For example,"},{"line_number":34,"context_line":"``select_destinations`` in the ``FilterScheduler`` can be associated with the"},{"line_number":35,"context_line":"list of ``instance_uuids`` passed to it and it runs only once for that set of"},{"line_number":36,"context_line":"instance uuids."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"The process for profiling is:"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7faddb67_2915dee5","line":36,"in_reply_to":"7faddb67_a97f8e64","updated":"2019-08-12 09:37:40.000000000","message":"I chose instance_uuids because as the person operating \u0027openstack server create\u0027 to spawn off the profile, the instance uuids are a thing that is obvious in the response.","commit_id":"886142b17aeb678680ea62a98b4f6f853fd3ae57"}]}